Re: Review Request 29918: Introduced a generic checkpoint function.

> On Jan. 23, 2015, 6:44 p.m., Jie Yu wrote: > > src/slave/state.hpp, line 120 > > > > > > One more thought: > > > > Can we introduce a third parameter for this function to let users opt > > out the temp + re

Re: Review Request 29918: Introduced a generic checkpoint function.

> On Jan. 23, 2015, 6:44 p.m., Jie Yu wrote: > > src/slave/state.hpp, line 120 > > > > > > One more thought: > > > > Can we introduce a third parameter for this function to let users opt > > out the temp + re

Re: Review Request 29918: Introduced a generic checkpoint function.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29918/#review69523 --- Patch looks great! Reviews applied: [30143, 30109, 30110, 30143, 30

Re: Review Request 29918: Introduced a generic checkpoint function.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29918/ --- (Updated Jan. 24, 2015, 1:21 a.m.) Review request for mesos, Adam B, Benjamin H

Re: Review Request 29918: Introduced a generic checkpoint function.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29918/#review69435 --- src/slave/state.hpp

Re: Review Request 29918: Introduced a generic checkpoint function.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29918/#review69426 --- Ship it! Overall, LGTM! src/slave/state.hpp

Re: Review Request 29918: Introduced a generic checkpoint function.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29918/#review69134 --- Patch looks great! Reviews applied: [30143, 30109, 30110, 30143, 30

Re: Review Request 29918: Introduced a generic checkpoint function.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29918/ --- (Updated Jan. 22, 2015, 5 a.m.) Review request for mesos, Adam B, Benjamin Hind

Re: Review Request 29918: Introduced a generic checkpoint function.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29918/ --- (Updated Jan. 22, 2015, 4:53 a.m.) Review request for mesos, Adam B, Benjamin H

Re: Review Request 29918: Introduced a generic checkpoint function.

> On Jan. 22, 2015, 1:16 a.m., Jie Yu wrote: > > src/slave/state.hpp, lines 76-78 > > > > > > Wrap comment in 70 char width. Do you mean it's wrapped too early? - Michael ---

Re: Review Request 29918: Introduced a generic checkpoint function.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29918/#review69076 --- include/mesos/resources.hpp

Re: Review Request 29918: Introduced a generic checkpoint function.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29918/#review69068 --- Bad patch! Reviews applied: [30108, 30143, 30109] Failed command:

Re: Review Request 29918: Introduced a generic checkpoint function.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29918/ --- (Updated Jan. 21, 2015, 10:08 p.m.) Review request for mesos, Adam B, Benjamin

Re: Review Request 29918: Introduced a generic checkpoint function.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29918/#review68940 --- src/slave/state.hpp

Re: Review Request 29918: Introduced a generic checkpoint function.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29918/#review68941 --- Patch looks great! Reviews applied: [30108, 30111, 30110, 29918] A

Re: Review Request 29918: Introduced a generic checkpoint function.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29918/ --- (Updated Jan. 21, 2015, 4:41 p.m.) Review request for mesos, Adam B, Benjamin H

Re: Review Request 29918: Introduced a generic checkpoint function.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29918/ --- (Updated Jan. 21, 2015, 10:50 a.m.) Review request for mesos, Adam B, Benjamin

Re: Review Request 29918: Introduced a generic checkpoint function.

> On Jan. 15, 2015, 7:07 p.m., Jie Yu wrote: > > src/slave/state.cpp, line 802 > > > > > > You probably wanna move the TODO here. The `TODO` is now addressed with the use of `os::rename` - Michael

Re: Review Request 29918: Introduced a generic checkpoint function.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29918/ --- (Updated Jan. 21, 2015, 10:32 a.m.) Review request for mesos, Adam B, Benjamin