---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30931/#review78046
---
Ship it!
Ship It!
- Alexander Rojas
On March 26, 2015, 12:20
On March 25, 2015, 3:37 p.m., Michael Park wrote:
Perhaps a dumb question, but I'm wondering why the enclosing braces belong
here rather than in `operator (std::ostream stream, const FlagsBase
flags)`?
Adressed
- Joerg
---
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30931/#review77739
---
Perhaps a dumb question, but I'm wondering why the enclosing braces
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30931/#review77834
---
Patch looks great!
Reviews applied: [32105, 30931]
All tests
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30931/#review77724
---
Ship it!
Ship It!
- Till Toenshoff
On March 16, 2015, 3:20
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30931/
---
(Updated March 25, 2015, 11:20 p.m.)
Review request for mesos and Till
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30931/
---
(Updated March 16, 2015, 3:20 p.m.)
Review request for mesos and Till
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30931/#review76564
---
Patch looks great!
Reviews applied: [32105, 30931]
All tests
On Feb. 25, 2015, 10:54 p.m., Ben Mahler wrote:
src/common/type_utils.cpp, lines 203-205
https://reviews.apache.org/r/30931/diff/8/?file=873690#file873690line203
You're taking a logging::Flags but you're iterating over non-logging
flags (i.e. slave::Flags, master::Flags), that's
On Feb. 23, 2015, 2:34 p.m., Till Toenshoff wrote:
src/slave/slave.cpp, line 176
https://reviews.apache.org/r/30931/diff/4/?file=863304#file863304line176
How about supporting Mesos local and possibly the test as well?
Joerg Schad wrote:
Is already automatially provided by
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30931/
---
(Updated Feb. 24, 2015, 9:30 a.m.)
Review request for mesos and Till
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30931/#review73786
---
Patch looks great!
Reviews applied: [30931]
All tests passed.
-
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30931/#review73563
---
include/mesos/type_utils.hpp
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30931/#review73573
---
Bad patch!
Reviews applied: [30931]
Failed command:
On Feb. 23, 2015, 2:34 p.m., Till Toenshoff wrote:
src/common/type_utils.cpp, line 208
https://reviews.apache.org/r/30931/diff/4/?file=863302#file863302line208
Maybe add a single space?
I followed the format of *curl localhost:5050/state.json* which does not have
any spaces.
On
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30931/
---
(Updated Feb. 23, 2015, 3:59 p.m.)
Review request for mesos and Till
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30931/
---
(Updated Feb. 23, 2015, 4:06 p.m.)
Review request for mesos and Till
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30931/#review73644
---
include/mesos/type_utils.hpp
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30931/#review73748
---
Patch looks great!
Reviews applied: [30931]
All tests passed.
-
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30931/
---
(Updated Feb. 23, 2015, 11:34 p.m.)
Review request for mesos and Till
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30931/#review72366
---
src/common/type_utils.cpp
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30931/
---
(Updated Feb. 13, 2015, 3:59 p.m.)
Review request for mesos and Till
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30931/#review72379
---
include/mesos/type_utils.hpp
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30931/
---
(Updated Feb. 13, 2015, 4:10 p.m.)
Review request for mesos and Till
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30931/
---
(Updated Feb. 13, 2015, 12:44 p.m.)
Review request for mesos and Till
25 matches
Mail list logo