---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31471/#review75500
---
3rdparty/libprocess/3rdparty/stout/include/stout/ip.hpp
On March 6, 2015, 6:23 p.m., Jie Yu wrote:
3rdparty/libprocess/3rdparty/stout/include/stout/ip.hpp, lines 268-270
https://reviews.apache.org/r/31471/diff/7/?file=886045#file886045line268
As we discussed offline, please change the name of this function to:
```
static
On March 6, 2015, 10:23 a.m., Jie Yu wrote:
3rdparty/libprocess/3rdparty/stout/include/stout/ip.hpp, lines 268-270
https://reviews.apache.org/r/31471/diff/7/?file=886045#file886045line268
As we discussed offline, please change the name of this function to:
```
static
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31471/
---
(Updated March 6, 2015, 8:05 p.m.)
Review request for mesos, Benjamin Hindman,
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31471/
---
(Updated March 6, 2015, 8:01 p.m.)
Review request for mesos, Benjamin Hindman,
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31471/
---
(Updated March 6, 2015, 7:58 p.m.)
Review request for mesos, Benjamin Hindman,
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31471/
---
(Updated March 5, 2015, 7:39 p.m.)
Review request for mesos, Benjamin Hindman,
On March 3, 2015, 6:39 p.m., Jie Yu wrote:
3rdparty/libprocess/3rdparty/stout/include/stout/ip.hpp, line 62
https://reviews.apache.org/r/31471/diff/4/?file=882869#file882869line62
`struct in_addr` stores ip address in network order by standard. No
need to mention that in the
On March 3, 2015, 5:06 p.m., Dominic Hamon wrote:
3rdparty/libprocess/3rdparty/stout/include/stout/net.hpp, line 108
https://reviews.apache.org/r/31471/diff/4/?file=882870#file882870line108
why did this change?
sorry for that, I accidentally used an old version of net.hpp
-
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31471/
---
(Updated March 5, 2015, 4:06 p.m.)
Review request for mesos, Benjamin Hindman,
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31471/
---
(Updated March 5, 2015, 3:46 p.m.)
Review request for mesos, Benjamin Hindman,
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31471/#review74978
---
3rdparty/libprocess/3rdparty/stout/include/stout/net.hpp
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31471/#review74987
---
This is looking good! Thanks for the cleanup!
On March 3, 2015, 6:39 p.m., Jie Yu wrote:
3rdparty/libprocess/3rdparty/stout/include/stout/ip.hpp, line 71
https://reviews.apache.org/r/31471/diff/4/?file=882869#file882869line71
By convension, if you store an ipv4 address in uint32_t, it should be
in host order. So the code
On March 3, 2015, 6:39 p.m., Jie Yu wrote:
3rdparty/libprocess/3rdparty/stout/include/stout/ip.hpp, lines 115-126
https://reviews.apache.org/r/31471/diff/4/?file=882869#file882869line115
I am wondering if this function is necessary given that we implemented
`==` operator. For
On March 3, 2015, 6:39 p.m., Jie Yu wrote:
3rdparty/libprocess/3rdparty/stout/include/stout/ip.hpp, line 63
https://reviews.apache.org/r/31471/diff/4/?file=882869#file882869line63
Please be consistent. You use `in_addr` here but you use `struct
in_addr` for the field member.
On March 3, 2015, 6:39 p.m., Jie Yu wrote:
3rdparty/libprocess/3rdparty/stout/include/stout/ip.hpp, lines 454-462
https://reviews.apache.org/r/31471/diff/4/?file=882869#file882869line454
The code here is a little verbose. I am wondering can we simply this
code by introducing a
On March 3, 2015, 6:39 p.m., Jie Yu wrote:
3rdparty/libprocess/3rdparty/stout/include/stout/ip.hpp, lines 211-213
https://reviews.apache.org/r/31471/diff/4/?file=882869#file882869line211
Fix the indent please
Evelina Dumitrescu wrote:
I put the parameters on different lines
On March 3, 2015, 6:39 p.m., Jie Yu wrote:
3rdparty/libprocess/3rdparty/stout/include/stout/ip.hpp, lines 115-126
https://reviews.apache.org/r/31471/diff/4/?file=882869#file882869line115
I am wondering if this function is necessary given that we implemented
`==` operator. For
On March 3, 2015, 6:39 p.m., Jie Yu wrote:
3rdparty/libprocess/3rdparty/stout/include/stout/ip.hpp, line 260
https://reviews.apache.org/r/31471/diff/4/?file=882869#file882869line260
Why this function returns a Try? Seems to be uncessary because it
shouldn't fail, right? How about
On March 3, 2015, 6:39 p.m., Jie Yu wrote:
3rdparty/libprocess/3rdparty/stout/include/stout/ip.hpp, lines 115-126
https://reviews.apache.org/r/31471/diff/4/?file=882869#file882869line115
I am wondering if this function is necessary given that we implemented
`==` operator. For
On March 3, 2015, 6:39 p.m., Jie Yu wrote:
3rdparty/libprocess/3rdparty/stout/include/stout/ip.hpp, line 71
https://reviews.apache.org/r/31471/diff/4/?file=882869#file882869line71
By convension, if you store an ipv4 address in uint32_t, it should be
in host order. So the code
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31471/
---
(Updated March 3, 2015, 11:27 a.m.)
Review request for mesos, Benjamin
On Feb. 27, 2015, 8:28 p.m., Jie Yu wrote:
3rdparty/libprocess/3rdparty/stout/include/stout/ip.hpp, line 364
https://reviews.apache.org/r/31471/diff/3/?file=879788#file879788line364
The comment here does not seem to add any value. Please kill it.
added in network order instead.
-
On Feb. 27, 2015, 8:28 p.m., Jie Yu wrote:
3rdparty/libprocess/3rdparty/stout/include/stout/ip.hpp, line 48
https://reviews.apache.org/r/31471/diff/3/?file=879788#file879788line48
Why this change? What does an IP storage mean? Please revert it.
Evelina Dumitrescu wrote:
I
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31471/#review74511
---
3rdparty/libprocess/3rdparty/stout/include/stout/ip.hpp
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31471/#review74525
---
3rdparty/libprocess/3rdparty/stout/include/stout/ip.hpp
On Feb. 27, 2015, 5:20 p.m., Dominic Hamon wrote:
3rdparty/libprocess/3rdparty/stout/include/stout/ip.hpp, line 305
https://reviews.apache.org/r/31471/diff/1-3/?file=877503#file877503line305
please don't overload create, especially when it might be possible to
introduce a bug
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31471/#review74552
---
I only looked at ip.hpp. Please address the existing comments first
On Feb. 27, 2015, 8:28 p.m., Jie Yu wrote:
3rdparty/libprocess/3rdparty/stout/include/stout/ip.hpp, lines 295-297
https://reviews.apache.org/r/31471/diff/3/?file=879788#file879788line295
Let's introduce this when we actually need it!
I use it in port_mapping.cpp instead of static
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31471/
---
(Updated Feb. 27, 2015, 9:22 a.m.)
Review request for mesos, Benjamin Hindman,
On Feb. 26, 2015, 6:06 p.m., Dominic Hamon wrote:
3rdparty/libprocess/3rdparty/stout/tests/ip_tests.cpp, line 17
https://reviews.apache.org/r/31471/diff/1/?file=877505#file877505line17
why do you need this?
Accidentally left, I used it for debugging.
On Feb. 26, 2015, 6:06 p.m.,
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31471/#review74300
---
3rdparty/libprocess/3rdparty/stout/include/stout/ip.hpp
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31471/
---
Review request for mesos, Benjamin Hindman, Dominic Hamon, Jie Yu, Joris Van
34 matches
Mail list logo
