Re: Review Request 32505: Added SHUTDOWN scheduler call.

2015-04-20 Thread Vinod Kone
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32505/ --- (Updated April 20, 2015, 8:01 p.m.) Review request for mesos, Benjamin Hindman

Re: Review Request 32505: Added SHUTDOWN scheduler call.

2015-04-08 Thread Alexander Rukletsov
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32505/#review79369 --- src/master/master.cpp

Re: Review Request 32505: Added SHUTDOWN scheduler call.

2015-04-03 Thread Vinod Kone
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32505/ --- (Updated April 3, 2015, 11:38 p.m.) Review request for mesos, Benjamin Hindman

Re: Review Request 32505: Added SHUTDOWN scheduler call.

2015-04-03 Thread Vinod Kone
On April 1, 2015, 12:20 a.m., Ben Mahler wrote: Modulo comments. I noticed you added SlaveID on Shutdown, can you add it to Kill as well? Yup. Will send a patch for it as well. On April 1, 2015, 12:20 a.m., Ben Mahler wrote: include/mesos/scheduler/scheduler.proto, line 127

Re: Review Request 32505: Added SHUTDOWN scheduler call.

2015-03-31 Thread Ben Mahler
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32505/#review78415 --- Ship it! Modulo comments. I noticed you added SlaveID on

Re: Review Request 32505: Added SHUTDOWN scheduler call.

2015-03-30 Thread Vinod Kone
On March 27, 2015, 3:22 p.m., Alexander Rojas wrote: src/scheduler/scheduler.cpp, lines 679-680 https://reviews.apache.org/r/32505/diff/1/?file=906104#file906104line679 Do you mind adding a comment why an exited executor is always marked as a failure? It is not clear to me. This

Re: Review Request 32505: Added SHUTDOWN scheduler call.

2015-03-30 Thread Vinod Kone
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32505/ --- (Updated March 31, 2015, 12:09 a.m.) Review request for mesos, Benjamin

Re: Review Request 32505: Added SHUTDOWN scheduler call.

2015-03-27 Thread Alexander Rojas
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32505/#review78050 --- src/master/master.cpp

Review Request 32505: Added SHUTDOWN scheduler call.

2015-03-25 Thread Vinod Kone
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32505/ --- Review request for mesos, Benjamin Hindman and Ben Mahler. Bugs: MESOS-1127