Re: Review Request 32845: Renamed UNREGISTER call to UNSUBSCRIBE.

2015-04-21 Thread Alexander Rukletsov
On April 8, 2015, 5:52 p.m., Alexander Rukletsov wrote: src/master/master.cpp, lines 1626-1628 https://reviews.apache.org/r/32845/diff/1/?file=915074#file915074line1626 Shall we check `framework-pid == from` as we do in `Master::unregisterFramework()`? Also metrcis

Re: Review Request 32845: Renamed UNREGISTER call to UNSUBSCRIBE.

2015-04-20 Thread Ben Mahler
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32845/#review80870 --- include/mesos/scheduler/scheduler.proto

Re: Review Request 32845: Renamed UNREGISTER call to UNSUBSCRIBE.

2015-04-20 Thread Vinod Kone
On April 8, 2015, 5:52 p.m., Alexander Rukletsov wrote: src/master/master.cpp, lines 1626-1628 https://reviews.apache.org/r/32845/diff/1/?file=915074#file915074line1626 Shall we check `framework-pid == from` as we do in `Master::unregisterFramework()`? Also metrcis

Re: Review Request 32845: Renamed UNREGISTER call to UNSUBSCRIBE.

2015-04-20 Thread Vinod Kone
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32845/ --- (Updated April 20, 2015, 8:04 p.m.) Review request for mesos and Ben Mahler.

Re: Review Request 32845: Renamed UNREGISTER call to UNSUBSCRIBE.

2015-04-08 Thread Alexander Rukletsov
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32845/#review79381 --- src/master/master.cpp

Re: Review Request 32845: Renamed UNREGISTER call to UNSUBSCRIBE.

2015-04-03 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32845/#review78869 --- Patch looks great! Reviews applied: [32500, 32501, 32502, 32504,

Review Request 32845: Renamed UNREGISTER call to UNSUBSCRIBE.

2015-04-03 Thread Vinod Kone
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32845/ --- Review request for mesos and Ben Mahler. Bugs: MESOS-1127