[RESULT] [VOTE] Apache Metamodel release 5.1.1

2018-10-03 Thread Kasper Sørensen
Hi all, Thank you so much for voting. We have 5 votes for and 0 against the release: Arjan Seijkens Alberto Rodriguez * Laxmi Lal Menaria Kasper Sørensen * Dennis Krøger * * = Indicates PMC. I will continue with the release procedure. Best regards, Kasper Den ons. 3. okt. 2018 kl. 05.11 skrev

[GitHub] metamodel pull request #190: Added cache for prepared statements in JdbcUpda...

2018-10-03 Thread kaspersorensen
Github user kaspersorensen commented on a diff in the pull request: https://github.com/apache/metamodel/pull/190#discussion_r222489367 --- Diff: jdbc/src/main/java/org/apache/metamodel/jdbc/JdbcDataContext.java --- @@ -903,4 +905,17 @@ public String getDatabaseProductName() {

[GitHub] metamodel pull request #190: Added cache for prepared statements in JdbcUpda...

2018-10-03 Thread kaspersorensen
Github user kaspersorensen commented on a diff in the pull request: https://github.com/apache/metamodel/pull/190#discussion_r222489903 --- Diff: jdbc/src/test/java/org/apache/metamodel/jdbc/ConnectionWrapper.java --- @@ -0,0 +1,286 @@ +/** + * Licensed to the Apache Softwar

[GitHub] metamodel pull request #190: Added cache for prepared statements in JdbcUpda...

2018-10-03 Thread kaspersorensen
Github user kaspersorensen commented on a diff in the pull request: https://github.com/apache/metamodel/pull/190#discussion_r222490606 --- Diff: jdbc/src/main/java/org/apache/metamodel/jdbc/JdbcUpdateCallback.java --- @@ -42,18 +43,35 @@ import org.slf4j.Logger; import or

[GitHub] metamodel pull request #190: Added cache for prepared statements in JdbcUpda...

2018-10-03 Thread kaspersorensen
Github user kaspersorensen commented on a diff in the pull request: https://github.com/apache/metamodel/pull/190#discussion_r222490126 --- Diff: jdbc/src/main/java/org/apache/metamodel/jdbc/JdbcUpdateCallback.java --- @@ -42,18 +43,35 @@ import org.slf4j.Logger; import or

[GitHub] metamodel pull request #190: Added cache for prepared statements in JdbcUpda...

2018-10-03 Thread kaspersorensen
Github user kaspersorensen commented on a diff in the pull request: https://github.com/apache/metamodel/pull/190#discussion_r222489649 --- Diff: jdbc/src/main/java/org/apache/metamodel/jdbc/JdbcUpdateCallback.java --- @@ -42,18 +43,35 @@ import org.slf4j.Logger; import or

[GitHub] metamodel pull request #190: Added cache for prepared statements in JdbcUpda...

2018-10-03 Thread kaspersorensen
Github user kaspersorensen commented on a diff in the pull request: https://github.com/apache/metamodel/pull/190#discussion_r222491235 --- Diff: jdbc/src/test/java/org/apache/metamodel/jdbc/CloseableConnectionWrapper.java --- @@ -44,13 +44,12 @@ * closed or not, without actua

[GitHub] metamodel pull request #190: Added cache for prepared statements in JdbcUpda...

2018-10-03 Thread jakubneubauer
GitHub user jakubneubauer opened a pull request: https://github.com/apache/metamodel/pull/190 Added cache for prepared statements in JdbcUpdateCallback Closes METAMODEL-1199 You can merge this pull request into a Git repository by running: $ git pull https://github.com/jakubneu

Re: [VOTE] Apache Metamodel release 5.1.1

2018-10-03 Thread Dennis Krøger
+1 On Wed, Oct 3, 2018 at 4:42 AM Kasper Sørensen < i.am.kasper.soren...@gmail.com> wrote: > +1 from myself too :-) > > Den man. 1. okt. 2018 kl. 01.48 skrev Laxmi Lal Menaria < > menarialaxmi...@gmail.com>: > > > +1 > > > > On Mon, Oct 1, 2018 at 12:17 PM Alberto Rodriguez > > wrote: > > > > >