Github user LosD commented on the issue:
https://github.com/apache/metamodel/pull/194
Yeah, I agree, everything looks good.
Nope, not really. I'll take a look in a moment.
---
Github user kaspersorensen commented on the issue:
https://github.com/apache/metamodel/pull/194
No I think this is perfect. Thanks again for doing extra due diligence on
the PR. I think we can merge ...
Did you by any chance look at the two other JDK9+ related PRs?
---
Github user LosD commented on the issue:
https://github.com/apache/metamodel/pull/194
D'oh, of course they're blocking, I'm doing the loop inside an update
script! Let me know if you want me to change it. :-)
---
Github user LosD commented on the issue:
https://github.com/apache/metamodel/pull/194
Okay, made an even stupider test, this time doing multiple inserts, from
multiple threads (I think we had problems with that on Excel previously) :)
```java
import java.io.File;
impo
Github user kaspersorensen commented on the issue:
https://github.com/apache/metamodel/pull/194
I like it! Thanks a bunch for testing it.
---
Github user LosD commented on the issue:
https://github.com/apache/metamodel/pull/194
D'oh! Forgot about the multiple inserts.
It's getting a bit late here, but I'll try those out Sunday (family visit
tomorrow).
---
Github user LosD commented on the issue:
https://github.com/apache/metamodel/pull/194
Made a (bit stupid) test:
```Java
import org.apache.metamodel.data.DataSet;
import org.apache.metamodel.excel.ExcelDataContext;
import org.apache.metamodel.schema.Column;
import org
Github user LosD commented on the issue:
https://github.com/apache/metamodel/pull/194
Okay, I'll give it a spin.
But first, I'll hunt around for a large Excel file (or make one) :)
---
Github user kaspersorensen commented on the issue:
https://github.com/apache/metamodel/pull/194
I think our tests should cover most of the stuff, but the one thing that I
will admit was somewhat complicated was what I noted in the third commit:
> I ran into an issue that remin
Github user LosD commented on the issue:
https://github.com/apache/metamodel/pull/194
LGTM, but I haven't tested yet. Guess such a big jump should have some kind
of manual test. Anything I should look specifically at trying out?
---
10 matches
Mail list logo
