[GitHub] metamodel pull request: Updating FromItemParser to parse tableName...

Github user asfgit closed the pull request at: https://github.com/apache/metamodel/pull/72 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is en

[GitHub] metamodel pull request: Updating FromItemParser to parse tableName...

Github user kaspersorensen commented on a diff in the pull request: https://github.com/apache/metamodel/pull/72#discussion_r45185504 --- Diff: core/src/main/java/org/apache/metamodel/query/QueryConstants.java --- @@ -0,0 +1,41 @@ +/** + * Licensed to the Apache Software Fou

[GitHub] metamodel pull request: Updating FromItemParser to parse tableName...

Github user ashwinrayaprolu1984 commented on a diff in the pull request: https://github.com/apache/metamodel/pull/72#discussion_r45000717 --- Diff: core/src/main/java/org/apache/metamodel/query/QueryConstants.java --- @@ -0,0 +1,41 @@ +/** + * Licensed to the Apache Softwar

[GitHub] metamodel pull request: Updating FromItemParser to parse tableName...

Github user kaspersorensen commented on a diff in the pull request: https://github.com/apache/metamodel/pull/72#discussion_r44868818 --- Diff: core/src/main/java/org/apache/metamodel/query/QueryConstants.java --- @@ -0,0 +1,41 @@ +/** + * Licensed to the Apache Software Fou

[GitHub] metamodel pull request: Updating FromItemParser to parse tableName...

Github user ashwinrayaprolu1984 commented on the pull request: https://github.com/apache/metamodel/pull/72#issuecomment-156789594 Sure.. It got checked in by mistake.. Will remove those... > On Nov 15, 2015, at 12:07 AM, Kasper Sørensen wrote: > > I would suggest to remo

[GitHub] metamodel pull request: Updating FromItemParser to parse tableName...

Github user kaspersorensen commented on the pull request: https://github.com/apache/metamodel/pull/72#issuecomment-156789508 I would suggest to remove the CSV directory related things from this PR since its unrelated. Keep that in a different working branch. --- If your project is s

[GitHub] metamodel pull request: Updating FromItemParser to parse tableName...

Github user ashwinrayaprolu1984 commented on the pull request: https://github.com/apache/metamodel/pull/72#issuecomment-156571141 Note sure why this checkin is failing.. Debugging that.. Need to go out will be back in 15 min and check my repository --- If your project is set up for

[GitHub] metamodel pull request: Updating FromItemParser to parse tableName...

Github user ashwinrayaprolu1984 commented on the pull request: https://github.com/apache/metamodel/pull/72#issuecomment-156570966 Please review code in https://github.com/ashwinrayaprolu1984/metamodel/commit/2a7aa9b7f4a9398ce0822d7eccb1f2d208affe8d core/src/main/java

[GitHub] metamodel pull request: Updating FromItemParser to parse tableName...

Github user ashwinrayaprolu1984 commented on the pull request: https://github.com/apache/metamodel/pull/72#issuecomment-155359607 Sure will proceed with above logic.. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If yo

[GitHub] metamodel pull request: Updating FromItemParser to parse tableName...

Github user kaspersorensen commented on the pull request: https://github.com/apache/metamodel/pull/72#issuecomment-155358929 Thanks for the feedback @albertostratio. I think we can then come to an agreement that both syntaxes (double quotes and square brackets) should be parseable by

[GitHub] metamodel pull request: Updating FromItemParser to parse tableName...

Github user albertostratio commented on the pull request: https://github.com/apache/metamodel/pull/72#issuecomment-155357162 If we're going to add this feature I'd also go for both syntaxes. IMO it won't be a good idea to force the user to use a specific one. @kaspersorensen y

[GitHub] metamodel pull request: Updating FromItemParser to parse tableName...

Github user ashwinrayaprolu1984 commented on the pull request: https://github.com/apache/metamodel/pull/72#issuecomment-155152411 I'll leave this decision up to you.. As you guys are owners of this.. But yeah i agree with @kaspersorensen that we should embrace everything... Will pro

[GitHub] metamodel pull request: Updating FromItemParser to parse tableName...

Github user kaspersorensen commented on the pull request: https://github.com/apache/metamodel/pull/72#issuecomment-155147158 Something like that (using regex) may be possible for sure, but that's more an implementation concern. For now the question that I am most concerned about is th

[GitHub] metamodel pull request: Updating FromItemParser to parse tableName...

Github user ashwinrayaprolu1984 commented on the pull request: https://github.com/apache/metamodel/pull/72#issuecomment-155143846 In this case i would prefer we defining metacharacter list in core API class which parse all token form its delimiters and returns value . Metamod

[GitHub] metamodel pull request: Updating FromItemParser to parse tableName...

Github user kaspersorensen commented on the pull request: https://github.com/apache/metamodel/pull/72#issuecomment-155140230 For me an extremely hard question to answer. As a java developer I anyways personally prefer the programmatic Java Query API over the string parser.

[GitHub] metamodel pull request: Updating FromItemParser to parse tableName...

Github user ashwinrayaprolu1984 commented on the pull request: https://github.com/apache/metamodel/pull/72#issuecomment-155097833 Will update in 2 hours and commit.. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] metamodel pull request: Updating FromItemParser to parse tableName...

Github user LosD commented on the pull request: https://github.com/apache/metamodel/pull/72#issuecomment-155097130 I certainly agree that people has a tendency of screwing it up... Which is no wonder, as MySQL uses backtick as the default identifier quote, T-SQL uses brackets and when

[GitHub] metamodel pull request: Updating FromItemParser to parse tableName...

Github user ashwinrayaprolu1984 commented on the pull request: https://github.com/apache/metamodel/pull/72#issuecomment-155094566 I was actually going that route but from my experience i found people always make mistakes in escaping double quotes and hence took this route.. I can chan

[GitHub] metamodel pull request: Updating FromItemParser to parse tableName...

Github user LosD commented on the pull request: https://github.com/apache/metamodel/pull/72#issuecomment-155016092 The code looks good, but wouldn't it be better to use the SQL standard double quotes than the T-SQL specific brackets? I do believe T-SQL also supports those by default.

Re: [GitHub] metamodel pull request: Updating FromItemParser to parse tableName...

Regarding formatting: i’m talking more on these lines.. http://code.revelc.net/formatter-maven-plugin/examples.html#Setting_Source_Files If you ok to chat on any IM let me know what do you use. I would connect yo

Re: [GitHub] metamodel pull request: Updating FromItemParser to parse tableName...

Hi, Even i was not sure why that DerbyTest got changed. I initially checked out from https://git-wip-us.apache.org/repos/asf/metamodel.git and then migrated to a different repository url cloned from (https://github.com/apache/metamo

[GitHub] metamodel pull request: Updating FromItemParser to parse tableName...

Github user kaspersorensen commented on the pull request: https://github.com/apache/metamodel/pull/72#issuecomment-154881570 Hi there, Thank you very much for the contribution! I think this is a good idea, but the PR is a bit questionable in it's current shape, so I hope you w

[GitHub] metamodel pull request: Updating FromItemParser to parse tableName...

GitHub user ashwinrayaprolu1984 opened a pull request: https://github.com/apache/metamodel/pull/72 Updating FromItemParser to parse tableNames with spaces I had a requirement where tablename contains spaces.. And FromItemParser is throwing exceptions. I made [] as token delimit