Github user ottobackwards commented on the issue:
https://github.com/apache/metron/pull/814
Great catch! Moved it out.
---
Github user jjmeyer0 commented on a diff in the pull request:
https://github.com/apache/metron/pull/814#discussion_r152456690
--- Diff:
metron-stellar/stellar-common/src/main/antlr4/org/apache/metron/stellar/common/generated/Stellar.g4
---
@@ -254,6 +259,7 @@ identifier_operand :
Github user merrimanr commented on the issue:
https://github.com/apache/metron/pull/803
Most of the functional tests worked for me as well. I was able to get the
e2e tests to pass after several runs with the exception of a time picker test
that I believe is due to a timezone issue
Github user asfgit closed the pull request at:
https://github.com/apache/metron/pull/843
---
Github user nickwallen commented on the issue:
https://github.com/apache/metron/pull/843
+1 LGTM. No need to run it up again.
---
Github user merrimanr commented on the issue:
https://github.com/apache/metron/pull/843
Sorry I understand now. Yes I did end up running this in full dev. I
don't mind doing it again to make sure.
---
Github user nickwallen commented on the issue:
https://github.com/apache/metron/pull/843
Stated differently... Your PR description says "I need to run this up in
Full Dev." I am just looking for confirmation that you did that. That's all.
---
Github user nickwallen commented on the issue:
https://github.com/apache/metron/pull/843
Unless I missed it, I just don't see confirmation that you ran this change
up in Full Dev. If you already did, I am just looking for confirmation. I am
not asking you to run it up again, after
Github user merrimanr commented on the issue:
https://github.com/apache/metron/pull/843
The latest commit only includes comments and an additional LOG statement.
I didn't think rebuilding full dev was necessary.
---
Github user nickwallen commented on the issue:
https://github.com/apache/metron/pull/803
IMHO I think the functionality is good on this PR. There are 3 functional
tests that failed, but they are minor and can be addressed after we get this PR
in.
My only hold-up right now
Github user iraghumitra commented on the issue:
https://github.com/apache/metron/pull/803
@nickwallen can you raise a jira to track this. I guess even if we are able
to reproduce I highly doubt if it is bcoz of changes in this PR.
---
Github user justinleet commented on the issue:
https://github.com/apache/metron/pull/803
@nickwallen I agree, unless I'm missing something, it seems like a bug with
recent searches, since you didn't say searches were weird during the initial
attempts.
---
Github user nickwallen commented on the issue:
https://github.com/apache/metron/pull/803
@justinleet @iraghumitra I am glad that no one else can reproduce. I will
work on trying to get a set of steps to reproduce this. Let's not worry about
this on the current PR.
---
Github user iraghumitra commented on the issue:
https://github.com/apache/metron/pull/803
@nickwallen That looks wicked can you share your manual steps that lead to
this?
---
Github user merrimanr commented on a diff in the pull request:
https://github.com/apache/metron/pull/843#discussion_r152347240
--- Diff:
metron-interface/metron-rest/src/main/java/org/apache/metron/rest/service/impl/SearchServiceImpl.java
---
@@ -96,6 +96,11 @@ public
Github user merrimanr commented on a diff in the pull request:
https://github.com/apache/metron/pull/843#discussion_r152347150
--- Diff:
metron-interface/metron-rest/src/test/java/org/apache/metron/rest/controller/SearchControllerIntegrationTest.java
---
@@ -132,6 +132,30 @@
Github user merrimanr commented on a diff in the pull request:
https://github.com/apache/metron/pull/843#discussion_r152347116
--- Diff:
metron-interface/metron-rest/src/main/java/org/apache/metron/rest/service/impl/SearchServiceImpl.java
---
@@ -96,6 +96,11 @@ public
Github user justinleet commented on the issue:
https://github.com/apache/metron/pull/803
@nickwallen I haven't been able to get into the same sort of state, but I
know you've used/tested the UI more than me. Do you know a repeatable way to
reproduce this? Or have you been able to
Github user nickwallen commented on the issue:
https://github.com/apache/metron/pull/803
Something seems to be wrong with saved searches. When I run through a
manual test script of creating metaalerts, deleting and navigating, most (if
not all) of my saved searches are these giant
Github user merrimanr commented on a diff in the pull request:
https://github.com/apache/metron/pull/803#discussion_r152311299
--- Diff:
metron-interface/metron-alerts/e2e/alerts-list/meta-alerts/meta-alert.po.ts ---
@@ -0,0 +1,43 @@
+/**
+ * Licensed to the Apache
Github user justinleet commented on a diff in the pull request:
https://github.com/apache/metron/pull/803#discussion_r152310478
--- Diff:
metron-interface/metron-alerts/e2e/alerts-list/meta-alerts/meta-alert.po.ts ---
@@ -0,0 +1,43 @@
+/**
+ * Licensed to the Apache
Github user iraghumitra commented on the issue:
https://github.com/apache/metron/pull/803
@merrimanr Thanks for
https://github.com/iraghumitra/incubator-metron/pull/5. It was a pretty
significant issue. I merged the fix ð
---
Github user nickwallen commented on the issue:
https://github.com/apache/metron/pull/841
That's weird @anandsubbu . What version of Vagrant and VirtualBox are you
running?
Here are the versions that I am running...
* Virtualbox Version 5.1.22 r115126
* Vagrant
Github user nickwallen commented on the issue:
https://github.com/apache/metron/pull/803
> I am not refreshing on purpose. If I refresh the UI after any operation
users would lose the current context and see new alerts (If available).
Ok @iraghumitra. Since you have a valid
Github user iraghumitra commented on the issue:
https://github.com/apache/metron/pull/803
@nickwallen I am not refreshing on purpose. If I refresh the UI after any
operation users would lose the current context and see new alerts (If
available). If you think this is not a major
Github user nickwallen commented on the issue:
https://github.com/apache/metron/pull/803
Hi @iraghumitra - The UI does not refresh itself after a metaalert is
deleted. If this is something easy to fix, let's tackle it. Otherwise, I can
create a JIRA to track this and we can fix it
Github user iraghumitra commented on the issue:
https://github.com/apache/metron/pull/803
I noticed that when I am running e2e test's, the comments that were added
in the previous run are still visible at times. The e2e tests delete's all the
comments that it added and the only way
Github user iraghumitra commented on the issue:
https://github.com/apache/metron/pull/803
@justinleet Thanks for taking time to test the PR. I was using an incorrect
index to find the alert to delete when I implemented the new API's I fixed it
now. Also added tests for all the issues
28 matches
Mail list logo
