[GitHub] incubator-metron issue #519: METRON-832 Fixed CEF parser for Palo Alto FITW

2017-04-10 Thread kylerichardson
Github user kylerichardson commented on the issue: https://github.com/apache/incubator-metron/pull/519 +1 by inspection --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled

[GitHub] incubator-metron issue #497: METRON-804: Create a document to describe kerbe...

2017-03-29 Thread kylerichardson
Github user kylerichardson commented on the issue: https://github.com/apache/incubator-metron/pull/497 @mmiklavc Nice document! Planning to run through it myself later this week. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub

[GitHub] incubator-metron issue #472: METRON-700: Add hadoop container to metron-dock...

2017-03-28 Thread kylerichardson
Github user kylerichardson commented on the issue: https://github.com/apache/incubator-metron/pull/472 Thanks! Next time the storm Dockerfile needs a tweak, I'll rework it to use the packages approach too. --- If your project is set up for it, you can reply to this email and have

[GitHub] incubator-metron issue #472: METRON-700: Add hadoop container to metron-dock...

2017-03-27 Thread kylerichardson
Github user kylerichardson commented on the issue: https://github.com/apache/incubator-metron/pull/472 @merrimanr Just pushed the changes for adding the indexing configs. Should be ready to go now. Can you give it another glance? --- If your project is set up for it, you can reply

[GitHub] incubator-metron issue #479: METRON-769 Added syslog prog to ASA patterns an...

2017-03-20 Thread kylerichardson
Github user kylerichardson commented on the issue: https://github.com/apache/incubator-metron/pull/479 +1 by inspection --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled

[GitHub] incubator-metron issue #472: METRON-700: Add hadoop container to metron-dock...

2017-03-08 Thread kylerichardson
Github user kylerichardson commented on the issue: https://github.com/apache/incubator-metron/pull/472 @merrimanr That's interesting. I did get warnings in the logs about the indexing configs but it seemed like the defaults applied and I was still able to see data indexed into HDFS

[GitHub] incubator-metron issue #471: METRON-755 Update GitHub PR Template

2017-03-06 Thread kylerichardson
Github user kylerichardson commented on the issue: https://github.com/apache/incubator-metron/pull/471 I'd prefer contributor comments at the top. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[GitHub] incubator-metron issue #472: METRON-700: Add hadoop container to metron-dock...

2017-03-04 Thread kylerichardson
Github user kylerichardson commented on the issue: https://github.com/apache/incubator-metron/pull/472 ### Description Added a Hadoop/HDFS container to metron-docker. As part of the change, the geo enrichment database is now staged in HDFS to closer mimic a real cluster

[GitHub] incubator-metron pull request #472: METRON-700: Add hadoop container to metr...

2017-03-04 Thread kylerichardson
GitHub user kylerichardson opened a pull request: https://github.com/apache/incubator-metron/pull/472 METRON-700: Add hadoop container to metron-docker Thank you for submitting a contribution to Apache Metron (Incubating). Please refer to our [Development Guidelines](https

[GitHub] incubator-metron issue #467: METRON-743: Sort the files when reading results...

2017-03-01 Thread kylerichardson
Github user kylerichardson commented on the issue: https://github.com/apache/incubator-metron/pull/467 @mmiklavc I ran into the same issue with installing pycapa on quick-dev. My solution was to tweak the playbook to rule the pycapa role as part of the sensor-stubs tag. --- If your

[GitHub] incubator-metron issue #467: METRON-743: Sort the files when reading results...

2017-02-27 Thread kylerichardson
Github user kylerichardson commented on the issue: https://github.com/apache/incubator-metron/pull/467 +1 passes unit and integration tests, ran through @cestella's test script successfully Thanks for your patience and for fixing! --- If your project is set up for it, you

[GitHub] incubator-metron issue #462: METRON-734 Builds failing because of MaxMind DB...

2017-02-23 Thread kylerichardson
Github user kylerichardson commented on the issue: https://github.com/apache/incubator-metron/pull/462 +1 to proceeded with commit based on @justinleet's Travis results On Thu, Feb 23, 2017 at 7:39 AM, Casey Stella <notificati...@github.com> wrote: &

[GitHub] incubator-metron issue #462: METRON-734 Builds failing because of MaxMind DB...

2017-02-22 Thread kylerichardson
Github user kylerichardson commented on the issue: https://github.com/apache/incubator-metron/pull/462 gotcha, must just be backed up today On Wed, Feb 22, 2017 at 3:07 PM, Casey Stella <notificati...@github.com> wrote: > @kylerichardson <https:

[GitHub] incubator-metron issue #462: METRON-734 Builds failing because of MaxMind DB...

2017-02-22 Thread kylerichardson
Github user kylerichardson commented on the issue: https://github.com/apache/incubator-metron/pull/462 +1 builds and all tests passing. Maybe close and reopen to kick travis? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub

[GitHub] incubator-metron issue #441: METRON-646: Add index templates to metron-docke...

2017-02-22 Thread kylerichardson
Github user kylerichardson commented on the issue: https://github.com/apache/incubator-metron/pull/441 Thanks, @merrimanr! I'll get that change pushed out later today. Waiting on #462 to be merged to fix the build errors we're seeing and then I'll rebase and push

[GitHub] incubator-metron issue #441: METRON-646: Add index templates to metron-docke...

2017-02-21 Thread kylerichardson
Github user kylerichardson commented on the issue: https://github.com/apache/incubator-metron/pull/441 bump... I read back through the discuss thread from the dev list and we didn't land on any specifics. There seems to be general agreement that metron-docker: - fulfills

[GitHub] incubator-metron issue #451: METRON-157: Added CEF Parser

2017-02-21 Thread kylerichardson
Github user kylerichardson commented on the issue: https://github.com/apache/incubator-metron/pull/451 Not from me. +1, great contribution. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] incubator-metron pull request #451: METRON-157: Added CEF Parser

2017-02-13 Thread kylerichardson
Github user kylerichardson commented on a diff in the pull request: https://github.com/apache/incubator-metron/pull/451#discussion_r100864330 --- Diff: metron-platform/metron-parsers/src/main/java/org/apache/metron/parsers/utils/DateUtils.java --- @@ -0,0 +1,78

[GitHub] incubator-metron pull request #451: METRON-157: Added CEF Parser

2017-02-13 Thread kylerichardson
Github user kylerichardson commented on a diff in the pull request: https://github.com/apache/incubator-metron/pull/451#discussion_r100862828 --- Diff: metron-platform/metron-parsers/src/main/java/org/apache/metron/parsers/cef/CEFParser.java --- @@ -0,0 +1,274

[GitHub] incubator-metron issue #451: METRON-157: Added CEF Parser

2017-02-11 Thread kylerichardson
Github user kylerichardson commented on the issue: https://github.com/apache/incubator-metron/pull/451 @simonellistonball, thanks for picking this one up! I have unassigned the JIRA from myself as I've clearly not had the time to work on it recently. --- If your project is set up

[GitHub] incubator-metron issue #441: METRON-646: Add index templates to metron-docke...

2017-02-05 Thread kylerichardson
Github user kylerichardson commented on the issue: https://github.com/apache/incubator-metron/pull/441 Good point, @nickwallen. My hope for metron-docker is as a lightweight alternative to vagrant for development. That said, I would hate to see it become a large overhead

[GitHub] incubator-metron pull request #441: METRON-646: Add index templates to metro...

2017-02-05 Thread kylerichardson
GitHub user kylerichardson opened a pull request: https://github.com/apache/incubator-metron/pull/441 METRON-646: Add index templates to metron-docker Enhance metron-docker environment by automatically deploying index templates to elasticsearch as part of the container startup

[GitHub] incubator-metron issue #413: METRON-654 Create RPM Installer for Profiler

2017-01-10 Thread kylerichardson
Github user kylerichardson commented on the issue: https://github.com/apache/incubator-metron/pull/413 +1 Performed same sanity check testing as @nickwallen --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well

[GitHub] incubator-metron issue #393: METRON-622: Create a Metron Docker Compose appl...

2017-01-10 Thread kylerichardson
Github user kylerichardson commented on the issue: https://github.com/apache/incubator-metron/pull/393 +1 Awesome contribution. I'm already working on some follow on PRs for this :-). --- If your project is set up for it, you can reply to this email and have your reply

[GitHub] incubator-metron issue #393: METRON-622: Create a Metron Docker Compose appl...

2017-01-05 Thread kylerichardson
Github user kylerichardson commented on the issue: https://github.com/apache/incubator-metron/pull/393 @merrimanr Thanks for pointing out the location of the storm logs. I think it would be worth adding that to the README. I have a fix for the kafkazk image running on local

[GitHub] incubator-metron issue #409: METRON-644 RPM builds only work with Docker for...

2017-01-05 Thread kylerichardson
Github user kylerichardson commented on the issue: https://github.com/apache/incubator-metron/pull/409 @justinleet Good catch. Updated the README to remove the note about Docker for Mac. --- If your project is set up for it, you can reply to this email and have your reply appear

[GitHub] incubator-metron issue #393: METRON-622: Create a Metron Docker Compose appl...

2017-01-03 Thread kylerichardson
Github user kylerichardson commented on the issue: https://github.com/apache/incubator-metron/pull/393 I'll created METRON-646 for the elasticsearch image customizations. I already have a start on those changes. --- If your project is set up for it, you can reply to this email

[GitHub] incubator-metron issue #393: METRON-622: Create a Metron Docker Compose appl...

2017-01-03 Thread kylerichardson
Github user kylerichardson commented on the issue: https://github.com/apache/incubator-metron/pull/393 I've run this up and successfully tested it using the examples provided in the README. It works as documented on docker-machine/boot2docker. Nice job. One showstopper for me

[GitHub] incubator-metron issue #393: METRON-622: Create a Metron Docker Compose appl...

2016-12-21 Thread kylerichardson
Github user kylerichardson commented on the issue: https://github.com/apache/incubator-metron/pull/393 Thanks for the explanation @merrimanr. I totally agree on the need for the local IDE to have access to the containerized services. It's an easy enough fix for me to manipulate

[GitHub] incubator-metron issue #396: METRON-625: Parser Filters cannot be specified ...

2016-12-19 Thread kylerichardson
Github user kylerichardson commented on the issue: https://github.com/apache/incubator-metron/pull/396 +1 by inspection. Thanks for fixing! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] incubator-metron issue #393: METRON-622: Create a Metron Docker Compose appl...

2016-12-18 Thread kylerichardson
Github user kylerichardson commented on the issue: https://github.com/apache/incubator-metron/pull/393 @merrimanr I'm super excited about this one! Thanks for your work! While kicking the tires on it, I did notice something that isn't really a bug but got me thinking

[GitHub] incubator-metron pull request #384: METRON-603 Update website to use Apache ...

2016-12-05 Thread kylerichardson
Github user kylerichardson commented on a diff in the pull request: https://github.com/apache/incubator-metron/pull/384#discussion_r90926228 --- Diff: site/_includes/primary-nav-items.html --- @@ -10,6 +10,6 @@ News - https://github.com

[GitHub] incubator-metron pull request #384: METRON-603 Update website to use Apache ...

2016-12-01 Thread kylerichardson
GitHub user kylerichardson opened a pull request: https://github.com/apache/incubator-metron/pull/384 METRON-603 Update website to use Apache release repo Update the DOWNLOAD link on the navigation menu of the website to point to the Apache release repository. Verified

[GitHub] incubator-metron pull request #382: METRON-598 Add Kyle Richardson to commit...

2016-12-01 Thread kylerichardson
GitHub user kylerichardson opened a pull request: https://github.com/apache/incubator-metron/pull/382 METRON-598 Add Kyle Richardson to committers Add Kyle Richardson to list of committers on website Verified site by following instructions on wiki [1]. [1] https

[GitHub] incubator-metron pull request #338: METRON-295: Script parsing bolt

2016-11-09 Thread kylerichardson
Github user kylerichardson commented on a diff in the pull request: https://github.com/apache/incubator-metron/pull/338#discussion_r87226233 --- Diff: metron-platform/metron-parsers/src/main/java/org/apache/metron/parsers/ScriptParser.java --- @@ -0,0 +1,175 @@ +package

[GitHub] incubator-metron pull request #338: METRON-295: Script parsing bolt

2016-11-09 Thread kylerichardson
Github user kylerichardson commented on a diff in the pull request: https://github.com/apache/incubator-metron/pull/338#discussion_r87228757 --- Diff: metron-platform/metron-parsers/src/main/java/org/apache/metron/parsers/ScriptParser.java --- @@ -0,0 +1,189

[GitHub] incubator-metron pull request #338: METRON-295: Script parsing bolt

2016-11-09 Thread kylerichardson
Github user kylerichardson commented on a diff in the pull request: https://github.com/apache/incubator-metron/pull/338#discussion_r87221966 --- Diff: metron-platform/metron-parsers/src/main/resources/scripts/python/common --- @@ -0,0 +1,20 @@ + # Licensed to the Apache

[GitHub] incubator-metron pull request #338: METRON-295: Script parsing bolt

2016-11-09 Thread kylerichardson
Github user kylerichardson commented on a diff in the pull request: https://github.com/apache/incubator-metron/pull/338#discussion_r87221525 --- Diff: metron-platform/metron-parsers/pom.xml.orig --- @@ -0,0 +1,370 @@ + + + +http://maven.apache.org/POM/4.0.0

[GitHub] incubator-metron pull request #338: METRON-295: Script parsing bolt

2016-11-09 Thread kylerichardson
Github user kylerichardson commented on a diff in the pull request: https://github.com/apache/incubator-metron/pull/338#discussion_r87221814 --- Diff: metron-platform/metron-parsers/src/main/resources/scripts/groovy/common --- @@ -0,0 +1,23 @@ +/** + * Licensed

[GitHub] incubator-metron issue #276: METRON-363 Fix Cisco ASA Parser

2016-11-02 Thread kylerichardson
Github user kylerichardson commented on the issue: https://github.com/apache/incubator-metron/pull/276 A big thank you to @ottobackwards for helping to troubleshoot the CI build fails. This should be good to go now. --- If your project is set up for it, you can reply to this email

[GitHub] incubator-metron issue #276: METRON-363 Fix Cisco ASA Parser

2016-11-01 Thread kylerichardson
Github user kylerichardson commented on the issue: https://github.com/apache/incubator-metron/pull/276 Ok, need some helping figuring out why the CI build keeps failing... I get several of these at the end of the log: ``` Running

[GitHub] incubator-metron pull request #276: METRON-363 Fix Cisco ASA Parser

2016-11-01 Thread kylerichardson
GitHub user kylerichardson reopened a pull request: https://github.com/apache/incubator-metron/pull/276 METRON-363 Fix Cisco ASA Parser I've rewritten the ASA parser which can be extended, as needed, to new ASA message types by editing the bundled asa patterns file and the static

[GitHub] incubator-metron pull request #276: METRON-363 Fix Cisco ASA Parser

2016-11-01 Thread kylerichardson
Github user kylerichardson closed the pull request at: https://github.com/apache/incubator-metron/pull/276 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] incubator-metron issue #276: METRON-363 Fix Cisco ASA Parser

2016-10-31 Thread kylerichardson
Github user kylerichardson commented on the issue: https://github.com/apache/incubator-metron/pull/276 Rebased against master to incorporate the global junit version change. Should be good to go now pending Travis. Thanks again to everyone for all of the suggestions, feedback

[GitHub] incubator-metron pull request #276: METRON-363 Fix Cisco ASA Parser

2016-10-29 Thread kylerichardson
Github user kylerichardson commented on a diff in the pull request: https://github.com/apache/incubator-metron/pull/276#discussion_r85651135 --- Diff: metron-platform/metron-parsers/src/main/resources/patterns/asa --- @@ -107,7 +108,7 @@ COMBINEDAPACHELOG %{COMMONAPACHELOG

[GitHub] incubator-metron issue #325: METRON-512 up default junit to 4.12

2016-10-26 Thread kylerichardson
Github user kylerichardson commented on the issue: https://github.com/apache/incubator-metron/pull/325 Great idea! +1 (non-binding) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] incubator-metron issue #276: METRON-363 Fix Cisco ASA Parser

2016-10-25 Thread kylerichardson
Github user kylerichardson commented on the issue: https://github.com/apache/incubator-metron/pull/276 Any other feedback or suggestions for me? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[GitHub] incubator-metron issue #276: METRON-363 Fix Cisco ASA Parser

2016-10-19 Thread kylerichardson
Github user kylerichardson commented on the issue: https://github.com/apache/incubator-metron/pull/276 Whew, got the CI build to finally pass. All integration and unit tests are passing. I've also re-testing in the single node vm environment I described above. --- If your project

[GitHub] incubator-metron pull request #276: METRON-363 Fix Cisco ASA Parser

2016-10-19 Thread kylerichardson
GitHub user kylerichardson reopened a pull request: https://github.com/apache/incubator-metron/pull/276 METRON-363 Fix Cisco ASA Parser I've rewritten the ASA parser which can be extended, as needed, to new ASA message types by editing the bundled asa patterns file and the static

[GitHub] incubator-metron pull request #276: METRON-363 Fix Cisco ASA Parser

2016-10-19 Thread kylerichardson
Github user kylerichardson closed the pull request at: https://github.com/apache/incubator-metron/pull/276 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] incubator-metron pull request #276: METRON-363 Fix Cisco ASA Parser

2016-10-17 Thread kylerichardson
Github user kylerichardson commented on a diff in the pull request: https://github.com/apache/incubator-metron/pull/276#discussion_r83768223 --- Diff: metron-platform/metron-parsers/src/main/java/org/apache/metron/parsers/utils/SyslogUtils.java --- @@ -0,0 +1,125

[GitHub] incubator-metron pull request #276: METRON-363 Fix Cisco ASA Parser

2016-10-14 Thread kylerichardson
Github user kylerichardson commented on a diff in the pull request: https://github.com/apache/incubator-metron/pull/276#discussion_r83520638 --- Diff: metron-platform/metron-parsers/src/test/java/org/apache/metron/parsers/utils/SyslogUtilsTest.java --- @@ -0,0 +1,61

[GitHub] incubator-metron pull request #276: METRON-363 Fix Cisco ASA Parser

2016-10-14 Thread kylerichardson
Github user kylerichardson commented on a diff in the pull request: https://github.com/apache/incubator-metron/pull/276#discussion_r83520042 --- Diff: metron-platform/metron-parsers/src/main/java/org/apache/metron/parsers/utils/SyslogUtils.java --- @@ -0,0 +1,89

[GitHub] incubator-metron issue #308: Metron-498 Grok patterns are now read from zook...

2016-10-14 Thread kylerichardson
Github user kylerichardson commented on the issue: https://github.com/apache/incubator-metron/pull/308 The ASA patterns file `/incubator-metron/metron-platform/metron-parsers/src/main/resources/patterns/asa` is being used (or soon will be) by PR #276. --- If your project is set up

[GitHub] incubator-metron issue #307: METRON-499 Check for Metron Jar Fails During Qu...

2016-10-12 Thread kylerichardson
Github user kylerichardson commented on the issue: https://github.com/apache/incubator-metron/pull/307 +1 (non-binding) Thanks for fixing. Tested in quick dev. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well

[GitHub] incubator-metron issue #276: METRON-363 Fix Cisco ASA Parser

2016-10-12 Thread kylerichardson
Github user kylerichardson commented on the issue: https://github.com/apache/incubator-metron/pull/276 @nickwallen Apologies, I should have been more specific. I tested using the same steps provided earlier in the PR. That said, my "single node vm" testing is not done wi

[GitHub] incubator-metron issue #276: METRON-363 Fix Cisco ASA Parser

2016-10-12 Thread kylerichardson
Github user kylerichardson commented on the issue: https://github.com/apache/incubator-metron/pull/276 Thanks. Looks like re-opening did the trick. I've done my best to incorporate everyone's feedback into this version. Re-tested in single node vm successfully. --- If your

[GitHub] incubator-metron pull request #276: METRON-363 Fix Cisco ASA Parser

2016-10-11 Thread kylerichardson
GitHub user kylerichardson reopened a pull request: https://github.com/apache/incubator-metron/pull/276 METRON-363 Fix Cisco ASA Parser I've rewritten the ASA parser which can be extended, as needed, to new ASA message types by editing the bundled asa patterns file and the static

[GitHub] incubator-metron pull request #276: METRON-363 Fix Cisco ASA Parser

2016-10-11 Thread kylerichardson
Github user kylerichardson closed the pull request at: https://github.com/apache/incubator-metron/pull/276 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] incubator-metron issue #276: METRON-363 Fix Cisco ASA Parser

2016-10-11 Thread kylerichardson
Github user kylerichardson commented on the issue: https://github.com/apache/incubator-metron/pull/276 Not entirely sure why the CI build failed. The error was: ``` testExample1(org.apache.metron.profiler.integration.ProfilerIntegrationTest) Time elapsed: 35.546 sec

[GitHub] incubator-metron pull request #302: METRON-492 Run metron_common build check...

2016-10-07 Thread kylerichardson
GitHub user kylerichardson opened a pull request: https://github.com/apache/incubator-metron/pull/302 METRON-492 Run metron_common build check as local_action When testing various deployment options, noticed the logic for the metron_common role didn't work as expected. Updated

[GitHub] incubator-metron pull request #276: METRON-363 Fix Cisco ASA Parser

2016-10-07 Thread kylerichardson
Github user kylerichardson commented on a diff in the pull request: https://github.com/apache/incubator-metron/pull/276#discussion_r82490277 --- Diff: metron-platform/metron-parsers/src/main/java/org/apache/metron/parsers/utils/SyslogUtils.java --- @@ -0,0 +1,89

[GitHub] incubator-metron pull request #276: METRON-363 Fix Cisco ASA Parser

2016-10-07 Thread kylerichardson
Github user kylerichardson commented on a diff in the pull request: https://github.com/apache/incubator-metron/pull/276#discussion_r82489921 --- Diff: metron-platform/metron-parsers/src/main/java/org/apache/metron/parsers/utils/SyslogUtils.java --- @@ -0,0 +1,89

[GitHub] incubator-metron pull request #276: METRON-363 Fix Cisco ASA Parser

2016-10-01 Thread kylerichardson
Github user kylerichardson commented on a diff in the pull request: https://github.com/apache/incubator-metron/pull/276#discussion_r81454727 --- Diff: metron-deployment/roles/metron_kafka_topics/defaults/main.yml --- @@ -21,6 +21,7 @@ topics_to_create: - { topic: &quo

[GitHub] incubator-metron pull request #276: METRON-363 Fix Cisco ASA Parser

2016-10-01 Thread kylerichardson
Github user kylerichardson commented on a diff in the pull request: https://github.com/apache/incubator-metron/pull/276#discussion_r81454659 --- Diff: metron-platform/metron-parsers/src/main/java/org/apache/metron/parsers/asa/BasicAsaParser.java --- @@ -0,0 +1,165

[GitHub] incubator-metron pull request #276: METRON-363 Fix Cisco ASA Parser

2016-10-01 Thread kylerichardson
Github user kylerichardson commented on a diff in the pull request: https://github.com/apache/incubator-metron/pull/276#discussion_r81454500 --- Diff: metron-platform/metron-parsers/src/main/java/org/apache/metron/parsers/asa/BasicAsaParser.java --- @@ -0,0 +1,165

[GitHub] incubator-metron pull request #276: METRON-363 Fix Cisco ASA Parser

2016-10-01 Thread kylerichardson
Github user kylerichardson commented on a diff in the pull request: https://github.com/apache/incubator-metron/pull/276#discussion_r81454486 --- Diff: metron-platform/metron-parsers/src/main/java/org/apache/metron/parsers/asa/BasicAsaParser.java --- @@ -0,0 +1,165

[GitHub] incubator-metron pull request #276: METRON-363 Fix Cisco ASA Parser

2016-10-01 Thread kylerichardson
Github user kylerichardson commented on a diff in the pull request: https://github.com/apache/incubator-metron/pull/276#discussion_r81453779 --- Diff: metron-platform/metron-parsers/src/main/java/org/apache/metron/parsers/asa/BasicAsaParser.java --- @@ -0,0 +1,165

[GitHub] incubator-metron pull request #276: METRON-363 Fix Cisco ASA Parser

2016-10-01 Thread kylerichardson
Github user kylerichardson commented on a diff in the pull request: https://github.com/apache/incubator-metron/pull/276#discussion_r81453224 --- Diff: metron-platform/metron-integration-test/src/main/sample/data/asa/raw/asa_raw --- @@ -0,0 +1,128 @@ +<167>Jan 5 08

[GitHub] incubator-metron issue #276: METRON-363 Fix Cisco ASA Parser

2016-09-28 Thread kylerichardson
Github user kylerichardson commented on the issue: https://github.com/apache/incubator-metron/pull/276 @nickwallen @cestella Thanks very much for the feedback! Much appreciated. I'll get started on these changes and respond to your questions as soon as I can. --- If your project

[GitHub] incubator-metron issue #276: METRON-363 Fix Cisco ASA Parser

2016-09-28 Thread kylerichardson
Github user kylerichardson commented on the issue: https://github.com/apache/incubator-metron/pull/276 **Testing** It occurs to me I haven't outlined how to test or how I tested this code (apologies, this is my first PR). All my testing was performed on a single node

[GitHub] incubator-metron issue #276: METRON-363 Fix Cisco ASA Parser

2016-09-27 Thread kylerichardson
Github user kylerichardson commented on the issue: https://github.com/apache/incubator-metron/pull/276 Currently my branch doesn't have build_utils. Going to rebase and see if that fixes the CI build. --- If your project is set up for it, you can reply to this email and have your

[GitHub] incubator-metron issue #276: METRON-363 Fix Cisco ASA Parser

2016-09-27 Thread kylerichardson
Github user kylerichardson commented on the issue: https://github.com/apache/incubator-metron/pull/276 I've tested in a slimmed down single node vm (no sensors) but not in vagrant. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub

[GitHub] incubator-metron pull request #276: METRON-363 Fix Cisco ASA Parser

2016-09-26 Thread kylerichardson
GitHub user kylerichardson opened a pull request: https://github.com/apache/incubator-metron/pull/276 METRON-363 Fix Cisco ASA Parser I've rewritten the ASA parser which can be extended, as needed, to new ASA message types by editing the bundled asa patterns file and the static map