[GitHub] [mina] elecharny commented on issue #25: make NioProcessor and NioSocketAcceptor extendable by removing final from class declaration

elecharny commented on issue #25: URL: https://github.com/apache/mina/pull/25#issuecomment-617576157 Was thinking about your requirement... Wondering : would it make sense for you to implement your own flavor of NioAcceptor for that purpose ? (note : your suggestion is trivia

[GitHub] [mina] snufkinsnorka commented on issue #25: make NioProcessor and NioSocketAcceptor extendable by removing final from class declaration

snufkinsnorka commented on issue #25: URL: https://github.com/apache/mina/pull/25#issuecomment-617560051 @elecharny ping :) This is an automated message from the Apache Git Service. To respond to the message, please log on to

Re: Autoformat source code issue

Merge yours, I'll try another ackk (remove / add back) tomorrow. Le mar. 21 avr. 2020 à 19:44, Lyor Goldstein a écrit : > >> >> Could you try with https://github.com/gnodet/mina-sshd/tree/SSHD-978 > and see if it's stable for you > > Works for me - except BCrypt.java seems to still require CRL

Re: Autoformat source code issue

>> >> Could you try with https://github.com/gnodet/mina-sshd/tree/SSHD-978 and see if it's stable for you Works for me - except BCrypt.java seems to still require CRLF changes somehow I guess it will keep doing that every time we "ping pong" commits for it. I therefore think since it is the only

Re: Autoformat source code issue

>> I can still see mixed lf / crlf in the BCrypt.java file, so I'll push another commit to get rid of those. I saw the same and tried to get rid of them - no success either >> Could you try with https://github.com/gnodet/mina-sshd/tree/SSHD-978 and see if it's stable for you Will do - but if BCr

[GitHub] [mina-sshd] lgoldstein commented on a change in pull request #124: [SSHD-982] Fix race condition when loading known hosts file

lgoldstein commented on a change in pull request #124: URL: https://github.com/apache/mina-sshd/pull/124#discussion_r412261261 ## File path: sshd-core/src/main/java/org/apache/sshd/client/keyverifier/KnownHostsServerKeyVerifier.java ## @@ -153,35 +153,43 @@ public void setMod

[jira] [Work logged] (SSHD-982) Race condition when loading known hosts

[ https://issues.apache.org/jira/browse/SSHD-982?focusedWorklogId=425728&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-425728 ] ASF GitHub Bot logged work on SSHD-982: --- Author: ASF GitHub Bot

[jira] [Work logged] (SSHD-982) Race condition when loading known hosts

[ https://issues.apache.org/jira/browse/SSHD-982?focusedWorklogId=425727&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-425727 ] ASF GitHub Bot logged work on SSHD-982: --- Author: ASF GitHub Bot

[GitHub] [mina-sshd] FliegenKLATSCH commented on a change in pull request #124: [SSHD-982] Fix race condition when loading known hosts file

FliegenKLATSCH commented on a change in pull request #124: URL: https://github.com/apache/mina-sshd/pull/124#discussion_r412255847 ## File path: sshd-core/src/main/java/org/apache/sshd/client/keyverifier/KnownHostsServerKeyVerifier.java ## @@ -153,35 +153,43 @@ public void se

[jira] [Work logged] (SSHD-982) Race condition when loading known hosts

[ https://issues.apache.org/jira/browse/SSHD-982?focusedWorklogId=425723&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-425723 ] ASF GitHub Bot logged work on SSHD-982: --- Author: ASF GitHub Bot

[GitHub] [mina-sshd] lgoldstein commented on a change in pull request #124: [SSHD-982] Fix race condition when loading known hosts file

lgoldstein commented on a change in pull request #124: URL: https://github.com/apache/mina-sshd/pull/124#discussion_r412253325 ## File path: sshd-core/src/main/java/org/apache/sshd/client/keyverifier/KnownHostsServerKeyVerifier.java ## @@ -153,35 +153,43 @@ public void setMod

[jira] [Work logged] (SSHD-982) Race condition when loading known hosts

[ https://issues.apache.org/jira/browse/SSHD-982?focusedWorklogId=425722&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-425722 ] ASF GitHub Bot logged work on SSHD-982: --- Author: ASF GitHub Bot

[GitHub] [mina-sshd] lgoldstein commented on a change in pull request #124: [SSHD-982] Fix race condition when loading known hosts file

lgoldstein commented on a change in pull request #124: URL: https://github.com/apache/mina-sshd/pull/124#discussion_r412252747 ## File path: sshd-core/src/main/java/org/apache/sshd/client/keyverifier/KnownHostsServerKeyVerifier.java ## @@ -153,35 +153,43 @@ public void setMod

[GitHub] [mina-sshd] lgoldstein commented on a change in pull request #122: Allow colon as valid host pattern char to support ipv6 entries in kno…

lgoldstein commented on a change in pull request #122: URL: https://github.com/apache/mina-sshd/pull/122#discussion_r412249624 ## File path: sshd-core/src/test/resources/org/apache/sshd/client/keyverifier/known_hosts ## @@ -13,3 +13,5 @@ server.sshd.apache.org,10.23.222.240 ec

[GitHub] [mina-sshd] lgoldstein commented on issue #122: Allow colon as valid host pattern char to support ipv6 entries in kno…

lgoldstein commented on issue #122: URL: https://github.com/apache/mina-sshd/pull/122#issuecomment-617223739 >> Should be fine now. Thx - will check it out and merge it in the next few days >> Do you already have any plannings regarding the next release (date)? Not reall

Re: Autoformat source code issue

>> When working on an existing repo and modifying the .gitattributes, you may need to use the --renormalize option as indicated in https://help.github.com/en/github/using-git/configuring-git-to-handle-line-endings#refreshing-a-repository-after-changing-line-endings to fix the line endings. >> Afte

[jira] [Work logged] (SSHD-978) Autoformat source code instead of using checkstyle

[ https://issues.apache.org/jira/browse/SSHD-978?focusedWorklogId=425705&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-425705 ] ASF GitHub Bot logged work on SSHD-978: --- Author: ASF GitHub Bot

[GitHub] [mina-sshd] lgoldstein opened a new pull request #125: [SSHD-978] Updated EOL settings

lgoldstein opened a new pull request #125: URL: https://github.com/apache/mina-sshd/pull/125 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[jira] [Commented] (SSHD-979) Rework SFTP streams so that we can send or receive as much data as possible

[ https://issues.apache.org/jira/browse/SSHD-979?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17088720#comment-17088720 ] Subramaniajeeva commented on SSHD-979: -- Thanks for the input. Hoping to see this in n

[GitHub] [mina-sshd] lgoldstein commented on a change in pull request #123: SFTP transfer speeds, clean API

lgoldstein commented on a change in pull request #123: URL: https://github.com/apache/mina-sshd/pull/123#discussion_r412199074 ## File path: sshd-core/src/main/java/org/apache/sshd/common/session/helpers/AbstractSession.java ## @@ -954,7 +954,9 @@ protected IoWriteFuture doWri

[GitHub] [mina-sshd] gnodet commented on a change in pull request #123: SFTP transfer speeds, clean API

gnodet commented on a change in pull request #123: URL: https://github.com/apache/mina-sshd/pull/123#discussion_r412196892 ## File path: sshd-core/src/main/java/org/apache/sshd/common/session/helpers/AbstractSession.java ## @@ -954,7 +954,9 @@ protected IoWriteFuture doWritePa

[GitHub] [mina-sshd] lgoldstein commented on a change in pull request #123: SFTP transfer speeds, clean API

lgoldstein commented on a change in pull request #123: URL: https://github.com/apache/mina-sshd/pull/123#discussion_r412195385 ## File path: sshd-core/src/main/java/org/apache/sshd/common/session/helpers/AbstractSession.java ## @@ -954,7 +954,9 @@ protected IoWriteFuture doWri

[GitHub] [mina-sshd] gnodet commented on a change in pull request #123: SFTP transfer speeds, clean API

gnodet commented on a change in pull request #123: URL: https://github.com/apache/mina-sshd/pull/123#discussion_r412193011 ## File path: sshd-core/src/main/java/org/apache/sshd/common/session/helpers/AbstractSession.java ## @@ -954,7 +954,9 @@ protected IoWriteFuture doWritePa

[GitHub] [mina-sshd] gnodet commented on a change in pull request #123: SFTP transfer speeds, clean API

gnodet commented on a change in pull request #123: URL: https://github.com/apache/mina-sshd/pull/123#discussion_r412193011 ## File path: sshd-core/src/main/java/org/apache/sshd/common/session/helpers/AbstractSession.java ## @@ -954,7 +954,9 @@ protected IoWriteFuture doWritePa

[GitHub] [mina-sshd] lgoldstein commented on a change in pull request #123: SFTP transfer speeds, clean API

lgoldstein commented on a change in pull request #123: URL: https://github.com/apache/mina-sshd/pull/123#discussion_r412178637 ## File path: sshd-core/src/main/java/org/apache/sshd/common/session/helpers/AbstractSession.java ## @@ -954,7 +954,9 @@ protected IoWriteFuture doWri

[GitHub] [mina-sshd] lgoldstein commented on a change in pull request #123: SFTP transfer speeds, clean API

lgoldstein commented on a change in pull request #123: URL: https://github.com/apache/mina-sshd/pull/123#discussion_r412176392 ## File path: sshd-sftp/src/main/java/org/apache/sshd/client/subsystem/sftp/impl/SftpRemotePathChannel.java ## @@ -524,13 +527,13 @@ protected void en

[GitHub] [mina-sshd] lgoldstein commented on a change in pull request #123: SFTP transfer speeds, clean API

lgoldstein commented on a change in pull request #123: URL: https://github.com/apache/mina-sshd/pull/123#discussion_r412176062 ## File path: sshd-sftp/src/test/java/org/apache/sshd/client/subsystem/sftp/SftpTransferTest.java ## @@ -0,0 +1,131 @@ +/* + * Licensed to the Apache

[jira] [Commented] (SSHD-981) Implement no-flow-control SFTP extension

[ https://issues.apache.org/jira/browse/SSHD-981?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17088664#comment-17088664 ] Lyor Goldstein commented on SSHD-981: - Great - thanks > Implement no-flow-control SFTP

[jira] [Commented] (SSHD-979) Rework SFTP streams so that we can send or receive as much data as possible

[ https://issues.apache.org/jira/browse/SSHD-979?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17088661#comment-17088661 ] Guillaume Nodet commented on SSHD-979: -- The problems I fixed are in the client.  But y

[jira] [Commented] (SSHD-979) Rework SFTP streams so that we can send or receive as much data as possible

[ https://issues.apache.org/jira/browse/SSHD-979?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17088652#comment-17088652 ] Subramaniajeeva commented on SSHD-979: -- [~gnodet]    By x ms latency you mean the ti

[jira] [Comment Edited] (SSHD-979) Rework SFTP streams so that we can send or receive as much data as possible

[ https://issues.apache.org/jira/browse/SSHD-979?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17088576#comment-17088576 ] Guillaume Nodet edited comment on SSHD-979 at 4/21/20, 11:14 AM:

[jira] [Commented] (SSHD-979) Rework SFTP streams so that we can send or receive as much data as possible

[ https://issues.apache.org/jira/browse/SSHD-979?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17088576#comment-17088576 ] Guillaume Nodet commented on SSHD-979: -- Here is the output of the SftpPerformanceTest

[jira] [Commented] (SSHD-979) Rework SFTP streams so that we can send or receive as much data as possible

[ https://issues.apache.org/jira/browse/SSHD-979?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17088470#comment-17088470 ] Subramaniajeeva commented on SSHD-979: -- Is there any comparision of speed before and a

[jira] [Commented] (SSHD-981) Implement no-flow-control SFTP extension

[ https://issues.apache.org/jira/browse/SSHD-981?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17088452#comment-17088452 ] Guillaume Nodet commented on SSHD-981: -- This extension has been specified by [https://

[jira] [Updated] (SSHD-981) Implement no-flow-control SFTP extension

[ https://issues.apache.org/jira/browse/SSHD-981?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Guillaume Nodet updated SSHD-981: - Description: This extension has been specified by  [https://tools.ietf.org/html/rfc8308] > Implemen

[jira] [Resolved] (SSHD-978) Autoformat source code instead of using checkstyle

[ https://issues.apache.org/jira/browse/SSHD-978?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Guillaume Nodet resolved SSHD-978. -- Resolution: Fixed > Autoformat source code instead of using checkstyle >

[jira] [Resolved] (SSHD-979) Rework SFTP streams so that we can send or receive as much data as possible

[ https://issues.apache.org/jira/browse/SSHD-979?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Guillaume Nodet resolved SSHD-979. -- Resolution: Fixed > Rework SFTP streams so that we can send or receive as much data as possible >

[jira] [Resolved] (SSHD-980) Make the SFTP Api cleaner by moving the implementation classes into the non public package

[ https://issues.apache.org/jira/browse/SSHD-980?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Guillaume Nodet resolved SSHD-980. -- Resolution: Fixed > Make the SFTP Api cleaner by moving the implementation classes into the non

[jira] [Commented] (SSHD-982) Race condition when loading known hosts

[ https://issues.apache.org/jira/browse/SSHD-982?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17088394#comment-17088394 ] FliegenKLATSCH commented on SSHD-982: - [https://github.com/apache/mina-sshd/pull/124]

[jira] [Work logged] (SSHD-982) Race condition when loading known hosts

[ https://issues.apache.org/jira/browse/SSHD-982?focusedWorklogId=425596&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-425596 ] ASF GitHub Bot logged work on SSHD-982: --- Author: ASF GitHub Bot

[GitHub] [mina-sshd] FliegenKLATSCH opened a new pull request #124: [SSHD-982] Fix race condition when loading known hosts file

FliegenKLATSCH opened a new pull request #124: URL: https://github.com/apache/mina-sshd/pull/124 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL ab

[jira] [Created] (SSHD-982) Race condition when loading known hosts

FliegenKLATSCH created SSHD-982: --- Summary: Race condition when loading known hosts Key: SSHD-982 URL: https://issues.apache.org/jira/browse/SSHD-982 Project: MINA SSHD Issue Type: Bug Affec