[jira] [Commented] (SSHD-966) Deadlock on disconnection at the end of key-exchange

[ https://issues.apache.org/jira/browse/SSHD-966?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17520362#comment-17520362 ] Thomas Wolf commented on SSHD-966: -- Yes, the code becomes more complicated. I think one p

Re: MINA 2.2.0-M1

Hi Christophe, sorry, my late mail was off base. The pb here is that the SSLEngine excpeiton is not propagated to the handler, when it should. My guess is that we have some missing call somewhere in the stack. I'm going to check that out. On 11/04/2022 00:15, Christoph John wrote: Hi, th

Re: MINA 2.2.0-M1

Hi! I've made a slight mistake yesterday evening (or should I say this early this morning): I name the release 2.2.0. I haven't yet launch the vote, so I may revert and delete the release to name it 2.2.0-M1, and also check the pb Cristoph is mentionning (the non propagation of an exception

[jira] [Commented] (SSHD-966) Deadlock on disconnection at the end of key-exchange

[ https://issues.apache.org/jira/browse/SSHD-966?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17520446#comment-17520446 ] Thomas Wolf commented on SSHD-966: -- I'm actually making good progress with a solution that

Re: MINA 2.2.0-M1

Hi Emmanuel, another short question that came up when checking my unit tests. Formerly there was a method SslFilter.getSslSession: https://github.com/apache/mina/blob/35aafff17ee3fc655844058b28489c4c14af65fa/mina-core/src/main/java/org/apache/mina/filter/ssl/SslFilter.java#L199 What is the re

Re: MINA 2.2.0-M1

Its now exposed through this Attribute https://github.com/apache/mina/blob/9c237cabb4ecc5ef8c379cc2d7a75c9d09c164cb/mina-core/src/main/java/org/apache/mina/filter/ssl/SslFilter.java#L57 This change ensures that the developer can only access that object after the handshake is complete. CONFIDENTI

Re: MINA 2.2.0-M1

Works like a charm, thank you. Cheers, Chris. On 11.04.22 13:48, Jonathan Valliere wrote: Its now exposed through this Attribute https://github.com/apache/mina/blob/9c237cabb4ecc5ef8c379cc2d7a75c9d09c164cb/mina-core/src/main/java/org/apache/mina/filter/ssl/SslFilter.java#L57 This change ensur

[GitHub] [mina-ftpserver] elecharny commented on pull request #15: [FTPSERVER-509] Enable GitHub Action build

elecharny commented on PR #15: URL: https://github.com/apache/mina-ftpserver/pull/15#issuecomment-1095075313 Hi Gary, we don't use anymore the master branch. Development is done in the 1.1.X or 1.2.X branches. -- This is an automated message from the Apache Git Service. To respond

GitHub Action builds

Hi All: I enabled GitHub Actions builds which will give us quick feedback on PRs as well as sanity checks for building and testing on Java LTS versions. See https://github.com/apache/mina-ftpserver/actions Gary

Re: GitHub Action builds

Super, thanks Gregory ! On 11/04/2022 15:57, Gary Gregory wrote: Hi All: I enabled GitHub Actions builds which will give us quick feedback on PRs as well as sanity checks for building and testing on Java LTS versions. See https://github.com/apache/mina-ftpserver/actions Gary -- *Emmanuel L

[jira] [Commented] (SSHD-966) Deadlock on disconnection at the end of key-exchange

[ https://issues.apache.org/jira/browse/SSHD-966?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17520691#comment-17520691 ] Lyor Goldstein commented on SSHD-966: - {quote} I'm actually making good progress with a

[GitHub] [mina-ftpserver] garydgregory commented on pull request #15: [FTPSERVER-509] Enable GitHub Action build

garydgregory commented on PR #15: URL: https://github.com/apache/mina-ftpserver/pull/15#issuecomment-1095301707 Good to know, TY! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comm

Re: GitHub Action builds

YW. As I mentioned at some point in the past, I will add support for checking binary compatibility. I see we already have an "enforce" profile, so I will make it part of that. Then that can become part of the GitHub build. Gary On Mon, Apr 11, 2022, 11:07 Emmanuel Lécharny wrote: > Super, than

[jira] [Closed] (FTPSERVER-509) Enable GitHub Action build

[ https://issues.apache.org/jira/browse/FTPSERVER-509?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gary D. Gregory closed FTPSERVER-509. - Resolution: Fixed Done in 1.1.x and 1.2.x (and master) but that's unused) > Enable Gi

Re: GitHub Action builds

Hm, if I make a BC check as part of the enforce profile, I'll have to fix Checkstyle errors. There are a lot, simple, but quite a few. Do we want that? Gary On Mon, Apr 11, 2022, 14:15 Gary Gregory wrote: > YW. As I mentioned at some point in the past, I will add support for > checking binary c