[jira] [Commented] (DIRMINA-893) 'fake deadlock' causes IoFuture.await() to malfunction

2018-03-05 Thread Jonathan Valliere (JIRA)
[ https://issues.apache.org/jira/browse/DIRMINA-893?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16386375#comment-16386375 ] Jonathan Valliere commented on DIRMINA-893: --- That is interesting. because I probably would have

[jira] [Commented] (DIRMINA-1068) Mina 2.0.7 cpu load 100% on windows server 64

2018-03-05 Thread Jonathan Valliere (JIRA)
[ https://issues.apache.org/jira/browse/DIRMINA-1068?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16386352#comment-16386352 ] Jonathan Valliere commented on DIRMINA-1068: Please pull MINA from GIT and compile the 2.0

[jira] [Commented] (DIRMINA-1079) MINA fails to connect from behind a proxy if endpoint is not resolved

2018-03-05 Thread Jonathan Valliere (JIRA)
[ https://issues.apache.org/jira/browse/DIRMINA-1079?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16386331#comment-16386331 ] Jonathan Valliere commented on DIRMINA-1079: Please make your suggestion as a patch created

[jira] [Commented] (DIRMINA-893) 'fake deadlock' causes IoFuture.await() to malfunction

2018-03-05 Thread Jonathan Valliere (JIRA)
[ https://issues.apache.org/jira/browse/DIRMINA-893?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16386323#comment-16386323 ] Jonathan Valliere commented on DIRMINA-893: --- Seems to me like a deadlock check should

Re: Errors when buuilding MINA 2.0 branch

2018-03-03 Thread Jonathan Valliere
<elecha...@gmail.com> wrote: > > > Le 03/03/2018 à 21:15, Jonathan Valliere a écrit : > > Emmanuel, > > > > IMHO ConnectorTest, from a quick glance, suffers from some pretty bad > > concurrency problems in how it waits on the handler and manipulates

Re: Errors when buuilding MINA 2.0 branch

2018-03-03 Thread Jonathan Valliere
anything wrong with Mina. On Sat, Mar 3, 2018 at 2:48 PM, Jonathan Valliere <john...@apache.org> wrote: > I’m fixing AprIo right now > > On Sat, Mar 3, 2018 at 2:47 PM Emmanuel Lécharny <elecha...@gmail.com> > wrote: > >> Hi, >> >> I'm trying to build MINA

Re: Errors when buuilding MINA 2.0 branch

2018-03-03 Thread Jonathan Valliere
I’m fixing AprIo right now On Sat, Mar 3, 2018 at 2:47 PM Emmanuel Lécharny wrote: > Hi, > > I'm trying to build MINA 2.0 with the latest changes made by Jonathan, > and I get some random error in a test : > > [ERROR] Tests run: 3, Failures: 1, Errors: 0, Skipped: 0, Time

[jira] [Commented] (DIRMINA-1076) Leaking NioProcessors/NioSocketConnectors hanging in call to dispose

2018-03-02 Thread Jonathan Valliere (JIRA)
[ https://issues.apache.org/jira/browse/DIRMINA-1076?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16383990#comment-16383990 ] Jonathan Valliere commented on DIRMINA-1076: [~elecharny] What branch should I apply

Re: How to handle NetworkRecycledException in AbstractPollingIoAcceptor?

2018-02-26 Thread Jonathan Valliere
It is going to be complicated to re-bind; probably the first patch will simply let it fully fail. I’ll have to test the ulimit protection to see if I can determine if the exception is related to ulimit or something else. On Mon, Feb 26, 2018 at 11:35 AM, dgriff wrote:

[jira] [Updated] (DIRMINA-1076) Leaking NioProcessors/NioSocketConnectors hanging in call to dispose

2018-02-26 Thread Jonathan Valliere (JIRA)
[ https://issues.apache.org/jira/browse/DIRMINA-1076?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jonathan Valliere updated DIRMINA-1076: --- Component/s: Core > Leaking NioProcessors/NioSocketConnectors hanging in c

[jira] [Updated] (DIRMINA-1076) Leaking NioProcessors/NioSocketConnectors hanging in call to dispose

2018-02-26 Thread Jonathan Valliere (JIRA)
[ https://issues.apache.org/jira/browse/DIRMINA-1076?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jonathan Valliere updated DIRMINA-1076: --- Fix Version/s: 2.0.17 > Leaking NioProcessors/NioSocketConnectors hanging in c

[jira] [Updated] (DIRMINA-1077) Threads hanging in dispose() on SSLHandshakeException

2018-02-26 Thread Jonathan Valliere (JIRA)
[ https://issues.apache.org/jira/browse/DIRMINA-1077?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jonathan Valliere updated DIRMINA-1077: --- Fix Version/s: 2.0.17 > Threads hanging in dispose() on SSLHandshakeExcept

Release Targets in JIRA

2018-02-26 Thread Jonathan Valliere
Just a thought… At work, we always have a release target similar to 2.0-NEXT which always represents the next release. When a new release is completed, the target is renamed to the correct version number and a new 2.0-NEXT release is created. This style makes it easier to configure and schedule

[jira] [Work started] (DIRMINA-1077) Threads hanging in dispose() on SSLHandshakeException

2018-02-26 Thread Jonathan Valliere (JIRA)
[ https://issues.apache.org/jira/browse/DIRMINA-1077?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Work on DIRMINA-1077 started by Jonathan Valliere. -- > Threads hanging in dispose() on SSLHandshakeExcept

[jira] [Work started] (DIRMINA-1076) Leaking NioProcessors/NioSocketConnectors hanging in call to dispose

2018-02-26 Thread Jonathan Valliere (JIRA)
[ https://issues.apache.org/jira/browse/DIRMINA-1076?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Work on DIRMINA-1076 started by Jonathan Valliere. -- > Leaking NioProcessors/NioSocketConnectors hanging in c

[jira] [Commented] (DIRMINA-1076) Leaking NioProcessors/NioSocketConnectors hanging in call to dispose

2018-02-25 Thread Jonathan Valliere (JIRA)
[ https://issues.apache.org/jira/browse/DIRMINA-1076?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16376223#comment-16376223 ] Jonathan Valliere commented on DIRMINA-1076: [~chrjohn] Please apply the patch for Option 3

Re: Needs Immutable Iterator

2018-02-25 Thread Jonathan Valliere
Thanks for the replies; I ended up figuring out a way to not require it. On Sat, Feb 24, 2018 at 9:42 PM Emmanuel Lécharny <elecha...@gmail.com> wrote: > > > Le 25/02/2018 à 00:59, Jonathan Valliere a écrit : > > Hi Everyone, > > > > Working on a couple of bugs

[jira] [Commented] (DIRMINA-1076) Leaking NioProcessors/NioSocketConnectors hanging in call to dispose

2018-02-24 Thread Jonathan Valliere (JIRA)
[ https://issues.apache.org/jira/browse/DIRMINA-1076?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16375945#comment-16375945 ] Jonathan Valliere commented on DIRMINA-1076: {{wakeup()}} actually doesn't mitigate the next

[jira] [Commented] (DIRMINA-1076) Leaking NioProcessors/NioSocketConnectors hanging in call to dispose

2018-02-24 Thread Jonathan Valliere (JIRA)
[ https://issues.apache.org/jira/browse/DIRMINA-1076?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16375929#comment-16375929 ] Jonathan Valliere commented on DIRMINA-1076: {{selector.close()}} occurs inside

[jira] [Commented] (DIRMINA-1076) Leaking NioProcessors/NioSocketConnectors hanging in call to dispose

2018-02-24 Thread Jonathan Valliere (JIRA)
[ https://issues.apache.org/jira/browse/DIRMINA-1076?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16375919#comment-16375919 ] Jonathan Valliere commented on DIRMINA-1076: When called from the {{IoProcessor}} worker

[jira] [Commented] (DIRMINA-1076) Leaking NioProcessors/NioSocketConnectors hanging in call to dispose

2018-02-24 Thread Jonathan Valliere (JIRA)
[ https://issues.apache.org/jira/browse/DIRMINA-1076?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16375908#comment-16375908 ] Jonathan Valliere commented on DIRMINA-1076: The problem is no atomic method of knowing

[jira] [Commented] (DIRMINA-1077) Threads hanging in dispose() on SSLHandshakeException

2018-02-24 Thread Jonathan Valliere (JIRA)
[ https://issues.apache.org/jira/browse/DIRMINA-1077?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16375885#comment-16375885 ] Jonathan Valliere commented on DIRMINA-1077: Seems like DIRMINA-1076 was not fully fixed

[jira] [Commented] (DIRMINA-1076) Leaking NioProcessors/NioSocketConnectors hanging in call to dispose

2018-02-24 Thread Jonathan Valliere (JIRA)
[ https://issues.apache.org/jira/browse/DIRMINA-1076?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16375884#comment-16375884 ] Jonathan Valliere commented on DIRMINA-1076: *Why Patch 2.0 doesn't fully work* Seems like

Needs Immutable Iterator

2018-02-24 Thread Jonathan Valliere
Hi Everyone, Working on a couple of bugs and needed an Immutable Iterator. Is there an Immutable Iterator in any of the existing dependencies or the codebase of Mina that I should use instead of adding one. -J

Re: How to handle NetworkRecycledException in AbstractPollingIoAcceptor?

2018-02-22 Thread Jonathan Valliere
What is it that you expect Mina to do when the networking is reset? On Thu, Feb 22, 2018 at 5:48 AM, dgriff wrote: > Yes, it contains that message. How would you handle such an exception? > > > > -- > Sent from: http://apache-mina.10907.n7.nabble.com/Apache-MINA- >

Re: How to handle NetworkRecycledException in AbstractPollingIoAcceptor?

2018-02-21 Thread Jonathan Valliere
So, that is an IBM specific exception which extends IOException. Is the message “Network Recycled while accepting connection” ? We can’t watch for NetworkRecycledException but can probably watch for an IOException with the word “recycled” in the message. On Wed, Feb 21, 2018 at 12:33 PM, dgriff

[jira] [Commented] (DIRMINA-1077) Threads hanging in dispose() on SSLHandshakeException

2018-02-19 Thread Jonathan Valliere (JIRA)
[ https://issues.apache.org/jira/browse/DIRMINA-1077?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16369313#comment-16369313 ] Jonathan Valliere commented on DIRMINA-1077: I'm waiting to commit DIRMINA-1076 until I can

Re: Linter / Code Formatting

2018-02-19 Thread Jonathan Valliere
t; > > Le 19/02/2018 à 16:47, Jonathan Valliere a écrit : > > Any interest in adding support for a linter to automatically check for > > formatting / quality issues and formatting the code to enforce consistent > > style across the entire codebase? > > > > I w

Linter / Code Formatting

2018-02-19 Thread Jonathan Valliere
Any interest in adding support for a linter to automatically check for formatting / quality issues and formatting the code to enforce consistent style across the entire codebase?

[jira] [Commented] (DIRMINA-1078) OrderedThreadPoolExecutor should allow sessions to be prioritized

2018-02-19 Thread Jonathan Valliere (JIRA)
[ https://issues.apache.org/jira/browse/DIRMINA-1078?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16369225#comment-16369225 ] Jonathan Valliere commented on DIRMINA-1078: Might be a good idea to create and add a Unit

[jira] [Commented] (DIRMINA-1078) OrderedThreadPoolExecutor should allow sessions to be prioritized

2018-02-19 Thread Jonathan Valliere (JIRA)
[ https://issues.apache.org/jira/browse/DIRMINA-1078?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16369199#comment-16369199 ] Jonathan Valliere commented on DIRMINA-1078: Idk? Call the class "SortingThreadPoolExe

[jira] [Commented] (DIRMINA-1078) OrderedThreadPoolExecutor should allow sessions to be prioritized

2018-02-19 Thread Jonathan Valliere (JIRA)
[ https://issues.apache.org/jira/browse/DIRMINA-1078?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16369181#comment-16369181 ] Jonathan Valliere commented on DIRMINA-1078: Please change the name of the class and update

[jira] [Commented] (DIRMINA-1069) Number of pipe and eventpoll goes up about 30 when connecting to server with NioSocketConnector

2018-02-18 Thread Jonathan Valliere (JIRA)
[ https://issues.apache.org/jira/browse/DIRMINA-1069?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16368564#comment-16368564 ] Jonathan Valliere commented on DIRMINA-1069: Every TCP socket connection has

[jira] [Comment Edited] (DIRMINA-1069) Number of pipe and eventpoll goes up about 30 when connecting to server with NioSocketConnector

2018-02-18 Thread Jonathan Valliere (JIRA)
[ https://issues.apache.org/jira/browse/DIRMINA-1069?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16368564#comment-16368564 ] Jonathan Valliere edited comment on DIRMINA-1069 at 2/18/18 3:31 PM

[jira] [Updated] (DIRMINA-1078) OrderedThreadPoolExecutor should allow sessions to be prioritized

2018-02-18 Thread Jonathan Valliere (JIRA)
[ https://issues.apache.org/jira/browse/DIRMINA-1078?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jonathan Valliere updated DIRMINA-1078: --- Priority: Minor (was: Major) > OrderedThreadPoolExecutor should allow sessi

[jira] [Updated] (DIRMINA-1054) High CPU lasting between 5-15 minutes during heavy load

2018-02-15 Thread Jonathan Valliere (JIRA)
[ https://issues.apache.org/jira/browse/DIRMINA-1054?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jonathan Valliere updated DIRMINA-1054: --- Attachment: thread-dump.txt Description: After upgrading from version 2.0.7

[jira] [Commented] (DIRMINA-1075) mina client can't receive message from mina server when android version below 4.4.2

2018-02-15 Thread Jonathan Valliere (JIRA)
[ https://issues.apache.org/jira/browse/DIRMINA-1075?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16366062#comment-16366062 ] Jonathan Valliere commented on DIRMINA-1075: HI Bill, I might be shooting in the dark but I

[jira] [Assigned] (DIRMINA-1077) Threads hanging in dispose() on SSLHandshakeException

2018-02-15 Thread Jonathan Valliere (JIRA)
[ https://issues.apache.org/jira/browse/DIRMINA-1077?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jonathan Valliere reassigned DIRMINA-1077: -- Assignee: Jonathan Valliere > Threads hanging in disp

[jira] [Assigned] (DIRMINA-1076) Leaking NioProcessors/NioSocketConnectors hanging in call to dispose

2018-02-15 Thread Jonathan Valliere (JIRA)
[ https://issues.apache.org/jira/browse/DIRMINA-1076?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jonathan Valliere reassigned DIRMINA-1076: -- Assignee: Jonathan Valliere > Leaking NioProcessors/NioSocketConnect

Re: Pease welcome Jonathan Vallliere, who has been voted as a new MINA committer

2018-02-13 Thread Jonathan Valliere
Hi everybody! On Tue, Feb 13, 2018 at 11:53 AM, Lyor Goldstein <lgoldst...@apache.org> wrote: > Welcome aboard. > > > >> Hi ! > >> > >> I'm pleased to announce that Jonathan Valliere has been voted in this > weekend > as a new committer of the MINA project ! >

Re: leaking NioProcessors/NioSocketConnectors hanging in call to dispose - DIRMINA-1076

2018-02-12 Thread Jonathan Valliere
//issues.apache.org/jira >> /browse/DIRMINA-1076 >> >> Thanks in advanceand best regards, >> Chris. >> >> >> On 09/02/18 15:11, Jonathan Valliere wrote: >> >>> If there isn’t a ticket in JIRA, please create one. I’d prefer to work >&

[jira] [Commented] (DIRMINA-1076) Leaking NioProcessors/NioSocketConnectors hanging in call to dispose

2018-02-12 Thread Jonathan Valliere (JIRA)
[ https://issues.apache.org/jira/browse/DIRMINA-1076?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16360860#comment-16360860 ] Jonathan Valliere commented on DIRMINA-1076: Christoph, There could be a way to detect

[jira] [Comment Edited] (DIRMINA-1076) Leaking NioProcessors/NioSocketConnectors hanging in call to dispose

2018-02-11 Thread Jonathan Valliere (JIRA)
[ https://issues.apache.org/jira/browse/DIRMINA-1076?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16360060#comment-16360060 ] Jonathan Valliere edited comment on DIRMINA-1076 at 2/12/18 12:38 AM

[jira] [Comment Edited] (DIRMINA-1076) Leaking NioProcessors/NioSocketConnectors hanging in call to dispose

2018-02-11 Thread Jonathan Valliere (JIRA)
[ https://issues.apache.org/jira/browse/DIRMINA-1076?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16360060#comment-16360060 ] Jonathan Valliere edited comment on DIRMINA-1076 at 2/12/18 12:37 AM

Re: Fatal Error Handling

2018-02-11 Thread Jonathan Valliere
Look at my patch notes for Christoph’s dispose bug in JIRA DIRMINA-1076I fixed the negative counter problem but want to add a critical check Incase it ever reappears. On Sun, Feb 11, 2018 at 5:15 PM Emmanuel Lécharny <elecha...@gmail.com> wrote: > > > Le 11/02/2018 à 19:14, Jo

Re: Fatal Error Handling

2018-02-11 Thread Jonathan Valliere
There is a condition in the IoProcessor where the expected Session Count turns negative. Basically the IoProcessor is now in a Fatal state. What should happen? On Sun, Feb 11, 2018 at 12:55 PM Emmanuel Lécharny <elecha...@gmail.com> wrote: > > > Le 11/02/2018 à 15:52, Jonathan V

[jira] [Commented] (DIRMINA-1076) Leaking NioProcessors/NioSocketConnectors hanging in call to dispose

2018-02-11 Thread Jonathan Valliere (JIRA)
[ https://issues.apache.org/jira/browse/DIRMINA-1076?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16359966#comment-16359966 ] Jonathan Valliere commented on DIRMINA-1076: Here is the patch to fix your issue; it also

[jira] [Updated] (DIRMINA-1076) Leaking NioProcessors/NioSocketConnectors hanging in call to dispose

2018-02-11 Thread Jonathan Valliere (JIRA)
[ https://issues.apache.org/jira/browse/DIRMINA-1076?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jonathan Valliere updated DIRMINA-1076: --- Attachment: (was: christoph-hanging-dispose.patch) > Leaking NioProcess

[jira] [Updated] (DIRMINA-1076) Leaking NioProcessors/NioSocketConnectors hanging in call to dispose

2018-02-11 Thread Jonathan Valliere (JIRA)
[ https://issues.apache.org/jira/browse/DIRMINA-1076?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jonathan Valliere updated DIRMINA-1076: --- Attachment: christoph-hanging-dispose.patch > Leaking NioProcess

Fatal Error Handling

2018-02-11 Thread Jonathan Valliere
Hi Team, What is the standard way in Mina of handing super fatal errors? i.e. unrecoverable invalid internal state Right now, I added an `assert` statement but that probably isn’t good enough.

[jira] [Commented] (DIRMINA-1076) Leaking NioProcessors/NioSocketConnectors hanging in call to dispose

2018-02-09 Thread Jonathan Valliere (JIRA)
[ https://issues.apache.org/jira/browse/DIRMINA-1076?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16358497#comment-16358497 ] Jonathan Valliere commented on DIRMINA-1076: What is the JDK version?  What Ubuntu version

[jira] [Commented] (DIRMINA-1076) Leaking NioProcessors/NioSocketConnectors hanging in call to dispose

2018-02-09 Thread Jonathan Valliere (JIRA)
[ https://issues.apache.org/jira/browse/DIRMINA-1076?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16358449#comment-16358449 ] Jonathan Valliere commented on DIRMINA-1076: Okay, thank you.  I would like to have all

Re: leaking NioProcessors/NioSocketConnectors hanging in call to dispose

2018-02-09 Thread Jonathan Valliere
in > a loop. > > Thanks, > Chris. > > On 09/02/18 14:47, Jonathan Valliere wrote: > > It’s been a while, I forget, is there code to run the brute force test > available? > > > > On Fri, Feb 9, 2018 at 7:56 AM Christoph John <christoph.j...@macd.com > > <ma

[jira] [Commented] (DIRMINA-1060) Handle the spinning selectors in Socket/Datagram Acceptor and Connector

2018-02-09 Thread Jonathan Valliere (JIRA)
[ https://issues.apache.org/jira/browse/DIRMINA-1060?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16358434#comment-16358434 ] Jonathan Valliere commented on DIRMINA-1060: Emmanuel, I think you can close this ticket

Re: leaking NioProcessors/NioSocketConnectors hanging in call to dispose

2018-02-09 Thread Jonathan Valliere
o do some more teststo be sure. > I now have added logic to iterate over the managed sessions of an > IoConnector and close them before calling IoConnector.dispose(). > > I will let you know if this solved the problem. > > Thanks, > Chris. > > On 16/10/17 16:

Re: [jira] [Commented] (SSHD-779) Deadlock in ChannelOutputStream

2017-12-08 Thread Jonathan Valliere
You said “less major issues”; are there bugs reported for MinaServiceFactoryFactory? On Fri, Dec 8, 2017 at 1:22 PM Hugo Arès (JIRA) wrote: > > [ >

[jira] [Commented] (SSHD-779) Deadlock in ChannelOutputStream

2017-12-08 Thread Jonathan Valliere (JIRA)
[ https://issues.apache.org/jira/browse/SSHD-779?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16283941#comment-16283941 ] Jonathan Valliere commented on SSHD-779: by nio 2 do you mean the JRE async nio api or something

[jira] [Commented] (SSHD-779) Deadlock in ChannelOutputStream

2017-12-08 Thread Jonathan Valliere (JIRA)
[ https://issues.apache.org/jira/browse/SSHD-779?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16283825#comment-16283825 ] Jonathan Valliere commented on SSHD-779: Is there a reproducible example? How about an example

Re: [jira] [Commented] (SSHD-743) Nio2Session sporadically leaks exceptions from nio2 threads

2017-11-11 Thread Jonathan Valliere
If you have an internal bug you still want to keep that bug from negatively affecting other sessions within the app. That’s why browsers are process per session. That’s also a case for overly generic catches in specific places. On Sat, Nov 11, 2017 at 9:07 AM Goldstein Lyor (JIRA)

Re: [jira] [Created] (SSHD-782) Consider implementing a "reverse" keep-alive mechanism in the server

2017-10-27 Thread Jonathan Valliere
The problem is distinguishing the difference between the keep alive traffic and a long transfer. Either Mina needs a more advanced idle measurement or SSHD would need its own idle manager. On Fri, Oct 27, 2017 at 11:08 AM Goldstein Lyor (JIRA) wrote: > Goldstein Lyor created

Re: [jira] [Commented] (DIRMINA-1060) Handle the spinning selectors in Socket/Datagram Acceptor and Connector

2017-10-27 Thread Jonathan Valliere
. On Fri, Oct 27, 2017 at 10:18 AM, Emmanuel Lécharny <elecha...@gmail.com> wrote: > > > Le 27/10/2017 à 15:58, Jonathan Valliere a écrit : > > For connector, I would allow the error to flow all the way up the stack. > > Currently, the excption is caught, a T

Re: [jira] [Commented] (DIRMINA-1060) Handle the spinning selectors in Socket/Datagram Acceptor and Connector

2017-10-27 Thread Jonathan Valliere
For connector, I would allow the error to flow all the way up the stack. On Fri, Oct 27, 2017 at 9:56 AM Emmanuel Lecharny (JIRA) wrote: > > [ >

[jira] [Commented] (DIRMINA-1060) Handle the spinning selectors in Socket/Datagram Acceptor and Connector

2017-10-27 Thread Jonathan Valliere (JIRA)
[ https://issues.apache.org/jira/browse/DIRMINA-1060?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=1619#comment-1619 ] Jonathan Valliere commented on DIRMINA-1060: Correct, its a work around

[jira] [Commented] (DIRMINA-1060) Handle the spinning selectors in Socket/Datagram Acceptor and Connector

2017-10-27 Thread Jonathan Valliere (JIRA)
[ https://issues.apache.org/jira/browse/DIRMINA-1060?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16222185#comment-16222185 ] Jonathan Valliere commented on DIRMINA-1060: Sorry, handle = File Handle = File Descriptor

[jira] [Comment Edited] (DIRMINA-1060) Handle the spinning selectors in Socket/Datagram Acceptor and Connector

2017-10-26 Thread Jonathan Valliere (JIRA)
[ https://issues.apache.org/jira/browse/DIRMINA-1060?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16221381#comment-16221381 ] Jonathan Valliere edited comment on DIRMINA-1060 at 10/26/17 10:48 PM

[jira] [Commented] (DIRMINA-1060) Handle the spinning selectors in Socket/Datagram Acceptor and Connector

2017-10-26 Thread Jonathan Valliere (JIRA)
[ https://issues.apache.org/jira/browse/DIRMINA-1060?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16221381#comment-16221381 ] Jonathan Valliere commented on DIRMINA-1060: For TCP connections `accept()` throws

Re: leaking NioProcessors/NioSocketConnectors hanging in call to dispose

2017-10-16 Thread Jonathan Valliere
gt; > > > > Le 16/10/2017 à 14:41, Christoph John a écrit : > >> Hi Emmanuel, Jonathan, > >> > >> thanks for your patches. Unfortunately neither of them does correct > >> the problem I am facing. > >> I'd suggest that I'll try to reproduc

Re: [jira] [Commented] (DIRMINA-1057) AbstractIoSession getScheduledWriteMessages always -negative?

2017-10-14 Thread Jonathan Valliere
Yay! Thanks Emmanuel! On Sat, Oct 14, 2017 at 7:48 AM, Emmanuel Lecharny (JIRA) wrote: > > [ https://issues.apache.org/jira/browse/DIRMINA-1057?page= > com.atlassian.jira.plugin.system.issuetabpanels:comment- > tabpanel=16204593#comment-16204593 ] > > Emmanuel Lecharny

[jira] [Commented] (DIRMINA-1060) Handle the spinning selectors in Socket/Datagram Acceptor and Connector

2017-10-13 Thread Jonathan Valliere (JIRA)
[ https://issues.apache.org/jira/browse/DIRMINA-1060?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16203674#comment-16203674 ] Jonathan Valliere commented on DIRMINA-1060: Emmanuel, is this resolved? > Han

[jira] [Commented] (DIRMINA-1057) AbstractIoSession getScheduledWriteMessages always -negative?

2017-10-13 Thread Jonathan Valliere (JIRA)
[ https://issues.apache.org/jira/browse/DIRMINA-1057?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16203637#comment-16203637 ] Jonathan Valliere commented on DIRMINA-1057: David, I ran the updated tests you provided

[jira] [Comment Edited] (DIRMINA-1057) AbstractIoSession getScheduledWriteMessages always -negative?

2017-10-13 Thread Jonathan Valliere (JIRA)
[ https://issues.apache.org/jira/browse/DIRMINA-1057?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16203637#comment-16203637 ] Jonathan Valliere edited comment on DIRMINA-1057 at 10/13/17 2:33 PM

Re: leaking NioProcessors/NioSocketConnectors hanging in call to dispose

2017-10-11 Thread Jonathan Valliere
Basically my proposed patch moves the check dispose conditional into a finally loop forcing it to run even if exceptions were caught. If the SSLFilter did something weird then it would be blocked on that filter. What is happening is that the Processor is not dying as requested. That's why I think

Re: leaking NioProcessors/NioSocketConnectors hanging in call to dispose

2017-10-10 Thread Jonathan Valliere
; What would be a good starting point to create a test? I see that there is > an SslTest in the mina-core module. So I probably have to change that test > to repeatedly connect and get a handshake exception everytime and then take > a number of stack traces. > > Thanks, > Chris.

[jira] [Comment Edited] (DIRMINA-1057) AbstractIoSession getScheduledWriteMessages always -negative?

2017-10-10 Thread Jonathan Valliere (JIRA)
[ https://issues.apache.org/jira/browse/DIRMINA-1057?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16199124#comment-16199124 ] Jonathan Valliere edited comment on DIRMINA-1057 at 10/10/17 6:25 PM

[jira] [Commented] (DIRMINA-1057) AbstractIoSession getScheduledWriteMessages always -negative?

2017-10-10 Thread Jonathan Valliere (JIRA)
[ https://issues.apache.org/jira/browse/DIRMINA-1057?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16199124#comment-16199124 ] Jonathan Valliere commented on DIRMINA-1057: Emmanuel, are you sure that error wasn't

Re: leaking NioProcessors/NioSocketConnectors hanging in call to dispose

2017-10-09 Thread Jonathan Valliere
Let me know if its hanging more than 1s On Mon, Oct 9, 2017 at 5:08 AM, Christoph John wrote: > Hi, > > I have another question regarding this one. There is > https://issues.apache.org/jira/browse/DIRMINA-1060 which also sounds a > little like the problem I'm having.

Re: [jira] [Comment Edited] (DIRMINA-1057) AbstractIoSession getScheduledWriteMessages always -negative?

2017-10-08 Thread Jonathan Valliere
Emmanuel, Do you want me to attach a diff or something with the patch to the JIRA? On Sun, Oct 8, 2017 at 5:41 AM, David Gibbs (JIRA) wrote: > > [ https://issues.apache.org/jira/browse/DIRMINA-1057?page= > com.atlassian.jira.plugin.system.issuetabpanels:comment- >

[jira] [Comment Edited] (DIRMINA-1057) AbstractIoSession getScheduledWriteMessages always -negative?

2017-10-08 Thread Jonathan Valliere (JIRA)
[ https://issues.apache.org/jira/browse/DIRMINA-1057?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16195937#comment-16195937 ] Jonathan Valliere edited comment on DIRMINA-1057 at 10/8/17 3:51 PM

[jira] [Comment Edited] (DIRMINA-1057) AbstractIoSession getScheduledWriteMessages always -negative?

2017-10-07 Thread Jonathan Valliere (JIRA)
[ https://issues.apache.org/jira/browse/DIRMINA-1057?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16195937#comment-16195937 ] Jonathan Valliere edited comment on DIRMINA-1057 at 10/7/17 11:24 PM

[jira] [Commented] (DIRMINA-1057) AbstractIoSession getScheduledWriteMessages always -negative?

2017-10-07 Thread Jonathan Valliere (JIRA)
[ https://issues.apache.org/jira/browse/DIRMINA-1057?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16195937#comment-16195937 ] Jonathan Valliere commented on DIRMINA-1057: Okay, sorry for all the edits of the previous

[jira] [Comment Edited] (DIRMINA-1057) AbstractIoSession getScheduledWriteMessages always -negative?

2017-10-07 Thread Jonathan Valliere (JIRA)
[ https://issues.apache.org/jira/browse/DIRMINA-1057?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16195839#comment-16195839 ] Jonathan Valliere edited comment on DIRMINA-1057 at 10/7/17 7:29 PM

[jira] [Comment Edited] (DIRMINA-1057) AbstractIoSession getScheduledWriteMessages always -negative?

2017-10-07 Thread Jonathan Valliere (JIRA)
[ https://issues.apache.org/jira/browse/DIRMINA-1057?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16195839#comment-16195839 ] Jonathan Valliere edited comment on DIRMINA-1057 at 10/7/17 7:15 PM

[jira] [Comment Edited] (DIRMINA-1057) AbstractIoSession getScheduledWriteMessages always -negative?

2017-10-07 Thread Jonathan Valliere (JIRA)
[ https://issues.apache.org/jira/browse/DIRMINA-1057?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16195839#comment-16195839 ] Jonathan Valliere edited comment on DIRMINA-1057 at 10/7/17 7:15 PM

[jira] [Commented] (DIRMINA-1057) AbstractIoSession getScheduledWriteMessages always -negative?

2017-10-07 Thread Jonathan Valliere (JIRA)
[ https://issues.apache.org/jira/browse/DIRMINA-1057?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16195839#comment-16195839 ] Jonathan Valliere commented on DIRMINA-1057: Okay, looks like I found a condition where

[jira] [Commented] (DIRMINA-1057) AbstractIoSession getScheduledWriteMessages always -negative?

2017-10-07 Thread Jonathan Valliere (JIRA)
[ https://issues.apache.org/jira/browse/DIRMINA-1057?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16195829#comment-16195829 ] Jonathan Valliere commented on DIRMINA-1057: Can you check

[jira] [Comment Edited] (DIRMINA-1057) AbstractIoSession getScheduledWriteMessages always -negative?

2017-10-07 Thread Jonathan Valliere (JIRA)
[ https://issues.apache.org/jira/browse/DIRMINA-1057?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16195829#comment-16195829 ] Jonathan Valliere edited comment on DIRMINA-1057 at 10/7/17 6:55 PM

[jira] [Comment Edited] (DIRMINA-1057) AbstractIoSession getScheduledWriteMessages always -negative?

2017-10-07 Thread Jonathan Valliere (JIRA)
[ https://issues.apache.org/jira/browse/DIRMINA-1057?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16195825#comment-16195825 ] Jonathan Valliere edited comment on DIRMINA-1057 at 10/7/17 6:44 PM

[jira] [Commented] (DIRMINA-1057) AbstractIoSession getScheduledWriteMessages always -negative?

2017-10-07 Thread Jonathan Valliere (JIRA)
[ https://issues.apache.org/jira/browse/DIRMINA-1057?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16195825#comment-16195825 ] Jonathan Valliere commented on DIRMINA-1057: Okay, I pulled the {{tag/2.0.16}} and found

Re: [jira] [Commented] (DIRMINA-1057) AbstractIoSession getScheduledWriteMessages always -negative?

2017-10-07 Thread Jonathan Valliere
ng said, > > > Le 06/10/2017 à 20:08, Jonathan Valliere a écrit : > > I haven’t looked at the Mina code in a while. Looking at > > DefaultIoFilterChain.java under HeadFilter#filterWrite > > > > WriteRequestQueue writeRequestQueue = s.getW

Re: [jira] [Commented] (DIRMINA-1057) AbstractIoSession getScheduledWriteMessages always -negative?

2017-10-06 Thread Jonathan Valliere
Additionally, moving the Queue control into the AbstractPollingIoProcessor and increasing backlog before adding to Queue and decreasing after removing will prevent the negative number race condition. On Fri, Oct 6, 2017 at 2:08 PM, Jonathan Valliere <jon.valli...@emoten.com> wrote: >

Re: [jira] [Commented] (DIRMINA-1057) AbstractIoSession getScheduledWriteMessages always -negative?

2017-10-06 Thread Jonathan Valliere
I haven’t looked at the Mina code in a while. Looking at DefaultIoFilterChain.java under HeadFilter#filterWrite WriteRequestQueue writeRequestQueue = s.getWriteRequestQueue(); if (!s.isWriteSuspended()) { if (writeRequestQueue.isEmpty(session)) {

Re: MINA3.0 recommended

2017-09-19 Thread Jonathan Valliere
, 2017 at 12:42 PM, Emmanuel Lécharny <elecha...@gmail.com> wrote: > I would add Brian Goetz take on synchronized vs Lock : > > > https://www.ibm.com/developerworks/library/j-jtp10264/ > > > > Le 19/09/2017 à 15:28, Jonathan Valliere a écrit : > > I forget, does M

Re: MINA3.0 recommended

2017-09-19 Thread Jonathan Valliere
; 2 threads, sync actually is faster. Personally, I use a custom ReentantLock but my use-case is much more complicated. On Tue, Sep 19, 2017 at 1:31 AM, Emmanuel Lécharny <elecha...@gmail.com> wrote: > > > Le 19/09/2017 à 00:24, Jonathan Valliere a écrit : > > Synchroniza

Re: MINA3.0 recommended

2017-09-18 Thread Jonathan Valliere
Synchronization, unlike Locks, does not create any memory garbage and are just as fast as CAS under low locking activity. Just because CAS/ Locks are faster when 8 threads are accessing one object, doesn't mean that standard Mutex Synchronization doesn't work just find when almost all of the time

Re: [jira] [Commented] (DIRMINA-1070) Avoid unbounded message queueing when sending large amounts of data to slow clients

2017-08-31 Thread Jonathan Valliere
I absolutely understand how you must write the entire message at once to ensure that another message from another thread doesn't cause the stream to be corrupted. That said, I also think this is an SSHD issue and not a Mina one. On Thu, Aug 31, 2017 at 2:50 AM Emmanuel Lecharny (JIRA)

Re: [jira] [Commented] (DIRMINA-1070) Avoid unbounded message queueing when sending large amounts of data to slow clients

2017-08-30 Thread Jonathan Valliere
Are you saying that Mina has a bug or are you proposing some new feature to handle your back pressure problem? On Wed, Aug 30, 2017 at 7:52 PM jpalacios (JIRA) wrote: > > [ >

Re: Mailing Lists

2017-08-30 Thread Jonathan Valliere
How about self-hosted forums? like vbulletin? VB allows you to subscribe to forums or threads and I think you can reply via email also. I would imagine the problem being hosting. On Wed, Aug 30, 2017 at 11:52 AM, Guido Medina wrote: > I forgot to mention that the Gitter

Mailing Lists

2017-08-30 Thread Jonathan Valliere
Hi Everyone! I've been on the mailing lists for a long time under a few different email addresses. I want to continue to contribute to MINA but the chatter on other projects, mainly SSHD, is blowing away my MINA folder in my email on a daily basis. I would appreciate some ideas on how to create

<    4   5   6   7   8   9