Re: Exception in filter (was: Re: [Vote] MINA 2.2.0 release)

Thanks, Jonathan. On 27.08.22 20:05, Jonathan Valliere wrote: https://github.com/apache/mina/blob/7893dfc29bb37dcef1345ffb482709902b6b6c9f/mina-core/src/main/java/org/apache/mina/transport/socket/nio/NioSocketSession.java#L94 On Aug 26, 2022 at 5:15:42 AM, Christoph John wrote: The

Re: Exception in filter (was: Re: [Vote] MINA 2.2.0 release)

https://github.com/apache/mina/blob/7893dfc29bb37dcef1345ffb482709902b6b6c9f/mina-core/src/main/java/org/apache/mina/transport/socket/nio/NioSocketSession.java#L94 On Aug 26, 2022 at 5:15:42 AM, Christoph John wrote: > The constant PEER_ADDRESS is no longer present in the code in 2.2.x > > I

Re: Exception in filter (was: Re: [Vote] MINA 2.2.0 release)

The constant PEER_ADDRESS is no longer present in the code in 2.2.x I can see however that in https://github.com/apache/mina/blob/7893dfc29bb37dcef1345ffb482709902b6b6c9f/mina-core/src/main/java/org/apache/mina/filter/ssl/SslFilter.java#L272 and

Re: Exception in filter (was: Re: [Vote] MINA 2.2.0 release)

It should be either doing it automatically or is a configurable option in the filter. I’m far away from my computer right now so I can’t check. On Wed, Aug 24, 2022 at 6:44 AM Christoph John wrote: > Hi Jonathan, > > are you able to help me with the last item on the list (see quote below)? > >

Re: Exception in filter (was: Re: [Vote] MINA 2.2.0 release)

Hi Jonathan, are you able to help me with the last item on the list (see quote below)? Thank you in advance and best regards, Chris. On 28.07.22 16:42, Emmanuel Lécharny wrote: 3. to use SNI we formerly set the "PEER_ADDRESS". Is this still possible? Please see here:

Re: Exception in filter (was: Re: [Vote] MINA 2.2.0 release)

Hi Christoph, answers inline On 28/07/2022 14:48, Christoph John wrote: Hi Emmanuel, I took a look at this and it seems the two latches were a red herring. One is for the initiator (connector) and the other one for the acceptor that are used in the unit test. I must admit I haven't

Re: Exception in filter (was: Re: [Vote] MINA 2.2.0 release)

Hi Emmanuel, I took a look at this and it seems the two latches were a red herring. One is for the initiator (connector) and the other one for the acceptor that are used in the unit test. I must admit I haven't spent enough time to unerstand what was going on ;-) No problem, thank you

Re: Exception in filter (was: Re: [Vote] MINA 2.2.0 release)

On 21/07/2022 15:38, Christoph John wrote: Hi Emmanuel, I took a look at this and it seems the two latches were a red herring. One is for the initiator (connector) and the other one for the acceptor that are used in the unit test. I must admit I haven't spent enough time to unerstand

Re: Exception in filter (was: Re: [Vote] MINA 2.2.0 release)

Hi Emmanuel, I took a look at this and it seems the two latches were a red herring. One is for the initiator (connector) and the other one for the acceptor that are used in the unit test. However, I think I found the root cause for the failing unit tests. We have an AbstractIoHandler which

Re: [Vote] MINA 2.2.0 release

+1 Le lun. 4 juil. 2022 à 23:43, Emmanuel Lécharny a écrit : > Hi! > > > it has been a couple of months now that I cut a version of MINA 2.2.0, > but haven't started a vote, because I wanted to test that exception were > properly handled when generated from the SslFilter. It took may way >

result: was [Vote] MINA 2.2.0 release

Thanks for the votes! I therefore close this vote with 3 binding +1 and o,ne non binding +1: - Christoph John (non binding) - Jeff (Genender) - Jonathan - and me I will push the packages, update the site and announce the release in the coming hours ! On 04/07/2022 23:43, Emmanuel Lécharny

Re: [Vote] MINA 2.2.0 release

mine is binding so we should be over the threshold now On Jul 16, 2022 at 11:54:40 AM, Jeff Genender wrote: > I dont remember if I voted or not…but if not… here it is… > > Jeff > > > On Jul 16, 2022, at 8:49 AM, Emmanuel Lécharny > wrote: > > > > > On 16/07/2022 11:31, Christoph John wrote:

Re: [Vote] MINA 2.2.0 release

I dont remember if I voted or not…but if not… here it is… Jeff > On Jul 16, 2022, at 8:49 AM, Emmanuel Lécharny wrote: > > > > On 16/07/2022 11:31, Christoph John wrote: >> +1 > > Thanks! > >> But don't know if my vote counts. > > Every vote *do* count, even if not all the votes are

Re: [Vote] MINA 2.2.0 release

On 16/07/2022 11:31, Christoph John wrote: +1 Thanks! But don't know if my vote counts. Every vote *do* count, even if not all the votes are binding. The idea is that if someone casts a -1, that means there is something that requires some investigation. Typically, when I started the

Re: [Vote] MINA 2.2.0 release

+1 CONFIDENTIALITY NOTICE: The contents of this email message and any attachments are intended solely for the addressee(s) and may contain confidential and/or privileged information and may be legally protected from disclosure. On Jul 16, 2022 at 4:31:51 AM, Emmanuel Lécharny wrote: > Hi, >

Re: [Vote] MINA 2.2.0 release

+1 But don't know if my vote counts. Thanks for your investigation. I will take a closer look next week. Cheers Chris Jul 16, 2022 10:32:02 Emmanuel Lécharny : > Hi, > > I need one more vote at least to get the release out. > > I'm confident the pb Christoph had was due to some bad test, not

Re: [Vote] MINA 2.2.0 release

Hi, I need one more vote at least to get the release out. I'm confident the pb Christoph had was due to some bad test, not to a MINA issue. Thanks ! On 05/07/2022 09:38, Christoph John wrote: Hi Emmanuel Did you manage to fix the bug which we talked about in the mail thread from May

Re: Exception in filter (was: Re: [Vote] MINA 2.2.0 release)

Hi Christoph, after further analysis, it appears that we have 2 countdown latch instances (exceptionThrownLatch) at play: * one that is decremented in the exceptionCaught event, [Count1]>:1]--->PKIX path validation failed: java.security.cert.CertPathValidatorException:

Re: Exception in filter (was: Re: [Vote] MINA 2.2.0 release)

Hi Christoph, actually, there is a kind of race condition in your test. I have added some logs: @Override public void exceptionCaught(NextFilter nextFilter, IoSession session, Throwable cause) throws Exception {

Re: Exception in filter (was: Re: [Vote] MINA 2.2.0 release)

On 13/07/2022 09:37, Christoph John wrote: Hi Emmanuel, thanks for your analysis. The filter that should catch the exception is added as last part in the chain. Could it be that the chain is not fully iterated somehow? Just guessing, I don't have enough MINA experience to make an educated

Re: Exception in filter (was: Re: [Vote] MINA 2.2.0 release)

Hi Emmanuel, thanks for your analysis. The filter that should catch the exception is added as last part in the chain. Could it be that the chain is not fully iterated somehow? Just guessing, I don't have enough MINA experience to make an educated guess. :) Cheers Chris Jul 13, 2022 06:38:00

Re: Exception in filter (was: Re: [Vote] MINA 2.2.0 release)

Here are some of my current findings. For the (failing) test shouldFailWhenUsingBadClientCertificate, here are the traces we get: juil. 13, 2022 6:28:42 AM org.apache.mina.filter.ssl.SSLHandlerG0 execute_task GRAVE: SSLHandlerG0@ae273e3[mode=server, connected=false] task() - storing error

Re: Exception in filter (was: Re: [Vote] MINA 2.2.0 release)

Never mind, I'm set up now, and in debug mode. All is good ! On 13/07/2022 00:47, Emmanuel Lécharny wrote: Hi Christoph, I'm trying to  ran the failing tests on my machine (eclipse with Java 8 and Java 11), and I'll probably need some assistance. I'm using the chrjohn-mina-2.2.0 branch. It

Re: Exception in filter (was: Re: [Vote] MINA 2.2.0 release)

Hi Christoph, I'm trying to ran the failing tests on my machine (eclipse with Java 8 and Java 11), and I'll probably need some assistance. I'm using the chrjohn-mina-2.2.0 branch. It seems that the generated code is not stored at the proper place. Any clue? On 09/07/2022 11:49,

Re: Exception in filter (was: Re: [Vote] MINA 2.2.0 release)

Hi Christoph, I think we should have the exact same tests in MINA. Poerting them should not take too long. On 06/07/2022 22:51, Christoph John wrote: Hi You could see the failing tests here: https://github.com/quickfix-j/quickfixj/runs/7201285514?check_suite_focus=true Basically these are

Re: Exception in filter (was: Re: [Vote] MINA 2.2.0 release)

Thanks. Anything I can do to assist? Although I might only find time the week after next because am currently on vacation. Jul 9, 2022 09:00:21 Emmanuel Lécharny : > I do think we need to have a look at it (and I may find some time to do it > too, as I'm in vacation in the coming week) > >

Re: Exception in filter (was: Re: [Vote] MINA 2.2.0 release)

I do think we need to have a look at it (and I may find some time to do it too, as I'm in vacation in the coming week) However, I think we should get this 2.0 out. Ther eis no problem in releasing a fix if needed. Thanks ! On 09/07/2022 07:17, Jonathan Valliere wrote: Sooo… do I need to

Re: Exception in filter (was: Re: [Vote] MINA 2.2.0 release)

Sooo… do I need to look into this or was this resolved? On Fri, Jul 8, 2022 at 11:51 PM Emmanuel Lécharny wrote: > The changes I did were to ensure that any ouutbound data are sent when a > TLS erroroccurs, because the Alert must be sent no matter what. This is > critical for a client to know

Re: Exception in filter (was: Re: [Vote] MINA 2.2.0 release)

The changes I did were to ensure that any ouutbound data are sent when a TLS erroroccurs, because the Alert must be sent no matter what. This is critical for a client to know what is the cause of the failure (typically when a bad certificate is provided - expired, revoked, etc -):

Re: Exception in filter (was: Re: [Vote] MINA 2.2.0 release)

Hi You could see the failing tests here: https://github.com/quickfix-j/quickfixj/runs/7201285514?check_suite_focus=true Basically these are tests that should fail when using a bad certificate. As an example here is one test that registers a filter that should get an exception but it doesn't:

Re: Exception in filter (was: Re: [Vote] MINA 2.2.0 release)

What test are you trying? Emmanuel made changes from the original design to cause it to throw on the filter. My original design threw on the filter but only during a subsequent read or write action thereby enforcing strong concurrency within the pipeline. On Jul 6, 2022 at 3:53:57 AM,

Exception in filter (was: Re: [Vote] MINA 2.2.0 release)

Ok, the tests in QuickFIX/J which expect the exception to be caught in a filter still don't work. I recall that you also did some changes in other Apache projects to make it work with MINA 2.2.0. Could it be that I also need to adapt something in this regard? Thanks Chris Jul 5, 2022 18:47:09

Re: [Vote] MINA 2.2.0 release

+1 Jeff > On Jul 4, 2022, at 3:43 PM, Emmanuel Lécharny wrote: > > Hi! > > > it has been a couple of months now that I cut a version of MINA 2.2.0, but > haven't started a vote, because I wanted to test that exception were properly > handled when generated from the SslFilter. It took may

Re: [Vote] MINA 2.2.0 release

I have tested that the exception gets propagated before launching the vote to be clear :-) On 05/07/2022 18:17, Christoph John wrote: Sorry, no. The last message regarding this was: --snip- 11.04.2022 09:37:30 Emmanuel Lécharny : Hi Christophe, sorry, my late mail was off

Re: [Vote] MINA 2.2.0 release

Sorry, no. The last message regarding this was: --snip- 11.04.2022 09:37:30 Emmanuel Lécharny : Hi Christophe, sorry, my late mail was off base. The pb here is that the SSLEngine excpeiton is not propagated to the handler, when it should. My guess is that we have some

Re: [Vote] MINA 2.2.0 release

Hi Christoph, yes. I guess you tested it already. On 05/07/2022 09:38, Christoph John wrote: Hi Emmanuel Did you manage to fix the bug which we talked about in the mail thread from May regarding the M1 milestone? Thanks Chris 04.07.2022 23:43:37 Emmanuel Lécharny : Hi! it has been a

Re: [Vote] MINA 2.2.0 release

Ah, sorry, copy/paste error: https://repository.apache.org/content/repositories/orgapachemina-1070/ On 05/07/2022 08:02, Jeff MAURY wrote: Staging repo is not available On Mon, Jul 4, 2022 at 11:43 PM Emmanuel Lécharny > wrote: Hi! it has been a couple

Re: [Vote] MINA 2.2.0 release

Hi Emmanuel Did you manage to fix the bug which we talked about in the mail thread from May regarding the M1 milestone? Thanks Chris 04.07.2022 23:43:37 Emmanuel Lécharny : > Hi! > > > it has been a couple of months now that I cut a version of MINA 2.2.0, but > haven't started a vote,

Re: [Vote] MINA 2.2.0 release

Staging repo is not available On Mon, Jul 4, 2022 at 11:43 PM Emmanuel Lécharny wrote: > Hi! > > > it has been a couple of months now that I cut a version of MINA 2.2.0, > but haven't started a vote, because I wanted to test that exception were > properly handled when generated from the

[Vote] MINA 2.2.0 release

Hi! it has been a couple of months now that I cut a version of MINA 2.2.0, but haven't started a vote, because I wanted to test that exception were properly handled when generated from the SslFilter. It took may way longer to check that, mainly due to external factors). Anyway, I'm done