[jira] [Commented] (SSHD-849) Possible race condition for local port forwarding channels

2018-11-06 Thread Goldstein Lyor (JIRA)
[ https://issues.apache.org/jira/browse/SSHD-849?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16677002#comment-16677002 ] Goldstein Lyor commented on SSHD-849: - Not a problem - time spent trying to improve the

[jira] [Commented] (SSHD-849) Possible race condition for local port forwarding channels

2018-11-06 Thread Goldstein Lyor (JIRA)
[ https://issues.apache.org/jira/browse/SSHD-849?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16676595#comment-16676595 ] Goldstein Lyor commented on SSHD-849: - Here is how to make sure you are correctly rebas

[jira] [Commented] (SSHD-849) Possible race condition for local port forwarding channels

2018-11-06 Thread Goldstein Lyor (JIRA)
[ https://issues.apache.org/jira/browse/SSHD-849?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16676486#comment-16676486 ] Goldstein Lyor commented on SSHD-849: - Hi Roberto, Sorry, but the PR is still not "cle

[jira] [Commented] (SSHD-849) Possible race condition for local port forwarding channels

2018-11-06 Thread Roberto Deandrea (JIRA)
[ https://issues.apache.org/jira/browse/SSHD-849?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16676316#comment-16676316 ] Roberto Deandrea commented on SSHD-849: --- Hi Lyor, My pull request with 2 files chan

[jira] [Commented] (SSHD-849) Possible race condition for local port forwarding channels

2018-11-06 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/SSHD-849?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16676315#comment-16676315 ] ASF GitHub Bot commented on SSHD-849: - GitHub user robertodeandrea opened a pull reques

[jira] [Commented] (SSHD-849) Possible race condition for local port forwarding channels

2018-11-05 Thread Goldstein Lyor (JIRA)
[ https://issues.apache.org/jira/browse/SSHD-849?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16675514#comment-16675514 ] Goldstein Lyor commented on SSHD-849: - Hi Roberto, I appreciate the effort, but I cann

[jira] [Commented] (SSHD-849) Possible race condition for local port forwarding channels

2018-11-05 Thread Roberto Deandrea (JIRA)
[ https://issues.apache.org/jira/browse/SSHD-849?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16675295#comment-16675295 ] Roberto Deandrea commented on SSHD-849: --- The code changes against master code is the

[jira] [Commented] (SSHD-849) Possible race condition for local port forwarding channels

2018-11-05 Thread Goldstein Lyor (JIRA)
[ https://issues.apache.org/jira/browse/SSHD-849?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16675113#comment-16675113 ] Goldstein Lyor commented on SSHD-849: - Hi Roberto, The code you published is out-of-sy

[jira] [Commented] (SSHD-849) Possible race condition for local port forwarding channels

2018-11-05 Thread Roberto Deandrea (JIRA)
[ https://issues.apache.org/jira/browse/SSHD-849?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16674870#comment-16674870 ] Roberto Deandrea commented on SSHD-849: --- Hi Lyor, our definitive pull request is the

[jira] [Commented] (SSHD-849) Possible race condition for local port forwarding channels

2018-11-05 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/SSHD-849?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16674868#comment-16674868 ] ASF GitHub Bot commented on SSHD-849: - GitHub user robertodeandrea opened a pull reques

[jira] [Commented] (SSHD-849) Possible race condition for local port forwarding channels

2018-10-31 Thread Goldstein Lyor (JIRA)
[ https://issues.apache.org/jira/browse/SSHD-849?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16670307#comment-16670307 ] Goldstein Lyor commented on SSHD-849: - Please create a new PR based on the latest check

[jira] [Commented] (SSHD-849) Possible race condition for local port forwarding channels

2018-10-31 Thread Roberto Deandrea (JIRA)
[ https://issues.apache.org/jira/browse/SSHD-849?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16670096#comment-16670096 ] Roberto Deandrea commented on SSHD-849: --- I'm afraid for this problem. I'm a newbie w

[jira] [Commented] (SSHD-849) Possible race condition for local port forwarding channels

2018-10-31 Thread Roberto Deandrea (JIRA)
[ https://issues.apache.org/jira/browse/SSHD-849?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16670084#comment-16670084 ] Roberto Deandrea commented on SSHD-849: --- Hi Lyor, The working changes in our environm

[jira] [Commented] (SSHD-849) Possible race condition for local port forwarding channels

2018-10-31 Thread Goldstein Lyor (JIRA)
[ https://issues.apache.org/jira/browse/SSHD-849?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16670042#comment-16670042 ] Goldstein Lyor commented on SSHD-849: - Hi Roberto, Quick reminder: * :) {quote}Your c

[jira] [Commented] (SSHD-849) Possible race condition for local port forwarding channels

2018-10-30 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/SSHD-849?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16668580#comment-16668580 ] ASF GitHub Bot commented on SSHD-849: - Github user lgoldstein closed the pull request a

[jira] [Commented] (SSHD-849) Possible race condition for local port forwarding channels

2018-10-30 Thread Roberto Deandrea (JIRA)
[ https://issues.apache.org/jira/browse/SSHD-849?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16668494#comment-16668494 ] Roberto Deandrea commented on SSHD-849: --- Your code changes are acceptable for us, you

[jira] [Commented] (SSHD-849) Possible race condition for local port forwarding channels

2018-10-30 Thread Goldstein Lyor (JIRA)
[ https://issues.apache.org/jira/browse/SSHD-849?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16668473#comment-16668473 ] Goldstein Lyor commented on SSHD-849: - As soon as you tell me that these changes are ac

[jira] [Commented] (SSHD-849) Possible race condition for local port forwarding channels

2018-10-30 Thread Roberto Deandrea (JIRA)
[ https://issues.apache.org/jira/browse/SSHD-849?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16668437#comment-16668437 ] Roberto Deandrea commented on SSHD-849: --- Hi Lyor, When you can merge code change rela

[jira] [Commented] (SSHD-849) Possible race condition for local port forwarding channels

2018-10-23 Thread Goldstein Lyor (JIRA)
[ https://issues.apache.org/jira/browse/SSHD-849?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16660536#comment-16660536 ] Goldstein Lyor commented on SSHD-849: - Hi [~roberto.deandrea] I have made the changes b

[jira] [Commented] (SSHD-849) Possible race condition for local port forwarding channels

2018-10-23 Thread Goldstein Lyor (JIRA)
[ https://issues.apache.org/jira/browse/SSHD-849?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16660470#comment-16660470 ] Goldstein Lyor commented on SSHD-849: - I take it back - after reviewing the code (see m

[jira] [Commented] (SSHD-849) Possible race condition for local port forwarding channels

2018-10-23 Thread Goldstein Lyor (JIRA)
[ https://issues.apache.org/jira/browse/SSHD-849?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16660457#comment-16660457 ] Goldstein Lyor commented on SSHD-849: - Hi [~roberto.deandrea], seems in order, but I do

[jira] [Commented] (SSHD-849) Possible race condition for local port forwarding channels

2018-10-22 Thread Roberto Deandrea (JIRA)
[ https://issues.apache.org/jira/browse/SSHD-849?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16658925#comment-16658925 ] Roberto Deandrea commented on SSHD-849: --- Hi Lyor, You can find our working code based

[jira] [Commented] (SSHD-849) Possible race condition for local port forwarding channels

2018-10-22 Thread Roberto Deandrea (JIRA)
[ https://issues.apache.org/jira/browse/SSHD-849?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16658918#comment-16658918 ] Roberto Deandrea commented on SSHD-849: --- Hi Lyor, I committed our working code based

[jira] [Commented] (SSHD-849) Possible race condition for local port forwarding channels

2018-10-18 Thread Goldstein Lyor (JIRA)
[ https://issues.apache.org/jira/browse/SSHD-849?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16656269#comment-16656269 ] Goldstein Lyor commented on SSHD-849: - The code can also be checked out and tested from

[jira] [Commented] (SSHD-849) Possible race condition for local port forwarding channels

2018-10-18 Thread Goldstein Lyor (JIRA)
[ https://issues.apache.org/jira/browse/SSHD-849?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16656162#comment-16656162 ] Goldstein Lyor commented on SSHD-849: - Hi, please review the solution I posted as a PR

[jira] [Commented] (SSHD-849) Possible race condition for local port forwarding channels

2018-10-18 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/SSHD-849?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16655328#comment-16655328 ] ASF GitHub Bot commented on SSHD-849: - GitHub user lgoldstein opened a pull request:

[jira] [Commented] (SSHD-849) Possible race condition for local port forwarding channels

2018-10-15 Thread Roberto Deandrea (JIRA)
[ https://issues.apache.org/jira/browse/SSHD-849?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16650320#comment-16650320 ] Roberto Deandrea commented on SSHD-849: --- Hi Lyor, Our pull request is [https://gith

[jira] [Commented] (SSHD-849) Possible race condition for local port forwarding channels

2018-10-15 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/SSHD-849?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16650316#comment-16650316 ] ASF GitHub Bot commented on SSHD-849: - GitHub user robertodeandrea opened a pull reques