[
https://issues.apache.org/jira/browse/SSHD-849?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16677002#comment-16677002
]
Goldstein Lyor commented on SSHD-849:
-
Not a problem - time spent trying to improve the
[
https://issues.apache.org/jira/browse/SSHD-849?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16676595#comment-16676595
]
Goldstein Lyor commented on SSHD-849:
-
Here is how to make sure you are correctly rebas
[
https://issues.apache.org/jira/browse/SSHD-849?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16676486#comment-16676486
]
Goldstein Lyor commented on SSHD-849:
-
Hi Roberto,
Sorry, but the PR is still not "cle
[
https://issues.apache.org/jira/browse/SSHD-849?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16676316#comment-16676316
]
Roberto Deandrea commented on SSHD-849:
---
Hi Lyor,
My pull request with 2 files chan
[
https://issues.apache.org/jira/browse/SSHD-849?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16676315#comment-16676315
]
ASF GitHub Bot commented on SSHD-849:
-
GitHub user robertodeandrea opened a pull reques
[
https://issues.apache.org/jira/browse/SSHD-849?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16675514#comment-16675514
]
Goldstein Lyor commented on SSHD-849:
-
Hi Roberto,
I appreciate the effort, but I cann
[
https://issues.apache.org/jira/browse/SSHD-849?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16675295#comment-16675295
]
Roberto Deandrea commented on SSHD-849:
---
The code changes against master code is the
[
https://issues.apache.org/jira/browse/SSHD-849?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16675113#comment-16675113
]
Goldstein Lyor commented on SSHD-849:
-
Hi Roberto,
The code you published is out-of-sy
[
https://issues.apache.org/jira/browse/SSHD-849?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16674870#comment-16674870
]
Roberto Deandrea commented on SSHD-849:
---
Hi Lyor, our definitive pull request is the
[
https://issues.apache.org/jira/browse/SSHD-849?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16674868#comment-16674868
]
ASF GitHub Bot commented on SSHD-849:
-
GitHub user robertodeandrea opened a pull reques
[
https://issues.apache.org/jira/browse/SSHD-849?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16670307#comment-16670307
]
Goldstein Lyor commented on SSHD-849:
-
Please create a new PR based on the latest check
[
https://issues.apache.org/jira/browse/SSHD-849?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16670096#comment-16670096
]
Roberto Deandrea commented on SSHD-849:
---
I'm afraid for this problem.
I'm a newbie w
[
https://issues.apache.org/jira/browse/SSHD-849?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16670084#comment-16670084
]
Roberto Deandrea commented on SSHD-849:
---
Hi Lyor,
The working changes in our environm
[
https://issues.apache.org/jira/browse/SSHD-849?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16670042#comment-16670042
]
Goldstein Lyor commented on SSHD-849:
-
Hi Roberto,
Quick reminder:
* :) {quote}Your c
[
https://issues.apache.org/jira/browse/SSHD-849?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16668580#comment-16668580
]
ASF GitHub Bot commented on SSHD-849:
-
Github user lgoldstein closed the pull request a
[
https://issues.apache.org/jira/browse/SSHD-849?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16668494#comment-16668494
]
Roberto Deandrea commented on SSHD-849:
---
Your code changes are acceptable for us, you
[
https://issues.apache.org/jira/browse/SSHD-849?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16668473#comment-16668473
]
Goldstein Lyor commented on SSHD-849:
-
As soon as you tell me that these changes are ac
[
https://issues.apache.org/jira/browse/SSHD-849?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16668437#comment-16668437
]
Roberto Deandrea commented on SSHD-849:
---
Hi Lyor,
When you can merge code change rela
[
https://issues.apache.org/jira/browse/SSHD-849?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16660536#comment-16660536
]
Goldstein Lyor commented on SSHD-849:
-
Hi [~roberto.deandrea] I have made the changes b
[
https://issues.apache.org/jira/browse/SSHD-849?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16660470#comment-16660470
]
Goldstein Lyor commented on SSHD-849:
-
I take it back - after reviewing the code (see m
[
https://issues.apache.org/jira/browse/SSHD-849?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16660457#comment-16660457
]
Goldstein Lyor commented on SSHD-849:
-
Hi [~roberto.deandrea], seems in order, but I do
[
https://issues.apache.org/jira/browse/SSHD-849?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16658925#comment-16658925
]
Roberto Deandrea commented on SSHD-849:
---
Hi Lyor,
You can find our working code based
[
https://issues.apache.org/jira/browse/SSHD-849?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16658918#comment-16658918
]
Roberto Deandrea commented on SSHD-849:
---
Hi Lyor,
I committed our working code based
[
https://issues.apache.org/jira/browse/SSHD-849?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16656269#comment-16656269
]
Goldstein Lyor commented on SSHD-849:
-
The code can also be checked out and tested from
[
https://issues.apache.org/jira/browse/SSHD-849?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16656162#comment-16656162
]
Goldstein Lyor commented on SSHD-849:
-
Hi, please review the solution I posted as a PR
[
https://issues.apache.org/jira/browse/SSHD-849?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16655328#comment-16655328
]
ASF GitHub Bot commented on SSHD-849:
-
GitHub user lgoldstein opened a pull request:
[
https://issues.apache.org/jira/browse/SSHD-849?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16650320#comment-16650320
]
Roberto Deandrea commented on SSHD-849:
---
Hi Lyor,
Our pull request is
[https://gith
[
https://issues.apache.org/jira/browse/SSHD-849?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16650316#comment-16650316
]
ASF GitHub Bot commented on SSHD-849:
-
GitHub user robertodeandrea opened a pull reques
28 matches
Mail list logo