Re: IoService API Growth

2008-07-13 Thread Emmanuel Lecharny
Hi, sorry, but the attachment didn't made its way through the Apache mail system (attachments are usually consider harmful, and removed). Can you attach the patch on the JIRA I created for this purpoe : https://issues.apache.org/jira/browse/DIRMINA-608 ? Thanks ! W.B. Garvelink wrote: Att

Re: IoService API Growth

2008-07-13 Thread W.B. Garvelink
Attached is a first proposal, please take a look. I'd like to see if there's any initial feedback now, and I'll work up a more extensive patch the coming weeks before M3 is released. Open issues: - should maybe leave the methodes on the IoService interface for the next milestone, marked deprecat

Re: IoService API Growth

2008-06-26 Thread peter royal
On Jun 25, 2008, at 12:53 AM, W.B. Garvelink wrote: I have some concern though that we're just trading the massive IoService API for a massive statistics API. It's an improvement!, but please consider splitting off the statistics methods into *two* statistics objects: one that deals with thr

Re: IoService API Growth

2008-06-25 Thread W.B. Garvelink
Sorry for joining this discussion late, it was held before I joined this list. Back in march/april, consensus was reached on this: On Thu, Mar 20, 2008 at 12:54 AM, peter royal <[EMAIL PROTECTED]> wrote: > On Mar 19, 2008, at 3:23 PM, Frédéric Brégier wrote: >> Those numbers are useful in producti

Re: IoService API growth

2008-04-08 Thread Julien Vermillard
On Tue, 8 Apr 2008 18:05:48 +0900 (KST) "이희승 (Trustin Lee) <[EMAIL PROTECTED]> wrote: > Julien Vermillard wrote: > > On Mon, 7 Apr 2008 21:39:03 +0900 (KST) > > "이희승 (Trustin Lee) <[EMAIL PROTECTED]> wrote: > > > >> After looking into IoSession and IoService, I ended up with the > >> conclusion t

Re: IoService API growth

2008-04-08 Thread 이희승 (Trustin Lee) <[EMAIL PROTECTED]>
Julien Vermillard wrote: > On Mon, 7 Apr 2008 21:39:03 +0900 (KST) > "이희승 (Trustin Lee) <[EMAIL PROTECTED]> wrote: > >> After looking into IoSession and IoService, I ended up with the >> conclusion that we can use the same statistics type instead of >> providing different types for IoSession and I

Re: IoService API growth

2008-04-07 Thread Mark Webb
+1 On Mon, Apr 7, 2008 at 8:52 AM, Julien Vermillard <[EMAIL PROTECTED]> wrote: > On Mon, 7 Apr 2008 21:39:03 +0900 (KST) > "이희승 (Trustin Lee) <[EMAIL PROTECTED]> wrote: > > > After looking into IoSession and IoService, I ended up with the > > conclusion that we can use the same statistics type i

Re: IoService API growth

2008-04-07 Thread Maarten Bosteels
On Mon, Apr 7, 2008 at 2:52 PM, Julien Vermillard <[EMAIL PROTECTED]> wrote: > On Mon, 7 Apr 2008 21:39:03 +0900 (KST) > "이희승 (Trustin Lee) <[EMAIL PROTECTED]> wrote: > > > After looking into IoSession and IoService, I ended up with the > > conclusion that we can use the same statistics type inste

Re: IoService API growth

2008-04-07 Thread Julien Vermillard
On Mon, 7 Apr 2008 21:39:03 +0900 (KST) "이희승 (Trustin Lee) <[EMAIL PROTECTED]> wrote: > After looking into IoSession and IoService, I ended up with the > conclusion that we can use the same statistics type instead of > providing different types for IoSession and IoService. > > The following is th

Re: IoService API growth

2008-04-07 Thread 이희승 (Trustin Lee) <[EMAIL PROTECTED]>
After looking into IoSession and IoService, I ended up with the conclusion that we can use the same statistics type instead of providing different types for IoSession and IoService. The following is the list of common methods in IoSession and IoService (please note that getLargestXXX() methods are

Re: IoService API growth

2008-03-20 Thread Mark Webb
+1. This would leave great potential for expansion (although I am not sure what other stats one would want :) ) On Thu, Mar 20, 2008 at 12:54 AM, peter royal <[EMAIL PROTECTED]> wrote: > On Mar 19, 2008, at 3:23 PM, Frédéric Brégier wrote: > > Those numbers are useful in production... (at least f

Re: IoService API growth

2008-03-20 Thread Frédéric Brégier
I would like, as a user (so it is not of course mandatory at all ;-) to have a way to get those values without using JMX. OK, it would probably be better to use JMX for external services which want to know about those tasks, but one could want (not me at that time, but I don't know in the future)

Re: IoService API growth

2008-03-20 Thread (Trustin Lee)
I agree with Frédéric in that we need to provide IoSessionStatistics if we are going to provide IoServiceStatistics. Again, IoServiceMBean and IoSessionMBean will detect all nested statistic properties automatically. No worries. :) 2008-03-20 (목), 15:09 +0900, Frédéric Brégier 쓰시길: > Peter, Emma

Re: IoService API growth

2008-03-20 Thread Julien Vermillard
On Thu, 20 Mar 2008 10:47:33 -0400 "Alex Karasulu" <[EMAIL PROTECTED]> wrote: > On Thu, Mar 20, 2008 at 9:48 AM, Emmanuel Lecharny > <[EMAIL PROTECTED]> wrote: > > > Julien Vermillard wrote: > > > On Wed, 19 Mar 2008 23:53:03 +0100 > > > Emmanuel Lecharny <[EMAIL PROTECTED]> wrote: > > > > > > >

Re: IoService API growth

2008-03-20 Thread Alex Karasulu
On Thu, Mar 20, 2008 at 9:48 AM, Emmanuel Lecharny <[EMAIL PROTECTED]> wrote: > Julien Vermillard wrote: > > On Wed, 19 Mar 2008 23:53:03 +0100 > > Emmanuel Lecharny <[EMAIL PROTECTED]> wrote: > > > > > >> Frédéric Brégier wrote: > >> > >>> Those numbers are useful in production... (at least for m

Re: IoService API growth

2008-03-20 Thread Emmanuel Lecharny
Julien Vermillard wrote: On Wed, 19 Mar 2008 23:53:03 +0100 Emmanuel Lecharny <[EMAIL PROTECTED]> wrote: Frédéric Brégier wrote: Those numbers are useful in production... (at least for my case) I know, it's only about statistics but some people want them... If I follow your idea, what

Re: IoService API growth

2008-03-20 Thread Julien Vermillard
On Wed, 19 Mar 2008 23:53:03 +0100 Emmanuel Lecharny <[EMAIL PROTECTED]> wrote: > Frédéric Brégier wrote: > > Those numbers are useful in production... (at least for my case) > > I know, it's only about statistics but some people want them... > > > > If I follow your idea, what will return IoServi

Re: IoService API growth

2008-03-20 Thread (Trustin Lee)
Hi Peter, It sounds like a good idea, and the current JMX integration module doesn't need any change. Let's file a JIRA issue. 2008-03-20 (목), 05:29 +0900, peter royal 쓰시길: > i just updated my project from a 2.0 build from last summer, and the > IoService API exploded! > > can we cull some of

Re: IoService API growth

2008-03-19 Thread Frédéric Brégier
Peter, Emmanuel, I understand your point. So this is a "cosmetic" change where all those methods will move to another class which will contain more or less the same methods and vars. Your intention is to get a smaller IoService class. As those values are update all the time (each send, receive, .

Re: IoService API growth

2008-03-19 Thread peter royal
On Mar 19, 2008, at 3:23 PM, Frédéric Brégier wrote: Those numbers are useful in production... (at least for my case) I know, it's only about statistics but some people want them... If I follow your idea, what will return IoService.getStatistics() ? What will you propose instead of those methods

Re: IoService API growth

2008-03-19 Thread Emmanuel Lecharny
Frédéric Brégier wrote: Those numbers are useful in production... (at least for my case) I know, it's only about statistics but some people want them... If I follow your idea, what will return IoService.getStatistics() ? I guess that Peter meant something like : getStatistics( IoSession.GE

Re: IoService API growth

2008-03-19 Thread Frédéric Brégier
Those numbers are useful in production... (at least for my case) I know, it's only about statistics but some people want them... If I follow your idea, what will return IoService.getStatistics() ? What will you propose instead of those methods in IoService? Also, those numbers are there, not elsew

Re: IoService API growth

2008-03-19 Thread Alex Karasulu
+1 - no need to clutter the API. Alex On Wed, Mar 19, 2008 at 4:29 PM, peter royal <[EMAIL PROTECTED]> wrote: > i just updated my project from a 2.0 build from last summer, and the > IoService API exploded! > > can we cull some of this? > > > http://svn.apache.org/viewvc/mina/trunk/core/src/main

IoService API growth

2008-03-19 Thread peter royal
i just updated my project from a 2.0 build from last summer, and the IoService API exploded! can we cull some of this? http://svn.apache.org/viewvc/mina/trunk/core/src/main/java/org/apache/mina/common/IoService.java?view=diff&r1=635424&r2=555855&diff_format=h ... does all that need to be in t