Re: [VOTE] Apache MINA 2.2.3, 2.1.8 and 2.0.25 releases

2023-09-12 Thread jgenender
I don’t remember if I voted because I have been voting on a lot of stuff lately. If I didn’t here is my +1 for all 3. Jeff > On Sep 12, 2023, at 2:29 AM, Emmanuel Lécharny wrote: > > Thanks Jeff & Gary. > > Is that for all the MINA versions? > > On 11/09/2023 16:27, Gary D. Gregory wrote:

Re: [VOTE] Apache MINA 2.2.3, 2.1.8 and 2.0.25 releases

2023-09-12 Thread Gary Gregory
I only tested 2.2.3 RC 1 on Windows with Java 17. My other test runs where on macOS with Java 8. Gary On Tue, Sep 12, 2023, 4:29 AM Emmanuel Lécharny wrote: > Thanks Jeff & Gary. > > Is that for all the MINA versions? > > On 11/09/2023 16:27, Gary D. Gregory wrote: > > I can confirm a failure

Re: [VOTE] Apache MINA 2.2.3, 2.1.8 and 2.0.25 releases

2023-09-12 Thread Emmanuel Lécharny
Never mind, got the same error. In Java 17 a call to CharsetEncoder.encode() on an immutable buffer throws a CoderMalfunctionError, not a ReadOnlyBufferException. The test has to be changed to reflect that. It does not change a thing for the release, it's still good to go. Thanks! On

Re: [VOTE] Apache MINA 2.2.3, 2.1.8 and 2.0.25 releases

2023-09-12 Thread Emmanuel Lécharny
Thanks Jeff & Gary. Is that for all the MINA versions? On 11/09/2023 16:27, Gary D. Gregory wrote: I can confirm a failure on Java 17 and Windows: [INFO] --- [INFO] T E S T S [INFO] ---

Re: [VOTE] Apache MINA 2.2.3, 2.1.8 and 2.0.25 releases

2023-09-11 Thread Gary D. Gregory
I can confirm a failure on Java 17 and Windows: [INFO] --- [INFO] T E S T S [INFO] --- [INFO] Running org.apache.mina.core.buffer.IoBufferHexDumperTest [INFO] Tests run: 2, Failures: 0,

Re: [VOTE] Apache MINA 2.2.3, 2.1.8 and 2.0.25 releases

2023-09-11 Thread Jeff MAURY
+1. 2 remarks: - Does not build with Java 17 - Build is failing on Windows On Mon, Sep 11, 2023 at 8:11 AM Guillaume Nodet wrote: > +1 > > Le jeu. 7 sept. 2023 à 05:30, Emmanuel Lecharny a > écrit : > > > hi! > > > > WARNING: there are 3 votes to cast! > > > > > > This is a vote for a

Re: [VOTE] Apache MINA 2.2.3, 2.1.8 and 2.0.25 releases

2023-09-11 Thread Guillaume Nodet
+1 Le jeu. 7 sept. 2023 à 05:30, Emmanuel Lecharny a écrit : > hi! > > WARNING: there are 3 votes to cast! > > > This is a vote for a triple release: > * MINA 2.2.3 > * MINA 2.1.8 > * MINA 2.0.25 > > Those versions are fixing a Datagram session bug: > DIRMINA-996:IoSessionRecycler RemoteAddress

Re: [VOTE] Apache MINA 2.2.3, 2.1.8 and 2.0.25 releases

2023-09-10 Thread jgenender
+1 Jeff > On Sep 6, 2023, at 9:29 PM, Emmanuel Lecharny wrote: > > hi! > > WARNING: there are 3 votes to cast! > > > This is a vote for a triple release: > * MINA 2.2.3 > * MINA 2.1.8 > * MINA 2.0.25 > > Those versions are fixing a Datagram session bug: > DIRMINA-996:IoSessionRecycler

Re: [VOTE] Apache MINA 2.2.3, 2.1.8 and 2.0.25 releases

2023-09-10 Thread Gary Gregory
Non-binding +1 for all three. Tested each src zip file with 'mvn clear verify' using: Apache Maven 3.9.4 (dfbb324ad4a7c8fb0bf182e6d91b0ae20e3d2dd9) Maven home: /usr/local/Cellar/maven/3.9.4/libexec Java version: 1.8.0_382, vendor: Homebrew, runtime:

RE: [VOTE] Apache MINA 2.2.3, 2.1.8 and 2.0.25 releases

2023-09-07 Thread Christoph John
* MINA 2.2.3 +1 * MINA 2.1.8 +1 * MINA 2.0.25 +1 Thanks Chris -Original Message- From: Emmanuel Lecharny Sent: 07 September 2023 05:30 To: dev@mina.apache.org Subject: [VOTE] Apache MINA 2.2.3, 2.1.8 and 2.0.25 releases hi! WARNING: there are 3 votes to cast! This is a vote for a

Re: Throwing RuntimeException is usually an anti-pattern

2023-07-04 Thread Gary Gregory
Thanks Emmanuel! Gary On Tue, Jul 4, 2023, 16:49 Emmanuel Lécharny wrote: > ... and Apache MINA Team page updated! > > On 04/07/2023 22:33, Emmanuel Lécharny wrote: > > Gary has commit rights :-) > > > > That makes me realize that I need to update the Team page. > > > > And, yes, I do think we

Re: Throwing RuntimeException is usually an anti-pattern

2023-07-04 Thread Emmanuel Lécharny
... and Apache MINA Team page updated! On 04/07/2023 22:33, Emmanuel Lécharny wrote: Gary has commit rights :-) That makes me realize that I need to update the Team page. And, yes, I do think we should thows some meaningful excection. On 04/07/2023 14:35, Jonathan Valliere wrote: Make a PR

Re: Throwing RuntimeException is usually an anti-pattern

2023-07-04 Thread Emmanuel Lécharny
Gary has commit rights :-) That makes me realize that I need to update the Team page. And, yes, I do think we should thows some meaningful excection. On 04/07/2023 14:35, Jonathan Valliere wrote: Make a PR On Mon, Jul 3, 2023 at 7:12 PM Gary Gregory wrote: Hi All, I noticed that in

Re: Throwing RuntimeException is usually an anti-pattern

2023-07-04 Thread Gary Gregory
On Tue, Jul 4, 2023 at 8:35 AM Jonathan Valliere wrote: > > Make a PR An order is not a thought. Gary > > On Mon, Jul 3, 2023 at 7:12 PM Gary Gregory wrote: >> >> Hi All, >> >> I noticed that in org.apache.ftpserver.util.EncryptUtils we explicitly >> throw RuntimeException. This is usually an

Re: Throwing RuntimeException is usually an anti-pattern

2023-07-04 Thread Jonathan Valliere
Make a PR On Mon, Jul 3, 2023 at 7:12 PM Gary Gregory wrote: > Hi All, > > I noticed that in org.apache.ftpserver.util.EncryptUtils we explicitly > throw RuntimeException. This is usually an anti-pattern as > IllegalArgumentException, IllegalStateException, and others are more > descriptive. >

Re: [FTP Server] Bumping deps

2023-07-03 Thread Gary Gregory
Hi Emmanuel, This all sounds good to me! Thank you for the update. Gary On Mon, Jul 3, 2023, 18:39 Emmanuel Lécharny wrote: > Hi Gary, > > I'm currently working on FTP Server for a week now. My goals are to get > MINA 2.2.2 replace the previous version, and to get a grip on teh FTP > serve

Re: Branch 1.2.X does not compile?

2023-07-03 Thread Emmanuel Lécharny
That's on me. I have added two encryption methods (SHA256 and SHA512) because FTPServer was only supporting MD5 and SHA-1. But the EncryptUtils has not yet been committed afaict. I'll check that. On 03/07/2023 23:44, Gary Gregory wrote: Hi All: Did I check out the wrong branch or have bad

Re: [FTP Server] Bumping deps

2023-07-03 Thread Emmanuel Lécharny
Hi Gary, I'm currently working on FTP Server for a week now. My goals are to get MINA 2.2.2 replace the previous version, and to get a grip on teh FTP serve code base. The first step is pretty much on its way, with a few road blocks: - there were some API changes that needed to be addressed

Re: Apache MINA Mastodon account is on!

2023-07-02 Thread Jonathan Valliere
 On Sun, Jul 2, 2023 at 6:32 PM Emmanuel Lécharny wrote: > Hi! > > we just have created a Mastodon account to inform the world abouut the > Apache MINA project evolution. > > Feel free to follow @apachem...@fosstodon.org ! > -- > *Emmanuel Lécharny* > >

Re: [VOTE] Apache MINA 2.2.2, 2.1.7, 2.0.24 releases

2023-06-04 Thread Emmanuel Lécharny
[X] +1 | Release MINA 2.2.2 [X] +1 | Release MINA 2.1.7 [X] +1 | Release MINA 2.0.24 -- *Emmanuel Lécharny - CTO* 205 Promenade des Anglais – 06200 NICE T. +33 (0)4 89 97 36 50 P. +33 (0)6 08 33 32 61 emmanuel.lecha...@busit.com https://www.busit.com/

Re: [VOTE] Apache MINA 2.2.2, 2.1.7, 2.0.24 releases

2023-06-04 Thread Gary Gregory
Non-binding +1 on 2.2.2. SHA512, ASC OK, and 'mvn clean verify' builds OK on: pache Maven 3.9.2 (c9616018c7a021c1c39be70fb2843d6f5f9b8a1c) Maven home: /usr/local/Cellar/maven/3.9.2/libexec Java version: 1.8.0_372, vendor: Homebrew, runtime:

Re: [VOTE] Apache MINA 2.2.2, 2.1.7, 2.0.24 releases

2023-06-04 Thread Gary Gregory
Hi, In the future, it would be convenient if the VOTE email contained a URL to the project's PGP/GPG KEYS file. Gary On Thu, Jun 1, 2023 at 6:58 PM Emmanuel Lécharny wrote: > hi! > > WARNING: there are 3 votes to cast! > > > This is a vote for a triple release: > * MINA 2.2.2 > * MINA 2.1.7 >

Re: [VOTE] Apache MINA 2.2.2, 2.1.7, 2.0.24 releases

2023-06-03 Thread Emmanuel Lécharny
Indeed. The reason we have both SHA-256 and 512 is historic. We can stop signing with SHA-256. I'll update the release process to reflect that. Thanks! On 04/06/2023 03:53, Gary Gregory wrote: In the future, it seems to me like we only need sha512 files, not both 512 and 256. Less clutter

Re: [VOTE] Apache MINA 2.2.2, 2.1.7, 2.0.24 releases

2023-06-03 Thread Gary Gregory
In the future, it seems to me like we only need sha512 files, not both 512 and 256. Less clutter IMO. Gary On Thu, Jun 1, 2023, 18:58 Emmanuel Lécharny wrote: > hi! > > WARNING: there are 3 votes to cast! > > > This is a vote for a triple release: > * MINA 2.2.2 > * MINA 2.1.7 > * MINA 2.0.24

Re: [VOTE] Apache MINA 2.2.2, 2.1.7, 2.0.24 releases

2023-06-02 Thread Jonathan Valliere
+3 On Thu, Jun 1, 2023 at 6:58 PM Emmanuel Lécharny wrote: > hi! > > WARNING: there are 3 votes to cast! > > > This is a vote for a triple release: > * MINA 2.2.2 > * MINA 2.1.7 > * MINA 2.0.24 > > Those versions are fixing some SSL/TLS issues and bring some added > features: > DIRMINA-1122:

RE: [VOTE] Apache MINA 2.2.2, 2.1.7, 2.0.24 releases

2023-06-02 Thread Christoph John
Let us vote : [ X] +1 | Release MINA 2.2.2 [ ] ± | Abstain [ ] -1 | Do *NOT* release MINA 2.2.2 [ X] +1 | Release MINA 2.1.7 [ ] ± | Abstain [ ] -1 | Do *NOT* release MINA 2.1.7 [ X] +1 | Release MINA 2.0.24 [ ] ± | Abstain [ ] -1 | Do *NOT* release MINA 2.0.24 -Original Message- From:

Re: [VOTE] Apache MINA 2.2.2, 2.1.7, 2.0.24 releases

2023-06-01 Thread Jeff Genender
Errr…. +1 to all 3. :-) Jeff > On Jun 1, 2023, at 8:21 PM, Jeff Genender wrote: > > +1 > > Jeff > >> On Jun 1, 2023, at 4:58 PM, Emmanuel Lécharny wrote: >> >> hi! >> >> WARNING: there are 3 votes to cast! >> >> >> This is a vote for a triple release: >> * MINA 2.2.2 >> * MINA 2.1.7 >>

Re: [VOTE] Apache MINA 2.2.2, 2.1.7, 2.0.24 releases

2023-06-01 Thread Jeff Genender
+1 Jeff > On Jun 1, 2023, at 4:58 PM, Emmanuel Lécharny wrote: > > hi! > > WARNING: there are 3 votes to cast! > > > This is a vote for a triple release: > * MINA 2.2.2 > * MINA 2.1.7 > * MINA 2.0.24 > > Those versions are fixing some SSL/TLS issues and bring some added features: >

[GitHub] [mina-sshd] tomaswolf merged pull request #382: GH-371: Re-implement the channel pool of an SftpFileSystem

2023-05-29 Thread via GitHub
tomaswolf merged PR #382: URL: https://github.com/apache/mina-sshd/pull/382 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [mina-sshd] tomaswolf opened a new pull request, #382: GH-371: Re-implement the channel pool of an SftpFileSystem

2023-05-27 Thread via GitHub
tomaswolf opened a new pull request, #382: URL: https://github.com/apache/mina-sshd/pull/382 The previous implementation always put unused SftpClients back into the pool, but SftpClients in the pool were never closed (unless the whole SSH session was closed). Let this pool work more

Re: [VOTE] Release Apache Mina SSHD 2.10.0

2023-05-13 Thread Guillaume Nodet
+1 Le mer. 10 mai 2023, 09:35, Guillaume Nodet a écrit : > I've staged a candidate release for 2.10.0 at: > Official staging repo: > https://dist.apache.org/repos/dist/dev/mina/sshd/2.10.0/ > Maven staging repo: > https://repository.apache.org/content/repositories/orgapachemina-1081 > Git

Re: [VOTE] Release Apache Mina SSHD 2.10.0

2023-05-10 Thread Guillaume Nodet
It's on public keyservers: https://keyserver.ubuntu.com/pks/lookup?search=073F7A9345756F3B40CDB99E6C70A3B7599C5736=on=index I've updated the KEYS file at https://dist.apache.org/repos/dist/release/mina/KEYS with the updated key. Thx ! Le mer. 10 mai 2023 à 21:10, Thomas Wolf a écrit : >

Re: [VOTE] Release Apache Mina SSHD 2.10.0

2023-05-10 Thread Thomas Wolf
On 10.05.23 09:35 , Guillaume Nodet wrote: I've staged a candidate release for 2.10.0 at: [...] Please review and vote ! +1 * JGit SSH tests pass * CI builds in Github are all green * Class versions are 52 (Java 8) * Src tar unpacks and builds fine; all tests pass locally (OS X) Thanks,

Re: [VOTE] Release Apache Mina SSHD 2.10.0

2023-05-10 Thread jgenender
+1 Jeff > On May 10, 2023, at 1:35 AM, Guillaume Nodet wrote: > > I've staged a candidate release for 2.10.0 at: > Official staging repo: > https://dist.apache.org/repos/dist/dev/mina/sshd/2.10.0/ > Maven staging repo: > https://repository.apache.org/content/repositories/orgapachemina-1081 >

Re: [jira] [Commented] (DIRMINA-1173) Apache mina 2.2.1 threads blocking on ConnectFuture.awaitUninterruptibly() for ever

2023-05-09 Thread Jonathan Valliere
Think of it like this. All of the Processor Pool threads share the same FilterChain. So if you have 8 cores there are 16 Processor Threads. If you add a ExecutorFilter with 4 threads then then all the tasks produced by those 16 threads will then be executed on the 4 shared threads and it will

Re: [jira] [Comment Edited] (DIRMINA-1173) Apache mina 2.2.1 threads blocking on ConnectFuture.awaitUninterruptibly() for ever

2023-05-09 Thread Jonathan Valliere
Yes, all sockets On Tue, May 9, 2023 at 11:21 AM KMVS (Jira) wrote: > > [ > https://issues.apache.org/jira/browse/DIRMINA-1173?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17720884#comment-17720884 > ] > > KMVS edited comment on DIRMINA-1173 at 5/9/23 3:20 PM: >

Re: [jira] [Created] (DIRMINA-1170) Will Apache MINA 2.1 and Apache MINA 2.2 evolve in dual branches?

2023-04-17 Thread Jonathan Valliere
Yes, we maintain at least two branches as LTS. However new features will likely only be added to the newest branch. On Mon, Apr 17, 2023 at 9:36 PM Radar wen (Jira) wrote: > Radar wen created DIRMINA-1170: > -- > > Summary: Will Apache MINA 2.1 and

Re: Friendly suggestion to make the dev-list readable again

2023-02-15 Thread Emmanuel Lécharny
Hi Christofer, nice work on plc4x! We will look at it and see how to apply to to the MINA project. Many thanks! On 15/02/2023 15:58, Christofer Dutz wrote: Hi, while reviewing your projects activity as part of my board duties, I came to notice, that the dev-list is in an almost unusable

Re: https://issues.apache.org/jira/browse/FTPSERVER-516

2022-12-01 Thread Christoph John
Hi, please see here: https://mina.apache.org/mina-project/2.2-vs-2.1.html Cheers Chris On 01.12.22 16:28, Gary D. Gregory wrote: Hi All, I want to migrate the FTP server component from Mina Core 2.1.6 to 2.2.1 but there is API breakage. Can someone do the port or provide directions? TY!

Re: Delay in message arrival, please help urgent

2022-11-16 Thread Emmanuel Lécharny
Hi, first, can you tell which MINA version you are using? Also what is your environment (OS, Java version, machine configuration - number of cores, type of CPU, frequency, ram-) Is there any valid reason to create two thread pool of 1000 threads? That sounds overkilling to me. Also are you

Re: Apache Mina key based authentication

2022-10-09 Thread Thomas Wolf
On 23.09.22 17:16 , Radhakrishnan Meiappan wrote: * If I pass the .ppk file I'm getting the below exception - getting exception during parsing of the key file Check what the file format of that PPK file is. If it mentions anything about "argon": you need at least Apache MINA sshd 2.9.0

Re: Please help code review

2022-09-08 Thread Thomas Wolf
On 08.09.22 13:11 , Jonathan Valliere wrote: I don’t know how to connect my personal account to my Apache permissions for Apache repos. IIRC all I had to do was enter my GitHub account name in the Apache account info at https://id.apache.org/ . It may take a few hours to take effect. See

Re: Please help code review

2022-09-08 Thread Jonathan Valliere
I don’t know how to connect my personal account to my Apache permissions for Apache repos. On Thu, Sep 8, 2022 at 3:25 AM Emmanuel Lécharny wrote: > Hi Jonathan, > > what is the pb you are having with GH ? Can't connect? Can't access to > the mina-sshd repo? > > On 2022/09/07 12:32, Jonathan

Re: Please help code review

2022-09-08 Thread Emmanuel Lécharny
Hi Jonathan, what is the pb you are having with GH ? Can't connect? Can't access to the mina-sshd repo? On 2022/09/07 12:32, Jonathan Valliere wrote: Emmanuel do you have a link somewhere how to fix my connection to Apache on GitHub? On Wed, Sep 7, 2022 at 4:29 AM Edward Zheng wrote: Hi

Re: Exception in filter (was: Re: [Vote] MINA 2.2.0 release)

2022-09-07 Thread Christoph John
Thanks, Jonathan. On 27.08.22 20:05, Jonathan Valliere wrote: https://github.com/apache/mina/blob/7893dfc29bb37dcef1345ffb482709902b6b6c9f/mina-core/src/main/java/org/apache/mina/transport/socket/nio/NioSocketSession.java#L94 On Aug 26, 2022 at 5:15:42 AM, Christoph John wrote: The

Re: Please help code review

2022-09-07 Thread Jonathan Valliere
Emmanuel do you have a link somewhere how to fix my connection to Apache on GitHub? On Wed, Sep 7, 2022 at 4:29 AM Edward Zheng wrote: > Hi guys, > > I create a pull request several days ago. > https://github.com/apache/mina-sshd/pull/242. I’m not sure if it’s a > bugfix or my usage is wrong,

Re: [VOTE] Release Apache Mina SSHD 2.9.1

2022-09-05 Thread Emmanuel Lécharny
Hi Guillaume, sorry, I should have tested it again, it now passes green (I was in vacation last week...). I guess it was a hicup... My +1 for teh release. On 2022/09/05 09:43, Guillaume Nodet wrote: I've run the test alone without any issue on osx, windows 10 and fedora, so I'm quite

Re: [VOTE] Release Apache Mina SSHD 2.9.1

2022-09-05 Thread Guillaume Nodet
I've run the test alone without any issue on osx, windows 10 and fedora, so I'm quite confident the underlying code is working correctly. Le mar. 30 août 2022 à 06:41, Emmanuel Lécharny a écrit : > Hi, > > got one error on sshd-core: > > [INFO] Running

Re: [VOTE] Release Apache Mina SSHD 2.9.1

2022-08-30 Thread Lyor Goldstein
+1

Re: [VOTE] Release Apache Mina SSHD 2.9.1

2022-08-29 Thread Emmanuel Lécharny
Hi, got one error on sshd-core: [INFO] Running org.apache.sshd.common.auth.PublicKeyAuthenticationTest [ERROR] Tests run: 7, Failures: 1, Errors: 0, Skipped: 0, Time elapsed: 0.847 s <<< FAILURE! - in org.apache.sshd.common.auth.PublicKeyAuthenticationTest [ERROR]

Re: [VOTE] Release Apache Mina SSHD 2.9.1

2022-08-29 Thread Guillaume Nodet
+1 Le lun. 22 août 2022 à 14:46, Guillaume Nodet a écrit : > I've staged a candidate release for 2.9.1 at: > https://repository.apache.org/content/repositories/orgapachemina-1079 > Git tag: > https://github.com/apache/mina-sshd/tree/sshd-2.9.1 > Issues solved: > >

Re: Exception in filter (was: Re: [Vote] MINA 2.2.0 release)

2022-08-27 Thread Jonathan Valliere
https://github.com/apache/mina/blob/7893dfc29bb37dcef1345ffb482709902b6b6c9f/mina-core/src/main/java/org/apache/mina/transport/socket/nio/NioSocketSession.java#L94 On Aug 26, 2022 at 5:15:42 AM, Christoph John wrote: > The constant PEER_ADDRESS is no longer present in the code in 2.2.x > > I

Re: Exception in filter (was: Re: [Vote] MINA 2.2.0 release)

2022-08-26 Thread Christoph John
The constant PEER_ADDRESS is no longer present in the code in 2.2.x I can see however that in https://github.com/apache/mina/blob/7893dfc29bb37dcef1345ffb482709902b6b6c9f/mina-core/src/main/java/org/apache/mina/filter/ssl/SslFilter.java#L272 and

Re: Exception in filter (was: Re: [Vote] MINA 2.2.0 release)

2022-08-25 Thread Jonathan Valliere
It should be either doing it automatically or is a configurable option in the filter. I’m far away from my computer right now so I can’t check. On Wed, Aug 24, 2022 at 6:44 AM Christoph John wrote: > Hi Jonathan, > > are you able to help me with the last item on the list (see quote below)? > >

Re: Exception in filter (was: Re: [Vote] MINA 2.2.0 release)

2022-08-24 Thread Christoph John
Hi Jonathan, are you able to help me with the last item on the list (see quote below)? Thank you in advance and best regards, Chris. On 28.07.22 16:42, Emmanuel Lécharny wrote: 3. to use SNI we formerly set the "PEER_ADDRESS". Is this still possible? Please see here:

Re: [VOTE] Release Apache Mina SSHD 2.9.1

2022-08-22 Thread Jeff Genender
+1 Jeff > On Aug 22, 2022, at 6:46 AM, Guillaume Nodet wrote: > > I've staged a candidate release for 2.9.1 at: > https://repository.apache.org/content/repositories/orgapachemina-1079 > Git tag: > https://github.com/apache/mina-sshd/tree/sshd-2.9.1 > Issues solved: >

Re: Apache MINA SSHD 2.9.1 bug-fix release needed (Was: Apache MINA 2.9.1 bug-fix release needed)

2022-08-12 Thread Thomas Wolf
On 11.08.22 15:08 , Guillaume Nodet wrote: I'm mostly offline these days, but i'll try to push a release candidate for a vote this week or next. Thanks, Guillaume! Make it next week; another issue has come up that needs a hotfix. (SSHD-1289) Cheers, Thomas

Re: Infinite loop in Apache Directory Server when using MINA 2.2.1

2022-08-11 Thread Emmanuel Lécharny
Directory. bascially, rebuilding Apache LDAP API with Java 8 did the trick. The pb was due to an exception caused by an API change in Java 9, related to ByteBuffer (see https://www.morling.dev/blog/bytebuffer-and-the-dreaded-nosuchmethoderror/) which was causing an exception to be thrown,

Re: Apache MINA SSHD 2.9.1 bug-fix release needed (Was: Apache MINA 2.9.1 bug-fix release needed)

2022-08-11 Thread Guillaume Nodet
I'm mostly offline these days, but i'll try to push a release candidate for a vote this week or next. Le mer. 3 août 2022 à 22:03, Thomas Wolf a écrit : > On 02.08.22 23:47 , Thomas Wolf wrote: > > The 2.9.0 release appears to have been built incorrectly. > > To clarify: of course I meant "The

Re: Infinite loop in Apache Directory Server when using MINA 2.2.1

2022-08-10 Thread Jonathan Valliere
Was the fix in Mina or Directory? On Wed, Aug 10, 2022 at 5:34 AM Emmanuel Lécharny wrote: > I confirm. I built the LDAP API with Java 11 targetting Java 8, but it's > not enough. > > Fixed in trunk. > > On 30/07/2022 10:23, Emmanuel Lécharny wrote: > > Seems like it's an issue with a mixed

Re: Infinite loop in Apache Directory Server when using MINA 2.2.1

2022-08-10 Thread Emmanuel Lécharny
I confirm. I built the LDAP API with Java 11 targetting Java 8, but it's not enough. Fixed in trunk. On 30/07/2022 10:23, Emmanuel Lécharny wrote: Seems like it's an issue with a mixed Java version being used: the lib built with Java 11 and running tests in Java 8, or something like that.

Re: Apache MINA SSHD 2.9.1 bug-fix release needed (Was: Apache MINA 2.9.1 bug-fix release needed)

2022-08-03 Thread Thomas Wolf
On 02.08.22 23:47 , Thomas Wolf wrote: The 2.9.0 release appears to have been built incorrectly. To clarify: of course I meant "The Apache MINA SSHD 2.9.0 release..." Guillaume, could you please prepare a 2.9.1 bug fix release? of Apache MINA SSHD? Cheers, Thomas

Re: Infinite loop in Apache Directory Server when using MINA 2.2.1

2022-07-30 Thread Emmanuel Lécharny
Seems like it's an issue with a mixed Java version being used: the lib built with Java 11 and running tests in Java 8, or something like that. Still investigating. On 30/07/2022 10:03, Emmanuel Lécharny wrote: Hi, I'm currently investiagting some infinite loop in Apache DS when setting up

Re: BindException on MacOS

2022-07-28 Thread Jonathan Valliere
I think it’s related to how the kqueue works in combination with the socket shutdown cycle in SocketChannel. It’s likely that our close event is triggering too early. On Thu, Jul 28, 2022 at 9:31 AM Christoph John wrote: > Hi, > > we have a test suite for QuickFIX/J which runs (at least) every

Re: Exception in filter (was: Re: [Vote] MINA 2.2.0 release)

2022-07-28 Thread Emmanuel Lécharny
Hi Christoph, answers inline On 28/07/2022 14:48, Christoph John wrote: Hi Emmanuel, I took a look at this and it seems the two latches were a red herring. One is for the initiator (connector) and the other one for the acceptor that are used in the unit test. I must admit I haven't

Re: Exception in filter (was: Re: [Vote] MINA 2.2.0 release)

2022-07-28 Thread Christoph John
Hi Emmanuel, I took a look at this and it seems the two latches were a red herring. One is for the initiator (connector) and the other one for the acceptor that are used in the unit test. I must admit I haven't spent enough time to unerstand what was going on ;-) No problem, thank you

Result, was Re: [VOTE] Apache MINA 2.2.1 release

2022-07-24 Thread Emmanuel Lécharny
Hi! I'm closing this vote with 4 binding +1 and one ,on binding +1: Binding - Jonathan - Jeff Genender - Guillaume - and me Non Binding: - Chistoph. Thanks for the votes, I'll push the packages and announce the release ASAP ! On 20/07/2022 15:41, Emmanuel Lécharny wrote: hi! This is a

Re: Exception in filter (was: Re: [Vote] MINA 2.2.0 release)

2022-07-21 Thread Emmanuel Lécharny
On 21/07/2022 15:38, Christoph John wrote: Hi Emmanuel, I took a look at this and it seems the two latches were a red herring. One is for the initiator (connector) and the other one for the acceptor that are used in the unit test. I must admit I haven't spent enough time to unerstand

Re: [VOTE] Release Apache Mina SSHD 2.9.0 (2nd try)

2022-07-21 Thread Guillaume Nodet
+1 Le lun. 18 juil. 2022 à 09:51, Guillaume Nodet a écrit : > > I've staged another candidate release at: > https://repository.apache.org/content/repositories/orgapachemina-1076 > Git tag: > https://github.com/apache/mina-sshd/tree/sshd-2.9.0 > Issues solved: >

Re: Exception in filter (was: Re: [Vote] MINA 2.2.0 release)

2022-07-21 Thread Christoph John
Hi Emmanuel, I took a look at this and it seems the two latches were a red herring. One is for the initiator (connector) and the other one for the acceptor that are used in the unit test. However, I think I found the root cause for the failing unit tests. We have an AbstractIoHandler which

Re: [VOTE] Apache MINA 2.2.1 release

2022-07-20 Thread Christoph John
+1 On 20.07.22 16:33, Guillaume Nodet wrote: +1 Le mer. 20 juil. 2022 à 15:42, Emmanuel Lécharny a écrit : hi! This is a vote for MINA 2.2.1. This version just fixes an issue in the export declaration for OSGi: a missing comma made MINA 2.2.0 impossible to use by application that

Re: [VOTE] Apache MINA 2.2.1 release

2022-07-20 Thread Guillaume Nodet
+1 Le mer. 20 juil. 2022 à 15:42, Emmanuel Lécharny a écrit : > hi! > > > This is a vote for MINA 2.2.1. > > This version just fixes an issue in the export declaration for OSGi: a > missing comma made MINA 2.2.0 impossible to use by application that > leverage OSGi, due to a concatenation of

Re: [VOTE] Apache MINA 2.2.1 release

2022-07-20 Thread Jonathan Valliere
+1 On Wed, Jul 20, 2022 at 9:46 AM Jeff Genender wrote: > +1 > > Jeff > > > On Jul 20, 2022, at 7:41 AM, Emmanuel Lécharny > wrote: > > > > hi! > > > > > > This is a vote for MINA 2.2.1. > > > > This version just fixes an issue in the export declaration for OSGi: a > missing comma made MINA

Re: [VOTE] Apache MINA 2.2.1 release

2022-07-20 Thread Jeff Genender
+1 Jeff > On Jul 20, 2022, at 7:41 AM, Emmanuel Lécharny wrote: > > hi! > > > This is a vote for MINA 2.2.1. > > This version just fixes an issue in the export declaration for OSGi: a > missing comma made MINA 2.2.0 impossible to use by application that leverage > OSGi, due to a

Re: [VOTE] Release Apache Mina SSHD 2.9.0 (2nd try)

2022-07-20 Thread Thomas Wolf
On 18.07.22 09:51 , Guillaume Nodet wrote: I've staged another candidate release at: https://repository.apache.org/content/repositories/orgapachemina-1076 Git tag: https://github.com/apache/mina-sshd/tree/sshd-2.9.0 Issues solved:

Re: [VOTE] Release Apache Mina SSHD 2.9.0 (2nd try)

2022-07-19 Thread Emmanuel Lécharny
+1 - checked the packages signatures (GPG and SHA) - built from source, tests all green (java 11) Thanks Guillaume ! PS: I'll update the site doco to point to the proper KEYS file On 19/07/2022 16:31, Guillaume Nodet wrote: It's a subkey of the my last key which I've uploaded to

Re: [VOTE] Release Apache Mina SSHD 2.9.0 (2nd try)

2022-07-19 Thread Guillaume Nodet
It's a subkey of the my last key which I've uploaded to https://dist.apache.org/repos/dist/release/mina/KEYS. It's available at http://keyserver.ubuntu.com/pks/lookup?search=4A61C968D0023541DAE9B1A0BC7DF305D87BDFA7=on=index but the key fingerprint does not appear in the KEYS file (I think that's

Re: [VOTE] Release Apache Mina SSHD 2.9.0 (2nd try)

2022-07-19 Thread Emmanuel Lécharny
Hi Guillaume, qstill have an issue with the KEYS file. Where did you pushed it ? (I have successfully checked the signature with the SHA256 sig you pushed, thanks !) On 19/07/2022 11:51, Guillaume Nodet wrote: I've uploaded the releases and SHA 256 / 512 signatures to

Re: [VOTE] Release Apache Mina SSHD 2.9.0 (2nd try)

2022-07-19 Thread Guillaume Nodet
I've uploaded the releases and SHA 256 / 512 signatures to https://dist.apache.org/repos/dist/dev/mina/sshd/ and added my new key to the mina KEYS file. Thx ! Le mar. 19 juil. 2022 à 06:49, Emmanuel Lécharny a écrit : > Just mentionning it because we *MUST* provide SHA256 and SHA 512 >

Re: [VOTE] Release Apache Mina SSHD 2.9.0 (2nd try)

2022-07-18 Thread Emmanuel Lécharny
Just mentionning it because we *MUST* provide SHA256 and SHA 512 signatures, and the standard maven release only generates MD5 and SHA1 signatures. On 19/07/2022 06:47, Emmanuel Lécharny wrote: Also the packages are missing from https://dist.apache.org/repos/dist/dev/mina/sshd/ On

Re: [VOTE] Release Apache Mina SSHD 2.9.0 (2nd try)

2022-07-18 Thread Emmanuel Lécharny
Also the packages are missing from https://dist.apache.org/repos/dist/dev/mina/sshd/ On 18/07/2022 09:51, Guillaume Nodet wrote: I've staged another candidate release at: https://repository.apache.org/content/repositories/orgapachemina-1076 Git tag:

Re: [VOTE] Release Apache Mina SSHD 2.9.0 (2nd try)

2022-07-18 Thread Jeff Genender
+1 Jeff > On Jul 18, 2022, at 1:51 AM, Guillaume Nodet wrote: > > I've staged another candidate release at: > https://repository.apache.org/content/repositories/orgapachemina-1076 > Git tag: > https://github.com/apache/mina-sshd/tree/sshd-2.9.0 > Issues solved: >

Re: [Vote] MINA 2.2.0 release

2022-07-17 Thread Guillaume Nodet
+1 Le lun. 4 juil. 2022 à 23:43, Emmanuel Lécharny a écrit : > Hi! > > > it has been a couple of months now that I cut a version of MINA 2.2.0, > but haven't started a vote, because I wanted to test that exception were > properly handled when generated from the SslFilter. It took may way >

Re: [VOTE] Release Apache Mina SSHD 2.9.0

2022-07-17 Thread Emmanuel Lécharny
time:/ Just to be sure. (not such a big deal, I can re-push the packages). On 17/07/2022 00:42, Guillaume Nodet wrote: Yes, I'll do that on monday. Le sam. 16 juil. 2022 à 10:38, Thomas Wolf a écrit : On 13.07.22 08:44 , Thomas Wolf wrote: On 13.07.22 00:20 , Emmanuel Lécharny wrote: I get

Re: [VOTE] Release Apache Mina SSHD 2.9.0

2022-07-16 Thread Guillaume Nodet
Yes, I'll do that on monday. Le sam. 16 juil. 2022 à 10:38, Thomas Wolf a écrit : > On 13.07.22 08:44 , Thomas Wolf wrote: > > On 13.07.22 00:20 , Emmanuel Lécharny wrote: > >> I get some error while running tests: > >> org.testcontainers.containers.ContainerLaunchException: Container > >>

Re: [Vote] MINA 2.2.0 release

2022-07-16 Thread Jonathan Valliere
mine is binding so we should be over the threshold now On Jul 16, 2022 at 11:54:40 AM, Jeff Genender wrote: > I dont remember if I voted or not…but if not… here it is… > > Jeff > > > On Jul 16, 2022, at 8:49 AM, Emmanuel Lécharny > wrote: > > > > > On 16/07/2022 11:31, Christoph John wrote:

Re: [Vote] MINA 2.2.0 release

2022-07-16 Thread Jeff Genender
I dont remember if I voted or not…but if not… here it is… Jeff > On Jul 16, 2022, at 8:49 AM, Emmanuel Lécharny wrote: > > > > On 16/07/2022 11:31, Christoph John wrote: >> +1 > > Thanks! > >> But don't know if my vote counts. > > Every vote *do* count, even if not all the votes are

Re: [Vote] MINA 2.2.0 release

2022-07-16 Thread Emmanuel Lécharny
On 16/07/2022 11:31, Christoph John wrote: +1 Thanks! But don't know if my vote counts. Every vote *do* count, even if not all the votes are binding. The idea is that if someone casts a -1, that means there is something that requires some investigation. Typically, when I started the

Re: [Vote] MINA 2.2.0 release

2022-07-16 Thread Jonathan Valliere
+1 CONFIDENTIALITY NOTICE: The contents of this email message and any attachments are intended solely for the addressee(s) and may contain confidential and/or privileged information and may be legally protected from disclosure. On Jul 16, 2022 at 4:31:51 AM, Emmanuel Lécharny wrote: > Hi, >

Re: [Vote] MINA 2.2.0 release

2022-07-16 Thread Christoph John
+1 But don't know if my vote counts. Thanks for your investigation. I will take a closer look next week. Cheers Chris Jul 16, 2022 10:32:02 Emmanuel Lécharny : > Hi, > > I need one more vote at least to get the release out. > > I'm confident the pb Christoph had was due to some bad test, not

Re: [VOTE] Release Apache Mina SSHD 2.9.0

2022-07-16 Thread Thomas Wolf
On 13.07.22 08:44 , Thomas Wolf wrote: On 13.07.22 00:20 , Emmanuel Lécharny wrote: I get some error while running tests: org.testcontainers.containers.ContainerLaunchException: Container startup failed The problem is that the entrypoint.sh files in the test resources don't have the

Re: [Vote] MINA 2.2.0 release

2022-07-16 Thread Emmanuel Lécharny
Hi, I need one more vote at least to get the release out. I'm confident the pb Christoph had was due to some bad test, not to a MINA issue. Thanks ! On 05/07/2022 09:38, Christoph John wrote: Hi Emmanuel Did you manage to fix the bug which we talked about in the mail thread from May

Re: Exception in filter (was: Re: [Vote] MINA 2.2.0 release)

2022-07-15 Thread Emmanuel Lécharny
Hi Christoph, after further analysis, it appears that we have 2 countdown latch instances (exceptionThrownLatch) at play: * one that is decremented in the exceptionCaught event, [Count1]>:1]--->PKIX path validation failed: java.security.cert.CertPathValidatorException:

Re: Exception in filter (was: Re: [Vote] MINA 2.2.0 release)

2022-07-13 Thread Emmanuel Lécharny
Hi Christoph, actually, there is a kind of race condition in your test. I have added some logs: @Override public void exceptionCaught(NextFilter nextFilter, IoSession session, Throwable cause) throws Exception {

Re: Exception in filter (was: Re: [Vote] MINA 2.2.0 release)

2022-07-13 Thread Emmanuel Lécharny
On 13/07/2022 09:37, Christoph John wrote: Hi Emmanuel, thanks for your analysis. The filter that should catch the exception is added as last part in the chain. Could it be that the chain is not fully iterated somehow? Just guessing, I don't have enough MINA experience to make an educated

Re: Exception in filter (was: Re: [Vote] MINA 2.2.0 release)

2022-07-13 Thread Christoph John
Hi Emmanuel, thanks for your analysis. The filter that should catch the exception is added as last part in the chain. Could it be that the chain is not fully iterated somehow? Just guessing, I don't have enough MINA experience to make an educated guess. :) Cheers Chris Jul 13, 2022 06:38:00

Re: [VOTE] Release Apache Mina SSHD 2.9.0

2022-07-13 Thread Thomas Wolf
On 13.07.22 00:20 , Emmanuel Lécharny wrote: Hi Guillaume, I get some error while running tests: [ERROR] Tests run: 6, Failures: 0, Errors: 6, Skipped: 0, Time elapsed: 33.642 s <<< FAILURE! - in org.apache.sshd.client.auth.pubkey.HostBoundPubKeyAuthTest [ERROR]

Re: Exception in filter (was: Re: [Vote] MINA 2.2.0 release)

2022-07-12 Thread Emmanuel Lécharny
Here are some of my current findings. For the (failing) test shouldFailWhenUsingBadClientCertificate, here are the traces we get: juil. 13, 2022 6:28:42 AM org.apache.mina.filter.ssl.SSLHandlerG0 execute_task GRAVE: SSLHandlerG0@ae273e3[mode=server, connected=false] task() - storing error

Re: Exception in filter (was: Re: [Vote] MINA 2.2.0 release)

2022-07-12 Thread Emmanuel Lécharny
Never mind, I'm set up now, and in debug mode. All is good ! On 13/07/2022 00:47, Emmanuel Lécharny wrote: Hi Christoph, I'm trying to  ran the failing tests on my machine (eclipse with Java 8 and Java 11), and I'll probably need some assistance. I'm using the chrjohn-mina-2.2.0 branch. It

Re: Exception in filter (was: Re: [Vote] MINA 2.2.0 release)

2022-07-12 Thread Emmanuel Lécharny
Hi Christoph, I'm trying to ran the failing tests on my machine (eclipse with Java 8 and Java 11), and I'll probably need some assistance. I'm using the chrjohn-mina-2.2.0 branch. It seems that the generated code is not stored at the proper place. Any clue? On 09/07/2022 11:49,

<    2   3   4   5   6   7   8   9   10   11   >