Re: [RESULT][LAZY VOTE] Next MXNet release

2018-11-06 Thread Sheng Zha
I'd like to propose that we expedite the 1.4.0 release slightly as there doesn't seem to be a rule that prevents a minor release from happening at the same time of a patch release. This would shorten the time it takes for new features to reach users. Proposed revision to the timeline: - Code

Re: [Announce] Upcoming Apache MXNet (incubating) 1.3.1 patch release

2018-11-06 Thread Sheng Zha
Similar to the two PRs that Haibin suggested, 12992 introduces new interface for controlling determinism, which is better suited for minor release. I think other than lack of release manager to drive 1.4.0 release, there’s no reason we cannot do two releases (1.4.0 & 1.3.1) at the same time.

Re: [Announce] Upcoming Apache MXNet (incubating) 1.3.1 patch release

2018-11-06 Thread Lin Yuan
Hi Anton, Thanks for helping the release. The following PRs are needed by customers who want to use deterministic CUDNN convolution algorithms: https://github.com/apache/incubator-mxnet/pull/12992 https://github.com/apache/incubator-mxnet/pull/13049 Thanks! Lin On Tue, Nov 6, 2018 at 1:51 PM

Re: [DISCUSS] Speedup non-code PR in CI

2018-11-06 Thread Lin Yuan
Kellen and Pedro, Thanks for your pointers. I am not an expert in CI but one naive speedup I can see is that if the PR only contains *.md file, then skip the build and testing cycles. This can make documentation/correction easier and save computation resource for other needed tests. Any side

Re: [DISCUSS] Speedup non-code PR in CI

2018-11-06 Thread Pedro Larroy
It has been raised but there are practical complications about introducing an additional layer of logic for skipping CI in some scenarios. How many of these PRs do we have which will justify investing human effort on optimizing an automated process? How much effort shall it be dedicated to this

Re: [Announce] Upcoming Apache MXNet (incubating) 1.3.1 patch release

2018-11-06 Thread Haibin Lin
Hi Naveen and Anton, Thanks for pointing that out. You are right that these are not critical fixes. Putting them in 1.4.0 is more appropriate. PRs are closed. Best, Haibin On Tue, Nov 6, 2018 at 7:35 AM Naveen Swamy wrote: > Please note that this is a patch release(1.3.1) to address critical

Re: [DISCUSS] Build OSX builds in CI (possibly with TravisCI).

2018-11-06 Thread Marco de Abreu
Hi, the PR has just been merged. Thank you, Sheng! Travis is now only running compilation on Travis for Mac OS X and we are no longer running tests. The issue to track this case is available at [1]. Best regards, Marco [1]: https://github.com/apache/incubator-mxnet/issues/13136 On Tue, Nov 6,

[DISCUSS] Speedup non-code PR in CI

2018-11-06 Thread Lin Yuan
Dear Community, I recently submitted a few small PRs with only changes in README files. However, I noticed they still triggered the full cycle of CI including build and test on all platforms. Do we have a plan to speed up this process, maybe skipping non-code related PRs in CI? Sorry, if this

Re: [DISCUSS] Build OSX builds in CI (possibly with TravisCI).

2018-11-06 Thread kellen sunderland
Looks good to me. Sorry this couldn't work out for the community. On Tue, Nov 6, 2018, 7:24 AM Marco de Abreu Hello, > > the PR is available at > https://github.com/apache/incubator-mxnet/pull/13137. > I'd appreciate a review and merge. > > Best regards, > Marco > > On Tue, Nov 6, 2018 at 12:01

Re: [Announce] Upcoming Apache MXNet (incubating) 1.3.1 patch release

2018-11-06 Thread Naveen Swamy
Please note that this is a patch release(1.3.1) to address critical bugs!, For everything else please wait for 1.4.0 which is planned very shortly after 1.3.1 > On Nov 6, 2018, at 7:17 AM, Anton Chernov wrote: > > The following PR's have been created so far: > > Infer dtype in SymbolBlock

Re: [DISCUSS] Build OSX builds in CI (possibly with TravisCI).

2018-11-06 Thread Marco de Abreu
Hello, the PR is available at https://github.com/apache/incubator-mxnet/pull/13137. I'd appreciate a review and merge. Best regards, Marco On Tue, Nov 6, 2018 at 12:01 AM Marco de Abreu wrote: > Sorry, wrong link. The right link is: > https://issues.apache.org/jira/browse/INFRA-17216 > >

Re: [Announce] Upcoming Apache MXNet (incubating) 1.3.1 patch release

2018-11-06 Thread Anton Chernov
The following PR's have been created so far: Infer dtype in SymbolBlock import from input symbol (v1.3.x) https://github.com/apache/incubator-mxnet/pull/13117 [MXNET-953] Fix oob memory read (v1.3.x) https://github.com/apache/incubator-mxnet/pull/13118 [MXNET-969] Fix buffer overflow in RNNOp

Re: [Announce] Upcoming Apache MXNet (incubating) 1.3.1 patch release

2018-11-06 Thread Anton Chernov
Hi Haibin, I have a few comments regarding the proposed performance improvement changes. CUDNN support for LSTM with projection & clipping https://github.com/apache/incubator-mxnet/pull/13056 There is no doubt that this change brings value, but I don't see it as a critical bug fix. I would

Re: [Announce] Upcoming Apache MXNet (incubating) 1.3.1 patch release

2018-11-06 Thread Anton Chernov
Hi Patric, This change was listed in the 'PR candidates suggested for consideration for v1.3.1 patch release' section [1]. You are right, I also think that this is not a critical hotfix change that should be included into the 1.3.1 patch release. Thus I'm not making any further efforts to bring