warnings and I would like to call for additional help and
contributions in this area.
There was a question from Lin about discussing this on the mailing
list, I have the feeling that everybody agrees on moving towards zero
warnings and warnings as errors. I think there are unavoidable
warnings
an a dozen of PRs fixing
> warnings and I would like to call for additional help and
> contributions in this area.
>
> There was a question from Lin about discussing this on the mailing
> list, I have the feeling that everybody agrees on moving towards zero
> warnings and warning
ional help and
> > contributions in this area.
> >
> > There was a question from Lin about discussing this on the mailing
> > list, I have the feeling that everybody agrees on moving towards zero
> > warnings and warnings as errors. I think there are unavoidable
> >
gt; > > trivial and ungrateful efforts, take nonetheless energy on the
> > > contributor side.
> > >
> > > I think overall I submitted myself more than a dozen of PRs fixing
> > > warnings and I would like to call for additional help and
> > > contri
Hi
I would like to propose to compile in CI with warnings as errors for
increased code quality. This has a dual purpose:
1. Enforce a clean compilation output. Warnings often indicate
deficiencies in the code and hide new warnings which can be an
indicator of problems.
2. Warnings can surface
+1
On Mon, Jan 15, 2018 at 6:27 PM, Pedro Larroy
wrote:
> Hi
>
> I would like to propose to compile in CI with warnings as errors for
> increased code quality. This has a dual purpose:
>
> 1. Enforce a clean compilation output. Warnings often indicate
> deficiencies in
+1 (binding)
On Mon, Jan 15, 2018 at 9:43 AM, Marco de Abreu <
marco.g.ab...@googlemail.com> wrote:
> +1
>
> On Mon, Jan 15, 2018 at 6:27 PM, Pedro Larroy <
> pedro.larroy.li...@gmail.com>
> wrote:
>
> > Hi
> >
> > I would like to prop
M, Pedro Larroy <
> pedro.larroy.li...@gmail.com>
> wrote:
>
> > Hi
> >
> > I would like to propose to compile in CI with warnings as errors for
> > increased code quality. This has a dual purpose:
> >
> > 1. Enforce a clean compilation output. Warnings often
t; a particular compiler/platform/version?
>
> On Mon, Jan 15, 2018 at 9:43 AM, Marco de Abreu <
> marco.g.ab...@googlemail.com> wrote:
>
> > +1
> >
> > On Mon, Jan 15, 2018 at 6:27 PM, Pedro Larroy <
> > pedro.larroy.li...@gmail.com>
> > wrote:
>
>
> > > +1
> > >
> > > On Mon, Jan 15, 2018 at 6:27 PM, Pedro Larroy <
> > > pedro.larroy.li...@gmail.com>
> > > wrote:
> > >
> > > > Hi
> > > >
> > > > I would like to propose to compile in CI with warnings
for treating warnings as errors in Linux & Clang builds
(-Werror)
+1 since warnings might be potential errors. In my perspective, an
excellent project is better to have 0 warnings.
Chris Olivier 于2018年1月16日 周二上午2:27写道：
> If enabled, it should only cause errors in Release builds, since
that will be easily fixable once we upgrade the compiler in CI.
We also get the benefit of preventing warnings on the gcc versions
that the author is using, in the case he has a different one. Another
option is to enable warnings as errors only on CI. I would prefer to
have it enabled by de
I'd vote for having warnings as errors only for CI but not in general
builds which are getting executed by users on their local machine. Just in
case CI misses a warning due to a different version, this could block a
developer from compiling MXNet locally even though it might just be a
wa
Personally, I don’t like treating warnings as errors because it prevents
compilation from completing and causes you to lose any ability to test the code
and get any other information. Killing the build because of a failed warning
for something that might not matter means that you may not find
So you're proposing to have a stage AFTER test execution which would report
warnings as errors? While this is a good idea, I'm afraid that a fail-fast
would also have its benefits - especially considering that compilation only
takes a few minutes and consumes few resources while test
open up a JIRA to your team and you will fix
them?
On Tue, Jan 16, 2018 at 7:48 AM Marco de Abreu
wrote:
> So you're proposing to have a stage AFTER test execution which would report
> warnings as errors? While this is a good idea, I'm afraid that a fail-fast
> would als
I can see an argument for treating warnings as errors during manual builds (if
the developer so wishes), but for automated builds I would rather get more
information. I also wouldn’t kill a build just because a test fails either
because there may be useful information from other tests. Why
ast having warnings as errors on CI.
Regarding my development experience, I just try to make bona fide
recommendations given that I worked (survived?) in C++ codebases with
hundreds of developers that run successfully in the order of billions
of devices. I'm sure you have your own bag of tricks
n to treat warnings as errors in any code that leaves a developer's own
machine. If a team/project doesn't do this, it is relying on the good
intentions of people to prevent code warnings from multiplying to the point
that they become effectively useless.
I have mixed feelings about
full tests
run for information purposes. However, given how resource intensive our
testing is I'd prefer that we run some sanity checks first before we launch
a full test run.
@Chris + Pedro: I think it's a good idea to focus discussion on what should
happen in CI. Most CI builds alread
a good idea to focus discussion on what should
happen in CI. Most CI builds already have warnings as errors turned on (as
mentioned by Xingjian ) because we have USE_DEV=1 set. We currently have
the following warnings disabled in CI (i.e. they won't fail the build, and
are n
21 matches
Mail list logo
