[jira] [Created] (TOBAGO-1044) The defaultCommand of button should have a special markup

2011-10-27 Thread Udo Schnurpfeil (Created) (JIRA)
The defaultCommand of button should have a special markup --- Key: TOBAGO-1044 URL: https://issues.apache.org/jira/browse/TOBAGO-1044 Project: MyFaces Tobago Issue Type: Improvement

[jira] [Created] (MYFACES-3377) unsynchronized lazy initialization could create concurrency errors

2011-10-27 Thread Mark Struberg (Created) (JIRA)
unsynchronized lazy initialization could create concurrency errors -- Key: MYFACES-3377 URL: https://issues.apache.org/jira/browse/MYFACES-3377 Project: MyFaces Core Issue

[jira] [Resolved] (MYFACES-3377) unsynchronized lazy initialization could create concurrency errors

2011-10-27 Thread Mark Struberg (Resolved) (JIRA)
[ https://issues.apache.org/jira/browse/MYFACES-3377?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mark Struberg resolved MYFACES-3377. Resolution: Fixed Fix Version/s: 2.1.4 unsynchronized lazy initialization

Re: [VOTE] extend maximum allowed line length from 120 to 160

2011-10-27 Thread Rudy De Busscher
+0 I'll find 160 much, even with a wide screen. On 26 October 2011 21:39, Leonardo Uribe lu4...@gmail.com wrote: +0 2011/10/26 Grant Smith work.gr...@gmail.com: +1 On Wed, Oct 26, 2011 at 7:23 AM, Michael Kurz michi.k...@gmx.at wrote: -1 Am 26.10.2011 14:18, schrieb Mark

Re: treating obsolete code

2011-10-27 Thread Rudy De Busscher
+1 -- Rudy De Busscher http://www.c4j.be On 27 October 2011 00:56, Grant Smith work.gr...@gmail.com wrote: +1 Be ruthless ! On Wed, Oct 26, 2011 at 11:35 AM, Gerhard Petracek gerhard.petra...@gmail.com wrote: +1 regards, gerhard http://www.irian.at Your JSF powerhouse - JSF

Antwort: Re: java.lang.IllegalStateException: zip file closed

2011-10-27 Thread Gregor . JARISCH
Hi Jakob, thank you for your answer. I agree to your explanation. Although I believe Jetty does work as expected. It allows concurrent exceptions, the only thing it is missing is the fact that it returns input streams also when they are closed. I would assume that it would be more suitable if

Re: treating obsolete code

2011-10-27 Thread Bernd Bohmann
+1 for deleting Regards Bernd On Wed, Oct 26, 2011 at 6:08 PM, Mark Struberg strub...@yahoo.de wrote: Hi folks! I see a lot of commented out code which is many years old. I'm highly in favour to just delete code we don't need anymore! IF you only temporarily comment out something, then

StateHolder#isTransient equals and hashCode question

2011-10-27 Thread Mark Struberg
Hi! we have lots of classes which implement equals but no hashCode() - this is bad. e.g. DoubleRangeValidator has an equals but doesn't include _transient in it's comparison. Is this ok? LieGrue, strub

Re: StateHolder#isTransient equals and hashCode question

2011-10-27 Thread Mike Kienenberger
I think it is ok to ignore transient values for equals/hasCode since it is also not saved as part of the state. But I'm not an expert. On Thu, Oct 27, 2011 at 9:53 AM, Mark Struberg strub...@yahoo.de wrote: Hi! we have lots of classes which implement equals but no hashCode() - this is bad.

Re: StateHolder#isTransient equals and hashCode question

2011-10-27 Thread Mark Struberg
Hi Mike! _transient is _not_ a transient value, but is the value returned by StateHolder#isTransient() http://javaserverfaces.java.net/nonav/docs/2.0/javadocs/javax/faces/component/StateHolder.html#isTransient%28%29 LieGrue, strub - Original Message - From: Mike Kienenberger

Re: StateHolder#isTransient equals and hashCode question

2011-10-27 Thread Mike Kienenberger
Yes, I know that. But since it is not part of the state, and would be lost anyway on a saveState/restoreState, I don't think it needs to be considered for equals. It seems to be a transient value :) On Thu, Oct 27, 2011 at 10:22 AM, Mark Struberg strub...@yahoo.de wrote: Hi Mike! _transient

Re: StateHolder#isTransient equals and hashCode question

2011-10-27 Thread Mark Struberg
oki, thanks for this info! LieGrue, strub - Original Message - From: Mike Kienenberger mkien...@gmail.com To: MyFaces Development dev@myfaces.apache.org; Mark Struberg strub...@yahoo.de Cc: Sent: Thursday, October 27, 2011 4:25 PM Subject: Re: StateHolder#isTransient equals and

Re: StateHolder#isTransient equals and hashCode question

2011-10-27 Thread Mike Kienenberger
Please don't take my word for it. I am guessing somewhat here. I admit that I don't really know. But it does seem like equality and saved state should be related. On Thu, Oct 27, 2011 at 10:32 AM, Mark Struberg strub...@yahoo.de wrote: oki, thanks for this info! LieGrue, strub -

[VOTE] disable DoubleCheckLockIdiom test?

2011-10-27 Thread Mark Struberg
Hi! The double-check-lock idiom was fundamentally broken up until Java5. With JSR-133 this got finally fixed. We use this design pattern in our code since a long time (of course not always correct due to the missing 'volatile' declaration), but it really only works with Java5 upwards. So

Re: [VOTE] disable DoubleCheckLockIdiom test?

2011-10-27 Thread Leonardo Uribe
+1 2011/10/27 Mark Struberg strub...@yahoo.de: Hi! The double-check-lock idiom was fundamentally broken up until Java5. With JSR-133 this got finally fixed. We use this design pattern in our code since a long time (of course not always correct due to the missing 'volatile' declaration),

Re: treating obsolete code

2011-10-27 Thread Jakob Korherr
+1 !! Regards, Jakob 2011/10/27 Bernd Bohmann bernd.bohm...@atanion.com: +1 for deleting Regards Bernd On Wed, Oct 26, 2011 at 6:08 PM, Mark Struberg strub...@yahoo.de wrote: Hi folks! I see a lot of commented out code which is many years old. I'm highly in favour to just delete code

[jira] [Created] (MYFACES-3378) UIComponent.setParent does not propagate setInView() call when processingEvents is false

2011-10-27 Thread Leonardo Uribe (Created) (JIRA)
UIComponent.setParent does not propagate setInView() call when processingEvents is false Key: MYFACES-3378 URL: https://issues.apache.org/jira/browse/MYFACES-3378

[jira] [Created] (MYFACES-3379) PostAddToViewEvent should be propagated to UIViewRoot

2011-10-27 Thread Leonardo Uribe (Created) (JIRA)
PostAddToViewEvent should be propagated to UIViewRoot - Key: MYFACES-3379 URL: https://issues.apache.org/jira/browse/MYFACES-3379 Project: MyFaces Core Issue Type: Bug

[jira] [Resolved] (MYFACES-3379) PostAddToViewEvent should be propagated to UIViewRoot

2011-10-27 Thread Leonardo Uribe (Resolved) (JIRA)
[ https://issues.apache.org/jira/browse/MYFACES-3379?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Leonardo Uribe resolved MYFACES-3379. - Resolution: Fixed Fix Version/s: 2.1.4 2.0.10

[jira] [Reopened] (MYFACES-3377) unsynchronized lazy initialization could create concurrency errors

2011-10-27 Thread Leonardo Uribe (Reopened) (JIRA)
[ https://issues.apache.org/jira/browse/MYFACES-3377?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Leonardo Uribe reopened MYFACES-3377: - The change should be applied only to AbstractThreadSafeAttributeMap. For the other cases,

[jira] [Resolved] (MYFACES-3377) unsynchronized lazy initialization could create concurrency errors

2011-10-27 Thread Leonardo Uribe (Resolved) (JIRA)
[ https://issues.apache.org/jira/browse/MYFACES-3377?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Leonardo Uribe resolved MYFACES-3377. - Resolution: Fixed Fix Version/s: 2.0.10 unsynchronized lazy initialization

[jira] [Resolved] (MYFACES-3378) UIComponent.setParent does not propagate setInView() call when processingEvents is false

2011-10-27 Thread Leonardo Uribe (Resolved) (JIRA)
[ https://issues.apache.org/jira/browse/MYFACES-3378?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Leonardo Uribe resolved MYFACES-3378. - Resolution: Fixed Fix Version/s: 2.1.4 2.0.10

[jira] [Resolved] (MYFACES-3374) Compatibility with Servlet API 2.4

2011-10-27 Thread Leonardo Uribe (Resolved) (JIRA)
[ https://issues.apache.org/jira/browse/MYFACES-3374?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Leonardo Uribe resolved MYFACES-3374. - Resolution: Fixed Fix Version/s: 2.1.4 2.0.10 Removing usage

[jira] [Commented] (MYFACES-3358) Flash created in ExceptionHandler not work

2011-10-27 Thread Leonardo Uribe (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/MYFACES-3358?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13137429#comment-13137429 ] Leonardo Uribe commented on MYFACES-3358: - Spec issue created for reference:

[jira] [Commented] (MYFACES-3368) enable 'standard' checkstyle checks in myfaces-core

2011-10-27 Thread Mark Struberg (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/MYFACES-3368?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13137507#comment-13137507 ] Mark Struberg commented on MYFACES-3368: Leo, can you please check the following

[DISCUSS] internal incubator

2011-10-27 Thread Gerhard Petracek
hi @ all, this is a new thread based on [1]. the idea of an internal incubator: esp. gsoc projects (for myfaces) could move pretty easy to myfaces. as soon as we see that there is a community for it, we can promote such a project (as an own sub-project or as a module of an existing

Re: [DISCUSS] internal incubator

2011-10-27 Thread Mark Struberg
+1 LieGrue, strub From: Gerhard Petracek gerhard.petra...@gmail.com To: MyFaces Development dev@myfaces.apache.org Sent: Thursday, October 27, 2011 11:18 PM Subject: [DISCUSS] internal incubator hi @ all, this is a new thread based on [1]. the idea of

[jira] [Reopened] (MFCOMMONS-33) Extended ResourceHandler implementation

2011-10-27 Thread Mark Struberg (Reopened) (JIRA)
[ https://issues.apache.org/jira/browse/MFCOMMONS-33?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mark Struberg reopened MFCOMMONS-33: Assignee: Mark Struberg (was: Leonardo Uribe) We shall drop GZIP handler since this

[DISCUSS] why do we overcomplicate our code soooo much?

2011-10-27 Thread Mark Struberg
  Hi folks! I'm just comparing the original proposal of the resource handler from Jakob (which works fine) http://code.google.com/a/apache-extras.org/p/relative-resource-handler/source/checkout and what we do have now in myfaces-commons-resource-handler

[jira] [Commented] (MFCOMMONS-33) Extended ResourceHandler implementation

2011-10-27 Thread Mark Struberg (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/MFCOMMONS-33?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13137670#comment-13137670 ] Mark Struberg commented on MFCOMMONS-33: Just to clarify that before any

Re: [DISCUSS] internal incubator

2011-10-27 Thread Matt Benson
Guys, Just a note on the concept of a mini-incubator: been there, done that [1]. The basic available approaches are noted at [2] (search for Some possible solutions). Matt [1] http://markmail.org/message/n3t7lksceuplh45r [2] http://markmail.org/message/r6ffmmyh6pxnn6nd On Thu, Oct 27, 2011

Re: [DISCUSS] why do we overcomplicate our code soooo much?

2011-10-27 Thread Leonardo Uribe
Hi I think you have the wrong impression, basically because you haven't tried to solve each one of the problems that the code try to solve. Is like the blind that try to see the elephant and say that is like a tree, because it touching its leg. To keep things simple, I'll describe and explain

[jira] [Commented] (MFCOMMONS-33) Extended ResourceHandler implementation

2011-10-27 Thread Leonardo Uribe (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/MFCOMMONS-33?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13137826#comment-13137826 ] Leonardo Uribe commented on MFCOMMONS-33: - Really EL expressions are only

[jira] [Commented] (MYFACES-3259) Custom Validator tag attributes are not configured when used with default tag handler in wrapping mode

2011-10-27 Thread Leonardo Uribe (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/MYFACES-3259?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13138034#comment-13138034 ] Leonardo Uribe commented on MYFACES-3259: - I checked again the solution proposed

[jira] [Commented] (MYFACES-3368) enable 'standard' checkstyle checks in myfaces-core

2011-10-27 Thread Leonardo Uribe (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/MYFACES-3368?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13138042#comment-13138042 ] Leonardo Uribe commented on MYFACES-3368: - Ok, no problem, but give me some

[jira] [Commented] (MYFACES-3259) Custom Validator tag attributes are not configured when used with default tag handler in wrapping mode

2011-10-27 Thread Matt Benson (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/MYFACES-3259?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13138046#comment-13138046 ] Matt Benson commented on MYFACES-3259: -- Thanks for all the attention to this, Leo!