an outstanding job, and welcome to
the club.
Btw. I am just a bystander to this issue, how much improvement did you get
by all this measures, do you have any performance or size numbers?
Werner
Am 18.08.10 15:55, schrieb Marius Petoi:
Hello,
The improvements I made in the GSoC project
Hello,
The improvements I made in the GSoC project regarding state saving are:
- add the size of the saved state for each of the components in the debug
page.
- remove the VISITED_FACET_COUNT ATTRIBUTE attribute used by UIDebug from
the component attributes map
- remove ATTACHED_OBJECT_HANDLERS
[
https://issues.apache.org/jira/browse/MYFACES-2774?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12898860#action_12898860
]
Marius Petoi commented on MYFACES-2774:
---
Hi Leonardo,
The test you are talking
Reporter: Marius Petoi
Priority: Minor
The saved state of UIInput needs to be cleaned. The default values should not
be saved.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[
https://issues.apache.org/jira/browse/MYFACES-2850?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Marius Petoi updated MYFACES-2850:
--
Status: Patch Available (was: Open)
Clean saved state of UIInput
Hello,
Apparently there have been some naming conventions that have not been
respected in defining the aliases in the Casablanca skin. I was wondering
whether there is anyone that extended this skin. I'm trying to determine the
impact that changing the names to the appropriate ones would have.
[
https://issues.apache.org/jira/browse/TRINIDAD-1860?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12891495#action_12891495
]
Marius Petoi commented on TRINIDAD-1860:
Hi Jeanne,
I've noticed now
a look - for you to continue: just
post the partial state values for typical pages right now (you can
also take the pages of the sample as a base if you want).
best regards,
Martin
On Wed, Jul 21, 2010 at 3:23 PM, Marius Petoi
marius.pe...@codebeat.ro
wrote:
Hello,
As I
, Marius Petoi marius.pe...@codebeat.ro
wrote:
Hello,
As I see, in JspStateManagerImpl.saveSerializedView (actually in the
isWritingState() method), there is a check whether the
JSP_IS_WRITING_STATE_ATTR is set in the FacesContext. But this attribute
is
set
[
https://issues.apache.org/jira/browse/TRINIDAD-1860?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Marius Petoi updated TRINIDAD-1860:
---
Status: Patch Available (was: Open)
Rename wrong style names in casablanca skin
it will slightly help
performance. If you think people have extended the skin, then you will break
them if you change it. That's the issue.
Jeanne
Marius Petoi wrote, On 7/21/2010 1:44 AM PT:
Hi Jeanne,
My colleague that created the Casablanca skin didn't know about the icon
and style naming
Affects Versions: 2.0.0-alpha-2
Reporter: Marius Petoi
Priority: Trivial
Some style names in casablanca skin are not properly named. Style names should
not end in Icon.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment
Hi Jeanne,
My colleague that created the Casablanca skin didn't know about the icon and
style naming convention. Should I change the names of the selectors? Or
should I wait until you decide whether you create a new @icon rule.
Regards,
Marius
On Wed, Jul 21, 2010 at 4:52 AM, Jeanne Waldman
by doing this, the xhtml pages don't work anymore...only the
jsp-s. There is no state saved in xhtml-s. Am I missing something?
Regards,
Marius
best regards,
Martin
On Tue, Jul 20, 2010 at 2:46 PM, Marius Petoi marius.pe...@codebeat.ro
wrote:
Hi Leonardo,
So you are working on UIData
?
Oh my. That´s a bug then. Leonardo, can you look into this (not that I
desperately need full state saving, but some users might need it)?
best regards,
Martin
On Tue, Jul 20, 2010 at 2:46 PM, Marius Petoi marius.pe...@codebeat.ro
wrote:
Hi Leonardo,
So you are working
Hi Martin,
On Wed, Jul 21, 2010 at 10:58 AM, Martin Marinschek
mmarinsc...@apache.orgwrote:
Hi guys,
I didn´t follow this in absolute detail anymore right now, but:
I do not think we should think about serializing MethodExpressions or
ValueExpressions - IMHO, MethodExpressions or
in that issue soon, so we can review it and make comments.
regards,
Leonardo Uribe
2010/7/19 Marius Petoi marius.pe...@codebeat.ro
Hi Martin,
Regarding state saving in tables, here are my observations and comments:
- there is no state saved in relation to the UIData objects.
- the states saved
for Mojarra, cause the RI team
will not be able to get this done.
best regards,
Martin
On 7/14/10, Marius Petoi marius.pe...@codebeat.ro wrote:
I placed a breakpoint in
DefaultFaceletsManagementStrategy.saveStateOnMap,
in the point where saveState is called for each component. That is the
point
Components: General
Affects Versions: 2.0.0
Reporter: Marius Petoi
Priority: Minor
UILeaf components are stateless. They have no children and no facets.
Therefore, the invokeOnComponent and visitTree methods should not go through
all the children and facets
[
https://issues.apache.org/jira/browse/MYFACES-2824?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Marius Petoi updated MYFACES-2824:
--
Status: Patch Available (was: Open)
Improve invokeOnComponent and visitTree methods
[
https://issues.apache.org/jira/browse/MYFACES-2774?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12888742#action_12888742
]
Marius Petoi commented on MYFACES-2774:
---
Hi Leonardo,
Stack inherits Vector, so
[
https://issues.apache.org/jira/browse/MYFACES-2774?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12888743#action_12888743
]
Marius Petoi commented on MYFACES-2774:
---
As a matter of fact, looking over
Hi Leonardo,
On Thu, Jul 15, 2010 at 8:38 AM, Leonardo Uribe lu4...@gmail.com wrote:
Hi Marius
2010/7/13 Marius Petoi marius.pe...@codebeat.ro
Hi Leonardo,
I corrected the things you required in the JIRA issues. When you have the
time, please have a look over them. See inline my comments
Hello,
After the improvements we discussed in previous threads, here is what the
state looks like for some of the components:
- the org.apache.myfaces.view.facelets.MARK_ID
(ComponentSupport.MARK_CREATED) attribute is present in almost all the
components, but that is put in the attributes map
about this - did you really check what
is in the partial state at the end of the lifecycle?
best regards,
Martin
On 7/14/10, Marius Petoi marius.pe...@codebeat.ro wrote:
Hello,
After the improvements we discussed in previous threads, here is what the
state looks like for some
Hi Leonardo,
I corrected the things you required in the JIRA issues. When you have the
time, please have a look over them. See inline my comments and questions:
On Sun, Jul 11, 2010 at 3:57 AM, Leonardo Uribe lu4...@gmail.com wrote:
Hi
Sorry for the late response, but I was looking other
Project: MyFaces Core
Issue Type: Improvement
Components: General
Affects Versions: 2.0.0
Reporter: Marius Petoi
Priority: Minor
Another state saving improvement is to remove the attached object handlers from
the component attributes map
Hello,
I created a JIRA ticket with a patch that removes the
CompositeComponentResourceTagH
andler.ATTACHED_OBJECT_HADLERS_KEY from the component attributes map.
Instead it creates a map with the attached object handlers indexed by the
component reference. The JIRA ticket is:
[
https://issues.apache.org/jira/browse/MYFACES-2802?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Marius Petoi updated MYFACES-2802:
--
Status: Patch Available (was: Open)
Remove
Hello,
So, I am not sure what you mean by map with the Reference of the component
as the key...is it a map in which the keys are java.lang.ref.Reference
objects? And if so, what kind of references should I use?
On the other hand, regarding serialization vs implements PartialStateHolder,
I've
Hi Leonardo,
Thank you again for your response!
On Mon, Jun 28, 2010 at 11:15 PM, Leonardo Uribe lu4...@gmail.com wrote:
Hi Marius
2010/6/28 Marius Petoi marius.pe...@codebeat.ro
Hello,
After looking more to the attributes of the components, here's what I've
found regarding state saving
Components: General
Affects Versions: 2.0.0
Reporter: Marius Petoi
Priority: Minor
In order to reduce the saved state, the ErrorPageWriter.VISITED_FACET_COUNT
should not be included in the component attributes map, as this is only an
intermediate parameter used
[
https://issues.apache.org/jira/browse/MYFACES-2777?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Marius Petoi updated MYFACES-2777:
--
Status: Patch Available (was: Open)
Remove VISITED_FACET_COUNT from component attributes
: General
Affects Versions: 2.0.0
Reporter: Marius Petoi
Priority: Minor
The ComponentSupport.MARK_DELETED attribute is used only inside one request. It
doesn't need to be saved in the state. It should be removed from the attributes
of the component. Instead a list
:12 PM, Marius Petoi marius.pe...@codebeat.rowrote:
Hello,
Thank you for the explanations! So, as I see here, it is ok to remove the
org.apache.myfaces.view.facelets.MARK_DELETED attribute from the partial
state and include it in the FaceletContext (as a list of components that are
marked
[
https://issues.apache.org/jira/browse/MYFACES-2774?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Marius Petoi updated MYFACES-2774:
--
Status: Patch Available (was: Open)
Remove MARK_DELETED attribute from the component
in the
CompositeComponentBeanInfo are ArrayList-s. But as they are included in the
saved state, my suggestion would be to make them _DeltaList-s.
Please tell me if my suggestions are correct. Thank you!
Regards,
Marius
On Mon, Jun 28, 2010 at 11:27 AM, Marius Petoi marius.pe...@codebeat.rowrote:
Hello,
I created
,
Martin
2010/6/24 Marius Petoi marius.pe...@codebeat.ro
Hello,
As you said, Martin, the attribute
org.apache.myfaces.view.facelets.APPLIED is included in the partial
state.
This, as well as all the other attributes of the components, as the
attributeMap in the UIComponentBase
2010/6/18 Marius Petoi marius.pe...@codebeat.ro
Hello,
In order to study the current performance of state saving, I designed a
small page that I included in the examples for MyFaces 2.0. Also, I
wrote
2
phase listeners that determine the length of the state saved in the
ExternalContext
Components: General
Affects Versions: 2.0.0
Reporter: Marius Petoi
Priority: Minor
Include in the ui:debug information about the saved state.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[
https://issues.apache.org/jira/browse/MYFACES-2770?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Marius Petoi updated MYFACES-2770:
--
Status: Patch Available (was: Open)
Improve ui:debug with information about the saved
Hello,
I created a JIRA ticket and attached a patch (
https://issues.apache.org/jira/browse/MYFACES-2770) that introduces some
information about the saved state in the debug page. The information
consists of the length of the state saved in the page, as well as the number
of bytes for each
the component size in the information per component
or centrally? I think it would be handy to have this with the
component detail information.
best regards,
Martin
On 6/23/10, Marius Petoi marius.pe...@codebeat.ro wrote:
Hello,
I created a JIRA ticket and attached a patch (
https
Hello,
I did the modifications and attached the patch to the JIRA ticket.
Regards,
Marius
On Wed, Jun 23, 2010 at 2:53 PM, Martin Marinschek
mmarinsc...@apache.orgwrote:
Hi Marius,
perfect. I think that is a good idea.
best regards,
Martin
On 6/23/10, Marius Petoi marius.pe
Hello,
In order to study the current performance of state saving, I designed a
small page that I included in the examples for MyFaces 2.0. Also, I wrote 2
phase listeners that determine the length of the state saved in the
ExternalContext before the render response phase and before the restore
[
https://issues.apache.org/jira/browse/TRINIDAD-1745?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Marius Petoi updated TRINIDAD-1745:
---
Status: Patch Available (was: Open)
Introduce @mode in CSS files
Hello,
In the XSS files there are some styles which are mode-dependent, such as:
styleSheet platforms=windows ppc browsers=ie versions=6
mode=quirks
//.
These are styles defined only for quirks mode.
In CSS this feature is not implemented and it is needed in order to port the
old XSS
-rule-ref:property(af|foo, color);
Marius Petoi wrote, On 4/2/2010 12:28 AM PT:
Hello,
Maybe you followed the discussions on this topic from
http://markmail.org/search/?q=skinning#query:skinning%20order%3Adate-backward+page:1+mid:4nt2ykmdnnmcyvp4+state:results
We need to decide between two
.
One little correction to your proposal: first measurements didn't show
a 20% improvement, but a reduction to 20% of the original state - so
an improvement by a factor of 5.
best regards,
Martin
On 4/6/10, Marius Petoi marius.pe...@codebeat.ro wrote:
Hello,
I would be interested
Hello,
I would be interested in applying for the GSOC project
https://issues.apache.org/jira/browse/MYFACES-2634 regarding state saving
performance improvements in MyFaces 2.0. I have already written a proposal
and updated it on the MyFaces wiki:
Hello,
Maybe you followed the discussions on this topic from
http://markmail.org/search/?q=skinning#query:skinning%20order%3Adate-backward+page:1+mid:4nt2ykmdnnmcyvp4+state:results
We need to decide between two alternatives for the syntax of the
-tr-include-property. The two alternatives are:
[
https://issues.apache.org/jira/browse/TRINIDAD-1680?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12852746#action_12852746
]
Marius Petoi commented on TRINIDAD-1680:
Hi Jeanne,
I have sent an email
: 1.2.13-core
Reporter: Marius Petoi
Priority: Minor
In order to transform the old XSS files in CSS files, @mode should be supported
in CSS
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[
https://issues.apache.org/jira/browse/TRINIDAD-1680?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12840070#action_12840070
]
Marius Petoi commented on TRINIDAD-1680:
Hi Jeanne,
I reformatted the code
that. We haven't had a need for this in
our css files that's we've created, but to port this stuff over it sounds
like we need it, or else we do not support it anymore.
Jeanne
Marius Petoi wrote, On 2/18/2010 11:21 PM PT:
For example the definition of the following style sheet:
styleSheet
[
https://issues.apache.org/jira/browse/TRINIDAD-1680?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12840079#action_12840079
]
Marius Petoi commented on TRINIDAD-1680:
Hi Jeanne,
I reformatted the code
[
https://issues.apache.org/jira/browse/TRINIDAD-1680?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12840081#action_12840081
]
Marius Petoi commented on TRINIDAD-1680:
Hi Jeanne,
I reformatted the code
Versions: 2.0.0-alpha
Reporter: Marius Petoi
Priority: Trivial
Attachments: licenceHeader.patch
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[
https://issues.apache.org/jira/browse/TRINIDAD-1742?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Marius Petoi updated TRINIDAD-1742:
---
Status: Patch Available (was: Open)
Add licence header in xhtml files in Trinidad
jeanne.wald...@oracle.comwrote:
What do you mean by 'mode' dependent?
Marius Petoi wrote, On 2/3/2010 11:17 PM PT:
Ok Jeanne. Thank you!
One more question, in order to transform the XSS files in CSS files, in
base-desktop.xss there are some styles which are mode-dependent. Should we
add @mode
Hello,
I am trying to run the new demo with Trinidad 2.0. Unfortunately, nothing
gets rendered. In web.xml, I use the following configuration for facelets:
!-- Facelets configuration, comment to use JSP --
context-param
param-namejavax.faces.FACELETS_VIEW_MAPPINGS/param-name
I'm talking about the 2.0 version of Trinidad...
On Fri, Feb 12, 2010 at 4:30 PM, Matthias Wessendorf mat...@apache.orgwrote:
the trinidad-demo works
= cd to_the_dir;
mvn jetty:run -PjettyConfig
On Fri, Feb 12, 2010 at 3:27 PM, Marius Petoi marius.pe...@codebeat.ro
wrote:
Hello,
I
.
Jeanne
Jeanne Waldman wrote, On 1/21/2010 11:51 AM PT:
Ok. Our performance team has noticed the Skinning Framework is using more
memory than not that long ago, so I want to look into that before we add
anymore patches.
Jeanne
Marius Petoi wrote, On 1/19/2010 1:23 AM PT:
Hi Jeanne,
The new
[
https://issues.apache.org/jira/browse/TRINIDAD-1689?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12803203#action_12803203
]
Marius Petoi commented on TRINIDAD-1689:
I added a new patch with a small
Hi Jeanne,
The new patch is ready.
Marius
On Tue, Jan 19, 2010 at 8:58 AM, Marius Petoi marius.pe...@codebeat.rowrote:
Ok. Then I shall adapt dealing with the aliases and I shall inform you when
the new patch is ready.
Marius
On Mon, Jan 18, 2010 at 11:16 PM, Jeanne Waldman
if people wanted to vote on it.
Marius Petoi wrote, On 1/15/2010 12:05 AM PT:
Yes, 'name' is an alias...I introduced it because I saw it was done this
way in the XSS. I will remove it. Are you saying I should change the syntax?
I personally think it is clearer this way.
Marius
On Fri, Jan 15
.I can see them not knowing is color what I'm
setting or is color what I'm retrieving? That is what I think the con is for
the CSS syntax like *padding: 0px 2px 3px 4px*
Regarding your link, I haven't had time to look at that yet.
Jeanne
Marius Petoi wrote, On 1/12/2010 11:46 PM PT:
Hi
at it closer before I vote.
Jeanne
Marius Petoi wrote, On 1/11/2010 4:52 AM PT:
Is there anyone who has already reviewed this or added them on his/her TODO
list? Thank you in advance!
Marius
On Fri, Jan 8, 2010 at 11:35 AM, Marius Petoi marius.pe...@codebeat.rowrote:
Hello,
I created a new
Is there anyone who has already reviewed this or added them on his/her TODO
list? Thank you in advance!
Marius
On Fri, Jan 8, 2010 at 11:35 AM, Marius Petoi marius.pe...@codebeat.rowrote:
Hello,
I created a new JIRA task for this issue (
https://issues.apache.org/jira/browse/TRINIDAD-1680
Reporter: Marius Petoi
Priority: Minor
The include-property feature is present in the XSS, but it is not supported in
the CSS. With this, we are one step closer to eliminating the old XSS files and
replacing them with CSS. In the XSS files, the syntax of includeProperty
[
https://issues.apache.org/jira/browse/TRINIDAD-1680?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Marius Petoi updated TRINIDAD-1680:
---
Status: Patch Available (was: Open)
Introduce include-property in CSS
Hello,
I created a new JIRA task for this issue (
https://issues.apache.org/jira/browse/TRINIDAD-1680) and I added a patch for
it.
I introduced a new -tr property: -tr-include-property. The syntax of this
is:
-tr-include-property: property(selector=af|foo,propertyName=color,
[
https://issues.apache.org/jira/browse/TRINIDAD-1415?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Marius Petoi updated TRINIDAD-1415:
---
Status: Patch Available (was: Open)
allow :alias support to merge in -tr- custom skin
[
https://issues.apache.org/jira/browse/TRINIDAD-1415?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12797031#action_12797031
]
Marius Petoi commented on TRINIDAD-1415:
Hello,
I added a patch to the task
Hello,
This is regarding the JIRA task
https://issues.apache.org/jira/browse/TRINIDAD-1415. I added a patch that
hopefully solves this issue.
In SkinStyleSheetParserUtils._createStyleSheetEntry(), when the parsing of
each selector is done, for each selector that is an alias (ends in :alias)
I
Ok, what should the syntax of the includeProperty in the CSS be?
Marius
On Mon, Dec 14, 2009 at 7:27 PM, Jeanne Waldman
jeanne.wald...@oracle.comwrote:
Marius Petoi wrote, On 12/11/2009 1:14 AM PT:
Hello,
This is related to the JIRA issue
https://issues.apache.org/jira/browse/TRINIDAD
Hello,
This is related to the JIRA issue
https://issues.apache.org/jira/browse/TRINIDAD-1043, regarding the
replacement of legacy XSS files with CSS files in the Tinidad skinning
module. I have a couple of questions.
First of all, @import should be supported in CSS. What should the syntax of
Hello,
I have added a patch that implements the support for skin selectors
depending on the locale (https://issues.apache.org/jira/browse/TRINIDAD-1041).
This is done in the CSS using @locale rules. The syntax of the @locale rules
is similar to the syntax of the @agent and @platform rules:
[
https://issues.apache.org/jira/browse/TRINIDAD-1041?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Marius Petoi updated TRINIDAD-1041:
---
Status: Patch Available (was: Open)
Support locale-specific styles
: Marius Petoi
A proposal for a new module that detects the agent in myFaces Commons. This
module is based on the already existing functionality from Trinidad
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
the same stuff
twice or more.
Regards,
Udo
Marius Petoi schrieb:
Hi everybody,
I would like to propose the creation of a new module in
MyFaces Commons, that will handle agent detection, a feature
which I hope you will consider, as such a module would
. We
were not so much agreeing and there was still the portlet issue to resolve.
It's an important issue, and would be a great addition, reviving the thread
could be a good idea.
Regards,
~ Simon
On Tue, Sep 22, 2009 at 9:47 AM, Marius Petoi marius.pe...@codebeat.rowrote:
Hello everybody
I managed to check out the code eventually. Sorry about the last mail.
Marius
On Wed, Sep 23, 2009 at 10:42 AM, Marius Petoi marius.pe...@codebeat.rowrote:
Hello,
Ok..so what I understand is that some work has been done in this
direction...I see that there is a project page (
http
Hello everybody,
You started discussing about making an independent module for skinning,
starting from the skinning in Trinidad (
http://markmail.org/thread/qlmp2w7j6clccd5r). I have some time allocated to
work on this subject...and I would like to know what the status of the
project is.
Hi everybody,
I would like to propose the creation of a new module in MyFaces Commons,
that will handle agent detection, a feature which I hope you will consider,
as such a module would be useful to any component set out there (or at least
to the ones in MyFaces).
My work is based on what
85 matches
Mail list logo
