Re: [TRINIDAD] New element in trinidad-skins.xml /SkinImpl/SkinAddition

2007-09-24 Thread Simon Lessard
EL implies a small performance overhead but I guess it's acceptable for the gain here. On 9/21/07, Adam Winer [EMAIL PROTECTED] wrote: -1 to trying to turn everything into ResourceBundle. Just use EL - ELResolver in 1.2, PropertyResolver in 1.1. As of 1.2, that gives you ResourceBundle and

Re: [TRINIDAD] New element in trinidad-skins.xml /SkinImpl/SkinAddition

2007-09-24 Thread Jeanne Waldman
I need help understanding how you are expecting I use the MapELResolver/ResourceBundleELResolver, Adam. First, let me explain what I was doing. I was creating a ValueExpression when I parsed the trinidad-skins.xml and found a value in translation-source. // could be Map or ResourceBundle, so

Re: [TRINIDAD] New element in trinidad-skins.xml /SkinImpl/SkinAddition

2007-09-24 Thread Adam Winer
1. Evaluate the base ValueExpression (without looking at the string or anything like that). Call this object base. Call the property propertyName. 2. Get the ELResolver from Application and the ELContext from FacesContext 3. Call elResolver.getValue(elContext, base, propertyName); You don't

Re: [TRINIDAD] New element in trinidad-skins.xml /SkinImpl/SkinAddition

2007-09-24 Thread Jeanne Waldman
Ahh, now I see. And now this part of the Java EE 5 Tutorial makes sense: "All of the standard and custom resolvers available to a particular application are collected in a chain in a particular order. This chain of resolvers is represented by a CompositeELResolver instance. When an

[TRINIDAD] New element in trinidad-skins.xml /SkinImpl/SkinAddition

2007-09-21 Thread Jeanne Waldman
Hi, I have a new issue I need to resolve and I wanted to run by my solution -- https://issues.apache.org/jira/browse/TRINIDAD-728 "support for el to be used in a skin to bind to other translation data sources" Currently, a SkinExtension and SkinAddition can have resource bundles associated

Re: [TRINIDAD] New element in trinidad-skins.xml /SkinImpl/SkinAddition

2007-09-21 Thread Simon Lessard
Hello Jeanne, I could live with that as long as the XSD should prevents the usage of both a bundle and a map at the same time. However, I would prefer a resource-bundle element than a translation-map. For one, it's much easier to create a ResourceBundle from a Map than the other way around. Also,

Re: [TRINIDAD] New element in trinidad-skins.xml /SkinImpl/SkinAddition

2007-09-21 Thread Jeanne Waldman
I should mention that the customer wants to bind to an XLIFF file which will get automatically converted to a Map in Jdeveloper, and maybe other IDEs. I don't know. I still need to test out this automatic conversion. So they get a Map for free. Simon Lessard wrote: Hello Jeanne, I could

Re: [TRINIDAD] New element in trinidad-skins.xml /SkinImpl/SkinAddition

2007-09-21 Thread Blake Sullivan
Simon Lessard wrote: Hello Jeanne, I could live with that as long as the XSD should prevents the usage of both a bundle and a map at the same time. I agree However, I would prefer a resource-bundle element than a translation-map. For one, it's much easier to create a ResourceBundle from a

Re: [TRINIDAD] New element in trinidad-skins.xml /SkinImpl/SkinAddition

2007-09-21 Thread Adam Winer
On 9/21/07, Simon Lessard [EMAIL PROTECTED] wrote: Hello Jeanne, I could live with that as long as the XSD should prevents the usage of both a bundle and a map at the same time. However, I would prefer a resource-bundle element than a translation-map. For one, it's much easier to create a

Re: [TRINIDAD] New element in trinidad-skins.xml /SkinImpl/SkinAddition

2007-09-21 Thread Jeanne Waldman
Adam Winer wrote: On 9/21/07, Simon Lessard [EMAIL PROTECTED] wrote: Hello Jeanne, I could live with that as long as the XSD should prevents the usage of both a bundle and a map at the same time. However, I would prefer a "resource-bundle" element than a "translation-map". For

Re: [TRINIDAD] New element in trinidad-skins.xml /SkinImpl/SkinAddition

2007-09-21 Thread Adam Winer
On 9/21/07, Jeanne Waldman [EMAIL PROTECTED] wrote: Adam Winer wrote: On 9/21/07, Simon Lessard [EMAIL PROTECTED] wrote: Hello Jeanne, I could live with that as long as the XSD should prevents the usage of both a bundle and a map at the same time. However, I would prefer a

Re: [TRINIDAD] New element in trinidad-skins.xml /SkinImpl/SkinAddition

2007-09-21 Thread Simon Lessard
On 9/21/07, Blake Sullivan [EMAIL PROTECTED] wrote: Simon Lessard wrote: Hello Jeanne, I could live with that as long as the XSD should prevents the usage of both a bundle and a map at the same time. I agree However, I would prefer a resource-bundle element than a translation-map.

Re: [TRINIDAD] New element in trinidad-skins.xml /SkinImpl/SkinAddition

2007-09-21 Thread Jeanne Waldman
I'll go with translation-source. Thanks! Jeanne Adam Winer wrote: On 9/21/07, Jeanne Waldman [EMAIL PROTECTED] wrote: Adam Winer wrote: On 9/21/07, Simon Lessard [EMAIL PROTECTED] wrote: Hello Jeanne, I could live with that as long as the XSD should prevents the usage of

Re: [TRINIDAD] New element in trinidad-skins.xml /SkinImpl/SkinAddition

2007-09-21 Thread Gary VanMatre
From: Simon Lessard [EMAIL PROTECTED] If we accept only a map, it's quite exclusive, unless we add yet another tag, but I would be -1 on that. However, as Adam suggested, we could call it translation-source and support both Map and ResourceBundle instances. We have to a very thin adapter

Re: [TRINIDAD] New element in trinidad-skins.xml /SkinImpl/SkinAddition

2007-09-21 Thread Adam Winer
-1 to trying to turn everything into ResourceBundle. Just use EL - ELResolver in 1.2, PropertyResolver in 1.1. As of 1.2, that gives you ResourceBundle and Map support. In 1.1, only Map (and bean, of course), but then again in 1.1 how do you get unwrapped ResourceBundle instances into EL