Re: Proposal to stop using SVN Keywords - (was: MyFaces shipping with JBoss AS6?)

2010-08-11 Thread Matthias Wessendorf
On Tue, Aug 10, 2010 at 11:55 PM, Bernd Bohmann bernd.bohm...@atanion.com wrote: Hello, why we need the @author tag? I don't like code owner ship. well, some do. I am fine without. In fact a lot of Apache project do so, since there is no code-ownership. SVN has still all the information

Re: Proposal to stop using SVN Keywords - (was: MyFaces shipping with JBoss AS6?)

2010-08-11 Thread Jan-Kees van Andel
Hey, I'm not a big fan of code ownership either, but the proposal was just to remove the redundant stuff. If there is a consensus about removing the @author tag too, that's fine with me. Removing all this stuff at once is easier than having multiple runs where we remove one thing at a time.

Re: Proposal to stop using SVN Keywords - (was: MyFaces shipping with JBoss AS6?)

2010-08-11 Thread Michael Kurz
I would also get rid of the author tags too. I guess that in many cases they are not correct anyway as files are constantly changed. Michael Am 11.08.2010 08:22, schrieb Matthias Wessendorf: On Tue, Aug 10, 2010 at 11:55 PM, Bernd Bohmann bernd.bohm...@atanion.com wrote: Hello, why we need

Re: Proposal to stop using SVN Keywords - (was: MyFaces shipping with JBoss AS6?)

2010-08-11 Thread Matthias Wessendorf
On Wed, Aug 11, 2010 at 8:38 AM, Jan-Kees van Andel jankeesvanan...@gmail.com wrote: Hey, I'm not a big fan of code ownership either, but the proposal was just to remove the redundant stuff. If there is a consensus about removing the @author tag too, that's fine with me. Removing all this

Re: Proposal to stop using SVN Keywords - (was: MyFaces shipping with JBoss AS6?)

2010-08-11 Thread Matthias Wessendorf
On Wed, Aug 11, 2010 at 8:40 AM, Michael Kurz michi.k...@gmx.at wrote: I would also get rid of the author tags too. I guess that in many cases they are not correct anyway as files are constantly changed. exactly, and still svn (blame) knows everything... Original committer and who introduced

Re: Proposal to stop using SVN Keywords - (was: MyFaces shipping with JBoss AS6?)

2010-08-11 Thread Ganesh
I'd like to keep the @author tags. Isn't the spirit of the meritocracy involved with making authors visible? Shouldn't personal merit for a project be made visible in the code? I think it's great to see Manfred Geiler as the orginal author of most MyFaces parts. Many people download the source

Re: Proposal to stop using SVN Keywords - (was: MyFaces shipping with JBoss AS6?)

2010-08-11 Thread Matthias Wessendorf
On Wed, Aug 11, 2010 at 9:21 AM, Ganesh gan...@j4fry.org wrote: I'd like to keep the @author tags. Isn't the spirit of the meritocracy involved with making authors visible? Actually not... There are a ton of discussions on this in the archives. Fact: there is no code ownership... Shouldn't

Re: Proposal to stop using SVN Keywords - (was: MyFaces shipping with JBoss AS6?)

2010-08-11 Thread Matthias Wessendorf
On Wed, Aug 11, 2010 at 9:31 AM, Matthias Wessendorf mat...@apache.org wrote: On Wed, Aug 11, 2010 at 9:21 AM, Ganesh gan...@j4fry.org wrote: I'd like to keep the @author tags. Isn't the spirit of the meritocracy involved with making authors visible? Actually not... There are a ton of

Re: Proposal to stop using SVN Keywords - (was: MyFaces shipping with JBoss AS6?)

2010-08-11 Thread Jakob Korherr
Hi guys, +1 on removing all this stuff. Frankly I always added or changed the headers to include author and version information, but only because I read it in the MyFaces developer notes [1] and the referenced Struts svn guide [2] in the wiki. @Jan-Kees: I don't really understand what you mean

Re: Proposal to stop using SVN Keywords - (was: MyFaces shipping with JBoss AS6?)

2010-08-11 Thread Matthias Wessendorf
On Wed, Aug 11, 2010 at 10:43 AM, Jakob Korherr jakob.korh...@gmail.com wrote: Hi guys, +1 on removing all this stuff. Frankly I always added or changed the headers to include author and version information, but only because I read it in the MyFaces developer notes [1] and the referenced

Re: Proposal to stop using SVN Keywords - (was: MyFaces shipping with JBoss AS6?)

2010-08-11 Thread Ganesh
there are other social issues dealing with collaborative development, but the Board is concerned about the legal ramifications around the use of author tags OK, I see the point.

Re: Proposal to stop using SVN Keywords - (was: MyFaces shipping with JBoss AS6?)

2010-08-10 Thread Werner Punz
+1 of removing this, the info is in svn anyway, why duplicate it? Werner Am 09.08.10 21:43, schrieb Jan-Kees van Andel: Hi, What do you guys think about pruning the SVN keywords in the source files? Matthias pointed out a nice example of an issue you run into with this stuff. 1 Not

Re: Proposal to stop using SVN Keywords - (was: MyFaces shipping with JBoss AS6?)

2010-08-10 Thread Jan-Kees van Andel
Hi, The issue has been filed: https://issues.apache.org/jira/browse/MYFACES-2871 About the guidelines Michael referred to: - I suggest to completely get rid of all SVN related stuff. - I think it's ok to keep the @author tags. - Also the @since tags seem useful to me. In other words, drop all

Re: Proposal to stop using SVN Keywords - (was: MyFaces shipping with JBoss AS6?)

2010-08-10 Thread Leonardo Uribe
Hi Could you provide an explicit example about how the header of java files should be? best regards, Leonardo

Re: Proposal to stop using SVN Keywords - (was: MyFaces shipping with JBoss AS6?)

2010-08-10 Thread Jan-Kees van Andel
Hi, Sure. For example, take a look at: http://svn.apache.org/repos/asf/myfaces/core/trunk/api/src/main/java/javax/faces/FacesException.java If we remove the SVN stuff, we'll end up with this JavaDoc comment: /** * see Javadoc of a href=

Re: Proposal to stop using SVN Keywords - (was: MyFaces shipping with JBoss AS6?)

2010-08-10 Thread Bernd Bohmann
Hello, why we need the @author tag? I don't like code owner ship. Does your request mean we don't allow the svn:keywords=Date Author Id Revision HeadURL in the Subversion config file? Regards Bernd On Tue, Aug 10, 2010 at 10:00 PM, Jan-Kees van Andel jankeesvanan...@gmail.com wrote: Hi,

Proposal to stop using SVN Keywords - (was: MyFaces shipping with JBoss AS6?)

2010-08-09 Thread Jan-Kees van Andel
Hi, What do you guys think about pruning the SVN keywords in the source files? Matthias pointed out a nice example of an issue you run into with this stuff. 1 Not everybody has (the same) svn:keywords on every file. 2 When 1, it will get out of sync. 3 Unreadable version numbers are pretty

Re: Proposal to stop using SVN Keywords - (was: MyFaces shipping with JBoss AS6?)

2010-08-09 Thread Gerhard
+1 these are the reasons why you won't find such information in the extensions projects. regards, gerhard http://www.irian.at Your JSF powerhouse - JSF Consulting, Development and Courses in English and German Professional Support for Apache MyFaces 2010/8/9 Jan-Kees van Andel

Re: Proposal to stop using SVN Keywords - (was: MyFaces shipping with JBoss AS6?)

2010-08-09 Thread Mark Struberg
+1 because it's most times broken anyway ;) LieGrue, strub From: Gerhard gerhard.petra...@gmail.com To: MyFaces Development dev@myfaces.apache.org Sent: Mon, August 9, 2010 11:22:34 PM Subject: Re: Proposal to stop using SVN Keywords - (was: MyFaces shipping with JBoss AS6?) +1 these are

Re: Proposal to stop using SVN Keywords - (was: MyFaces shipping with JBoss AS6?)

2010-08-09 Thread Michael Kurz
+1 as keeping information where it belongs (in the SVN) is basically a good idea. General guidelines about what should be in the header of a file might be useful. regards Michael Am 09.08.2010 23:41, schrieb Mark Struberg: +1 because it's most times broken anyway ;) LieGrue, strub From: