[jira] Commented: (MYFACES-1896) FacesConfigurator version check incorrect
[ https://issues.apache.org/jira/browse/MYFACES-1896?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12678298#action_12678298 ] Wolfgang Klaus commented on MYFACES-1896: - When applying the patch please extend the regular expression because when runnig MyFaces in Borland Enterprise Server the beginning of the Jar-URL is not jar: it is besjar: and file: is missing. The following Regex will also match this: public static final String REGEX_LIBRARY = (bes)?jar:((file:)+.*/(.+)- + (\\d+)(\\.(\\d+)(\\.(\\d+)(\\.(\\d+))?)?)?(-SNAPSHOT)? + \\.jar)!/META-INF/MANIFEST.MF; If this patch wouldn't be applied I can give you a patch for the old checkjar method. FacesConfigurator version check incorrect - Key: MYFACES-1896 URL: https://issues.apache.org/jira/browse/MYFACES-1896 Project: MyFaces Core Issue Type: Bug Affects Versions: 1.2.2 Reporter: Hilbert Schraal Attachments: MYFACES-1896-v2.patch, MYFACES-1896.patch The FacesConfigurator does some checks on whether there are multiple versions of Tomahawk and MyFaces in the classpath. This check is incorrect, in the sense that it can, and will, log incorrect error messages. This problem occurs when using the jar from the tomahawk-facelets project (http://code.google.com/p/tomahawk-facelets), of which I'm one of the maintainers. The current release is called tomahawk-facelets-1.1.6.2.jar, which gives the following error: ERROR FacesConfigurator?:404 - You are using the MyFaces?-package : tomahawk in different versions; first (and probably used) version is : 1.1.6, currently encountered version is : facelets-taglib. This will cause undesired behaviour. Please clean out your class-path. The first encountered version is loaded from : file:/G:/Development/IdeaProjects/blokart/out/exploded/blokartWeb/WEB-INF/lib/tomahawk-1.1.6.jar. The currently encountered version is loaded from : jar:file:/G:/Development/IdeaProjects/blokart/out/exploded/blokartWeb/WEB-INF/lib/tomahawk-facelets-taglib.jar!/META-INF/MANIFEST.MF However, this jar just contains taglibs and some supporting class files. So the error is logged without a valid reason. I've looked at the code in the FacesConfigurator and have seen that the checks can be improved, e.g. using the following regular expression for getting the version number of Tomahawk: tomahawk-(\d\.\d\.\d) -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
Re: [Core] Annotation processing discussion (attn: Jan Kees)
Sounds like a good plan. We can elaborate on this. But first, I'd like to clean up the current FacesConfigurator class (split up into some ConfiguratorStrategy classes). This will make it easier to work on the codebase together without having annoying merge conflicts. I can do this quite quickly I think... Thanks JK! Is there a JIRA issue opened for this or should I open one? I also don't mind contributing some of the code to get this off the ground. Thanks, Curtiss Howard
RE: [VOTE] Orchestra 1.3.1 release candidate
+1 Checked it now and looks good! --- Mario visit my blog at http://copy-con.blogspot.com/ -Original Message- From: Mario Ivankovits [mailto:ma...@ops.co.at] Sent: Tuesday, March 03, 2009 8:12 AM To: 'MyFaces Development' Subject: RE: [VOTE] Orchestra 1.3.1 release candidate +0 (I trust you made a high quality package again :-) ) -Original Message- From: Simon Kitching [mailto:skitch...@apache.org] Sent: Monday, March 02, 2009 9:58 PM To: MyFaces Development Subject: [VOTE] Orchestra 1.3.1 release candidate Hi All, I think it's time to release an update to Orchestra Core; we have about half-a-dozen minor/medium bugs fixed. Therefore I have created a release candidate for orchestra-core 1.3.1. Please have a look at these artifacts and vote: [1] http://people.apache.org/builds/myfaces/m2-staging- repository/org/apache/myfaces/orchestra/myfaces-orchestra-core/1.3.1 [2] http://people.apache.org/~skitching/orchestra-core- 1.3.1/index.html [3] https://svn.apache.org/repos/asf/myfaces/orchestra/branches/core- 1_3_1-prepare/RELEASE-NOTES.txt Note that the link from the site to the 1.3.1 release notes isn't there yet - it can't be done until after the vote has passed and the release- branch has been made a tag :-). But that's just a trivial site update.. [ ] +1 for community members who have reviewed the bits [ ] +0 [ ] -1 for fatal flaws that should cause these bits not to be released, and why.. Thanks! Simon
Re: [Core] Annotation processing discussion (attn: Jan Kees)
I'm almost done.I think I can work on it this Thursday and then commit it. But I've broken my test webapp, so I'll have to fix that before I can test the stuff... ;-) When it's in SVN, we have the necessary boilerplate to stay out of each others' way. ;-) Untill then, if you are bored, you can take a look at how to configure xbean in such a way that all neccessary jars/classes are scanned. This is still an open issue which needs to be fixed early, since you can't test properly without it. Regards, Jan-Kees 2009/3/3 Curtiss Howard curtiss.how...@gmail.com Sounds like a good plan. We can elaborate on this. But first, I'd like to clean up the current FacesConfigurator class (split up into some ConfiguratorStrategy classes). This will make it easier to work on the codebase together without having annoying merge conflicts. I can do this quite quickly I think... Thanks JK! Is there a JIRA issue opened for this or should I open one? I also don't mind contributing some of the code to get this off the ground. Thanks, Curtiss Howard
Re: [Core] Annotation processing discussion (attn: Jan Kees)
Well, my intention with the interface I proposed is to have the implementation set up xbean-finder (or whatever the case may be) when the impl class is created via the factory. That would in fact take care of all the problems my group and I would reasonably encounter. I.e., the default MyFaces impl for AnnotationScanner would configure xbean-finder as it is now (which is entirely appropriate for a lightweight environment like Tomcat) or perhaps use your bytecode scanner. Our impl, on the other hand, would do some other magic for our environment. With a pluggable AnnotationScannerFactory that passes in the FacesContext when creating AnnotationScanner instances, I think every base is adequately covered. Thanks, Curtiss Howard On Tue, Mar 3, 2009 at 3:29 PM, Jan-Kees van Andel jankeesvanan...@gmail.com wrote: I'm almost done.I think I can work on it this Thursday and then commit it. But I've broken my test webapp, so I'll have to fix that before I can test the stuff... ;-) When it's in SVN, we have the necessary boilerplate to stay out of each others' way. ;-) Untill then, if you are bored, you can take a look at how to configure xbean in such a way that all neccessary jars/classes are scanned. This is still an open issue which needs to be fixed early, since you can't test properly without it. Regards, Jan-Kees 2009/3/3 Curtiss Howard curtiss.how...@gmail.com Sounds like a good plan. We can elaborate on this. But first, I'd like to clean up the current FacesConfigurator class (split up into some ConfiguratorStrategy classes). This will make it easier to work on the codebase together without having annoying merge conflicts. I can do this quite quickly I think... Thanks JK! Is there a JIRA issue opened for this or should I open one? I also don't mind contributing some of the code to get this off the ground. Thanks, Curtiss Howard
[jira] Created: (TRINIDAD-1412) commandButton, panelAccordion and processChoiceBar have limited functionality in Non-JavaScript mobile browsers.
commandButton, panelAccordion and processChoiceBar have limited functionality in Non-JavaScript mobile browsers. Key: TRINIDAD-1412 URL: https://issues.apache.org/jira/browse/TRINIDAD-1412 Project: MyFaces Trinidad Issue Type: Bug Components: Components Affects Versions: 1.2.10-core Environment: Blackberry 4.2 Reporter: Mamallan Uthaman Priority: Minor Currently, we don't support the following in Non-JavaScript mobile browsers. 1) icon attribute of the tr:commandButton, 2) discloseNone attribute of tr:panelAccordion 3) drop-down of tr:processChoiceBar -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
Re: [VOTE] Orchestra 1.3.1 release candidate
+1 On Tue, Mar 3, 2009 at 11:55 AM, Mario Ivankovits ma...@ops.co.at wrote: +1 Checked it now and looks good! --- Mario visit my blog at http://copy-con.blogspot.com/ - Show quoted text - -Original Message- From: Mario Ivankovits [mailto:ma...@ops.co.at] Sent: Tuesday, March 03, 2009 8:12 AM To: 'MyFaces Development' Subject: RE: [VOTE] Orchestra 1.3.1 release candidate +0 (I trust you made a high quality package again :-) ) -Original Message- From: Simon Kitching [mailto:skitch...@apache.org] Sent: Monday, March 02, 2009 9:58 PM To: MyFaces Development Subject: [VOTE] Orchestra 1.3.1 release candidate Hi All, I think it's time to release an update to Orchestra Core; we have about half-a-dozen minor/medium bugs fixed. Therefore I have created a release candidate for orchestra-core 1.3.1. Please have a look at these artifacts and vote: [1] http://people.apache.org/builds/myfaces/m2-staging- repository/org/apache/myfaces/orchestra/myfaces-orchestra-core/1.3.1 [2] http://people.apache.org/~skitching/orchestra-core-http://people.apache.org/%7Eskitching/orchestra-core- 1.3.1/index.html [3] https://svn.apache.org/repos/asf/myfaces/orchestra/branches/core- 1_3_1-prepare/RELEASE-NOTES.txt Note that the link from the site to the 1.3.1 release notes isn't there yet - it can't be done until after the vote has passed and the release- branch has been made a tag :-). But that's just a trivial site update.. [ ] +1 for community members who have reviewed the bits [ ] +0 [ ] -1 for fatal flaws that should cause these bits not to be released, and why.. Thanks! Simon -- Grant Smith
Re: [VOTE] Orchestra 1.3.1 release candidate
+1 On Wed, Mar 4, 2009 at 2:21 AM, Grant Smith work.gr...@gmail.com wrote: +1 On Tue, Mar 3, 2009 at 11:55 AM, Mario Ivankovits ma...@ops.co.at wrote: +1 Checked it now and looks good! --- Mario visit my blog at http://copy-con.blogspot.com/ - Show quoted text - -Original Message- From: Mario Ivankovits [mailto:ma...@ops.co.at] Sent: Tuesday, March 03, 2009 8:12 AM To: 'MyFaces Development' Subject: RE: [VOTE] Orchestra 1.3.1 release candidate +0 (I trust you made a high quality package again :-) ) -Original Message- From: Simon Kitching [mailto:skitch...@apache.org] Sent: Monday, March 02, 2009 9:58 PM To: MyFaces Development Subject: [VOTE] Orchestra 1.3.1 release candidate Hi All, I think it's time to release an update to Orchestra Core; we have about half-a-dozen minor/medium bugs fixed. Therefore I have created a release candidate for orchestra-core 1.3.1. Please have a look at these artifacts and vote: [1] http://people.apache.org/builds/myfaces/m2-staging- repository/org/apache/myfaces/orchestra/myfaces-orchestra-core/1.3.1 [2] http://people.apache.org/~skitching/orchestra-core- 1.3.1/index.html [3] https://svn.apache.org/repos/asf/myfaces/orchestra/branches/core- 1_3_1-prepare/RELEASE-NOTES.txt Note that the link from the site to the 1.3.1 release notes isn't there yet - it can't be done until after the vote has passed and the release- branch has been made a tag :-). But that's just a trivial site update.. [ ] +1 for community members who have reviewed the bits [ ] +0 [ ] -1 for fatal flaws that should cause these bits not to be released, and why.. Thanks! Simon -- Grant Smith -- Matthias Wessendorf blog: http://matthiaswessendorf.wordpress.com/ sessions: http://www.slideshare.net/mwessendorf twitter: http://twitter.com/mwessendorf
