[orchestra] conversation timeouts

2007-08-18 Thread simon
Hi All, Currently orchestra has a feature that causes conversations that have not been accessed within 30 minutes to automatically be deleted. Similarly, conversation-contexts that have not been accessed within 30 minutes also get deleted. I don't personally see the use of this, but have been

[orchestra] ViewController stuff

2007-08-18 Thread simon
Hi All, Orchestra currently includes ViewController code to implement callbacks on backing beans for different lifecycle events, eg on creation of view (init), and pre-render. These kinds of callbacks are very useful, but is Orchestra really the right place for this? There is already an

[orchestra] Dependency on tomahawk sandbox

2007-08-18 Thread simon
Hi, For the release expected this week, is the orchestra core15 module (which includes dynaForm) expected to be in the release? If so, it currently depends on tomahawk sandbox component TypedNumberConverter which will make things difficult. Perhaps the right thing to do would be to copy that

[orchestra] ConnectionManagerDataSource.isWrapperFor

2007-08-18 Thread simon
Hi, In ConnectionManagerDataSource, method isWrapperFor currently returns false. Perhaps it should throw UnsupportedOperationException instead? I think it could be misleading if some user code asks whether this object is a wrapper then gets false returned. Yes the primary reason for this method

[orchestra] EndConversationMethodBindingFacade

2007-08-18 Thread simon
Hi, The errorOutcome attribute allows nice handling of the case where an action method throws an exception. However it doesn't close the current conversation. Wouldn't you normally want the conversation closed when an exception is thrown from an action method? Regards, Simon

Re: [orchestra] conversation timeouts

2007-08-18 Thread Mario Ivankovits
Hi! Currently orchestra has a feature that causes conversations that have not been accessed within 30 minutes to automatically be deleted. Similarly, conversation-contexts that have not been accessed within 30 minutes also get deleted. I don't personally see the use of this, but have been

[orchestra] FrameworkAdapter

2007-08-18 Thread simon
Hi, The FrameworkAdapter class currently uses a static variable to find its singleton object. However static variables are tricky in unit testing, and are a problem when a library is deployed via a shared classloader. However the whole point of the FrameworkAdapter is that it is accessable from

[orchestra] servlet filters ..

2007-08-18 Thread Matthias Wessendorf
Hi, looks like it's an orchestra day, today :-) I read the other mail from Simon on the frameworkAdapter, where he suggests to use a filter. However, I noticed that several filters are already used by orchestra, like to one to wrap the request (RequestParameterResponseWrapper) Why not using a

Re: [orchestra] ViewController stuff

2007-08-18 Thread Mario Ivankovits
Hi! There is already an implementation of this sort of thing in the Shale project's view-controller module: http://shale.apache.org/shale-view/index.html I do not have any good argument why I didn't go the shale way. Maybe I was just to shy to convince the shale people about the surely

Re: [orchestra] Dependency on tomahawk sandbox

2007-08-18 Thread Mario Ivankovits
Hi! For the release expected this week, is the orchestra core15 module (which includes dynaForm) expected to be in the release? If so, it currently depends on tomahawk sandbox component TypedNumberConverter which will make things difficult. In fact, I thought about NOT releasing the core15

Re: [orchestra] ConnectionManagerDataSource.isWrapperFor

2007-08-18 Thread Mario Ivankovits
Hi! In ConnectionManagerDataSource, method isWrapperFor currently returns false. Perhaps it should throw UnsupportedOperationException instead? And what about a solution using reflection? Maybe the most correct solution could be: public Object unwrap(Class iface) throws SQLException {

Re: [orchestra] EndConversationMethodBindingFacade

2007-08-18 Thread Mario Ivankovits
Hi! The errorOutcome attribute allows nice handling of the case where an action method throws an exception. However it doesn't close the current conversation. Yep, this is intentional. We don't wanted to force the close of an conversation as we don't know if the exception is one which

Re: [orchestra] FrameworkAdapter

2007-08-18 Thread Mario Ivankovits
Hi! The FrameworkAdapter class currently uses a static variable to find its singleton object. However static variables are tricky in unit testing, and are a problem when a library is deployed via a shared classloader. The only thing which comes to mind is using a ThreadLocal, and having a

Re: [orchestra] servlet filters ..

2007-08-18 Thread Mario Ivankovits
Hi! However, I noticed that several filters are already used by orchestra, like to one to wrap the request (RequestParameterResponseWrapper) BTW also something which should make it into a myfaces-commons. Why not using a FacesContextFactoryImpl ? Hehe, we tried several things to make

Re: [orchestra] servlet filters ..

2007-08-18 Thread Matthias Wessendorf
The only advantage of the current way (servlet filter) is, that it works in an mixed webapp environment (JSF/JSP) However, we can provide your's as the default and provide mine as an alternative if we would like to. jo, that's why I think the framework-adapter might be fine in a filter ?! -M

Re: [orchestra] servlet filters ..

2007-08-18 Thread Mario Ivankovits
Hi! The only advantage of the current way (servlet filter) is, that it works in an mixed webapp environment (JSF/JSP) However, we can provide your's as the default and provide mine as an alternative if we would like to. jo, that's why I think the framework-adapter might be fine in a

Re: [orchestra] servlet filters ..

2007-08-18 Thread simon
On Sat, 2007-08-18 at 14:51 +0200, simon wrote: On Sat, 2007-08-18 at 14:24 +0200, Mario Ivankovits wrote: The JsfFrameworkAdapter already depends on the OrchestraServletFilter where we setup two thread-locals to get access to the request/response object outside of a ready setup

Re: [orchestra] servlet filters ..

2007-08-18 Thread simon
On Sat, 2007-08-18 at 14:24 +0200, Mario Ivankovits wrote: Hi! The only advantage of the current way (servlet filter) is, that it works in an mixed webapp environment (JSF/JSP) However, we can provide your's as the default and provide mine as an alternative if we would like to.

Re: [orchestra] servlet filters ..

2007-08-18 Thread Mario Ivankovits
Hi! Ok, I've created a patch for review. My stupid email client wraps lines at 80 chars, so I've attached it instead of providing it inline. Using this place also to configure the FrameworkAdapter was exactly what I thought too :-) Just, maybe we can use frameworkAdapterClass as

Re: [orchestra] conversation timeouts

2007-08-18 Thread Adam Winer
Mostly ignorant of orchestra, but: Could you hitchhike on other requests? On any request, look through a conversation list, and any that haven't been accessed within 30 minutes get deleted. If no requests are coming in, then one really doesn't care about excessive resource use. :) Finding a way

[jira] Commented: (MYFACES-1709) faces-config.xml validation using an XML Schema

2007-08-18 Thread Paul McMahan (JIRA)
[ https://issues.apache.org/jira/browse/MYFACES-1709?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12520869 ] Paul McMahan commented on MYFACES-1709: --- I agree that this is a good improvement for myfaces. As an aside,

Re: [orchestra] conversation timeouts

2007-08-18 Thread Rahul Akolkar
On 8/18/07, simon [EMAIL PROTECTED] wrote: Hi All, Currently orchestra has a feature that causes conversations that have not been accessed within 30 minutes to automatically be deleted. Similarly, conversation-contexts that have not been accessed within 30 minutes also get deleted. I don't

[orchestra] Shale overlap (was Re: ViewController stuff)

2007-08-18 Thread Rahul Akolkar
On 8/18/07, Mario Ivankovits [EMAIL PROTECTED] wrote: Hi! There is already an implementation of this sort of thing in the Shale project's view-controller module: http://shale.apache.org/shale-view/index.html I do not have any good argument why I didn't go the shale way. Maybe I was

Re: [PORTAL] Liscencing

2007-08-18 Thread Scott O'Bryan
Done... (mostly). See my comment in the JIRA ticket. Scott O'Bryan wrote: Yeah, I agree. I'll try to get that as soon as I can, but it's good to know it won't hold up the committing. :) Scott Matthias Wessendorf wrote: but all this, can be fixed, when it's already committed. We needed

[jira] Created: (TRINIDAD-637) MenuModel is looking at the wrong locale

2007-08-18 Thread Luka Surija (JIRA)
MenuModel is looking at the wrong locale Key: TRINIDAD-637 URL: https://issues.apache.org/jira/browse/TRINIDAD-637 Project: MyFaces Trinidad Issue Type: Bug Reporter: Luka Surija

[jira] Resolved: (TRINIDAD-637) MenuModel is looking at the wrong locale

2007-08-18 Thread Adam Winer (JIRA)
[ https://issues.apache.org/jira/browse/TRINIDAD-637?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Adam Winer resolved TRINIDAD-637. - Resolution: Fixed Fix Version/s: 1.0.3-core Assignee: Adam Winer Fixed, thanks

[jira] Resolved: (TRINIDAD-601) delete unused parsers in org.apache.myfaces.trinidadinternal.ui.laf.xml.parse

2007-08-18 Thread Adam Winer (JIRA)
[ https://issues.apache.org/jira/browse/TRINIDAD-601?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Adam Winer resolved TRINIDAD-601. - Resolution: Fixed Fix Version/s: 1.0.3-core Assignee: Adam Winer Fixed.

[jira] Resolved: (TRINIDAD-158) PPR fails on session timeout with form-based authentication

2007-08-18 Thread Adam Winer (JIRA)
[ https://issues.apache.org/jira/browse/TRINIDAD-158?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Adam Winer resolved TRINIDAD-158. - Resolution: Fixed Fix Version/s: 1.0.2-core Assignee: Adam Winer If you use

[jira] Updated: (TRINIDAD-186) DEBUG-OUTPUT HTML Pretty Printer inserts unwanted whitespace after input element

2007-08-18 Thread Adam Winer (JIRA)
[ https://issues.apache.org/jira/browse/TRINIDAD-186?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Adam Winer updated TRINIDAD-186: Resolution: Fixed Fix Version/s: (was: 1.0.1-incubating-plugins-SNAPSHOT)

[jira] Updated: (TRINIDAD-399) unknown agent yields ServletException

2007-08-18 Thread Adam Winer (JIRA)
[ https://issues.apache.org/jira/browse/TRINIDAD-399?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Adam Winer updated TRINIDAD-399: Resolution: Fixed Fix Version/s: (was: 1.0.1-incubating-core-SNAPSHOT)

[jira] Updated: (TRINIDAD-455) More tagdoc improvements. Add the unsupported agents and renderkits to the description

2007-08-18 Thread Adam Winer (JIRA)
[ https://issues.apache.org/jira/browse/TRINIDAD-455?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Adam Winer updated TRINIDAD-455: Resolution: Fixed Fix Version/s: (was: 2.0.0-incubating-plugins-SNAPSHOT)