Re: [CORE] 2.0.3 release ?

Am 06.11.10 10:40, schrieb Matthias Wessendorf: Hi, I was wondering if there are any outstanding issue, or if we should/could think about a 2.0.3 release for myfaces core. Thanks! Matthias Hi, I want to get a bugfix in for the ipad, which I can commit today, I guess I will postpone the other

Wolfgang Toepfer ist außer Haus.

Ich werde ab dem 08.11.2010 nicht im Büro sein. Ich kehre zurück am 09.11.2010. I will be out of the office from 08.11.2010. I will be returning on 09.11.2010. Ich werde Ihre Nachricht nach meiner Rückkehr beantworten. **

Re: [CORE] 2.0.3 release ?

Am 08.11.10 09:54, schrieb Werner Punz: Am 06.11.10 10:40, schrieb Matthias Wessendorf: Hi, I was wondering if there are any outstanding issue, or if we should/could think about a 2.0.3 release for myfaces core. Thanks! Matthias Hi, I want to get a bugfix in for the ipad, which I can commit

Re: [CORE] 2.0.3 release ?

+1 on first fixing the Safari issues and Geronimo/JBoss integration. Those three are big improvements and I guess they don't take much time to finish, right? Next week my MyFaces 2.0 iPad app will be on a big screen at the Devoxx keynote! I'd like to use the 2.0.3-SNAPSHOT for this, with

[jira] Created: (MYFACES-2966) jsf.js impl request function refactoring

jsf.js impl request function refactoring Key: MYFACES-2966 URL: https://issues.apache.org/jira/browse/MYFACES-2966 Project: MyFaces Core Issue Type: Improvement Reporter: Werner Punz

Re: [CORE] 2.0.3 release ?

On Mon, Nov 8, 2010 at 10:08 AM, Jan-Kees van Andel jankeesvanan...@gmail.com wrote: +1 on first fixing the Safari issues and Geronimo/JBoss integration. Those three are big improvements and I guess they don't take much time to finish, right? Next week my MyFaces 2.0 iPad app will be on a big

[jira] Created: (MYFACES-2967) jsf.js i18n of internal error messages

jsf.js i18n of internal error messages -- Key: MYFACES-2967 URL: https://issues.apache.org/jira/browse/MYFACES-2967 Project: MyFaces Core Issue Type: Improvement Affects Versions: 2.0.3-SNAPSHOT

Re: Use maven-shade-plugin to prevent duplicate code

hi @ all, imo it would be nice to refactor it for 2.0.4. it would also allow an optional all-in-one jar file (mojarra is going to do the same [1]). regards, gerhard [1] https://javaserverfaces.dev.java.net/issues/show_bug.cgi?id=924 http://www.irian.at Your JSF powerhouse - JSF Consulting,

[jira] Resolved: (MYFACES-2965) MyFaces 2.0.2 AJAX crashes Safari on iPad

[ https://issues.apache.org/jira/browse/MYFACES-2965?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Werner Punz resolved MYFACES-2965. -- Resolution: Fixed Fix Version/s: 2.0.3-SNAPSHOT resolved MyFaces 2.0.2 AJAX crashes

[jira] Resolved: (MYFACES-2966) jsf.js impl request function refactoring

[ https://issues.apache.org/jira/browse/MYFACES-2966?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Werner Punz resolved MYFACES-2966. -- Resolution: Fixed resolved jsf.js impl request function refactoring

[jira] Resolved: (MYFACES-2967) jsf.js i18n of internal error messages

[ https://issues.apache.org/jira/browse/MYFACES-2967?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Werner Punz resolved MYFACES-2967. -- Resolution: Fixed Fix Version/s: 2.0.3-SNAPSHOT jsf.js i18n of internal error

Re: [CORE] 2.0.3 release ?

Hi Guys I have now committed the latest js changes, including the safari mobile bug workaround, I will do some additional testing on them this week (in the mobile sector mostly), so that you guys will have a stable codebase for devoxx next week. I cannot do it during the day however due to

[jira] Updated: (MYFACES-2882) 3.4.2.6 Event Broadcasting: processing events during the current lifecycle phase doesn't process additional events

[ https://issues.apache.org/jira/browse/MYFACES-2882?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Martin Kočí updated MYFACES-2882: - Status: Patch Available (was: Open) 3.4.2.6 Event Broadcasting: processing events during the

Re: Use maven-shade-plugin to prevent duplicate code

+1 Am 08.11.10 10:51, schrieb Gerhard: hi @ all, imo it would be nice to refactor it for 2.0.4. it would also allow an optional all-in-one jar file (mojarra is going to do the same [1]). regards, gerhard [1] https://javaserverfaces.dev.java.net/issues/show_bug.cgi?id=924 http://www.irian.at

Re: Use maven-shade-plugin to prevent duplicate code

Hi Unfortunately, maven-shade-plugin has some unwanted side effects. - The source jar file is not updated too, so if we shade shared, the sources are not updated. In theory, the source jar is used by IDEs like Eclipse or Netbeans to show the source file of a .class. - It does not play well with

Re: Use maven-shade-plugin to prevent duplicate code

hi, @ide-support: since you get an additional all-in-one sources jar file, it should work. i've created external codi examples which use the all-in-one jar of codi and the ide support works perfectly. @osgi: if there are restrictions, we should improve the shade plugin. (for now: osgi users just

Re: Use maven-shade-plugin to prevent duplicate code

Hi 2010/11/8 Gerhard gerhard.petra...@gmail.com hi, @ide-support: since you get an additional all-in-one sources jar file, it should work. i've created external codi examples which use the all-in-one jar of codi and the ide support works perfectly. Yes, that's true (I checked that code)

Re: require-bundle header in api bundle

Hi 2010/11/5 David Jencks david_jen...@yahoo.com I'm trying to understand why the require-bundle header is in the api bundle. This is a pretty bizarre thing to do in what I've seen of osgi. Could you be more explicit about this point? I don't see anything bizarre here. I took it out and

[jira] Commented: (MYFACES-2911) OSGi Manifest: MyFaces API Bundle requires IMPL Bundle

[ https://issues.apache.org/jira/browse/MYFACES-2911?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12929661#action_12929661 ] Leonardo Uribe commented on MYFACES-2911: - myfaces-api jar are only tested

[jira] Resolved: (MYFACES-2911) OSGi Manifest: MyFaces API Bundle requires IMPL Bundle

[ https://issues.apache.org/jira/browse/MYFACES-2911?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Leonardo Uribe resolved MYFACES-2911. - Resolution: Not A Problem Assignee: Leonardo Uribe OSGi Manifest: MyFaces API

Re: Use maven-shade-plugin to prevent duplicate code

Hi, Last week I created a branch (see [1]) to test the shade module integration of shared and also implee6 for MyFaces core. Coincidentally, Leonardo committed a similar solution to MyFaces core trunk, however only for the implee6 integration. The branch at [1] uses the shade plugin to include

Re: Use maven-shade-plugin to prevent duplicate code

i agree with jakob. regards, gerhard http://www.irian.at Your JSF powerhouse - JSF Consulting, Development and Courses in English and German Professional Support for Apache MyFaces 2010/11/8 Jakob Korherr jakob.korh...@gmail.com Hi, Last week I created a branch (see [1]) to test the

[jira] Commented: (MYFACES-2911) OSGi Manifest: MyFaces API Bundle requires IMPL Bundle

[ https://issues.apache.org/jira/browse/MYFACES-2911?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12929688#action_12929688 ] Mike Kienenberger commented on MYFACES-2911: For what it's worth, I think I

[jira] Commented: (MYFACES-2911) OSGi Manifest: MyFaces API Bundle requires IMPL Bundle

[ https://issues.apache.org/jira/browse/MYFACES-2911?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12929690#action_12929690 ] Mike Kienenberger commented on MYFACES-2911: Update build to produce a single

Re: Use maven-shade-plugin to prevent duplicate code

Hi 2010/11/8 Jakob Korherr jakob.korh...@gmail.com Hi, Last week I created a branch (see [1]) to test the shade module integration of shared and also implee6 for MyFaces core. Coincidentally, Leonardo committed a similar solution to MyFaces core trunk, however only for the implee6

Re: Use maven-shade-plugin to prevent duplicate code

Hi, IMHO shared code ist just as private as myfaces-impl code. Not more, not less. Adding the all-in-one-jar is not a change, but an improvement. It is just an additional (non-OSGi-ready) distribution form of MyFaces code and thus does not affect the problems we're having with myfaces-shared and

Re: Use maven-shade-plugin to prevent duplicate code

again - i agree with jakob! such an additional all-in-one dist won't change the situation for osgi users. (for now) they just have to stick with the current jar files. @shared: the classes of the shared module would be in the impl. module, if we don’t (have to) share them with other myfaces

Re: Use maven-shade-plugin to prevent duplicate code

Hi 2010/11/8 Jakob Korherr jakob.korh...@gmail.com Hi, IMHO shared code ist just as private as myfaces-impl code. Not more, not less. Yes, in theory, but in practice that rule is not maintained. To keep backward compatibility we can't change the package of DelegateServlet (maybe just add

Re: Use maven-shade-plugin to prevent duplicate code

Hi 2010/11/8 Gerhard gerhard.petra...@gmail.com again - i agree with jakob! such an additional all-in-one dist won't change the situation for osgi users. (for now) they just have to stick with the current jar files. @shared: the classes of the shared module would be in the impl. module,

Re: Use maven-shade-plugin to prevent duplicate code

hi, i didn't talk about copying the code to the impl. module. it would be a normal module (similar to the shared module) which gets shadded into the impl. module. actually both approaches are very similar. so you have the same advantages (compared to the shared module) and it's easier to handle

Re: Use maven-shade-plugin to prevent duplicate code

Hi 2010/11/8 Gerhard gerhard.petra...@gmail.com hi, i didn't talk about copying the code to the impl. module. it would be a normal module (similar to the shared module) which gets shadded into the impl. module. actually both approaches are very similar. so you have the same advantages

Re: Use maven-shade-plugin to prevent duplicate code

Hi Leo, you are getting this all wrong. Please take a look at the shade-branch, which I created, and then we can continue this discussion. Thanks. Regards, Jakob 2010/11/8 Leonardo Uribe lu4...@gmail.com: Hi 2010/11/8 Gerhard gerhard.petra...@gmail.com hi, i didn't talk about copying the

Re: Use maven-shade-plugin to prevent duplicate code

Hi No, I understand well, but maybe we are talking about many possible enhancements at the same time. I know how shade plugin works, after all, I did the necessary changes to use it on implee6. That's the reason why I know well the problems involved. I tried to use it in myfaces-test but the

Re: require-bundle header in api bundle

Before I spend a lot of time figuring out why FactoryFinder works in geronimo, I wonder if there is any need for any of the impl classes to be exported for any reason other than making them visible to FactoryFinder? If not then either packaging api and impl in a single bundle or making the

Re: require-bundle header in api bundle

Hi 2010/11/8 David Jencks david_jen...@yahoo.com Before I spend a lot of time figuring out why FactoryFinder works in geronimo, I wonder if there is any need for any of the impl classes to be exported for any reason other than making them visible to FactoryFinder? If not then either

Re: Use maven-shade-plugin to prevent duplicate code

If you don't need a shaded source jar, have you guys experimented with the bundle plugin for generating this jar? thanks david jencks On Nov 8, 2010, at 2:15 PM, Leonardo Uribe wrote: Hi No, I understand well, but maybe we are talking about many possible enhancements at the same time.

Re: Use maven-shade-plugin to prevent duplicate code

Hi 2010/11/8 David Jencks david_jen...@yahoo.com If you don't need a shaded source jar, have you guys experimented with the bundle plugin for generating this jar? I have never tried it. Maybe someone else? But in this case have a shaded source jar could be important. regards, Leonardo

[jira] Commented: (TOBAGO-929) Render partially doesn't work inside of ToolBar.

[ https://issues.apache.org/jira/browse/TOBAGO-929?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12929809#action_12929809 ] Udo Schnurpfeil commented on TOBAGO-929: You may test the next nighly build.

[TRINIDAD] testBinaryCompatibility build error

Hi, I got this error while building for my Skin Versioning patch. testBinaryCompatibility(org.apache.myfaces.trinidad.ClirrRunnerTest) I built the other day and it was fine. Did someone add a new test? I did add some new APIs. What do I have to do to get this to pass? Looking at the

Re: [TRINIDAD] testBinaryCompatibility build error

Jeanne, This is the result of the api checks for backwards compatibility. The trinidad-api/src/test/clirr/clirr-runner.txt file acts as a golden file for allowed api changes. If your test fails, the target directory will contain the clirr-runner.txt file of all of the api changes found.

Re: [TRINIDAD] testBinaryCompatibility build error

Jeanne, Was there an INFO diff? Perhaps I should change it to ERROR only .. -M sent from my Android phone On Nov 9, 2010 2:46 AM, Blake Sullivan blake.sulli...@oracle.com wrote: Jeanne, This is the result of the api checks for backwards compatibility. The