Yes full +1.
It seems that Leo still has auto-generating the @author in the files he
touches. Even if this file is a close to 1:1 clone of an almost 10 year old
file originally written by Tom.
We already voted in favour to get rid of the @author tags apart from the
ancient ones which have been
Btw, you wrote
that code has been there for years!!
I checked the logs now.
Actually most of the changes got only introduced in 2.1.9!
LieGrue,
strub
- Original Message -
From: Leonardo Uribe lu4...@gmail.com
To: MyFaces Development dev@myfaces.apache.org; Mark Struberg
I checked the work done in there and Imo this is far from usable. Let's get the
windowId right in 2.2 an backport it later.
It doesn't make any sense to have 2 branches to do try error in this area. To
stress your butterfly analogy: there is a difference between a cocoon and a
hydra ;)
I tried to keep trunk and core/branches/2.2.x in sync. But this is currently
totally broken
A.) it doesn't compile
B.) there are JavaScript compilation errors
c.) it still states a mixture of 2.0.0-SNAPSHOT and description says 2.1 in the
poms
PS: again, this should not be a personal critic. Every one makes errors. Only
the ones who do not work at all don't make errors :)
It just makes it clear that all of us must contribute more, actively review
changes and help out!
And Leo, you must open your mind to ideas of other people to let
Mark Struberg created MYFACES-3648:
--
Summary: some jsf files contain illegal UTF characters
Key: MYFACES-3648
URL: https://issues.apache.org/jira/browse/MYFACES-3648
Project: MyFaces Core
[
https://issues.apache.org/jira/browse/MYFACES-3648?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Mark Struberg resolved MYFACES-3648.
Resolution: Fixed
Fix Version/s: 2.2.0
some jsf files contain illegal UTF
Mark Struberg created MYFACES-3649:
--
Summary: myfaces-shaded-impl always unpacks myfaces-2.1.1
Key: MYFACES-3649
URL: https://issues.apache.org/jira/browse/MYFACES-3649
Project: MyFaces Core
[
https://issues.apache.org/jira/browse/MYFACES-3649?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13498690#comment-13498690
]
Mark Struberg commented on MYFACES-3649:
I added the implicit dependency and got
[
https://issues.apache.org/jira/browse/MYFACES-3649?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13498702#comment-13498702
]
Mark Struberg commented on MYFACES-3649:
This can only properly get resolved by
Hi folks!
I'm not sure if I'm seeing ghosts or if we still are broken since a while now
Please try the patch provided in
https://issues.apache.org/jira/browse/MYFACES-3649 yourself and provide
feedback.
If I didn't miss anything then we leak in classes from the myfaces-core-2.1.1
release via
+1
On Fri, Nov 16, 2012 at 2:54 AM, Mark Struberg strub...@yahoo.de wrote:
+1
LieGrue,
strub
PS: vote is open for 72h with lazy consensus (as always if nothing else
stated)
- Original Message -
From: Mark Struberg strub...@yahoo.de
To: My Faces Development
My understanding is that there was no 2.2 to work in when this branch
was started.
The idea was to get it right in 2.1 in our proprietary
implementation, and then use that to insure that the 2.2 spec worked
in practice as well as in theory.
On Fri, Nov 16, 2012 at 3:20 AM, Mark Struberg
Hi Radu!
Congratulations, you spotted a very deeply buried problem :) It actually has
nothing to do with CODI nor CDI. The problem is similar with every passivation
capable (==Serializable) bean: @PreDestroy is not 100% guaranteed to get fired.
I'm not sure if you really did hit a bug in the
2012/11/16 Mark Struberg strub...@yahoo.de:
what is this commit for? there is no JIRA in it and it has nothing to do with
the release rollback.
This is a merge of the changes done in 2.1.x and 2.1.x-client-window
branch, to keep all branches in sync. It is ok.
- Original Message -
2012/11/16 Mark Struberg strub...@yahoo.de:
there seems to be a UTF character in the JavaScript you committed ('Â'). This
might be broken on a few browsers.
Or is this only a commit mail artifact? (which I don't believe)
Ok, thanks for fix it. I have seen this issue in the past, it happens
2012/11/16 Mark Struberg strub...@yahoo.de:
Leo, why do you backport all this stuff to 2.0.x? That makes no sense to me.
Yes, I have to maintain all 4 branches, and it is easier if I backport
everything to 2.0.x, because if the code has less differences, that
simplifies maintenance in the long
Hmm, not sure - I was not even able to compile the project because of that.
In any case please watch this issue. Maybe there is a file encoding issue on
some box, email, etc.
LieGrue,
strub
- Original Message -
From: Leonardo Uribe lu4...@gmail.com
To: MyFaces Development
Hi
2012/11/16 Mark Struberg strub...@yahoo.de:
Btw, you wrote
that code has been there for years!!
I checked the logs now.
Actually most of the changes got only introduced in 2.1.9!
Mark, all refactoring started in MYFACES-3117, which has been
created in 2011, so I have been working
I remember this a bit different. But maybe I'm wrong.
Gerhard and I created all that windowId stuff in the first place in CODI and
pushed this feature to the spec as well (3 hours late night discussion with Ed
at the last con-fess) . The idea was to get this 'right' in JSF-2.2 first and
only
Hi
Mark, I have not been working in 2.2.x branch. Don't blame me! (don't
you get tired? because I am tired). Werner created the branch to work
on client-window javascript part. The environment he uses does not
require compile the java part, and at the end of the day he just
synchronize the
Hi
2012/11/16 Mark Struberg strub...@yahoo.de:
Hi folks!
I'm not sure if I'm seeing ghosts or if we still are broken since a while now
I tried it and trunk is working.
Please try the patch provided in
https://issues.apache.org/jira/browse/MYFACES-3649 yourself and provide
feedback.
+1. That will reduce overhead.
2012/11/16 Mike Kienenberger mkien...@gmail.com:
+1
On Fri, Nov 16, 2012 at 2:54 AM, Mark Struberg strub...@yahoo.de wrote:
+1
LieGrue,
strub
PS: vote is open for 72h with lazy consensus (as always if nothing else
stated)
- Original Message -
core/branches/2.2.x is the official JSF-2.2 branch, isn't?
trunk is still 2.1.x but 2.2 goes into that branch afaik.
LieGrue,
strub
- Original Message -
From: Leonardo Uribe lu4...@gmail.com
To: MyFaces Development dev@myfaces.apache.org; Mark Struberg
strub...@yahoo.de
Cc:
Well, I removed the core-impl-2.1.1 shading and started a CI build now.
Jenkins will tell us the truth.
If it's broken then we will not release next week but need to do a detailed
investigation.
LieGrue,
strub
- Original Message -
From: Leonardo Uribe lu4...@gmail.com
To: MyFaces
Hi
Really the advantage to work in 2.1.x-client-window is if people is
working in 2.2.x, there are chances that by some commit, the code gets
unstable for some time. Since 2.1.x-client-window is JSF 2.1 + client
window api does not contain any additional new feature, you can work
safely with
The clientWindow stuff needs jsf.js -2.2. There is no way you can do that in
2.1 without introducing changes.
- Original Message -
From: Leonardo Uribe lu4...@gmail.com
To: MyFaces Development dev@myfaces.apache.org; Mark Struberg
strub...@yahoo.de
Cc:
Sent: Friday, November
When client-window api get
stable, we can backport it to 2.1 in one step, knowing the changes
done and the implications.
Ok, seems we agree now. Because this is exactly what I proposed: do the
clientWindow stuff in 2.2 to a point it is usable and the JSF API is stable and
then port it back
+1 on that idea, especially given the jsf.js 2.2 dependency.
On Fri, Nov 16, 2012 at 7:45 AM, Mark Struberg strub...@yahoo.de wrote:
When client-window api get
stable, we can backport it to 2.1 in one step, knowing the changes
done and the implications.
Ok, seems we agree now. Because
Ok Leo, you won a beer.
It seems my local SVN got corrupted and didn't tell me any diffs despite
missing a few classes.
Will check your changes now.
LieGrue,
strub
- Original Message -
From: Mark Struberg strub...@yahoo.de
To: MyFaces Development dev@myfaces.apache.org
Cc:
+1
On Fri, Nov 16, 2012 at 7:31 AM, Leonardo Uribe lu4...@gmail.com wrote:
+1. That will reduce overhead.
2012/11/16 Mike Kienenberger mkien...@gmail.com:
+1
On Fri, Nov 16, 2012 at 2:54 AM, Mark Struberg strub...@yahoo.de
wrote:
+1
LieGrue,
strub
PS: vote is open for 72h
It's funny you should say that. I have not had the chance to look at
Myfaces code for a long time and yesterday did an svn update, resulting
in an uncompilable trunk. only after removing everything and performing a
fresh checkout could I get it to compile.
On Fri, Nov 16, 2012 at 7:54 AM, Mark
Hi
2012/11/16 Mark Struberg strub...@yahoo.de:
I had already the changes in my laptop, but I was careful and only
committed them after 2.1.8 release.
This is really a two sided sword Leo. I really appreciate your care to not
break an upcoming release. But otoh you take people the ability
2012/11/16 Mark Struberg strub...@yahoo.de:
core/branches/2.2.x is the official JSF-2.2 branch, isn't?
Yes.
trunk is still 2.1.x but 2.2 goes into that branch afaik.
Yes, in fact, I was thinking on make 2.2.x the new trunk. It is a good
time to do it.
regards,
Leonardo
LieGrue,
strub
Yes, in fact, I was thinking on make 2.2.x the new trunk. It is a good
time to do it.
I've no strong feelings the one way or the other. We just need to discuss it
upfront and then do the switch in a public way and make everyone aware of it
(blog, tweets, etc).
LieGrue,
strub
-
Mark Struberg created MYFACES-3650:
--
Summary: myfaces-2.2.x poms not properly set up
Key: MYFACES-3650
URL: https://issues.apache.org/jira/browse/MYFACES-3650
Project: MyFaces Core
Issue
[
https://issues.apache.org/jira/browse/MYFACES-3648?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13498902#comment-13498902
]
Mark Struberg commented on MYFACES-3648:
maven scm URLs are also all still
Problems with @ViewScoped and @PreDestroy have been identified in the
spec and a fix is slated for JSF 2.2:
http://java.net/jira/browse/JAVASERVERFACES_SPEC_PUBLIC-905
You guys might want to comment on it.
Stan
On 11/16/2012 9:50 AM, Mark Struberg wrote:
Hi Radu!
Congratulations, you
+1
On Fri, Nov 16, 2012 at 5:54 PM, Grant Smith gr...@marathonpm.com wrote:
+1
On Fri, Nov 16, 2012 at 7:31 AM, Leonardo Uribe lu4...@gmail.com wrote:
+1. That will reduce overhead.
2012/11/16 Mike Kienenberger mkien...@gmail.com:
+1
On Fri, Nov 16, 2012 at 2:54 AM, Mark Struberg
[
https://issues.apache.org/jira/browse/MYFACES-3649?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13498960#comment-13498960
]
Leonardo Uribe commented on MYFACES-3649:
-
I remember implee6 module was created
[
https://issues.apache.org/jira/browse/MYFACES-3649?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13498965#comment-13498965
]
Mark Struberg commented on MYFACES-3649:
It is perfectly possible to do both in
[
https://issues.apache.org/jira/browse/MYFACES-3636?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Leonardo Uribe updated MYFACES-3636:
Resolution: Fixed
Fix Version/s: 2.1.10
2.0.16
Hi
It could be good if we can do a release of myfaces core 2.1.10 /
2.0.16 next week.
The only issue to do is:
MYFACES-3649 myfaces-shaded-impl always unpacks myfaces-2.1.1
So I hope to start the necessary steps next monday/tuesday.
If you have any bug that needs to be fixed before release,
Working on that.
I also need to review the view key refactoring once again and test it with our
app.
LieGrue,
strub
- Original Message -
From: Leonardo Uribe lu4...@gmail.com
To: MyFaces Development dev@myfaces.apache.org
Cc:
Sent: Friday, November 16, 2012 8:06 PM
Subject:
Hi folks!
We did lots of tricks to keep core free of servlet-3.0. But sadly we leak it in
MyFaces-2.2 due to myfaces-shared HtmlInputFileRenderer.
This function requires the multi MIME Part which is new in servlet-3.0.
That means servlet-2.5 support is only guaranteed if you don't use that
+1
regards,
gerhard
http://www.irian.at
Your JSF/JavaEE powerhouse -
JavaEE Consulting, Development and
Courses in English and German
Professional Support for Apache MyFaces
2012/11/16 Mark Struberg strub...@yahoo.de
The JSF-2.0 spec came out in early 2009. There is a clarification/bugfix
That was it?
To sum up:
We are now exactly where I have been 2 days ago. Except that you now rolled
back all my changes and trashed all the commit logs with dozen of 'copy to move
history' messages. Just to apply them again - that's pure waste of time! Not
only yours, but also of all other
[
https://issues.apache.org/jira/browse/MYFACES-3649?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Mark Struberg resolved MYFACES-3649.
Resolution: Fixed
Fix Version/s: 2.1.10
2.2.0
fixed by
Hi
2012/11/16 Mark Struberg strub...@yahoo.de:
That was it?
To sum up:
We are now exactly where I have been 2 days ago. Except that you now rolled
back all my changes and trashed all the commit logs with dozen of 'copy to
move history' messages. Just to apply them again - that's pure
Thanks Thomas, sounds reasonable. Though there is still myfaces-2.1.x which
runs perfectly fine with only servlet-2.5
This is really only required for JSF-2.2. Now I personally assume that people
start using JSF-2.2 in production around Q3 next year (2013). And until then I
hope that all
What is the spec requirements for 2.2? If 2.2 doesn't insist on
servlet-3.0, then I'd make it a soft dependency rather than a hard
failure.
On Fri, Nov 16, 2012 at 5:10 PM, Mark Struberg strub...@yahoo.de wrote:
Thanks Thomas, sounds reasonable. Though there is still myfaces-2.1.x which
JSF-2.2 will be part of EE-7 thus servlet-3.1 even.
It's currently used in a few components in myfaces-shared.
Not sure where else we would need it. Probably for async-supported if we like
to implement that.
LieGrue,
strub
- Original Message -
From: Mike Kienenberger
Well, if servlet 3.1 is the minimum requirement, then I think we
should go with at least 3.0 rather than using a soft or optional
dependency.
On Fri, Nov 16, 2012 at 7:04 PM, Mark Struberg strub...@yahoo.de wrote:
JSF-2.2 will be part of EE-7 thus servlet-3.1 even.
It's currently used in a
[
https://issues.apache.org/jira/browse/MYFACES-3650?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Mark Struberg resolved MYFACES-3650.
Resolution: Fixed
Fix Version/s: 2.2.0
myfaces-2.2.x poms not properly set
54 matches
Mail list logo
