[jira] [Created] (TRINIDAD-2514) Make isEmailMode check more lenient

2014-10-14 Thread Blake Sullivan (JIRA)
Blake Sullivan created TRINIDAD-2514: Summary: Make isEmailMode check more lenient Key: TRINIDAD-2514 URL: https://issues.apache.org/jira/browse/TRINIDAD-2514 Project: MyFaces Trinidad

[jira] [Resolved] (TRINIDAD-2514) Make isEmailMode check more lenient

2014-10-14 Thread Blake Sullivan (JIRA)
[ https://issues.apache.org/jira/browse/TRINIDAD-2514?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Blake Sullivan resolved TRINIDAD-2514. -- Resolution: Fixed Fix Version/s: 2.1.1-core Assignee: Blake Sullivan

[jira] [Created] (TRINIDAD-2502) Finish RenderKit Test Improvements so we can always run all tests

2014-08-05 Thread Blake Sullivan (JIRA)
Blake Sullivan created TRINIDAD-2502: Summary: Finish RenderKit Test Improvements so we can always run all tests Key: TRINIDAD-2502 URL: https://issues.apache.org/jira/browse/TRINIDAD-2502

[jira] [Resolved] (TRINIDAD-2502) Finish RenderKit Test Improvements so we can always run all tests

2014-08-05 Thread Blake Sullivan (JIRA)
[ https://issues.apache.org/jira/browse/TRINIDAD-2502?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Blake Sullivan resolved TRINIDAD-2502. -- Resolution: Fixed Fix Version/s: 2.1.1-core Fixed in revision 1,615,878

[jira] [Created] (TRINIDAD-2503) Extend testing improvements in 2501 and 2502 to RenderKit subclasses

2014-08-05 Thread Blake Sullivan (JIRA)
Blake Sullivan created TRINIDAD-2503: Summary: Extend testing improvements in 2501 and 2502 to RenderKit subclasses Key: TRINIDAD-2503 URL: https://issues.apache.org/jira/browse/TRINIDAD-2503

[jira] [Resolved] (TRINIDAD-2503) Extend testing improvements in 2501 and 2502 to RenderKit subclasses

2014-08-05 Thread Blake Sullivan (JIRA)
[ https://issues.apache.org/jira/browse/TRINIDAD-2503?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Blake Sullivan resolved TRINIDAD-2503. -- Resolution: Fixed Resolved in 1,616,039 Extend testing improvements in 2501

[jira] [Created] (TRINIDAD-2501) Renderkit Test Improvements

2014-08-04 Thread Blake Sullivan (JIRA)
Blake Sullivan created TRINIDAD-2501: Summary: Renderkit Test Improvements Key: TRINIDAD-2501 URL: https://issues.apache.org/jira/browse/TRINIDAD-2501 Project: MyFaces Trinidad Issue

[jira] [Updated] (TRINIDAD-2501) Renderkit Test Improvements

2014-08-04 Thread Blake Sullivan (JIRA)
[ https://issues.apache.org/jira/browse/TRINIDAD-2501?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Blake Sullivan updated TRINIDAD-2501: - Status: Patch Available (was: Open) Renderkit Test Improvements

[jira] [Updated] (TRINIDAD-2501) Renderkit Test Improvements

2014-08-04 Thread Blake Sullivan (JIRA)
[ https://issues.apache.org/jira/browse/TRINIDAD-2501?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Blake Sullivan updated TRINIDAD-2501: - Resolution: Fixed Fix Version/s: 2.1.1-core Status: Resolved

[jira] [Commented] (TRINIDAD-2501) Renderkit Test Improvements

2014-08-04 Thread Blake Sullivan (JIRA)
[ https://issues.apache.org/jira/browse/TRINIDAD-2501?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14085678#comment-14085678 ] Blake Sullivan commented on TRINIDAD-2501: -- Resolved in 1,615,840 Renderkit

[jira] [Updated] (TRINIDAD-2493) Allow subclasses of UIXCollection to hook processFlattenedChildrenBegin

2014-07-21 Thread Blake Sullivan (JIRA)
[ https://issues.apache.org/jira/browse/TRINIDAD-2493?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Blake Sullivan updated TRINIDAD-2493: - Resolution: Fixed Status: Resolved (was: Patch Available) Resolved by patch

[jira] [Created] (TRINIDAD-2494) Switch Trinidad Plugin Source Code to use Generics

2014-07-21 Thread Blake Sullivan (JIRA)
Blake Sullivan created TRINIDAD-2494: Summary: Switch Trinidad Plugin Source Code to use Generics Key: TRINIDAD-2494 URL: https://issues.apache.org/jira/browse/TRINIDAD-2494 Project: MyFaces

[jira] [Resolved] (TRINIDAD-2494) Switch Trinidad Plugin Source Code to use Generics

2014-07-21 Thread Blake Sullivan (JIRA)
[ https://issues.apache.org/jira/browse/TRINIDAD-2494?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Blake Sullivan resolved TRINIDAD-2494. -- Resolution: Fixed Fix Version/s: 2.1.0-core Resolved in revision 1612454

[jira] [Commented] (TRINIDAD-2494) Switch Trinidad Plugin Source Code to use Generics

2014-07-21 Thread Blake Sullivan (JIRA)
[ https://issues.apache.org/jira/browse/TRINIDAD-2494?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14069792#comment-14069792 ] Blake Sullivan commented on TRINIDAD-2494: -- Resolved in reviison 1,612,454

[jira] [Created] (TRINIDAD-2493) Allow subclasses of UIXCollection to hook processFlattenedChildrenBegin

2014-07-17 Thread Blake Sullivan (JIRA)
Blake Sullivan created TRINIDAD-2493: Summary: Allow subclasses of UIXCollection to hook processFlattenedChildrenBegin Key: TRINIDAD-2493 URL: https://issues.apache.org/jira/browse/TRINIDAD-2493

[jira] [Updated] (TRINIDAD-2493) Allow subclasses of UIXCollection to hook processFlattenedChildrenBegin

2014-07-17 Thread Blake Sullivan (JIRA)
[ https://issues.apache.org/jira/browse/TRINIDAD-2493?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Blake Sullivan updated TRINIDAD-2493: - Status: Patch Available (was: Open) Allow subclasses of UIXCollection to hook

Re: [Trinidad] New API addition for Trinidad's UIXCollection

2014-05-16 Thread Blake Sullivan
It should be the same. — Blake Sullivan On May 15, 2014, at 7:58 AM, Andrew Robinson andrew.rw.robin...@gmail.com wrote: How is this different from just setting the current row index to -1? On Tue, May 6, 2014 at 1:49 PM, Jing Wu jing.x...@oracle.com wrote: Thanks Blake for your comment

Re: [Trinidad] New API addition for Trinidad's UIXCollection

2014-05-05 Thread Blake Sullivan
Jing, What is an example of a case where code external to the model implementation knows that: 1) The model is hanging onto a rowKey 2) The key is invalid The model implementation is typical supposed to encapsulate this information. -- Blake Sullivan On May 5, 2014, at 3:26 PM, Jing Wu wrote

Re: [VOTE] Release of Trinidad Maven Plugins 2.0.8

2013-11-06 Thread Blake Sullivan
metadata, which knows that this is an enum case. -- Blake Sullivan On Nov 6, 2013, at 1:35 PM, Andy Schwartz wrote: Hey Scott - Great, thanks for tracking this down. +1 for me then. Andy On Wed, Nov 6, 2013 at 12:55 PM, Scott O'Bryan darkar...@gmail.com wrote: I'm changing my vote

Re: [DISCUSS] trinidad.next

2013-10-30 Thread Blake Sullivan
That's only if you are wrapping another ExternalContext. If you need to create an ExternalContext out of thin air, then any new abstract methods are a problem. Essentially, the JSF specification made an incompatible api change between JSF 2.0 and 2.1. -- Blake Sullivan On Oct 30, 2013, at 3

Re: [DISCUSS] trinidad.next

2013-10-30 Thread Blake Sullivan
of this are the Configurators that abstract away ServletFilters. Other frameworks may not have tis functionality, but regardless JSF 2.0 and JSF 2.1 have api incompatibilities that I believe are illegal for minor releases. -- Blake Sullivan On Oct 30, 2013, at 4:12 PM, Gerhard Petracek wrote: hi

Re: Trinidad tr:commandlink tr:commandbutton

2013-08-14 Thread Blake Sullivan
The behavior is implemented by the browser and that is what the browser implements. -- Blake Sullivan On Aug 14, 2013, at 3:31 AM, steffen.her...@zf.com wrote: Hi all, does anyone one why the accessKey property behaves different for tr:commandLink and tr:commandButton. Setting

[jira] [Created] (TRINIDAD-2401) Clean up skinning code to avoid use of obsolete synchronized classes

2013-07-16 Thread Blake Sullivan (JIRA)
Blake Sullivan created TRINIDAD-2401: Summary: Clean up skinning code to avoid use of obsolete synchronized classes Key: TRINIDAD-2401 URL: https://issues.apache.org/jira/browse/TRINIDAD-2401

[jira] [Created] (TRINIDAD-2378) UIXComponentBase should override clearCachedClientId to avoid calling getId() at times when the UIViewRoot isn't present

2013-04-20 Thread Blake Sullivan (JIRA)
Blake Sullivan created TRINIDAD-2378: Summary: UIXComponentBase should override clearCachedClientId to avoid calling getId() at times when the UIViewRoot isn't present Key: TRINIDAD-2378 URL: https

[jira] [Created] (TRINIDAD-2374) UIXComponentBase._calculateClientId should throw exception if the component is not in the tree

2013-03-26 Thread Blake Sullivan (JIRA)
Blake Sullivan created TRINIDAD-2374: Summary: UIXComponentBase._calculateClientId should throw exception if the component is not in the tree Key: TRINIDAD-2374 URL: https://issues.apache.org/jira/browse

[jira] [Created] (TRINIDAD-2365) Change UIViewRoot caching behavior from per-window to per-session

2013-02-14 Thread Blake Sullivan (JIRA)
Blake Sullivan created TRINIDAD-2365: Summary: Change UIViewRoot caching behavior from per-window to per-session Key: TRINIDAD-2365 URL: https://issues.apache.org/jira/browse/TRINIDAD-2365

[jira] [Commented] (TRINIDAD-2293) multi file upload does not get replicated in a High Availability environment

2012-07-23 Thread Blake Sullivan (JIRA)
[ https://issues.apache.org/jira/browse/TRINIDAD-2293?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13420798#comment-13420798 ] Blake Sullivan commented on TRINIDAD-2293: -- There must be something that I am

[jira] [Updated] (TRINIDAD-2293) multi file upload does not get replicated in a High Availability environment

2012-07-23 Thread Blake Sullivan (JIRA)
[ https://issues.apache.org/jira/browse/TRINIDAD-2293?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Blake Sullivan updated TRINIDAD-2293: - Status: Open (was: Patch Available) multi file upload does not get replicated

[jira] [Commented] (TRINIDAD-2293) multi file upload does not get replicated in a High Availability environment

2012-07-23 Thread Blake Sullivan (JIRA)
[ https://issues.apache.org/jira/browse/TRINIDAD-2293?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13420916#comment-13420916 ] Blake Sullivan commented on TRINIDAD-2293: -- In the HA case you describe, your

[jira] [Commented] (TRINIDAD-2288) ClassCastException on XhtmlRenderer.getPartialTriggers

2012-07-12 Thread Blake Sullivan (JIRA)
[ https://issues.apache.org/jira/browse/TRINIDAD-2288?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13412938#comment-13412938 ] Blake Sullivan commented on TRINIDAD-2288: -- The getPartialTriggers() code

[jira] [Commented] (TRINIDAD-2287) atomicity violation bugs of misusing concurrent collections

2012-07-11 Thread Blake Sullivan (JIRA)
[ https://issues.apache.org/jira/browse/TRINIDAD-2287?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13411898#comment-13411898 ] Blake Sullivan commented on TRINIDAD-2287: -- I haven't looked at all of them

[jira] [Commented] (TRINIDAD-2287) atomicity violation bugs of misusing concurrent collections

2012-07-10 Thread Blake Sullivan (JIRA)
[ https://issues.apache.org/jira/browse/TRINIDAD-2287?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13411194#comment-13411194 ] Blake Sullivan commented on TRINIDAD-2287: -- I don't understand why you think

Re: [trinidad] javascript documentation using jsdoc

2012-07-05 Thread Blake Sullivan
of the prototype. Callers would refer to this method (var myContent = TrPanelPopup.staticGetContent()) directly rather than through an instance: var thePopup = new TrPanelPopup(); var theContent = thePopup.getContent(); -- Blake Sullivan On 7/5/12 5:59 AM, Leonardo Uribe wrote: Hi I tried

[jira] [Resolved] (TRINIDAD-2273) Allow scheme for application to control UIViewRoot caching logic

2012-06-27 Thread Blake Sullivan (JIRA)
[ https://issues.apache.org/jira/browse/TRINIDAD-2273?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Blake Sullivan resolved TRINIDAD-2273. -- Resolution: Fixed Fix Version/s: 2.0.0-core Allow scheme

[jira] [Reopened] (TRINIDAD-2273) Allow scheme for application to control UIViewRoot caching logic

2012-06-27 Thread Blake Sullivan (JIRA)
[ https://issues.apache.org/jira/browse/TRINIDAD-2273?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Blake Sullivan reopened TRINIDAD-2273: -- Allow scheme for application to control UIViewRoot caching logic

[jira] [Commented] (TRINIDAD-2273) Allow scheme for application to control UIViewRoot caching logic

2012-06-27 Thread Blake Sullivan (JIRA)
[ https://issues.apache.org/jira/browse/TRINIDAD-2273?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13402671#comment-13402671 ] Blake Sullivan commented on TRINIDAD-2273: -- Reopened because this caused

[jira] [Resolved] (TRINIDAD-2273) Allow scheme for application to control UIViewRoot caching logic

2012-06-27 Thread Blake Sullivan (JIRA)
[ https://issues.apache.org/jira/browse/TRINIDAD-2273?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Blake Sullivan resolved TRINIDAD-2273. -- Resolution: Fixed Allow scheme for application to control UIViewRoot caching

[jira] [Commented] (TRINIDAD-2278) HttpSession inside a synchronized block in the class TokenCache of trinidad-impl-1.0.10.jar could cause to deadlock while used with WAS 7

2012-06-26 Thread Blake Sullivan (JIRA)
[ https://issues.apache.org/jira/browse/TRINIDAD-2278?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13401744#comment-13401744 ] Blake Sullivan commented on TRINIDAD-2278: -- As you guys figured out, this code

[jira] [Created] (TRINIDAD-2273) Allow scheme for application to control UIViewRoot caching logic

2012-06-11 Thread Blake Sullivan (JIRA)
Blake Sullivan created TRINIDAD-2273: Summary: Allow scheme for application to control UIViewRoot caching logic Key: TRINIDAD-2273 URL: https://issues.apache.org/jira/browse/TRINIDAD-2273 Project

[jira] [Created] (TRINIDAD-2248) Change component templating scheme to generate superclasses of templated components rather than the templated components themselves

2012-03-22 Thread Blake Sullivan (Created) (JIRA)
-2248 URL: https://issues.apache.org/jira/browse/TRINIDAD-2248 Project: MyFaces Trinidad Issue Type: Improvement Components: Build Affects Versions: 2.0.1-core Reporter: Blake Sullivan The current component templating scheme works

[jira] [Resolved] (TRINIDAD-2248) Change component templating scheme to generate superclasses of templated components rather than the templated components themselves

2012-03-22 Thread Blake Sullivan (Resolved) (JIRA)
[ https://issues.apache.org/jira/browse/TRINIDAD-2248?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Blake Sullivan resolved TRINIDAD-2248. -- Resolution: Fixed Fix Version/s: 2.0.2-core Fixed in revision 1304149

Re: [VOTE] Trinidad 2.0.1 (try 2)

2012-02-25 Thread Blake Sullivan
+1 -- Blake Sullivan On Feb 25, 2012, at 3:36 AM, Andy Schwartz wrote: +1. Thanks for putting this together Scott. Andy On Feb 24, 2012, at 12:30 PM, Scott O'Bryan darkar...@gmail.com wrote: Hi Everyone, I was running the tasks needed to get the Trinidad 2.0.1 release out

Re: [VOTE] Release of Trinidad 2.0.1

2012-02-22 Thread Blake Sullivan
+1 On 2/21/12 9:18 PM, Scott O'Bryan wrote: Hi Everyone, I was running the tasks needed to get the Trinidad 2.0.1 release out and now I need a vote as to whether everything looks good or not. I have committed most of the most recent submitted patches and things look to be fairly stable.

[jira] [Created] (TRINIDAD-2221) Allow ancestor components to transform and filter ComponentChanges added by their descendants

2012-02-20 Thread Blake Sullivan (Created) (JIRA)
-2221 Project: MyFaces Trinidad Issue Type: Bug Components: Components Affects Versions: 2.0.0-beta-2 Reporter: Blake Sullivan Assignee: Blake Sullivan Priority: Minor Components currently directly add changes

[jira] [Commented] (TRINIDAD-2221) Allow ancestor components to transform and filter ComponentChanges added by their descendants

2012-02-20 Thread Blake Sullivan (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/TRINIDAD-2221?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13212306#comment-13212306 ] Blake Sullivan commented on TRINIDAD-2221: -- I forgot to add that this requires

[jira] [Resolved] (TRINIDAD-2221) Allow ancestor components to transform and filter ComponentChanges added by their descendants

2012-02-20 Thread Blake Sullivan (Resolved) (JIRA)
[ https://issues.apache.org/jira/browse/TRINIDAD-2221?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Blake Sullivan resolved TRINIDAD-2221. -- Resolution: Fixed Fix Version/s: 2.0.0-beta-2 Fixed in revision 1291571

Re: [Trinidad] RequestContext.Accessibility.valueOfAlias() API

2012-02-14 Thread Blake Sullivan
I would go with valueOfDisplayName(). I would actually add a displayName() as well, just like we have name(). I am not a fan of assuming that toString() == displayName() -- Blake Sullivan On 2/14/12 4:21 AM, Andy Schwartz wrote: Thanks for the comments guys. On Mon, Feb 13, 2012 at 11:51

Re: [Trinidad] RequestContext.Accessibility.valueOfAlias() API

2012-02-14 Thread Blake Sullivan
I prefer #1. If the caller really cares about what she gets, she can call the explicit method. -- Blake Sullivan On 2/14/12 9:18 AM, Andy Schwartz wrote: On Tue, Feb 14, 2012 at 11:33 AM, Blake Sullivan blake.sulli...@oracle.com wrote: I would go with valueOfDisplayName(). I would

Re: [Trinidad] RequestContext.Accessibility.valueOfAlias() API

2012-02-14 Thread Blake Sullivan
/14/12 9:18 AM, Andy Schwartz wrote: On Tue, Feb 14, 2012 at 11:33 AM, Blake Sullivan blake.sulli...@oracle.com wrote: I would go with valueOfDisplayName(). I would actually add a displayName() as well, just like we have name(). Sounds good, will do. I am not a fan of assuming that toString

Re: [Trinidad] RequestContext.Accessibility.valueOfAlias() API

2012-02-13 Thread Blake Sullivan
This example http://www.basilv.com/psd/blog/2006/advanced-uses-of-java-5-enumsuses getDisplayName(), though given the presence of name(), I think displayName() makes more sense (Josh Bloch hates the getXXX(), setXXX() pattern) -- Blake Sullivan On 2/13/12 7:23 PM, Andy Schwartz wrote

Re: [Trinidad] RequestContext.Accessibility.valueOfAlias() API

2012-02-13 Thread Blake Sullivan
Overloaded how? The other question is that we want to be able to go from the displayName-Enum -- Blake Sullivan On 2/13/12 8:44 PM, Scott O'Bryan wrote: How would this differ from an overloaded toString()? By contract, that can be overloaded to make more sense. Scott Sent from my iPad

[jira] [Commented] (TRINIDAD-2194) Trinidad PPR blocking does not work with 2 clicks that post

2012-01-17 Thread Blake Sullivan (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/TRINIDAD-2194?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13188041#comment-13188041 ] Blake Sullivan commented on TRINIDAD-2194: -- Reverted changes to branch

[jira] [Resolved] (TRINIDAD-2197) _threadLocals in ThreadLocalUtils has a potential of unbound growth

2012-01-10 Thread Blake Sullivan (Resolved) (JIRA)
[ https://issues.apache.org/jira/browse/TRINIDAD-2197?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Blake Sullivan resolved TRINIDAD-2197. -- Resolution: Fixed Fix Version/s: 2.0.0-core Remove

[jira] [Commented] (TRINIDAD-2194) Trinidad PPR blocking does not work with 2 clicks that post

2012-01-06 Thread Blake Sullivan (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/TRINIDAD-2194?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13181667#comment-13181667 ] Blake Sullivan commented on TRINIDAD-2194: -- Resolved in trunk in revision

[jira] [Created] (TRINIDAD-2180) Deprecate invokeOnComponent in favor of visitTree

2011-12-19 Thread Blake Sullivan (Created) (JIRA)
Components: Components Affects Versions: 2.0.0-core Reporter: Blake Sullivan a partial visit using visitTree is always at least as fast as invokeOnComponent. In addition, for components controlling visiting, providing both invokeOnComponent and visitTree implementations is a source

[jira] [Resolved] (TRINIDAD-2180) Deprecate invokeOnComponent in favor of visitTree

2011-12-19 Thread Blake Sullivan (Resolved) (JIRA)
[ https://issues.apache.org/jira/browse/TRINIDAD-2180?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Blake Sullivan resolved TRINIDAD-2180. -- Resolution: Fixed Fix Version/s: 2.0.2-core Fixed in revision 1220875

[jira] [Resolved] (TRINIDAD-2176) Switch use of Bean.isDesignTime() to use Agent Capabilities

2011-12-06 Thread Blake Sullivan (Resolved) (JIRA)
[ https://issues.apache.org/jira/browse/TRINIDAD-2176?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Blake Sullivan resolved TRINIDAD-2176. -- Resolution: Fixed Fix Version/s: 2.0.2-core Resolved in revision 1211067

[jira] [Created] (TRINIDAD-2176) Switch use of Bean.isDesignTime() to use Agent Capabilities

2011-12-05 Thread Blake Sullivan (Created) (JIRA)
: Improvement Components: Archetype Affects Versions: 2.0.0-core Reporter: Blake Sullivan Trinidad uses the static Beans.isDesignTime() to determine when a particular request should generate content based differently because the execution is occurring within a visual editor

[jira] [Updated] (TRINIDAD-2176) Switch use of Bean.isDesignTime() to use Agent Capabilities

2011-12-05 Thread Blake Sullivan (Updated) (JIRA)
[ https://issues.apache.org/jira/browse/TRINIDAD-2176?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Blake Sullivan updated TRINIDAD-2176: - Status: Patch Available (was: Open) Switch use of Bean.isDesignTime() to use

Re: [VOTE] extend maximum allowed line length from 120 to 160

2011-10-28 Thread Blake Sullivan
I personally find 120 characters to be the best balance. On the bright side, I expect that once we can use the diamond operator in JDK 7, the pressure for longer lines will decrease. -- Blake Sullivan On 10/28/11 10:33 AM, Gerhard Petracek wrote: @80: -1! @rest: +0 regards, gerhard http

Re: [jira] [Created] (PORTLETBRIDGE-221) Add explicit exclusions for trinidad in 329 branch

2011-10-20 Thread Blake Sullivan
management). In the portlet (and Faces) model, render is supposed to be idempotent. -- Blake Sullivan

Re: [trinidad] cleanup

2011-10-05 Thread Blake Sullivan
I agree that we want to get rid of the impl stuff first, but even more important would be to get rid of the last of the old UIX-based renderers and the image generation code that we don't use. -- Blake Sullivan On 10/5/11 6:18 AM, Scott O'Bryan wrote: Yeah, I'm not sure we know what third

[jira] [Commented] (TRINIDAD-2141) add a new 'browser-generic' agent

2011-09-27 Thread Blake Sullivan (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/TRINIDAD-2141?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13115738#comment-13115738 ] Blake Sullivan commented on TRINIDAD-2141: -- This isn't a generic agent

Re: [jira] [Commented] (TRINIDAD-2141) add a new 'browser-generic' agent

2011-09-27 Thread Blake Sullivan
Actually, that's because the committer who checked those in, did so with no public review. -- Blake Sullivan On 9/27/11 11:12 AM, Pavitra Subramaniam wrote: On 9/27/2011 10:37 AM, Blake Sullivan (Commented) (JIRA) wrote: [ https://issues.apache.org/jira/browse/TRINIDAD-2141?page

Re: [jira] [Commented] (TRINIDAD-2141) add a new 'browser-generic' agent

2011-09-27 Thread Blake Sullivan
. -- Blake Sullivan On 9/27/11 11:32 AM, Scott O'Bryan wrote: -1 to timescale. In my experience, things that REQUIRE maintenance do not work well in OS.. Scott On 09/27/2011 12:28 PM, Matt Cooper wrote: I'm okay with genericDesktop. Perhaps this isn't a concern but I wonder if there is any value

[jira] [Commented] (TRINIDAD-2141) add a new 'browser-generic' agent

2011-09-16 Thread Blake Sullivan (JIRA)
[ https://issues.apache.org/jira/browse/TRINIDAD-2141?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13106942#comment-13106942 ] Blake Sullivan commented on TRINIDAD-2141: -- Trinidad already has a generic

[jira] [Commented] (TRINIDAD-1395) Trinidad does not work with T-Online Browser

2011-07-29 Thread Blake Sullivan (JIRA)
[ https://issues.apache.org/jira/browse/TRINIDAD-1395?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13073063#comment-13073063 ] Blake Sullivan commented on TRINIDAD-1395: -- Or the less verbose

Re: [TRINIDAD] Supporting touch capability

2011-06-13 Thread Blake Sullivan
case, then I think we should expand the values to encompass the quality of the touch events. For example, is multi-touch supported? Anyway, we know from experience that we really don't want to ever add any boolean values. -- Blake Sullivan

Re: [TRINIDAD] Supporting touch capability

2011-06-13 Thread Blake Sullivan
I think we should have one per device and we might eventually want to support some keyboard-related ones as well to include differences between real and various on-screen keyboards. -- Blake Sullivan On 6/13/11 10:52 AM, Andrew Robinson wrote: We could have it return constant strings of none

Re: [jira] [Commented] (TRINIDAD-2108) Add touch capability to the agent API to be able to determine agents that are touch screen based.

2011-06-13 Thread Blake Sullivan
Don't we want something like none for the case where no support is available? -- Blake Sullivan On 6/13/11 4:17 PM, Andrew Robinson (JIRA) wrote: [ https://issues.apache.org/jira/browse/TRINIDAD-2108?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId

Re: [core] implicit object 'component' in rendered expression (myfaces and spec bug)

2011-05-25 Thread Blake Sullivan
, or it is going to have to ensure that the context is setup and torn down around each call to isRendered. -- Blake Sullivan On 5/25/11 11:27 AM, Martin Koci wrote: Hi, for spec I've created bug few days ago: http://java.net/jira/browse/JAVASERVERFACES_SPEC_PUBLIC-1002 but I didn't realize how deep

Re: [core] performance: use indices instead of iterator (MYFACES-3130)

2011-05-10 Thread Blake Sullivan
Mike, What Martin is talking about is that if the List doesn't implement the Marker interface RandomAccess then the List may implement indexed-based access through iteration, in which case iterating the list is n^2/2 -- Blake Sullivan On 5/10/11 1:17 PM, Mike Kienenberger wrote

Re: [Trinidad][API] web.xml context-param for skin cache size

2011-04-14 Thread Blake Sullivan
I vote for 2. -- Blake Sullivan On 4/14/11 11:22 AM, Jeanne Waldman wrote: Here are some more options combined with the old top vote getters (1) MAX_CACHED_SKINS (2) MAX_SKINS_CACHED (3) MAX_SKINS_IN_CACHE (4) SKIN_MAX_CACHE_SIZE Still, my vote is Pavitra's take on Blake's, (2

Re: [Trinidad][API] web.xml context-param for skin cache size

2011-04-13 Thread Blake Sullivan
will use. Thanks, Jeanne How about org.apache.myfaces.trinidad.skin.MAX_CACHED_SKINS? SKIN_STYLE_PROVIDER_CACHE_SIZE is more specific and more technically correct, though. -- Blake Sullivan

[jira] [Created] (TRINIDAD-2086) Trinidad uses relatively common parameters names that can conflict with component ids

2011-04-08 Thread Blake Sullivan (JIRA)
Project: MyFaces Trinidad Issue Type: Bug Components: Archetype Affects Versions: 1.2.14-core , 2.0.0-beta-3 Reporter: Blake Sullivan Assignee: Blake Sullivan Trinidad uses relatively common names for some of the POST parameters that it uses

[jira] [Commented] (TRINIDAD-2085) absolute urls for icon selectors preprends context-root when it shouldn't

2011-04-07 Thread Blake Sullivan (JIRA)
[ https://issues.apache.org/jira/browse/TRINIDAD-2085?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13017222#comment-13017222 ] Blake Sullivan commented on TRINIDAD-2085: -- The fix checked into trunk checks

[jira] [Commented] (TRINIDAD-2085) absolute urls for icon selectors preprends context-root when it shouldn't

2011-04-07 Thread Blake Sullivan (JIRA)
[ https://issues.apache.org/jira/browse/TRINIDAD-2085?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13017241#comment-13017241 ] Blake Sullivan commented on TRINIDAD-2085: -- Looks good. Calling

[jira] [Updated] (TRINIDAD-2078) SKIP_ITERATION forces visit of non-rendered components

2011-04-04 Thread Blake Sullivan (JIRA)
[ https://issues.apache.org/jira/browse/TRINIDAD-2078?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Blake Sullivan updated TRINIDAD-2078: - Status: Patch Available (was: Open) SKIP_ITERATION forces visit of non-rendered

[jira] [Updated] (TRINIDAD-2078) SKIP_ITERATION forces visit of non-rendered components

2011-04-04 Thread Blake Sullivan (JIRA)
[ https://issues.apache.org/jira/browse/TRINIDAD-2078?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Blake Sullivan updated TRINIDAD-2078: - Status: Open (was: Patch Available) SKIP_ITERATION forces visit of non-rendered

[jira] [Commented] (TRINIDAD-2078) SKIP_ITERATION forces visit of non-rendered components

2011-04-04 Thread Blake Sullivan (JIRA)
[ https://issues.apache.org/jira/browse/TRINIDAD-2078?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13015621#comment-13015621 ] Blake Sullivan commented on TRINIDAD-2078: -- The proposed patch fixes

[jira] [Commented] (TRINIDAD-1496) Need org.apache.myfaces.trinidad.skin.Icon to expose the raw content value instead of just getImageURI

2011-04-04 Thread Blake Sullivan (JIRA)
[ https://issues.apache.org/jira/browse/TRINIDAD-1496?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13015644#comment-13015644 ] Blake Sullivan commented on TRINIDAD-1496: -- I guess a getRawURI function

[jira] [Commented] (TRINIDAD-1496) Need org.apache.myfaces.trinidad.skin.Icon to expose the raw content value instead of just getImageURI

2011-04-04 Thread Blake Sullivan (JIRA)
[ https://issues.apache.org/jira/browse/TRINIDAD-1496?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13015647#comment-13015647 ] Blake Sullivan commented on TRINIDAD-1496: -- I forgot to say that I agree

[trinidad][api] TRINIDAD-2078 SKIP_ITERATION forces visit of non-rendered components

2011-04-04 Thread Blake Sullivan
) And made it the default implementation of visitChildrenWithoutIterating(), which should be sufficient for all of the subclasses of UIXCollection that ship with Trinidad. It also happens to be precisely the same behavior as the old code we are fixing. -- Blake Sullivan

[jira] [Created] (TRINIDAD-2074) RowKeySetAttributeChange doesn't check if oldValue is non-null and a RowKeySet before casting and dereferencing

2011-03-30 Thread Blake Sullivan (JIRA)
://issues.apache.org/jira/browse/TRINIDAD-2074 Project: MyFaces Trinidad Issue Type: Bug Components: Components Affects Versions: 1.2.12-core, 2.0.0-beta-3 Reporter: Blake Sullivan The problem is in the GetOldValueAndUpdate.invokeContextCallback

Re: [VOTE] Release of Trinidad Maven Plugins v. 2.0.5

2011-03-24 Thread Blake Sullivan
+1 -- Blake Sullivan On 3/24/11 9:32 AM, Scott O'Bryan wrote: Hello Everyone, I was running the tasks needed to get the Trinidad Maven Plugins v. 2.0.5 released and not I need a vote as to whether everything looks good or not. There were some minor fixes and the plugins now mark

[jira] [Commented] (TRINIDAD-2067) setUpEncodingContext called twice on all partial page rendered roots during optimized PPR

2011-03-21 Thread Blake Sullivan (JIRA)
[ https://issues.apache.org/jira/browse/TRINIDAD-2067?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13009284#comment-13009284 ] Blake Sullivan commented on TRINIDAD-2067: -- Rather than adding an api, I went

[jira] [Updated] (TRINIDAD-2067) setUpEncodingContext called twice on all partial page rendered roots during optimized PPR

2011-03-21 Thread Blake Sullivan (JIRA)
[ https://issues.apache.org/jira/browse/TRINIDAD-2067?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Blake Sullivan updated TRINIDAD-2067: - Status: Patch Available (was: Open) setUpEncodingContext called twice on all

[jira] [Updated] (TRINIDAD-2067) setUpEncodingContext called twice on all partial page rendered roots during optimized PPR

2011-03-21 Thread Blake Sullivan (JIRA)
[ https://issues.apache.org/jira/browse/TRINIDAD-2067?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Blake Sullivan updated TRINIDAD-2067: - Resolution: Fixed Fix Version/s: 2.0.0-beta-3 Status: Resolved

[jira] [Commented] (TRINIDAD-2067) setUpEncodingContext called twice on all partial page rendered roots during optimized PPR

2011-03-21 Thread Blake Sullivan (JIRA)
[ https://issues.apache.org/jira/browse/TRINIDAD-2067?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13009293#comment-13009293 ] Blake Sullivan commented on TRINIDAD-2067: -- resolved in 2.0.beta3 in revision

Re: PMC chair of Apache MyFaces changed

2011-03-17 Thread Blake Sullivan
Matthias, Thanks for all of your hard work. Gerhard, congratulations and I look forward to working with you. -- Blake On 3/17/11 12:20 AM, Matthias Wessendorf wrote: Hi, I am stepping back from being the Apache MyFaces PMC chair. The MyFaces PMC did vote (internally) that Gerhard Petracek

[trinidad][api] (TRINIDAD-2067) setUpEncodingContext called twice on all partial page rendered roots during optimized PPR

2011-03-17 Thread Blake Sullivan
The below api is a little gross, but I don't see a better solution to the problem. -- Blake Sullivan Original Message Subject: [jira] Created: (TRINIDAD-2067) setUpEncodingContext called twice on all partial page rendered roots during optimized PPR Date: Fri, 18 Mar 2011

[jira] Commented: (TRINIDAD-2049) At Serialization checking flag to check that all of the Session contents serialize correctly at the end of the request

2011-03-10 Thread Blake Sullivan (JIRA)
[ https://issues.apache.org/jira/browse/TRINIDAD-2049?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13005249#comment-13005249 ] Blake Sullivan commented on TRINIDAD-2049: -- resolved for 1.2.x branch

Re: [Trinidad] New utility method: ComponentUtils.getNonFlatteningAncestor()

2011-03-10 Thread Blake Sullivan
Looks good. -- Blake Sullivan On 3/10/11 11:36 AM, Andy Schwartz wrote: Gang - I would like to add a utility method for locating the nearest non-flattening ancestor component, as discussed here: https://issues.apache.org/jira/browse/TRINIDAD-2056 And shown in this patch: https

Re: [Trinidad] ChangeManagerWrapper API

2011-03-10 Thread Blake Sullivan
. -- Blake Sullivan On 3/10/11 12:20 PM, Scott O'Bryan wrote: I suppose I don't mind the currently implementation but I'm not sure I understand Point #2. Adding an interface does not change binary backward compatibility does it? Likewise, having a public getWrapped() method wouldn't have any

[jira] Created: (TRINIDAD-2060) Make Optimized PPR the default with a public flag to disable it at the web.xml and application levels

2011-03-10 Thread Blake Sullivan (JIRA)
/browse/TRINIDAD-2060 Project: MyFaces Trinidad Issue Type: Improvement Affects Versions: 2.0.0-beta-3 Reporter: Blake Sullivan Assignee: Blake Sullivan Priority: Minor Optimized PPR is currently enabled using the internal web.xml

[jira] Commented: (TRINIDAD-2060) Make Optimized PPR the default with a public flag to disable it at the web.xml and application levels

2011-03-10 Thread Blake Sullivan (JIRA)
[ https://issues.apache.org/jira/browse/TRINIDAD-2060?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13005435#comment-13005435 ] Blake Sullivan commented on TRINIDAD-2060: -- The name of the property

[jira] Updated: (TRINIDAD-2060) Make Optimized PPR the default with a public flag to disable it at the web.xml and application levels

2011-03-10 Thread Blake Sullivan (JIRA)
[ https://issues.apache.org/jira/browse/TRINIDAD-2060?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Blake Sullivan updated TRINIDAD-2060: - Status: Patch Available (was: Open) Make Optimized PPR the default with a public

[jira] Updated: (TRINIDAD-2060) Make Optimized PPR the default with a public flag to disable it at the web.xml and application levels

2011-03-10 Thread Blake Sullivan (JIRA)
[ https://issues.apache.org/jira/browse/TRINIDAD-2060?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Blake Sullivan updated TRINIDAD-2060: - Resolution: Fixed Fix Version/s: 2.0.0-beta-3 Status: Resolved

[jira] Commented: (TRINIDAD-2057) UIXTree/UIXTreeTable/UIXTable RowKeySets require that their attributes are only fetched when the component is in context

2011-03-10 Thread Blake Sullivan (JIRA)
[ https://issues.apache.org/jira/browse/TRINIDAD-2057?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13005452#comment-13005452 ] Blake Sullivan commented on TRINIDAD-2057: -- Fixed in 1.2.12.5 in revision

Re: [jira] Created: (TRINIDAD-2055) Introduce ChangeManager wrapper class

2011-03-09 Thread Blake Sullivan
+1 -- Blake On 3/9/11 12:32 PM, Pavitra Subramaniam wrote: +1 Thanks Pavitra On 3/9/2011 11:29 AM, Andy Schwartz (JIRA) wrote: Introduce ChangeManager wrapper class - Key: TRINIDAD-2055 URL:

  1   2   3   4   >