Result ( Was: [VOTE] Release of MyFaces Core 2.2.3 )

2014-04-28 Thread Leonardo Uribe
Hi Thanks to all people who vote We have 6 +1 Werner Punz Michael Kurz Martin Koci Grant Smith Mike Kienenberger Leonardo Uribe so we can continue with the necessary steps to release MyFaces Core 2.2.3 regards, Leonardo Uribe

[VOTE] Release of MyFaces Core 2.2.3

2014-04-22 Thread Leonardo Uribe
Hi, I was running the needed tasks to get the 2.2.3 release of Apache MyFaces core out. The artifacts passed the TCK test of Feb 2013 (jsftck-2.2_26-Feb-2013.zip). Please note that this vote concerns all of the following parts: 1. Maven artifact group org.apache.myfaces.shared v4.2.2 [1] 2.

Re: [VOTE] Release of MyFaces Core 2.2.3

2014-04-22 Thread Leonardo Uribe
+1 2014-04-22 12:20 GMT+02:00 Leonardo Uribe lu4...@gmail.com: Hi, I was running the needed tasks to get the 2.2.3 release of Apache MyFaces core out. The artifacts passed the TCK test of Feb 2013 (jsftck-2.2_26-Feb-2013.zip). Please note that this vote concerns all of the following

Re: [VOTE] Release of MyFaces Core 2.2.3

2014-04-22 Thread Mike Kienenberger
- signatures and checksums match - source builds - apache rat passes +1 Below are the linux commands I used to verify the release of the myfaces-core-assembly-2.2.3-src files: = # check checksums find . -name '*.md5' -exec cat {} \; -printf ' %f\n'

Re: [VOTE] Release of MyFaces Core 2.2.3

2014-04-22 Thread Grant Smith
+1 On Tue, Apr 22, 2014 at 5:48 AM, Mike Kienenberger mkien...@gmail.comwrote: - signatures and checksums match - source builds - apache rat passes +1 Below are the linux commands I used to verify the release of the myfaces-core-assembly-2.2.3-src files:

Re: [VOTE] Release of MyFaces Core 2.2.3

2014-04-22 Thread Martin Kočí
+1 2014-04-22 12:20 GMT+02:00 Leonardo Uribe lu4...@gmail.com: Hi, I was running the needed tasks to get the 2.2.3 release of Apache MyFaces core out. The artifacts passed the TCK test of Feb 2013 (jsftck-2.2_26-Feb-2013.zip). Please note that this vote concerns all of the following

Re: [VOTE] Release of MyFaces Core 2.2.3

2014-04-22 Thread Michael Kurz
+1 Am 22.04.2014 um 18:16 schrieb Martin Kočí martin.kocicak.k...@gmail.com: +1 2014-04-22 12:20 GMT+02:00 Leonardo Uribe lu4...@gmail.com: Hi, I was running the needed tasks to get the 2.2.3 release of Apache MyFaces core out. The artifacts passed the TCK test of Feb 2013

Re: [VOTE] Release of MyFaces Core 2.2.3

2014-04-22 Thread Werner Punz
+1 Werner Am 22.04.14 12:20, schrieb Leonardo Uribe: Hi, I was running the needed tasks to get the 2.2.3 release of Apache MyFaces core out. The artifacts passed the TCK test of Feb 2013 (jsftck-2.2_26-Feb-2013.zip). Please note that this vote concerns all of the following parts: 1.

Re: [VOTE] Release of MyFaces Core 2.2.3

2014-04-17 Thread Mark Struberg
+1 LieGrue, strub On Wednesday, 16 April 2014, 19:18, Leonardo Uribe lu4...@gmail.com wrote: +1 2014-04-16 19:17 GMT+02:00 Leonardo Uribe lu4...@gmail.com: Hi, I was running the needed tasks to get the 2.2.3 release of Apache MyFaces core out. The artifacts passed the TCK test of Feb

Re: [VOTE] Release of MyFaces Core 2.2.3

2014-04-17 Thread Mike Kienenberger
Sorry. -1 Rat shows that we have several non-trivial files that are missing headers: impl/src/test/resources/org/apache/myfaces/view/facelets/pss/acid/resources/testComposite/dynComp_1.xhtml

Re: [VOTE] Release of MyFaces Core 2.2.3

2014-04-17 Thread Leonardo Uribe
Hi Those files are used for test only. Is it so important to block a quick fix release? Regards Leonardo On Apr 17, 2014 11:36 AM, Mike Kienenberger mkien...@gmail.com wrote: Sorry. -1 Rat shows that we have several non-trivial files that are missing headers:

Re: [VOTE] Release of MyFaces Core 2.2.3

2014-04-17 Thread Mike Kienenberger
I've cleaned up all of these files. Trunk builds and passes rat, so a new release candidate should pass rat as well. On Thu, Apr 17, 2014 at 5:35 AM, Mike Kienenberger mkien...@gmail.com wrote: Sorry. -1 Rat shows that we have several non-trivial files that are missing headers:

Re: [VOTE] Release of MyFaces Core 2.2.3

2014-04-17 Thread Mike Kienenberger
You asked about licensing on test files the last time this came up as well so I will point to my previous reply for that topic: http://mail-archives.apache.org/mod_mbox/myfaces-dev/201209.mbox/%3ccam1yojbz2jn5obhkfavo-v5rvfauzsk0yjeoj66pm+wejk_...@mail.gmail.com%3E As for a quick fix release, It

Re: [VOTE] Release of MyFaces Core 2.2.3

2014-04-17 Thread Mike Kienenberger
For what it's worth, if you and two other people disagree that the licensing of these files should be a blocking issue, you can still do a release. As the release manager, the final decision is yours so long as you have a majority approval. [1] [1]

Re: [VOTE] Release of MyFaces Core 2.2.3

2014-04-17 Thread Leonardo Uribe
Ok, so it is unavoidable. I didn't knew that. The problem is rat plugin is never executed automatically as part of the release, so there is no chance to detect and fix it early. I'll take a look at that. On Apr 17, 2014 12:54 PM, Mike Kienenberger mkien...@gmail.com wrote: You asked about

Re: [VOTE] Release of MyFaces Core 2.2.3

2014-04-17 Thread Mike Kienenberger
On Thu, Apr 17, 2014 at 7:10 AM, Leonardo Uribe lu4...@gmail.com wrote: The problem is rat plugin is never executed automatically as part of the release, so there is no chance to detect and fix it early. I'll take a look at that. I really hate having to vote against a release just because we

Re: [VOTE] Release of MyFaces Core 2.2.3

2014-04-17 Thread Leonardo Uribe
I usually do wiki page for each release. The one for 2.2.3 is here: http://wiki.apache.org/myfaces/CoreRelease223 There are two options, or we put the rat plugin command at the beginning, or we add the plugin when the release preparations are done. The idea is if a file miss the license, the rat

Re: [VOTE] Release of MyFaces Core 2.2.3

2014-04-17 Thread Leonardo Uribe
Hi I have tried adding this fragment on core/parent/pom.xml profile idprepare-release/id activation property nameprepareRelease/name /property /activation build plugins

[VOTE] Release of MyFaces Core 2.2.3

2014-04-16 Thread Leonardo Uribe
Hi, I was running the needed tasks to get the 2.2.3 release of Apache MyFaces core out. The artifacts passed the TCK test of Feb 2013 (jsftck-2.2_26-Feb-2013.zip). Please note that this vote concerns all of the following parts: 1. Maven artifact group org.apache.myfaces.shared v4.2.2 [1] 2.

Re: [VOTE] Release of MyFaces Core 2.2.3

2014-04-16 Thread Leonardo Uribe
+1 2014-04-16 19:17 GMT+02:00 Leonardo Uribe lu4...@gmail.com: Hi, I was running the needed tasks to get the 2.2.3 release of Apache MyFaces core out. The artifacts passed the TCK test of Feb 2013 (jsftck-2.2_26-Feb-2013.zip). Please note that this vote concerns all of the following

Re: [VOTE] release of MyFaces Core 2.2.3

2014-04-12 Thread Michael Kurz
-1 I have serious problems with version 2.2.3 provided by Leo and with the current snapshot in one of my examples. It seems, that there is some problem with resources or templates or both. The application works and looks fine with 2.2.1 and 2.2.2 but not with 2.2.3 or the current snapshot.

Re: [VOTE] release of MyFaces Core 2.2.3

2014-04-12 Thread Leonardo Uribe
Hi We have only 6 changes in the release, and none of them are related to templates or resources. (3 for html friendly markup, 1 for the wrappers, 1 for the PostRestoreStateEvent, 1 for for attribute in a converter). Could you please give us more information about the specific example?. So I can

Re: [VOTE] release of MyFaces Core 2.2.3

2014-04-12 Thread Michael Kurz
I created MYFACES-3882 including my application. Best regards Michi Am 12.04.2014 um 15:47 schrieb Leonardo Uribe lu4...@gmail.com: Hi We have only 6 changes in the release, and none of them are related to templates or resources. (3 for html friendly markup, 1 for the wrappers, 1 for

Re: [VOTE] release of MyFaces Core 2.2.3

2014-04-12 Thread Leonardo Uribe
Hi The problem is caused because h:outputScript and h:outputStylesheet are the only components that does not have implemented its attributes in the component class, and instead they use an instance of UIOutput. This cause a problem with the new algorithm in place for html5 friendly markup,

Re: [VOTE] release of MyFaces Core 2.2.3

2014-04-11 Thread Werner Punz
+1 Am 08.04.14 17:11, schrieb Leonardo Uribe: Hi, I was running the needed tasks to get the 2.2.3 release of Apache MyFaces core out. The artifacts passed the TCK test of Feb 2013 (jsftck-2.2_26-Feb-2013.zip). Please note that this vote concerns all of the following parts: 1. Maven

Re: [VOTE] release of MyFaces Core 2.2.3

2014-04-10 Thread Grant Smith
, I was running the needed tasks to get the 2.2.3 release of Apache From: Leonardo Uribe lu4...@gmail.com To: MyFaces Development dev@myfaces.apache.org, Date: 04/08/2014 11:11 AM Subject: [VOTE] release of MyFaces Core 2.2.3 -- Hi, I was running the needed

Re: [VOTE] release of MyFaces Core 2.2.3

2014-04-09 Thread Paul Nicolucci
+1 Regards, Paul Nicolucci From: Leonardo Uribe lu4...@gmail.com To: MyFaces Development dev@myfaces.apache.org, Date: 04/08/2014 11:11 AM Subject:[VOTE] release of MyFaces Core 2.2.3 Hi, I was running the needed tasks to get the 2.2.3 release of Apache MyFaces core out

[VOTE] release of MyFaces Core 2.2.3

2014-04-08 Thread Leonardo Uribe
Hi, I was running the needed tasks to get the 2.2.3 release of Apache MyFaces core out. The artifacts passed the TCK test of Feb 2013 (jsftck-2.2_26-Feb-2013.zip). Please note that this vote concerns all of the following parts: 1. Maven artifact group org.apache.myfaces.shared v4.2.2 [1] 2.

Re: [VOTE] release of MyFaces Core 2.2.3

2014-04-08 Thread Leonardo Uribe
+1 2014-04-08 17:11 GMT+02:00 Leonardo Uribe lu4...@gmail.com: Hi, I was running the needed tasks to get the 2.2.3 release of Apache MyFaces core out. The artifacts passed the TCK test of Feb 2013 (jsftck-2.2_26-Feb-2013.zip). Please note that this vote concerns all of the following