Hi!
So I am fine by adding some Framework-Adapter specified stuff to the
OrchestraServletFilter - instead of creating a new filter.
Isn't OrchestraServletFilter currently optional [1]? Using it to set up
the FrameworkAdapter would make it mandatory...
Sorry Mario, I should have
On Sun, 2007-08-19 at 13:07 +0200, Mario Ivankovits wrote:
I am currently cleaning up the RequestParameterProvider (as proposed by
Matthias). I'll now provide a FacesContextFactory and the filter.
When testing the filter I've found, that it also requires the
FrameworkAdapter which requires the
Hi,
looks like it's an orchestra day, today :-)
I read the other mail from Simon on the frameworkAdapter, where he
suggests to use a filter.
However, I noticed that several filters are already used by orchestra,
like to one to wrap the request
(RequestParameterResponseWrapper)
Why not using a
Hi!
However, I noticed that several filters are already used by orchestra,
like to one to wrap the request
(RequestParameterResponseWrapper)
BTW also something which should make it into a myfaces-commons.
Why not using a FacesContextFactoryImpl ?
Hehe, we tried several things to make
The only advantage of the current way (servlet filter) is, that it works
in an mixed webapp environment (JSF/JSP)
However, we can provide your's as the default and provide mine as an
alternative if we would like to.
jo, that's why I think the framework-adapter might be fine in a filter ?!
-M
Hi!
The only advantage of the current way (servlet filter) is, that it works
in an mixed webapp environment (JSF/JSP)
However, we can provide your's as the default and provide mine as an
alternative if we would like to.
jo, that's why I think the framework-adapter might be fine in a
On Sat, 2007-08-18 at 14:51 +0200, simon wrote:
On Sat, 2007-08-18 at 14:24 +0200, Mario Ivankovits wrote:
The JsfFrameworkAdapter already depends on the OrchestraServletFilter
where we setup two thread-locals to get access to the request/response
object outside of a ready setup
On Sat, 2007-08-18 at 14:24 +0200, Mario Ivankovits wrote:
Hi!
The only advantage of the current way (servlet filter) is, that it works
in an mixed webapp environment (JSF/JSP)
However, we can provide your's as the default and provide mine as an
alternative if we would like to.
Hi!
Ok, I've created a patch for review.
My stupid email client wraps lines at 80 chars, so I've attached it
instead of providing it inline.
Using this place also to configure the FrameworkAdapter was exactly what
I thought too :-)
Just, maybe we can use frameworkAdapterClass as
