Re: Unit test failing? (was: Re: [VOTE] release for myfaces core 2.0.0)

2010-04-15 Thread Matthias Wessendorf
These two revisions cause the problem: http://svn.apache.org/viewvc?view=revisionrevision=933814 http://svn.apache.org/viewvc?view=revisionrevision=933812 On Thu, Apr 15, 2010 at 7:43 AM, Matthias Wessendorf mat...@apache.org wrote: Yesterday I mentioned the same, on trunk I am on Linux,

Re: Unit test failing? (was: Re: [VOTE] release for myfaces core 2.0.0)

2010-04-15 Thread Leonardo Uribe
Hi In my machine works fine. I compiled sources on both Linux and Windows. regards, Leonardo Uribe 2010/4/15 Matthias Wessendorf mat...@apache.org These two revisions cause the problem: http://svn.apache.org/viewvc?view=revisionrevision=933814

Re: Unit test failing? (was: Re: [VOTE] release for myfaces core 2.0.0)

2010-04-15 Thread Matthias Wessendorf
that's funny :-) What JDK ? 1.5 ? I am on 1.6.x = mat...@woody:~/work/source/Apache/myfaces/trunk$ mvn -v Apache Maven 2.2.1 (r801777; 2009-08-06 21:16:01+0200) Java version: 1.6.0_13 Java home: /java/jdk1.6.0_13/jre Default locale: en_US, platform encoding: UTF-8 OS name: linux version:

Re: Unit test failing? (was: Re: [VOTE] release for myfaces core 2.0.0)

2010-04-15 Thread Jan-Kees van Andel
I just runned the build on Windows Vista x64: D:\dev\work\myfaces2\core_2_0_0mvn --version Maven version: 2.0.10 Java version: 1.6.0_14 OS name: windows vista version: 6.0 arch: amd64 Family: windows The tests worked fine. @Matthias: Can you see which test method is causing the issue and which

Re: Unit test failing? (was: Re: [VOTE] release for myfaces core 2.0.0)

2010-04-15 Thread Werner Punz
I can reproduce the problem here in OSX, the JDK version might be the problem here, I am on Java6 here. Werner Am 15.04.10 08:55, schrieb Leonardo Uribe: Hi In my machine works fine. I compiled sources on both Linux and Windows. regards, Leonardo Uribe 2010/4/15 Matthias Wessendorf

Re: Unit test failing? (was: Re: [VOTE] release for myfaces core 2.0.0)

2010-04-15 Thread Matthias Wessendorf
Hey Jan, these two new methods: http://svn.apache.org/viewvc?view=revisionrevision=933814 http://svn.apache.org/viewvc?view=revisionrevision=933812 On Thu, Apr 15, 2010 at 9:22 AM, Jan-Kees van Andel jankeesvanan...@gmail.com wrote: I just runned the build on Windows Vista x64:

Re: Unit test failing? (was: Re: [VOTE] release for myfaces core 2.0.0)

2010-04-15 Thread Werner Punz
Ok here is some additional information: testsuite failures=2 time=0.037 errors=0 skipped=0 tests=6 name=org.apache.myfaces.renderkit.html.HtmlTextRendererTest properties property name=java.runtime.name value=Java(TM) SE Runtime Environment/ property name=sun.boot.library.path

Re: Unit test failing? (was: Re: [VOTE] release for myfaces core 2.0.0)

2010-04-15 Thread Jan-Kees van Andel
Hrm, maybe an encoding issue? Also ran the tests from IntelliJ. Worked fine too... /JK 2010/4/15 Werner Punz werner.p...@gmail.com Ok here is some additional information: testsuite failures=2 time=0.037 errors=0 skipped=0 tests=6 name=org.apache.myfaces.renderkit.html.HtmlTextRendererTest

Re: Unit test failing? (was: Re: [VOTE] release for myfaces core 2.0.0)

2010-04-15 Thread Werner Punz
Ok the affected part is the escape quoting, which had a bug recently which Jakob fixed. inputText.getAttributes().put(onchange, alert('test')); The test checks for following: assertTrue(output.contains(apos;alert(\\apos;test\\apos;)apos;)); but the output string I am getting here is:

Re: Unit test failing? (was: Re: [VOTE] release for myfaces core 2.0.0)

2010-04-15 Thread Werner Punz
Could also be a simple encoding issue which is more likely on a second thought (and as Jan has pointed out), the replaceAll is highly unlikely to be inconsistent in its weird behavior, never encountered that. Anyway as I said I will have a look as soon as it is possible for me (otherwise

Re: Unit test failing? (was: Re: [VOTE] release for myfaces core 2.0.0)

2010-04-15 Thread Jakob Korherr
On my machine it all works fine. I'm using Mac OS X 10.6.3, Java 1.6.0_17 and Maven 2.2.1. Just a guess in the blue - The changes I applied are on shared. Did you guys remember to rebuild shared before running the test on impl? Regards, Jakob 2010/4/15 Werner Punz werner.p...@gmail.com Could

Re: Unit test failing? (was: Re: [VOTE] release for myfaces core 2.0.0)

2010-04-15 Thread Jan-Kees van Andel
I did some quick debugging, but I don't see any usual suspect. The string replace functions don't use special String methods. It's all hand written and should be platform independent AFAICS. I quess it's an encoding issue or Jakob's dependency suggestion. /JK 2010/4/15 Jakob Korherr

Re: Unit test failing? (was: Re: [VOTE] release for myfaces core 2.0.0)

2010-04-15 Thread Werner Punz
Hi Jan the problem is in the referenced shared version in the pom of the impl on the trunk! It points to a 4.0.1-SNAPSHOT which some way along the line got the fix in, but if you have an older build lingering around which does not have the fix, the test fails. The problem is it never gets

Unit test failing? (was: Re: [VOTE] release for myfaces core 2.0.0)

2010-04-14 Thread Matthias Wessendorf
Yesterday I mentioned the same, on trunk I am on Linux, Werner is on OS X. Jakob/Leo: r u windoze ? Thx, Matthias PS: I changed the subject to not hijack the vote ;-) On Thu, Apr 15, 2010 at 7:37 AM, Werner Punz werner.p...@gmail.com wrote: Before I am giving my vote here, there is still a