Re: Thoughts on deprecating LOG_VERSION 2 and making the default LOG_VERSION 3
Yes, please! Brian. On Fri, Nov 8, 2019 at 10:08 AM will sanfilippo wrote: > Fine with me too :-) > > > On Nov 8, 2019, at 8:02 AM, marko kiiskila wrote: > > > > > > > >> On 7 Nov 2019, at 16.50, Christopher Collins wrote: > >> > >> On Thu, Nov 07, 2019 at 11:56:36AM -0800, Vipul Rahane wrote: > >>> Hello, > >>> > >>> LOG_VERSION 2 has been around for quite some time but is mostly just a > >>> string based log. LOG_VERSION 3 supports string based logs as well as > >>> others. LOG_VERSION 2 does not play well with the MCUmgr mobile > library as > >>> well. > >>> > >>> I would like to suggest getting rid of LOG_VERSION 2 which would allow > us > >>> to make the code a bit simpler and not worrying about backwards > >>> compatibility. > >>> > >>> This discussion was mainly triggered by a PR > >>> https://github.com/apache/mynewt-core/pull/2087 by Jerzy for adding > back > >>> string based reboot log just to make it work with LOG_VERSION 2. > >>> > >>> LOG_VERSION 2 also doesn't play well with the MCUmgr mobile library. > >>> > >>> I suggest we deprecate LOG_VERSION 2 and make the default 3 going > forward. > >> > >> I agree. Version 3 has been around for quite a while (two years?) and > >> it is superior to version 2. I am fine with dropping support for > >> version 2. > >> > > > > I’d ok with that one as well. > >
Re: Thoughts on deprecating LOG_VERSION 2 and making the default LOG_VERSION 3
Fine with me too :-) > On Nov 8, 2019, at 8:02 AM, marko kiiskila wrote: > > > >> On 7 Nov 2019, at 16.50, Christopher Collins wrote: >> >> On Thu, Nov 07, 2019 at 11:56:36AM -0800, Vipul Rahane wrote: >>> Hello, >>> >>> LOG_VERSION 2 has been around for quite some time but is mostly just a >>> string based log. LOG_VERSION 3 supports string based logs as well as >>> others. LOG_VERSION 2 does not play well with the MCUmgr mobile library as >>> well. >>> >>> I would like to suggest getting rid of LOG_VERSION 2 which would allow us >>> to make the code a bit simpler and not worrying about backwards >>> compatibility. >>> >>> This discussion was mainly triggered by a PR >>> https://github.com/apache/mynewt-core/pull/2087 by Jerzy for adding back >>> string based reboot log just to make it work with LOG_VERSION 2. >>> >>> LOG_VERSION 2 also doesn't play well with the MCUmgr mobile library. >>> >>> I suggest we deprecate LOG_VERSION 2 and make the default 3 going forward. >> >> I agree. Version 3 has been around for quite a while (two years?) and >> it is superior to version 2. I am fine with dropping support for >> version 2. >> > > I’d ok with that one as well.
Re: Thoughts on deprecating LOG_VERSION 2 and making the default LOG_VERSION 3
+1 for deprecating LOG_VERSION 2 Miguel Azevedo On Fri, Nov 8, 2019 at 5:56 PM Gonçalo Alexandre wrote: > > +1 for this change. We also had some problems with LOG_VERSION 2 and the > MCUmgr libraries for android and ios. > > On Fri, Nov 8, 2019 at 4:04 PM marko kiiskila wrote: > > > > > > > > On 7 Nov 2019, at 16.50, Christopher Collins wrote: > > > > > > On Thu, Nov 07, 2019 at 11:56:36AM -0800, Vipul Rahane wrote: > > >> Hello, > > >> > > >> LOG_VERSION 2 has been around for quite some time but is mostly just a > > >> string based log. LOG_VERSION 3 supports string based logs as well as > > >> others. LOG_VERSION 2 does not play well with the MCUmgr mobile library > > as > > >> well. > > >> > > >> I would like to suggest getting rid of LOG_VERSION 2 which would allow > > us > > >> to make the code a bit simpler and not worrying about backwards > > >> compatibility. > > >> > > >> This discussion was mainly triggered by a PR > > >> https://github.com/apache/mynewt-core/pull/2087 by Jerzy for adding > > back > > >> string based reboot log just to make it work with LOG_VERSION 2. > > >> > > >> LOG_VERSION 2 also doesn't play well with the MCUmgr mobile library. > > >> > > >> I suggest we deprecate LOG_VERSION 2 and make the default 3 going > > forward. > > > > > > I agree. Version 3 has been around for quite a while (two years?) and > > > it is superior to version 2. I am fine with dropping support for > > > version 2. > > > > > > > I’d ok with that one as well.
Re: Thoughts on deprecating LOG_VERSION 2 and making the default LOG_VERSION 3
+1 for this change. We also had some problems with LOG_VERSION 2 and the MCUmgr libraries for android and ios. On Fri, Nov 8, 2019 at 4:04 PM marko kiiskila wrote: > > > > On 7 Nov 2019, at 16.50, Christopher Collins wrote: > > > > On Thu, Nov 07, 2019 at 11:56:36AM -0800, Vipul Rahane wrote: > >> Hello, > >> > >> LOG_VERSION 2 has been around for quite some time but is mostly just a > >> string based log. LOG_VERSION 3 supports string based logs as well as > >> others. LOG_VERSION 2 does not play well with the MCUmgr mobile library > as > >> well. > >> > >> I would like to suggest getting rid of LOG_VERSION 2 which would allow > us > >> to make the code a bit simpler and not worrying about backwards > >> compatibility. > >> > >> This discussion was mainly triggered by a PR > >> https://github.com/apache/mynewt-core/pull/2087 by Jerzy for adding > back > >> string based reboot log just to make it work with LOG_VERSION 2. > >> > >> LOG_VERSION 2 also doesn't play well with the MCUmgr mobile library. > >> > >> I suggest we deprecate LOG_VERSION 2 and make the default 3 going > forward. > > > > I agree. Version 3 has been around for quite a while (two years?) and > > it is superior to version 2. I am fine with dropping support for > > version 2. > > > > I’d ok with that one as well.
Re: Thoughts on deprecating LOG_VERSION 2 and making the default LOG_VERSION 3
> On 7 Nov 2019, at 16.50, Christopher Collins wrote: > > On Thu, Nov 07, 2019 at 11:56:36AM -0800, Vipul Rahane wrote: >> Hello, >> >> LOG_VERSION 2 has been around for quite some time but is mostly just a >> string based log. LOG_VERSION 3 supports string based logs as well as >> others. LOG_VERSION 2 does not play well with the MCUmgr mobile library as >> well. >> >> I would like to suggest getting rid of LOG_VERSION 2 which would allow us >> to make the code a bit simpler and not worrying about backwards >> compatibility. >> >> This discussion was mainly triggered by a PR >> https://github.com/apache/mynewt-core/pull/2087 by Jerzy for adding back >> string based reboot log just to make it work with LOG_VERSION 2. >> >> LOG_VERSION 2 also doesn't play well with the MCUmgr mobile library. >> >> I suggest we deprecate LOG_VERSION 2 and make the default 3 going forward. > > I agree. Version 3 has been around for quite a while (two years?) and > it is superior to version 2. I am fine with dropping support for > version 2. > I’d ok with that one as well.
Re: Thoughts on deprecating LOG_VERSION 2 and making the default LOG_VERSION 3
On Thu, Nov 07, 2019 at 11:56:36AM -0800, Vipul Rahane wrote: > Hello, > > LOG_VERSION 2 has been around for quite some time but is mostly just a > string based log. LOG_VERSION 3 supports string based logs as well as > others. LOG_VERSION 2 does not play well with the MCUmgr mobile library as > well. > > I would like to suggest getting rid of LOG_VERSION 2 which would allow us > to make the code a bit simpler and not worrying about backwards > compatibility. > > This discussion was mainly triggered by a PR > https://github.com/apache/mynewt-core/pull/2087 by Jerzy for adding back > string based reboot log just to make it work with LOG_VERSION 2. > > LOG_VERSION 2 also doesn't play well with the MCUmgr mobile library. > > I suggest we deprecate LOG_VERSION 2 and make the default 3 going forward. I agree. Version 3 has been around for quite a while (two years?) and it is superior to version 2. I am fine with dropping support for version 2. Chris
Thoughts on deprecating LOG_VERSION 2 and making the default LOG_VERSION 3
Hello, LOG_VERSION 2 has been around for quite some time but is mostly just a string based log. LOG_VERSION 3 supports string based logs as well as others. LOG_VERSION 2 does not play well with the MCUmgr mobile library as well. I would like to suggest getting rid of LOG_VERSION 2 which would allow us to make the code a bit simpler and not worrying about backwards compatibility. This discussion was mainly triggered by a PR https://github.com/apache/mynewt-core/pull/2087 by Jerzy for adding back string based reboot log just to make it work with LOG_VERSION 2. LOG_VERSION 2 also doesn't play well with the MCUmgr mobile library. I suggest we deprecate LOG_VERSION 2 and make the default 3 going forward. I would like to hear thoughts from the community about the same. -- Regards, Vipul Rahane
