[GitHub] jeongyooneo commented on a change in pull request #114: [NEMO-203] Beam SQL Aggregation fails to match RowCoder in Combine transform

jeongyooneo commented on a change in pull request #114: [NEMO-203] Beam SQL Aggregation fails to match RowCoder in Combine transform URL: https://github.com/apache/incubator-nemo/pull/114#discussion_r215145888 ## File path: examples/beam/src/test/java/edu/snu/nemo/examples/beam/Bea

[GitHub] jeongyooneo commented on a change in pull request #114: [NEMO-203] Beam SQL Aggregation fails to match RowCoder in Combine transform

jeongyooneo commented on a change in pull request #114: [NEMO-203] Beam SQL Aggregation fails to match RowCoder in Combine transform URL: https://github.com/apache/incubator-nemo/pull/114#discussion_r215145757 ## File path: examples/beam/src/main/java/edu/snu/nemo/examples/beam/Sim

[GitHub] sanha closed pull request #115: [NEMO-96] Modularize DataSkewPolicy to use MetricVertex and BarrierVertex

sanha closed pull request #115: [NEMO-96] Modularize DataSkewPolicy to use MetricVertex and BarrierVertex URL: https://github.com/apache/incubator-nemo/pull/115 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of

[GitHub] sanha closed pull request #115: [NEMO-96] Modularize DataSkewPolicy to use MetricVertex and BarrierVertex

sanha closed pull request #115: [NEMO-96] Modularize DataSkewPolicy to use MetricVertex and BarrierVertex URL: https://github.com/apache/incubator-nemo/pull/115 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of

[GitHub] jeongyooneo commented on issue #115: [NEMO-96] Modularize DataSkewPolicy to use MetricVertex and BarrierVertex

jeongyooneo commented on issue #115: [NEMO-96] Modularize DataSkewPolicy to use MetricVertex and BarrierVertex URL: https://github.com/apache/incubator-nemo/pull/115#issuecomment-418599520 @sanha I’ve addressed your comments! Thanks for the thorough review!

[GitHub] sanha commented on a change in pull request #115: [NEMO-96] Modularize DataSkewPolicy to use MetricVertex and BarrierVertex

sanha commented on a change in pull request #115: [NEMO-96] Modularize DataSkewPolicy to use MetricVertex and BarrierVertex URL: https://github.com/apache/incubator-nemo/pull/115#discussion_r214889652 ## File path: compiler/optimizer/src/main/java/edu/snu/nemo/compiler/optimizer/pa

[GitHub] sanha commented on a change in pull request #115: [NEMO-96] Modularize DataSkewPolicy to use MetricVertex and BarrierVertex

sanha commented on a change in pull request #115: [NEMO-96] Modularize DataSkewPolicy to use MetricVertex and BarrierVertex URL: https://github.com/apache/incubator-nemo/pull/115#discussion_r214886648 ## File path: common/src/main/java/edu/snu/nemo/common/ir/vertex/transform/Metric

[GitHub] sanha commented on a change in pull request #115: [NEMO-96] Modularize DataSkewPolicy to use MetricVertex and BarrierVertex

sanha commented on a change in pull request #115: [NEMO-96] Modularize DataSkewPolicy to use MetricVertex and BarrierVertex URL: https://github.com/apache/incubator-nemo/pull/115#discussion_r214889097 ## File path: common/src/main/java/edu/snu/nemo/common/coder/EncoderFactory.java

[GitHub] sanha commented on a change in pull request #115: [NEMO-96] Modularize DataSkewPolicy to use MetricVertex and BarrierVertex

sanha commented on a change in pull request #115: [NEMO-96] Modularize DataSkewPolicy to use MetricVertex and BarrierVertex URL: https://github.com/apache/incubator-nemo/pull/115#discussion_r214886675 ## File path: common/src/main/java/edu/snu/nemo/common/ir/vertex/transform/Metric

[GitHub] sanha commented on a change in pull request #115: [NEMO-96] Modularize DataSkewPolicy to use MetricVertex and BarrierVertex

sanha commented on a change in pull request #115: [NEMO-96] Modularize DataSkewPolicy to use MetricVertex and BarrierVertex URL: https://github.com/apache/incubator-nemo/pull/115#discussion_r214889060 ## File path: common/src/main/java/edu/snu/nemo/common/coder/DecoderFactory.java

[GitHub] jeongyooneo commented on issue #115: [NEMO-96] Modularize DataSkewPolicy to use MetricVertex and BarrierVertex

jeongyooneo commented on issue #115: [NEMO-96] Modularize DataSkewPolicy to use MetricVertex and BarrierVertex URL: https://github.com/apache/incubator-nemo/pull/115#issuecomment-418336037 @johnyangk @sanha Thanks for review! I've resolved comments. Please take a look! -