Re: [DISCUSS] Projects, Builds and IDE magic

2024-08-22 Thread Eirik Bakke
> having unmaintained features is the worrying part. Dropping them would be the > ultimate consequence. I think this is the core disagreement. Dropping a feature is a "one-way decision"; it permanently throws away work which may have taken people months or years to create. Leaving a buggy featu

Re: Janitor cleans other platform apps caches

2024-08-22 Thread Patrik Karlström
Thanks, I will try. Den tors 22 aug. 2024 kl 20:12 skrev Michael Bien : > if you open a PR, please base it on the "delivery" branch. There is a > chance to get fixes like this into NB 23 still if they are reviewed in > time. > > -mbien > > > On 22.08.24 16:04, Patrik Karlström wrote: > > I was cu

Re: Janitor cleans other platform apps caches

2024-08-22 Thread Michael Bien
if you open a PR, please base it on the "delivery" branch. There is a chance to get fixes like this into NB 23 still if they are reviewed in time. -mbien On 22.08.24 16:04, Patrik Karlström wrote: I was curious to see if the janitor is supposed to clean abandoned cache dirs for other apps tha

Re: Janitor cleans other platform apps caches

2024-08-22 Thread Michael Bien
Hi Patrik, this looks indeed like it should check the cacheDir - possibly a copy/paste mistake from the block above. would you like to open a PR for this? best regards, -mbien On 22.08.24 16:04, Patrik Karlström wrote: I was curious to see if the janitor is supposed to clean abandoned ca

Re: [DISCUSS] Projects, Builds and IDE magic

2024-08-22 Thread Michael Bien
On 22.08.24 18:04, Eirik Bakke wrote: (I could open another can of worms which is the NB profiler https://github.com/apache/netbeans/issues/7323) Indeed; I use the NetBeans profiler quite a lot. I see a worrying line of argument in these discussions: Some contributors say, quoting from the PR

Janitor cleans other platform apps caches

2024-08-22 Thread Patrik Karlström
I was curious to see if the janitor is supposed to clean abandoned cache dirs for other apps than the current one so I had a look at the code and while doing so I found this line. https://github.com/apache/netbeans/blob/c1ee059fa5772440986a5e51384c20fcfbcd04ce/platform/janitor/src/org/netbeans/mod

Re: [DISCUSS] Projects, Builds and IDE magic

2024-08-22 Thread Eirik Bakke
> (I could open another can of worms which is the NB profiler > https://github.com/apache/netbeans/issues/7323) Indeed; I use the NetBeans profiler quite a lot. I see a worrying line of argument in these discussions: Some contributors say, quoting from the PR above, "I don't use [feature X] at

Re: Q: last minute gradle update for NB23?

2024-08-22 Thread Neil C Smith
On Thu, 22 Aug 2024 at 14:51, Michael Bien wrote: > I did clear ~/.gradle and testuserdir. But if its working for you - I > trust you there :) I hadn't tried with cleared ~/.gradle. Still working, but it does download both 8.9 and 8.10 so the initial wizard takes forever! I wish we had more fee

Re: Q: last minute gradle update for NB23?

2024-08-22 Thread Michael Bien
On 22.08.24 15:11, Neil C Smith wrote: On Thu, 22 Aug 2024 at 13:27, Michael Bien wrote: On 22.08.24 11:07, Michael Bien wrote: On 22.08.24 10:50, Neil C Smith wrote: No comment on the update as yet, although use of the Tooling API should mean we have support of Gradle 8.10 already. Somethin

Re: Q: last minute gradle update for NB23?

2024-08-22 Thread Neil C Smith
On Thu, 22 Aug 2024 at 13:27, Michael Bien wrote: > > On 22.08.24 11:07, Michael Bien wrote: > > On 22.08.24 10:50, Neil C Smith wrote: > >> > >> No comment on the update as yet, although use of the Tooling API > >> should mean we have support of Gradle 8.10 already. Something to > >> check, as m

Re: Q: last minute gradle update for NB23?

2024-08-22 Thread Michael Bien
On 22.08.24 11:07, Michael Bien wrote: On 22.08.24 10:50, Neil C Smith wrote: No comment on the update as yet, although use of the Tooling API should mean we have support of Gradle 8.10 already.  Something to check, as might be changes specifically in the tooling api itself. right. Someone wi

Re: Q: last minute maven update for NB23?

2024-08-22 Thread Michael Bien
On 22.08.24 10:39, Neil C Smith wrote: On Sun, 18 Aug 2024 at 12:53, Michael Bien wrote: opinions: should we update bundled maven to 3.9.9 super late in the RC cycle or leave it at 3.9.8? on one hand this is a low risk minor point release which fixes a few bugs, on the other hand it would be b

Re: Q: last minute gradle update for NB23?

2024-08-22 Thread Michael Bien
On 22.08.24 10:50, Neil C Smith wrote: On Thu, 22 Aug 2024 at 07:37, Michael Bien wrote: (please indicate if this should go to delivery or master during review) Please don't do it that way around. Or propose a change to https://cwiki.apache.org/confluence/display/NETBEANS/Pull+requests+for+de

Re: Q: last minute gradle update for NB23?

2024-08-22 Thread Neil C Smith
On Thu, 22 Aug 2024 at 07:37, Michael Bien wrote: > (please indicate if this should go to delivery or master during review) Please don't do it that way around. Or propose a change to https://cwiki.apache.org/confluence/display/NETBEANS/Pull+requests+for+delivery In particular #2 - Checking suit

Re: Q: last minute maven update for NB23?

2024-08-22 Thread Neil C Smith
On Sun, 18 Aug 2024 at 12:53, Michael Bien wrote: > > opinions: should we update bundled maven to 3.9.9 super late in the RC > cycle or leave it at 3.9.8? > > on one hand this is a low risk minor point release which fixes a few > bugs, on the other hand it would be bad if this causes more delays f