I'm deleting my fork.
there is one PR left
https://github.com/apache/netbeans/pull/5417
Will it get merged or shall I close it?
--
Łukasz Bownik
Used jdk 17. Works. Thanks.
pt., 24 lut 2023, 18:12 użytkownik Neil C Smith
napisał:
> On Fri, 24 Feb 2023 at 17:08, Łukasz Bownik
> wrote:
> > I'm on Windows 11 Home, jdk 1.8.181
>
> Build req
or details.
[repeat] 1 error
[nbmerge] Failed to build target: all-xml.schema.model
:((
--
Łukasz Bownik
https://drive.google.com/file/d/1-IdW4Ci-wMEsh2rKm9KbsXRbAxlo-eCA/view?usp=share_link
My intention is to remove all the code which is unreachable (colored red)
when invoking LiveReferences.fromRoots methods as it is probably a dead
code.
On Thu, Feb 2, 2023 at 10:07 PM Michael Bien wrote:
m/file/d/1-IdW4Ci-wMEsh2rKm9KbsXRbAxlo-eCA/view?usp=share_link
).
If this PR gerts merged, could the unused code be deleted in next PR?
--
Łukasz Bownik
23 at 8:56 AM Laszlo Kishalmi >
> wrote:
>
> > As of readability and debug-ability, I'm sorry to say but old-school
> wins.
> >
> > It starting to look like when you found the hammer everything seems to
> > be a nail...
> >
> > On 1/29/23 02:21, Łukasz B
hing seems to
> be a nail...
>
> On 1/29/23 02:21, Łukasz Bownik wrote:
> > I can't help it
> > It's stronger than me!
> >
> > AARGH!
> >
> > ;););););)
> >
> >
> > toURLs(Stream.of(prjs)
es\autoupdate\pluginimporter\InstallerTest.java
> > - o.n.upgrader\src\org\netbeans\upgrade\AutoUpgrade.java
> > - test\unit\src\org\netbeans\upgrade\AutoUpgradeTest.java
> >
> >
> > Can i make PR or not?
> >
>
>
> -
> To unsubscribe, e-mail: dev-unsubscr...@netbeans.apache.org
> For additional commands, e-mail: dev-h...@netbeans.apache.org
>
> For further information about the NetBeans mailing lists, visit:
> https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
>
>
>
>
--
Łukasz Bownik
How about "Stream.of"? it reads more like English :)
niedz., 29 sty 2023, 06:59 użytkownik name name2
napisał:
> toURLs(
> Arrays.asList(prjs).stream().flatMap(
> (prj) -> Arrays.asList(
> AntArtifactQuery.findArtifactsByType(prj,
> JavaProjectConstants.ARTIFACT_TYPE_JAR)
> )
e someone is willing to sit
> down with a coffee and review a big changeset, others might not willing
> to do that - both can be valid and depends on the concrete changeset.
>
>
> but let me answer a few more of your points inline
>
>
> On 28.01.23 16:19, Łukasz Bownik wro
That would be helpful as then it would be possible to have
pre-PR/in-progres reviews.
sob., 28 sty 2023, 20:02 użytkownik Michael Bien
napisał:
> On 28.01.23 19:55, Łukasz Bownik wrote:
> > Hi.
> > I noticed that as soon as I push a branch to my copy of the repository
> CI
&
Hi.
I noticed that as soon as I push a branch to my copy of the repository CI
picks it up. Is there a way to postpone CI process until a PR is being
created?
ore emails from them"
10. "we want 100% backward compatibility" vs "we let plugins to disappear
from the 'available' list all the time"
So I think it might be a good idea for the core theme to sit, discuss and
create a document ironing out these issues and laying a general process
that should be followed by contributors.
Best regards.
--
Łukasz Bownik
gible than what I
do at work (without breaking anything).
>
> BTW: I think we were talking about these
>
> https://github.com/apache/netbeans/pull/5115 and
> https://github.com/apache/netbeans/pull/5061
>
>
Yes.
&g
?
> >
> > BTW: I think we were talking about these
> >
> > https://github.com/apache/netbeans/pull/5115 and
> > https://github.com/apache/netbeans/pull/5061
> >
> >
> > On 12/22/22 03:55, Łukasz Bownik wrote:
> > > The pace of PR processing
The pace of PR processing is ... demotivating :(((
Hi. Any chance of merging https://github.com/apache/netbeans/pull/5061
before Christmas?
e latest code base, and it is ready to go, will do the
> trick.
>
>
> -brad w.
>
> On Thu, Dec 1, 2022 at 6:01 AM Łukasz Bownik
> wrote:
>
> > " The slowest response times are for issues where the submitter has gone
> > silent and the pull response might need a
gotten a little bit "old", if you will.. Usually
> a simple message to the group that I've rebased the code, tested it out
> again against the latest code base, and it is ready to go, will do the
> trick.
>
>
> -brad w.
>
> On Thu, Dec 1, 2022 at 6:01 AM Łukasz
formation about the NetBeans mailing lists, visit:
> https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
>
>
>
>
--
Łukasz Bownik
Hi.
What is the average PR merge/rejection time?
I see some PRs that are over half a year old.
--
Łukasz Bownik
Could someone look and maybe merge the following PRs.
They only touch unit tests.
https://github.com/apache/netbeans/pull/4112
https://github.com/apache/netbeans/pull/3988
https://github.com/apache/netbeans/pull/4294
--
Łukasz Bownik
<https://www.avast.com/sig-email?utm_medium=email&utm
Ok. Thanks.
On Wed, Jun 22, 2022, 8:57 PM László Kishalmi
wrote:
> That actually never stopped. At the moment there are 69 Pars merged for
> NB15
>
> On Thu, Jun 23, 2022, 04:37 Łukasz Bownik wrote:
>
> > When will you guys start merging PRs again?
> > No pressure, just asking.
> >
>
When will you guys start merging PRs again?
No pressure, just asking.
eout. It only attempts to sleep for at least the timeout - assuming now
> RT kernels are in use.
>
> if (delta < 900 || delta > 1100) {
>
> this is going to fail for various load related reasons, even without
> having CPU bugs. delta < 900 makes somewhat sense to test for de
e could remove the code with more
> confidence, unless someone thinks we should keep it.
>
> best regards,
> michael
>
> On 13.05.22 00:04, Łukasz Bownik wrote:
> > Hi.
> >
> > I stated to clean and extend test cases for org.openide.util.Task class.
> > In the te
le to wait 1s!"
does anybody know what is the history of this? does it concern currently
supported platforms?
--
Łukasz Bownik
Hello.
Does NetBeans CI provide code coverage reports?
rust :-).
> >
> > Some of the committers around (not me, though) use NetBeans as a
> > platform for building applications, or to build plugins, so it's
> > always a good idea to ask in the mailing list when suggesting an API
> > change.
> >
> > Kind
May 9, 2022 at 11:09 PM antonio wrote:
> Hi,
>
> Some comments below.
>
> El 9/5/22 a las 22:17, Łukasz Bownik escribió:
> > So I suspect that the probability of any *external client *calling this
> > method is 0.
>
> As we have explained in some other threads, Ne
ed.
>
> This email format is not really suitable for such discussions especially
> with 78 character wrapping...
>
> On 5/9/22 13:17, Łukasz Bownik wrote:
> > Hello.
> >
> > I refactored the
> /platform/openide.util/src/org/openide/util/MapFormat.jav
> &
ructure unchanged then I could provide
a stubbed implementation like
@deprecated <https://github.com/deprecated>
public String processPattern(String newPattern) throws
IllegalArgumentException {
return newPattern;
}
would it be acceptable?
--
Łukasz Bownik
APIs are like stars - http://
> wiki.apidesign.org/wiki/Star - you cannot know "who's watching". A star
> cannot
> "just disappear". A method in an API cannot be "just refactored". Not even
> when it seems unused.
>
> -jt
>
>
> Dne sobota 30. dubna 2022 1:38
be submitted in a specific
> pull-request, and don't really belong to a unit-test pull request.
>
> Hope this helps,
> Antonio
>
>
> [1]
> $ grep -lR 'org.openide.util.BaseUtilities' | wc -l
> 536
>
> El 1/5/22 a las 0:25, Łukasz Bownik
ob/71f182d6f160bcb3879c38c1f9f9a4925f18074f/platform/openide.util/nbproject/project.xml#L57
>
> [2]
> https://github.com/apache/netbeans/pull/3988#pullrequestreview-950945196
>
> El 30/4/22 a las 1:38, Łukasz Bownik escribió:
> > and I found a “*wrapStringToArray
> > <
>
rray*
and make *BaseUtilities.wrapStringToArray* private to be able to refactor
BaseUtilities.wrapString into more efficient implementation (after
writing characterization
tests <https://en.wikipedia.org/wiki/Characterization_test>first).
--
Łukasz Bownik
origin master # You update _your_ master branch
>
>
> Now _your_ master branch (in your repo) is synchronized with NetBeans'
> master branch.
>
> You now want to create some other patch, you usually do that in a new
> branch, branching from your updated master, like so:
>
What about branching. May I keep pumping PRs from the same branch?
On Thu, Apr 14, 2022, 1:08 PM Geertjan Wielenga
wrote:
> Small is good. :-)
>
> Gj
>
> On Thu, 14 Apr 2022 at 15:59, Łukasz Bownik
> wrote:
>
> > Hello.
> > I got my first PR merged.
> >
&
Hello.
I got my first PR merged.
Can I continue development on my branch or shall i create new branch for
each pull request?
Do you guys prefer small or larger PRs?
te:
> NetBeans used Cobertura [1] for code coverage. You may have more chances
> using it.
>
> nbbuild/netbeans/harness/README.md has some instructions.
>
> Cheers,
> Antonio
>
> [1]
> https://cobertura.github.io/cobertura/
>
> El 28/3/22 a las 22:21, Łukasz Bowni
t;
> Am Sonntag, dem 27.03.2022 um 20:35 -0700 schrieb Łukasz Bownik:
> > What should I use for code covarage?
>
> the problem of NetBeans currently is not the number of tests, but the
> number of tests, that are broken in various ways.
>
> In know that this might sound hereti
ns.apache.org/src/content/participate/submit-pr.asciidoc
>
> On March 27, 2022 at 4:50:35 PM CDT, Łukasz Bownik <
> lukasz.bow...@gmail.com> wrote:
> ok. I will install jdk 11 . by the way, what are coding conventions for
> netbeans?
> The url
> https://netbeans.apache.org//community/guidelines/code-conventions.html
>
> Says page not found :(
>
>
Got it. Thanks.
On Sat, Mar 26, 2022, 7:57 PM Michael Bien wrote:
> On 27.03.22 03:37, Łukasz Bownik wrote:
>
> Ok. 2 more questions
> If i fix something may I bump language version to 11?
>
> unfortunately no. Many modules have still the requirement to run on 8. A
>
but we're also compiling with other
> versions [2].
>
> Cheers,
> Antonio
>
> [1]
> https://github.com/apache/netbeans/#readme
>
> [2]
> https://github.com/apache/netbeans/pull/3785
>
> El 26/3/22 a las 16:21, Łukasz Bownik escribió:
> > Thanks. By the wa
est/platform/html/ help
> yourself!
>
> Cheers,
> Antonio
>
> P.S.: Welcomers are expected to bring some free beers to the Team.
> During the first two weeks at least.
>
> El 25/3/22 a las 21:52, Łukasz Bownik escribió:
> > Hi averyone.
> >
> > I'd
Hi averyone.
I'd like to contribute, but I need some guidance first. I think i might
start with writing some unit tests to get into grip with the code base.
Could someone suggest some module which might use some more test coverage?
By the way, the link to "coding conventions" on the page is dead,
Hello.
I subscribed to the mailing list, now what?
--
Łukasz Bownik
47 matches
Mail list logo
