Re: Rust, anyone?

2023-03-04 Thread Antonio
Hi, In order for org.netbeans.modules.ide.ergonomics.DynamicVerifyTest to pass the commit validation test, one has to add ProjectFactories in the test itself, as in [1]. This works fine if the ProjectFactory is included in the cluster configuration ("full" for instance) but makes the test fa

Re: Rust, anyone?

2023-02-27 Thread Neil C Smith
On Sun, 26 Feb 2023 at 21:11, Antonio wrote: > Wow, it's full of clusters [1]! :-) > If we added "rust" to "clusters.config.full.list" will it end up in the > stable update center? Maybe we don't want that yet, right? -Dcluster.config=release is used for everything - source, binaries and update

Re: Rust, anyone?

2023-02-27 Thread Neil C Smith
On Sun, 26 Feb 2023 at 21:20, Michael Bien wrote: > this draft tests switching CI from release to the full cluster config. > > https://github.com/apache/netbeans/pull/5568 > > the properties file does need some cleanup IMO and we should make sure > that the cluster order isn't significantly differ

Re: Rust, anyone?

2023-02-26 Thread Michael Bien
Hi Antonio, this draft tests switching CI from release to the full cluster config. https://github.com/apache/netbeans/pull/5568 the properties file does need some cleanup IMO and we should make sure that the cluster order isn't significantly different from whatever ends up running during CI a

Re: Rust, anyone?

2023-02-26 Thread Antonio
Hi, Wow, it's full of clusters [1]! Taking a look at cluster.properties I noticed these entries for the update centers... nb.cluster.stableuc.depends=${clusters.config.full.list} nb.cluster.betauc.depends=${clusters.config.full.list} nb.cluster.experimental.depends=${clusters.config.full.list

Re: Rust, anyone?

2023-02-26 Thread Michael Bien
On 26.02.23 20:44, Neil C Smith wrote: On Sun, 26 Feb 2023, 19:35 Michael Bien, wrote: we have to make up our mind how to handle testing :) ... a) the "rust" branch approach we switch everything in main.yml to the rust cluster in that branch ... My suggestion above was to add rust into the

Re: Rust, anyone?

2023-02-26 Thread Neil C Smith
On Sun, 26 Feb 2023, 19:35 Michael Bien, wrote: > we have to make up our mind how to handle testing :) > ... > a) the "rust" branch approach > > we switch everything in main.yml to the rust cluster in that branch ... > My suggestion above was to add rust into the release cluster in the rust bra

Re: Rust, anyone?

2023-02-26 Thread Matthias Bläsing
Hi, Am Sonntag, dem 26.02.2023 um 20:30 +0100 schrieb Michael Bien: > b) we merge to master right away, but we will have to add rust to a > cluster config which is essentially release+rust and use this config for CI we can build with "-Dcluster-config=full" for CI/CD. That way all modules are bu

Re: Rust, anyone?

2023-02-26 Thread Michael Bien
we have to make up our mind how to handle testing :) if we simply merge it to master as detached cluster, it sidelines CI completely as previously mentioned and we could essentially turn CI off if a PR is labeled with 'rust'. We can fix this of course, but we have to figure out how. a) the

Re: Rust, anyone?

2023-02-26 Thread Antonio
By the way, don't know how to set this up in cluster.properties, build fails with: netbeans/nbbuild/build.xml:677: Target "all-rust.cargo" does not exist in the project "main". It is used from target "nbmerge-build-one-cluster". Since I removed "rust" from clusters.config.full.list at https:/

Re: Rust, anyone?

2023-02-26 Thread Antonio
Hi, So I skipped 1.2 and did a PR against master. Let me know if you prefer a PR against a "rust" branch, though. Kind regards, Antonio [1] https://github.com/apache/netbeans/pull/5567 On 24/2/23 18:21, Michael Bien wrote: On 24.02.23 18:21, Neil C Smith wrote: On Fri, 24 Feb 2023 at 17:12

Re: Rust, anyone?

2023-02-24 Thread Michael Bien
On 24.02.23 18:21, Neil C Smith wrote: On Fri, 24 Feb 2023 at 17:12, Michael Bien wrote: We could skip 1.2 if you want and go right to master and develop it there, no? ... Regarding testing... As you probably know, github actions build the 'release' cluster config in a matrix, ... I was with y

Re: Rust, anyone?

2023-02-24 Thread Neil C Smith
On Fri, 24 Feb 2023 at 17:12, Michael Bien wrote: > We could skip 1.2 if you want and go right to master and develop it > there, no? > ... > Regarding testing... As you probably know, github actions build the > 'release' cluster config in a matrix, ... I was with you initially on skipping 1.2. H

Re: Rust, anyone?

2023-02-24 Thread Michael Bien
sounds good to me. We could skip 1.2 if you want and go right to master and develop it there, no? Regarding testing... As you probably know, github actions build the 'release' cluster config in a matrix, compress the whole workspace it and use this as artifact for all secondary test jobs (r

Re: Rust, anyone?

2023-02-21 Thread Antonio
Hi all, So to summarize, if I understand correctly: 1. We want Rust or other experimental stuff in the main repo. 1.1. I'll make a PR in a few days (once I domesticate the grammar). 1.2. We want it in a "rust" branch first to fine-tune. 1.3. Then we may want to merge "rust" to "master" in:

Re: Rust, anyone?

2023-02-17 Thread Neil C Smith
On Fri, 17 Feb 2023 at 11:32, Michael Bien wrote: > we could hide the feature a little bit during beta, e.g keep the modules > disabled by default and print a warning notification that this is an > experimental feature when someone enables the modules. Possibly. Make that b.5 though! :-) I actua

Re: Rust, anyone?

2023-02-17 Thread Michael Bien
me too. Would prefer to have it in NB rather than as plugin since language support is a core feature of IDEs IMO. Having it in the main repo during dev time has also its benefits, CI, potentially more eyes on the code etc. we could hide the feature a little bit during beta, e.g keep the modul

Re: Rust, anyone?

2023-02-16 Thread László Kishalmi
I'd vote for b.4 by Neil. On Thu, Feb 16, 2023 at 12:02 PM Chris wrote: > Hey all, > > as far as I can remember, under oracle there was a time where we had a > similar process to continous deployment. That means, that it was also > possible, to release bugfixes inside the core and updates of plu

Re: Rust, anyone?

2023-02-16 Thread Chris
Hey all, as far as I can remember, under oracle there was a time where we had a similar process to continous deployment. That means, that it was also possible, to release bugfixes inside the core and updates of plugins from the core between releases. Sometimes I opened NetBeans 7.1 and after week

Re: Rust, anyone?

2023-02-16 Thread Neil C Smith
Hi, On Thu, 16 Feb 2023 at 07:02, Antonio wrote: > a) I don't think Rust support is ready yet to be merged with core: ... > b.2) Create a repo of ours and let "rust" be an experimental plugin, and > keep on improving it there. b.4) might be to merge into master as a separate cluster, or in an ex

Re: Rust, anyone?

2023-02-16 Thread John Kostaras
I would vote for b2) for various reasons: the baseline doesn't depend on rust development, many people can develop independently using pull requests, open the bugs in github instead of communicating them in emails. Minus: the burden to add it to the plugins repo (or will it be integrated in the cor

Re: Rust, anyone?

2023-02-15 Thread Antonio
Hi again, So, to clarify: a) I don't think Rust support is ready yet to be merged with core: it's in alpha state ([1] details some aspects that need work). b) If we want to add Rust support to NetBeans we have to decide the best way: b.1) Create a "rust" branch in the main repo, add code t

Re: Rust, anyone?

2023-02-15 Thread Antonio
Hi, It's currently integrated in my repo :-). Whether this goes to core and is released as a plugin is not clear yet, I think. That needs some thought. Releasing it as a plugin has the advantage that it can have a different lifecycle than the core. On 15/2/23 19:48, John Kostaras wrote: Thi

Re: Re: Rust, anyone?

2023-02-15 Thread John Kostaras
This is integrated into the core. @antonio I will try to add this functionality I proposed. :) On Wed, Feb 15, 2023 at 7:32 PM Eric Bresie wrote: > Sorry…so is the implication it’s being provided as a plug-in or integrated > as a core plugin? > > Given my past attempt to bring nbpython in, are

Re: Re: Rust, anyone?

2023-02-15 Thread Eric Bresie
Sorry…so is the implication it’s being provided as a plug-in or integrated as a core plugin? Given my past attempt to bring nbpython in, are there any donation concerns one way or another? Eric Bresie ebre...@gmail.com > On February 14, 2023 at 3:33:26 PM CST, John Kostaras (mailto:jkosta...@

Re: Rust, anyone?

2023-02-14 Thread Antonio
Hi László, Thanks for the pointer, I was taking a look at that very line too. To clarify, the original Rust grammars by the Rust Team ignore the ">>" lexer token [1] and let the parser decide [2],[3] if that is valid or not depending if we're analyzing an expression or a type parameter:

Re: Rust, anyone?

2023-02-14 Thread László Kishalmi
That could be due to virtual tokens (ANTLR token with no length) Maybe I've done something insufficient here: https://github.com/apache/netbeans/blob/15ad55e3f28727e64a4642971f3a980b538c6d4d/ide/lexer.antlr4/src/org/netbeans/spi/lexer/antlr4/AbstractAntlrLexerBridge.java#L152 On Mon, Feb 13, 2023

Re: Rust, anyone?

2023-02-14 Thread Antonio
Sure! I'm currently having fun with the SHL/SHR [1] operators in the Lexer, though. Cheers, Antonio [1] https://github.com/antlr/grammars-v4/blob/master/rust/RustLexer.g4#L302 On 14/2/23 22:33, John Kostaras wrote: Click on *Tools → Options* or *NetBeans → Preferences* (Mac) --> *Rust* .

Re: Rust, anyone?

2023-02-14 Thread John Kostaras
The new plugin works pretty much like the previous one. well done Antonio. Would such a window be necessary for this plugin, too? I suppose so. Click on *Tools → Options* or *NetBeans → Preferences* (Mac) --> *Rust* . [image: εικόνα.png] On Mon, Feb 13, 2023 at 9:01 PM John Kostaras wrote:

Re: Rust, anyone?

2023-02-13 Thread John Kostaras
I know, I wrote that sentence! :) I mention it here for awareness and maybe reuse some of the code... :) On Mon, Feb 13, 2023 at 7:50 PM László Kishalmi wrote: > It says: It is recommended to rewrite/migrate the plugin to ANTLR4 and LSP. > > On Sun, Feb 12, 2023 at 11:08 PM John Kostaras > wro

Re: Rust, anyone?

2023-02-13 Thread Antonio
Hi, Well, the Antlr4 lexer/parser works pretty well, but from time to time it throws an AssertionError [1] and freezes NetBeans, so it needs more work. Detecting test cases (by opening random Rust projects) and detecting where things break is useful. But there're lots of things to do: improv

Re: Rust, anyone?

2023-02-13 Thread László Kishalmi
It says: It is recommended to rewrite/migrate the plugin to ANTLR4 and LSP. On Sun, Feb 12, 2023 at 11:08 PM John Kostaras wrote: > Hello there. There has already been something about Rust > > (written > in JavaCC). > > Ioannis.

Re: Rust, anyone?

2023-02-13 Thread Jakub Herkel
Antonio, is there any list of things that you want (need) to implement? Maybe someone (me also) can take some of them. Jakub On Mon, Feb 13, 2023 at 8:08 AM John Kostaras wrote: > > Hello there. There has already been something about Rust >

Re: Rust, anyone?

2023-02-12 Thread John Kostaras
Hello there. There has already been something about Rust (written in JavaCC). Ioannis. On Sun, Feb 12, 2023 at 10:18 AM Antonio wrote: > Thanks Michael! > > D'oh! My intents to add Rust to the NetBeans core (very much as in the

Re: Rust, anyone?

2023-02-12 Thread Antonio
Thanks Michael! D'oh! My intents to add Rust to the NetBeans core (very much as in the Linux kernel case) have been detected! :-D Latest commits solve these issues, though (and add new bugs). Next challenge: Cargo workspaces [1]. Cheers, Antonio [1] https://doc.rust-lang.org/book/ch14-03-ca

Re: Rust, anyone?

2023-02-12 Thread Michael Bien
well, I just wrote my first Rust program in NetBeans - great work Antonio! already added the 'Rust' label :) for others who want to give it a try: I had to fix two things to make the build pass:  - removed references of RustPackage in org.openide.nodes.Node (probably a happy coding accident)

Re: Rust, anyone?

2023-02-11 Thread Ernie Rael
On 23/02/11 5:26 PM, Arafat BOUCHAFRA wrote: Hi, I'm here to help, just create a GitHub repository, and a discord server channel, and share them with me In a later message: https://github.com/vieiro/netbeans-cnd/tree/rust Regards Le sam. 11 févr. 2023 à 15:54, Antonio a écrit : Hi all

Re: Rust, anyone?

2023-02-11 Thread Arafat BOUCHAFRA
Hi, I'm here to help, just create a GitHub repository, and a discord server channel, and share them with me Regards Le sam. 11 févr. 2023 à 15:54, Antonio a écrit : > Hi all, > > Is there interest in adding Rust support to NetBeans? > > I have a minimal cluster with Rust support, but I'm not s

Re: Rust, anyone?

2023-02-11 Thread Antonio
Hi again, For those interesed, an alpha version (under heavy refactoring) is available at https://github.com/vieiro/netbeans-cnd/tree/rust Buildable with "ant -Dcluster.config=rust" Cheers, Antonio P.S.: Of course, you need Rust's "cargo" on your command line to make any use of it. On 11

Re: Rust, anyone?

2023-02-11 Thread Matthias Bläsing
Hi, Am Samstag, dem 11.02.2023 um 15:54 +0100 schrieb Antonio: > > Is there interest in adding Rust support to NetBeans? > > I have a minimal cluster with Rust support, but I'm not sure I'll be > able to maintain it. Maybe a plugin is a better idea? I think it would be fine as a core plugin. W

Re: Rust, anyone?

2023-02-11 Thread Geertjan Wielenga
Would be very cool as a plugin, I think. Looking forward to trying it and congrats! Gj On Sat, Feb 11, 2023 at 3:54 PM Antonio wrote: > > Hi all, > > Is there interest in adding Rust support to NetBeans? > > I have a minimal cluster with Rust support, but I'm not sure I'll be > able to maintain

Rust, anyone?

2023-02-11 Thread Antonio
Hi all, Is there interest in adding Rust support to NetBeans? I have a minimal cluster with Rust support, but I'm not sure I'll be able to maintain it. Maybe a plugin is a better idea? Thanks, Antonio - To unsubscribe, e-mai