[GitHub] nifi pull request: NIFI-1656 Added locale support to ConvertAvroSc...

Github user trkurc commented on the pull request: https://github.com/apache/nifi/pull/292#issuecomment-199137191 Thanks for following up, @pvillard31 . I think maybe building with other default locales may be worth exploring to add to travis-ci (tagging @apiri who may know if that's

Re: Closing in on the Apache NiFi 0.6.0 release

The Locale issue was reviewed, confirmed as fixed by reporter and merged in. On Sun, Mar 20, 2016 at 10:35 PM, Joe Witt wrote: > Team, > > There are a couple finishing touches PRs to fix a big defect in > SplitText for certain input types, improve locale handling and test >

[GitHub] nifi pull request: NIFI-1656 Added locale support to ConvertAvroSc...

Github user asfgit closed the pull request at: https://github.com/apache/nifi/pull/292 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] nifi pull request: NIFI-1656 Added locale support to ConvertAvroSc...

Github user pvillard31 commented on the pull request: https://github.com/apache/nifi/pull/292#issuecomment-199134795 Everything OK, I'm a :+1: --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

Re: Closing in on the Apache NiFi 0.6.0 release

Team, There are a couple finishing touches PRs to fix a big defect in SplitText for certain input types, improve locale handling and test behavior for Kit bundle, and to clean up content viewing from connections. Getting good input on findings folks have so please keep it coming as that helps

[GitHub] nifi pull request: NIFI-1620 Allow empty Content-Type in InvokeHTT...

Github user joewitt commented on the pull request: https://github.com/apache/nifi/pull/272#issuecomment-199086549 @pvillard31 If you stay focused on the goal of NIFI-1620 here and avoid the body manipulation this seems like a good step. Clearly you found a case worthy of support

[GitHub] nifi pull request: NIFI-1620 Allow empty Content-Type in InvokeHTT...

Github user taftster commented on the pull request: https://github.com/apache/nifi/pull/272#issuecomment-199086081 This pull request is not strictly dealing with NIFI-1620. The edge case of suppressing the Content-Type header for an empty message-body makes sense to fix and address.

[GitHub] nifi pull request: NIFI-1656 Added locale support to ConvertAvroSc...

Github user trkurc commented on the pull request: https://github.com/apache/nifi/pull/292#issuecomment-199051348 @pvillard31 - can you try this one? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[GitHub] nifi pull request: NIFI-1656 Added locale support to ConvertAvroSc...

GitHub user trkurc opened a pull request: https://github.com/apache/nifi/pull/292 NIFI-1656 Added locale support to ConvertAvroSchema and fixed locale … …problems in unit tests See: https://issues.apache.org/jira/browse/NIFI-1656 You can merge this pull request into a

[GitHub] nifi pull request: NIFI-1651 unit tests work on windows. removed c...

Github user trkurc commented on the pull request: https://github.com/apache/nifi/pull/291#issuecomment-198997621 So, likely needs a processor change to add a default locale and some ability to override it --- If your project is set up for it, you can reply to this email and have

[GitHub] nifi pull request: NIFI-1578: Create PutSlack processor

Github user joewitt commented on the pull request: https://github.com/apache/nifi/pull/256#issuecomment-198996892 @adamonduty Saw your tweet. https://twitter.com/microbatch/status/711618210886340608 I've not worked with Slack myself but have heard very positive things. We should

[GitHub] nifi pull request: NIFI-1651 unit tests work on windows. removed c...

Github user joewitt commented on the pull request: https://github.com/apache/nifi/pull/291#issuecomment-198995171 hmm good find @pvillard31 We need to make the code more locale tolerant apparently. --- If your project is set up for it, you can reply to this email and have your

[GitHub] nifi pull request: NIFI-1651 unit tests work on windows. removed c...

Github user pvillard31 commented on the pull request: https://github.com/apache/nifi/pull/291#issuecomment-198994990 Just for the record, the error is because of my local env. This is fixed by setting the locale to US on the scanner: `scanner.useLocale(java.util.Locale.US);`

[GitHub] nifi pull request: NIFI-1651 unit tests work on windows. removed c...

Github user asfgit closed the pull request at: https://github.com/apache/nifi/pull/291 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] nifi pull request: NIFI-1651 unit tests work on windows. removed c...

Github user pvillard31 commented on the pull request: https://github.com/apache/nifi/pull/291#issuecomment-198987604 @trkurc I am currently checking on my side why the other unit tests are in failure. But as you said, this is not related to this PR, so it is OK for me. --- If your

[GitHub] nifi pull request: NIFI-1651 unit tests work on windows. removed c...

Github user trkurc commented on the pull request: https://github.com/apache/nifi/pull/291#issuecomment-198986806 @pvillard31 - I was able to replicate the errors in the txt file you included by adding \r's to the file (windows line endings). The other errors are on tests that haven't

[GitHub] nifi pull request: NIFI-1651 unit tests work on windows. removed c...

Github user pvillard31 commented on the pull request: https://github.com/apache/nifi/pull/291#issuecomment-198982574 Sorry for the delay... I am on a different computer than usual and forgot to check the git property. Did a full clone again (so slow with airport wifi...) and checked

[GitHub] nifi pull request: NIFI-1651 unit tests work on windows. removed c...

Github user apiri commented on the pull request: https://github.com/apache/nifi/pull/291#issuecomment-198978900 Windows 7, Maven 3.3.3, and JDK 8u71 looks good here. Will look for updates from @pvillard31 --- If your project is set up for it, you can reply to this email

[GitHub] nifi pull request: NIFI-1651 unit tests work on windows. removed c...

Github user mosermw commented on the pull request: https://github.com/apache/nifi/pull/291#issuecomment-198974775 Using Windows 10, maven 3.3.9, java 1.7.0_79 the nifi-kite-bundle fails on this unit test before this patch. nifi-kite-bundle unit tests work fine after this patch. +1

[GitHub] nifi pull request: NIFI-1651 unit tests work on windows. removed c...

Github user trkurc commented on the pull request: https://github.com/apache/nifi/pull/291#issuecomment-198971642 Did you clone the code with autocrlf? Does the schema in src/test/resources have line endings? --- If your project is set up for it, you can reply to this email and have

[GitHub] nifi pull request: NIFI-1651 unit tests work on windows. removed c...

Github user pvillard31 commented on the pull request: https://github.com/apache/nifi/pull/291#issuecomment-198970178 Windows 7 Pro / Maven 3.3.9 / Java 1.8.0_74 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] nifi pull request: NIFI-1651 unit tests work on windows. removed c...

Github user trkurc commented on the pull request: https://github.com/apache/nifi/pull/291#issuecomment-198969736 Pierre, what environment are you running on? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

Re: Re: Re: Re: Processor additional documentation

Uwe Noticed your other threads on great progress. That is awesome. Really want to help you get to the bottom of the additional details piece though. We clearly have to do a better job with documenting (or implementing) how to do this. Do you have any more details to share on symptoms you're

[GitHub] nifi pull request: NIFI-1651 unit tests work on windows. removed c...

Github user pvillard31 commented on the pull request: https://github.com/apache/nifi/pull/291#issuecomment-198968796 Tried a mvn clean install without success on my side (I missed something?): [mvn_output.txt](https://github.com/apache/nifi/files/181411/mvn_output.txt) --- If

[GitHub] nifi pull request: NIFI-1651 unit tests work on windows. removed c...

Github user apiri commented on the pull request: https://github.com/apache/nifi/pull/291#issuecomment-198963197 reviewing --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled

[GitHub] nifi pull request: NIFI-1118 Update SplitText Processor - add supp...

Github user markap14 commented on a diff in the pull request: https://github.com/apache/nifi/pull/280#discussion_r56329501 --- Diff: nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/SplitText.java --- @@ -143,72

Re: [GitHub] nifi pull request: NIFI-856 Implements experimental ListenLumberja...

All, Apologies for the mess, git got me on this one. This is my first code contribution in Java and will probably sound a bit like gibberish to my untrained ears, so please be nice. :-) Cheers On Sat, Mar 19, 2016 at 2:37 AM, trixpan wrote: > GitHub user trixpan opened

[GitHub] nifi pull request: NIFI-1617 Add source filename metadata to Ident...

Github user mattyb149 commented on the pull request: https://github.com/apache/nifi/pull/273#issuecomment-198199315 LGTM, successfully built PR, ran unit tests, and tested with running NiFi with both a CSV file and an Atom file (both types recognized by extension:

[GitHub] nifi pull request: NIFI-1571 initial commit of SpringContext suppo...

Github user trkurc commented on the pull request: https://github.com/apache/nifi/pull/271#issuecomment-197323770 @olegz: A sample app would be great. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[GitHub] nifi-site pull request: Added Matt Burgess to committers

Github user mattyb149 closed the pull request at: https://github.com/apache/nifi-site/pull/1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] nifi pull request: NIFI-1571 initial commit of SpringContext suppo...

Github user olegz commented on a diff in the pull request: https://github.com/apache/nifi/pull/271#discussion_r56446641 --- Diff: nifi-nar-bundles/nifi-spring-bundle/nifi-spring-processors/src/main/java/org/apache/nifi/spring/SpringContextProcessor.java --- @@ -0,0 +1,392 @@

[GitHub] nifi pull request: Nifi 1274

Github user JPercivall commented on a diff in the pull request: https://github.com/apache/nifi/pull/284#discussion_r56509790 --- Diff: nifi-nar-bundles/nifi-kerberos-iaa-providers-bundle/nifi-kerberos-iaa-providers/src/test/resources/nifi.properties --- @@ -0,0 +1,185 @@ +#

Re: [ANNOUNCE] New Apache NiFi Committer Oleg Zhurakousky

Congrats Oleg! - - - - - - Joseph Percivall linkedin.com/in/Percivall e: joeperciv...@yahoo.com On Tuesday, March 15, 2016 9:45 PM, Jeremy Dyer wrote: Congrats Oleg! Sent from my iPhone > On Mar 15, 2016, at 9:01 PM, Ricky Saltzer wrote: > > Big

[GitHub] nifi pull request: NIFI-1571 initial commit of SpringContext suppo...

Github user trkurc commented on a diff in the pull request: https://github.com/apache/nifi/pull/271#discussion_r56596211 --- Diff: nifi-nar-bundles/nifi-spring-bundle/nifi-spring-processors/src/main/java/org/apache/nifi/spring/SpringContextProcessor.java --- @@ -0,0 +1,448 @@

[GitHub] nifi pull request: NIFI-1118 Update SplitText Processor - add supp...

Github user jskora commented on a diff in the pull request: https://github.com/apache/nifi/pull/280#discussion_r56322564 --- Diff: nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/SplitText.java --- @@ -134,6 +168,28