Github user olegz commented on a diff in the pull request:
https://github.com/apache/nifi/pull/392#discussion_r63907479
--- Diff:
nifi-nar-bundles/nifi-mqtt-bundle/nifi-mqtt-processors/src/main/java/org/apache/nifi/processors/mqtt/common/AbstractMQTTProcessor.java
---
@@ -0,0
Github user olegz commented on a diff in the pull request:
https://github.com/apache/nifi/pull/392#discussion_r63906843
--- Diff:
nifi-nar-bundles/nifi-mqtt-bundle/nifi-mqtt-processors/src/main/java/org/apache/nifi/processors/mqtt/common/AbstractMQTTProcessor.java
---
@@ -0,0
Github user olegz commented on a diff in the pull request:
https://github.com/apache/nifi/pull/392#discussion_r63902327
--- Diff:
nifi-nar-bundles/nifi-mqtt-bundle/nifi-mqtt-processors/src/main/java/org/apache/nifi/processors/mqtt/ConsumeMQTT.java
---
@@ -0,0 +1,338
Github user olegz commented on a diff in the pull request:
https://github.com/apache/nifi/pull/392#discussion_r63900979
--- Diff:
nifi-nar-bundles/nifi-mqtt-bundle/nifi-mqtt-processors/src/main/java/org/apache/nifi/processors/mqtt/ConsumeMQTT.java
---
@@ -0,0 +1,338
GitHub user olegz opened a pull request:
https://github.com/apache/nifi/pull/455
NIFI-1898 fixed @OnSchedule methods to accept ProcessContext
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/olegz/nifi NIFI-1898
Alternatively
Github user olegz commented on the pull request:
https://github.com/apache/nifi/pull/453#issuecomment-220173989
@mosermw I think as a community we should stay away from jumping to quick
conclusions without giving this PR a thorough and adequate review as we do with
others.
SFTP
Github user olegz commented on the pull request:
https://github.com/apache/nifi/pull/366#issuecomment-219837303
@andrewmlim yep some of it has already been addressed, but I'd stay away
from munging yet another JIRA to this one. So good point and will be reviewed
and addressed once
Github user olegz commented on the pull request:
https://github.com/apache/nifi/pull/366#issuecomment-219832281
Thanks @pvillard31! Regarding @joewitt's comment, yes it is still an
outstanding issue since we need to modify ReflectionUtils to allow the
invocation of non-public methods
Github user olegz commented on a diff in the pull request:
https://github.com/apache/nifi/pull/392#discussion_r63585043
--- Diff:
nifi-nar-bundles/nifi-mqtt-bundle/nifi-mqtt-processors/src/main/java/org/apache/nifi/processors/mqtt/PublishMQTT.java
---
@@ -0,0 +1,239
Github user olegz commented on a diff in the pull request:
https://github.com/apache/nifi/pull/392#discussion_r63583956
--- Diff:
nifi-nar-bundles/nifi-mqtt-bundle/nifi-mqtt-processors/src/main/java/org/apache/nifi/processors/mqtt/common/AbstractMQTTProcessor.java
---
@@ -0,0
Github user olegz commented on a diff in the pull request:
https://github.com/apache/nifi/pull/392#discussion_r63581819
--- Diff:
nifi-nar-bundles/nifi-mqtt-bundle/nifi-mqtt-processors/src/main/java/org/apache/nifi/processors/mqtt/common/AbstractMQTTProcessor.java
---
@@ -0,0
Github user olegz commented on a diff in the pull request:
https://github.com/apache/nifi/pull/392#discussion_r63580606
--- Diff:
nifi-nar-bundles/nifi-mqtt-bundle/nifi-mqtt-processors/src/main/java/org/apache/nifi/processors/mqtt/PublishMQTT.java
---
@@ -0,0 +1,239
Github user olegz commented on a diff in the pull request:
https://github.com/apache/nifi/pull/392#discussion_r63580288
--- Diff:
nifi-nar-bundles/nifi-mqtt-bundle/nifi-mqtt-processors/src/main/java/org/apache/nifi/processors/mqtt/common/AbstractMQTTProcessor.java
---
@@ -0,0
Github user olegz commented on a diff in the pull request:
https://github.com/apache/nifi/pull/392#discussion_r63579787
--- Diff:
nifi-nar-bundles/nifi-mqtt-bundle/nifi-mqtt-processors/src/main/java/org/apache/nifi/processors/mqtt/common/AbstractMQTTProcessor.java
---
@@ -0,0
Github user olegz commented on a diff in the pull request:
https://github.com/apache/nifi/pull/392#discussion_r63579631
--- Diff:
nifi-nar-bundles/nifi-mqtt-bundle/nifi-mqtt-processors/src/main/java/org/apache/nifi/processors/mqtt/common/AbstractMQTTProcessor.java
---
@@ -0,0
Github user olegz commented on a diff in the pull request:
https://github.com/apache/nifi/pull/392#discussion_r63578922
--- Diff:
nifi-nar-bundles/nifi-mqtt-bundle/nifi-mqtt-processors/src/main/java/org/apache/nifi/processors/mqtt/PublishMQTT.java
---
@@ -0,0 +1,239
Github user olegz commented on a diff in the pull request:
https://github.com/apache/nifi/pull/392#discussion_r63578737
--- Diff:
nifi-nar-bundles/nifi-mqtt-bundle/nifi-mqtt-processors/src/main/java/org/apache/nifi/processors/mqtt/PublishMQTT.java
---
@@ -0,0 +1,239
Github user olegz commented on a diff in the pull request:
https://github.com/apache/nifi/pull/392#discussion_r63577875
--- Diff:
nifi-nar-bundles/nifi-mqtt-bundle/nifi-mqtt-processors/src/main/java/org/apache/nifi/processors/mqtt/PublishMQTT.java
---
@@ -0,0 +1,239
Github user olegz commented on the pull request:
https://github.com/apache/nifi/pull/392#issuecomment-219808772
@JPercivall just a heads up; the branch now has merge conflicts
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub
Github user olegz commented on a diff in the pull request:
https://github.com/apache/nifi/pull/392#discussion_r63551055
--- Diff:
nifi-nar-bundles/nifi-mqtt-bundle/nifi-mqtt-processors/src/main/java/org/apache/nifi/processors/mqtt/ConsumeMQTT.java
---
@@ -0,0 +1,341
Github user olegz commented on a diff in the pull request:
https://github.com/apache/nifi/pull/392#discussion_r63549263
--- Diff:
nifi-nar-bundles/nifi-mqtt-bundle/nifi-mqtt-processors/src/main/java/org/apache/nifi/processors/mqtt/ConsumeMQTT.java
---
@@ -0,0 +1,341
Github user olegz commented on a diff in the pull request:
https://github.com/apache/nifi/pull/392#discussion_r63540545
--- Diff:
nifi-nar-bundles/nifi-mqtt-bundle/nifi-mqtt-processors/src/main/java/org/apache/nifi/processors/mqtt/ConsumeMQTT.java
---
@@ -0,0 +1,341
Github user olegz commented on a diff in the pull request:
https://github.com/apache/nifi/pull/392#discussion_r63539083
--- Diff:
nifi-nar-bundles/nifi-mqtt-bundle/nifi-mqtt-processors/src/main/java/org/apache/nifi/processors/mqtt/common/AbstractMQTTProcessor.java
---
@@ -0,0
Github user olegz commented on a diff in the pull request:
https://github.com/apache/nifi/pull/392#discussion_r63537518
--- Diff:
nifi-nar-bundles/nifi-mqtt-bundle/nifi-mqtt-processors/src/main/java/org/apache/nifi/processors/mqtt/ConsumeMQTT.java
---
@@ -0,0 +1,341
Github user olegz commented on a diff in the pull request:
https://github.com/apache/nifi/pull/392#discussion_r63536461
--- Diff:
nifi-nar-bundles/nifi-mqtt-bundle/nifi-mqtt-processors/src/main/java/org/apache/nifi/processors/mqtt/ConsumeMQTT.java
---
@@ -0,0 +1,341
Github user olegz commented on a diff in the pull request:
https://github.com/apache/nifi/pull/392#discussion_r63535091
--- Diff:
nifi-nar-bundles/nifi-mqtt-bundle/nifi-mqtt-processors/src/main/java/org/apache/nifi/processors/mqtt/ConsumeMQTT.java
---
@@ -0,0 +1,341
Github user olegz commented on a diff in the pull request:
https://github.com/apache/nifi/pull/392#discussion_r63533161
--- Diff:
nifi-nar-bundles/nifi-mqtt-bundle/nifi-mqtt-processors/src/main/java/org/apache/nifi/processors/mqtt/ConsumeMQTT.java
---
@@ -0,0 +1,341
Github user olegz commented on a diff in the pull request:
https://github.com/apache/nifi/pull/392#discussion_r63532252
--- Diff:
nifi-nar-bundles/nifi-mqtt-bundle/nifi-mqtt-processors/src/main/java/org/apache/nifi/processors/mqtt/ConsumeMQTT.java
---
@@ -0,0 +1,341
Github user olegz commented on a diff in the pull request:
https://github.com/apache/nifi/pull/392#discussion_r63530121
--- Diff:
nifi-nar-bundles/nifi-mqtt-bundle/nifi-mqtt-processors/src/main/java/org/apache/nifi/processors/mqtt/ConsumeMQTT.java
---
@@ -0,0 +1,341
Github user olegz commented on a diff in the pull request:
https://github.com/apache/nifi/pull/416#discussion_r63529484
--- Diff:
nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/util/SCPTransfer.java
---
@@ -0,0
Github user olegz commented on a diff in the pull request:
https://github.com/apache/nifi/pull/416#discussion_r63526995
--- Diff:
nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/util/SCPTransfer.java
---
@@ -0,0
Github user olegz commented on a diff in the pull request:
https://github.com/apache/nifi/pull/416#discussion_r63523209
--- Diff:
nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/util/SCPTransfer.java
---
@@ -0,0
Github user olegz commented on the pull request:
https://github.com/apache/nifi/pull/451#issuecomment-219717800
@pvillard31 all merged, but it seems like the auto-close hook didn't work.
Could you please close this PR?
---
If your project is set up for it, you can reply
Github user olegz commented on a diff in the pull request:
https://github.com/apache/nifi/pull/416#discussion_r63426185
--- Diff:
nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/util/SCPTransfer.java
---
@@ -0,0
Github user olegz commented on the pull request:
https://github.com/apache/nifi/pull/404#issuecomment-219540129
Cool, let me do a final review and I'll merge
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user olegz commented on a diff in the pull request:
https://github.com/apache/nifi/pull/416#discussion_r63419802
--- Diff:
nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/util/SCPTransfer.java
---
@@ -0,0
Github user olegz commented on a diff in the pull request:
https://github.com/apache/nifi/pull/416#discussion_r63419525
--- Diff:
nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/util/SCPTransfer.java
---
@@ -0,0
Github user olegz commented on a diff in the pull request:
https://github.com/apache/nifi/pull/416#discussion_r63418280
--- Diff:
nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/util/SCPTransfer.java
---
@@ -0,0
Github user olegz commented on a diff in the pull request:
https://github.com/apache/nifi/pull/416#discussion_r63414327
--- Diff:
nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/util/SCPTransfer.java
---
@@ -0,0
Github user olegz commented on a diff in the pull request:
https://github.com/apache/nifi/pull/416#discussion_r63412890
--- Diff:
nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/PutSCP.java
---
@@ -0,0 +1,93
Github user olegz commented on a diff in the pull request:
https://github.com/apache/nifi/pull/416#discussion_r63408651
--- Diff:
nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/util/SCPTransfer.java
---
@@ -0,0
Github user olegz commented on a diff in the pull request:
https://github.com/apache/nifi/pull/416#discussion_r63404486
--- Diff:
nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/util/SCPTransfer.java
---
@@ -0,0
Github user olegz commented on a diff in the pull request:
https://github.com/apache/nifi/pull/416#discussion_r63403903
--- Diff:
nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/GetSCP.java
---
@@ -0,0 +1,118
Github user olegz commented on the pull request:
https://github.com/apache/nifi/pull/416#issuecomment-219508344
Ok, I guess I jumped the gun too soon and spoke of my personal preference
as if it was a decision.
Anyway, will be reviewing.
---
If your project is set up
Github user olegz commented on the pull request:
https://github.com/apache/nifi/pull/404#issuecomment-219502908
@pvillard31 there is a merge conflict in
```
CONFLICT (content): Merge conflict in
nifi-mock/src/test/java/org/apache/nifi/util/TestStandardProcessorTestRunner.java
Github user olegz commented on the pull request:
https://github.com/apache/nifi/pull/416#issuecomment-219501349
@eorgad First, thank you for your contribution. This is definitely
something people had asked for.
Now, . . . . I see that you added it to the standard processors. What
Github user olegz commented on the pull request:
https://github.com/apache/nifi/pull/438#issuecomment-219498693
@pvillard31 could you please close this PR? I've merged both but forgot to
amend the commit message on this one to automatically close.
---
If your project is set up
Github user olegz commented on the pull request:
https://github.com/apache/nifi/pull/347#issuecomment-219489958
merging
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
Github user olegz commented on the pull request:
https://github.com/apache/nifi/pull/366#issuecomment-219106272
@joewitt the OOM tests are still here and running. They were not @Ignored.
I've adjusted them a bit to play nice with the overall build. The @Ignored
tests are only
Github user olegz commented on the pull request:
https://github.com/apache/nifi/pull/366#issuecomment-216890092
As far as cosmetic remarks, all addressed will push soon.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well
Github user olegz commented on the pull request:
https://github.com/apache/nifi/pull/366#issuecomment-216852394
@pvillard31 Thanks for playing with it. Quick question. I don't quite
understand the second point.So let me try to paraphrase it until I stumble:
1. You say PublishKafka
Github user olegz commented on a diff in the pull request:
https://github.com/apache/nifi/pull/392#discussion_r61956949
--- Diff:
nifi-nar-bundles/nifi-mqtt-bundle/nifi-mqtt-processors/src/main/java/org/apache/nifi/processors/mqtt/PublishMQTT.java
---
@@ -0,0 +1,288
Github user olegz commented on the pull request:
https://github.com/apache/nifi/pull/411#issuecomment-216637498
Looks good now. Validated no more trailing white spaces. +1 for merge
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub
Github user olegz commented on the pull request:
https://github.com/apache/nifi/pull/347#issuecomment-216635676
Sure, I'll give it a shot
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user olegz commented on the pull request:
https://github.com/apache/nifi/pull/335#issuecomment-216625510
@owieboy First of all thank you for a contribution
Unfortunately this PR is now a duplicate and we would have noticed it a
while back if it had an associated JIRA
Github user olegz commented on the pull request:
https://github.com/apache/nifi/pull/343#issuecomment-216616249
+1. We need to get it out there and if some minor issues pop up will
address them as we go along. Otherwise all builds are in failed state at the
moment.
---
If your
Github user olegz commented on the pull request:
https://github.com/apache/nifi/pull/339#issuecomment-216612703
+1. I am going to merge this unless there are objections. Documentation is
an ongoing task, so I am sure there will be updates to it in the future, and
will be addressed
Github user olegz commented on the pull request:
https://github.com/apache/nifi/pull/347#issuecomment-216612204
@pvillard31 Are you planning to add tests for this? If not I can take a
crack at it. LMK.
---
If your project is set up for it, you can reply to this email and have your
Github user olegz commented on the pull request:
https://github.com/apache/nifi/pull/390#issuecomment-216611109
Given @joewitt latest comment in JIRA we may need to close this a "No Fix"
---
If your project is set up for it, you can reply to this email and have your
re
Github user olegz commented on the pull request:
https://github.com/apache/nifi/pull/392#issuecomment-216610646
Also, can you update the PR message with some description? Currently it
only shows 'NIFI-1808'
---
If your project is set up for it, you can reply to this email and have
Github user olegz commented on a diff in the pull request:
https://github.com/apache/nifi/pull/392#discussion_r61917362
--- Diff:
nifi-nar-bundles/nifi-mqtt-bundle/nifi-mqtt-processors/src/main/java/org/apache/nifi/processors/mqtt/common/AbstractMQTTProcessor.java
---
@@ -0,0
Github user olegz commented on a diff in the pull request:
https://github.com/apache/nifi/pull/392#discussion_r61917246
--- Diff:
nifi-nar-bundles/nifi-mqtt-bundle/nifi-mqtt-processors/src/main/java/org/apache/nifi/processors/mqtt/SubscribeMQTT.java
---
@@ -0,0 +1,301
Github user olegz commented on a diff in the pull request:
https://github.com/apache/nifi/pull/392#discussion_r61917098
--- Diff:
nifi-nar-bundles/nifi-mqtt-bundle/nifi-mqtt-processors/src/main/java/org/apache/nifi/processors/mqtt/SubscribeMQTT.java
---
@@ -0,0 +1,301
Github user olegz commented on a diff in the pull request:
https://github.com/apache/nifi/pull/392#discussion_r61916950
--- Diff:
nifi-nar-bundles/nifi-mqtt-bundle/nifi-mqtt-processors/src/main/java/org/apache/nifi/processors/mqtt/SubscribeMQTT.java
---
@@ -0,0 +1,301
Github user olegz commented on a diff in the pull request:
https://github.com/apache/nifi/pull/392#discussion_r61916053
--- Diff:
nifi-nar-bundles/nifi-mqtt-bundle/nifi-mqtt-processors/src/main/java/org/apache/nifi/processors/mqtt/SubscribeMQTT.java
---
@@ -0,0 +1,301
Github user olegz commented on a diff in the pull request:
https://github.com/apache/nifi/pull/392#discussion_r61915046
--- Diff:
nifi-nar-bundles/nifi-mqtt-bundle/nifi-mqtt-processors/src/main/java/org/apache/nifi/processors/mqtt/PublishMQTT.java
---
@@ -0,0 +1,288
Github user olegz commented on a diff in the pull request:
https://github.com/apache/nifi/pull/392#discussion_r61913545
--- Diff:
nifi-nar-bundles/nifi-mqtt-bundle/nifi-mqtt-processors/src/main/java/org/apache/nifi/processors/mqtt/PublishMQTT.java
---
@@ -0,0 +1,288
Github user olegz commented on a diff in the pull request:
https://github.com/apache/nifi/pull/392#discussion_r61913245
--- Diff:
nifi-nar-bundles/nifi-mqtt-bundle/nifi-mqtt-processors/src/main/java/org/apache/nifi/processors/mqtt/PublishMQTT.java
---
@@ -0,0 +1,288
Github user olegz commented on a diff in the pull request:
https://github.com/apache/nifi/pull/392#discussion_r61913088
--- Diff:
nifi-nar-bundles/nifi-mqtt-bundle/nifi-mqtt-processors/src/main/java/org/apache/nifi/processors/mqtt/PublishMQTT.java
---
@@ -0,0 +1,288
Github user olegz commented on a diff in the pull request:
https://github.com/apache/nifi/pull/392#discussion_r61912184
--- Diff:
nifi-nar-bundles/nifi-mqtt-bundle/nifi-mqtt-processors/src/main/java/org/apache/nifi/processors/mqtt/PublishMQTT.java
---
@@ -0,0 +1,288
Github user olegz commented on a diff in the pull request:
https://github.com/apache/nifi/pull/339#discussion_r61892921
--- Diff: nifi-docs/src/main/asciidoc/nifi-in-depth.adoc ---
@@ -0,0 +1,209 @@
+//
+// Licensed to the Apache Software Foundation (ASF) under one or more
Github user olegz commented on the pull request:
https://github.com/apache/nifi/pull/366#issuecomment-213767740
Actually @pvillard31 this is yet another great observation as @joewitt and
I have seen something similar during the intermittent failures
Github user olegz commented on a diff in the pull request:
https://github.com/apache/nifi/pull/366#discussion_r60830161
--- Diff:
nifi-nar-bundles/nifi-kafka-bundle/nifi-kafka-pubsub-processors/src/test/java/org/apache/nifi/processors/kafka/pubsub
Github user olegz commented on a diff in the pull request:
https://github.com/apache/nifi/pull/366#discussion_r60829253
--- Diff:
nifi-nar-bundles/nifi-kafka-bundle/nifi-kafka-pubsub-processors/src/main/java/org/apache/nifi/processors/kafka/pubsub/PublishKafka.java
---
@@ -0,0
Github user olegz commented on a diff in the pull request:
https://github.com/apache/nifi/pull/366#discussion_r60828896
--- Diff:
nifi-nar-bundles/nifi-kafka-bundle/nifi-kafka-pubsub-processors/src/main/java/org/apache/nifi/processors/kafka/pubsub/ConsumeKafka.java
---
@@ -0,0
Github user olegz commented on a diff in the pull request:
https://github.com/apache/nifi/pull/366#discussion_r60828756
--- Diff:
nifi-nar-bundles/nifi-kafka-bundle/nifi-kafka-pubsub-processors/src/test/java/org/apache/nifi/processors/kafka/pubsub
Github user olegz commented on the pull request:
https://github.com/apache/nifi/pull/347#issuecomment-212995061
@pvillard31 let me dig some more. Yes you have to have the "other side"
running but I had some other code bits to simulate that. I'll post here once I
find
-
Github user olegz closed the pull request at:
https://github.com/apache/nifi/pull/350
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
Github user olegz commented on the pull request:
https://github.com/apache/nifi/pull/350#issuecomment-212597713
Closing it after discussing it with @joewitt. Will be addressed as part of
the https://github.com/apache/nifi/pull/366 PR since there are already
dependency on renaming
Github user olegz commented on a diff in the pull request:
https://github.com/apache/nifi/pull/372#discussion_r60468517
--- Diff:
nifi-nar-bundles/nifi-hive-bundle/nifi-hive-processors/src/main/java/org/apache/nifi/processors/hive/PutHiveQL.java
---
@@ -0,0 +1,320
Github user olegz commented on a diff in the pull request:
https://github.com/apache/nifi/pull/372#discussion_r60468215
--- Diff:
nifi-nar-bundles/nifi-hive-bundle/nifi-hive-processors/src/main/java/org/apache/nifi/processors/hive/PutHiveQL.java
---
@@ -0,0 +1,320
Github user olegz commented on a diff in the pull request:
https://github.com/apache/nifi/pull/372#discussion_r60467879
--- Diff:
nifi-nar-bundles/nifi-hive-bundle/nifi-hive-processors/src/main/java/org/apache/nifi/processors/hive/ExecuteHiveQL.java
---
@@ -0,0 +1,172
Github user olegz commented on a diff in the pull request:
https://github.com/apache/nifi/pull/372#discussion_r60467669
--- Diff:
nifi-nar-bundles/nifi-hive-bundle/nifi-hive-processors/src/main/java/org/apache/nifi/dbcp/hive/HiveConnectionPool.java
---
@@ -0,0 +1,184
Github user olegz commented on a diff in the pull request:
https://github.com/apache/nifi/pull/372#discussion_r60467535
--- Diff:
nifi-nar-bundles/nifi-hive-bundle/nifi-hive-processors/src/main/java/org/apache/nifi/dbcp/hive/HiveConnectionPool.java
---
@@ -0,0 +1,184
Github user olegz commented on a diff in the pull request:
https://github.com/apache/nifi/pull/372#discussion_r60467301
--- Diff:
nifi-nar-bundles/nifi-hive-bundle/nifi-hive-processors/src/main/java/org/apache/nifi/dbcp/hive/HiveConnectionPool.java
---
@@ -0,0 +1,184
Github user olegz commented on a diff in the pull request:
https://github.com/apache/nifi/pull/372#discussion_r60467110
--- Diff:
nifi-nar-bundles/nifi-hive-bundle/nifi-hive-processors/src/main/java/org/apache/nifi/dbcp/hive/HiveConnectionPool.java
---
@@ -0,0 +1,184
Github user olegz commented on a diff in the pull request:
https://github.com/apache/nifi/pull/372#discussion_r60466456
--- Diff:
nifi-nar-bundles/nifi-hive-bundle/nifi-hive-processors/src/main/java/org/apache/nifi/dbcp/hive/HiveConnectionPool.java
---
@@ -0,0 +1,184
Github user olegz commented on the pull request:
https://github.com/apache/nifi/pull/366#issuecomment-212462519
@pvillard31 would be nice (if/when you get time) for you to test and review
this one. Basically we want to try to merge this one as quick as possible so
community get's
Github user olegz commented on the pull request:
https://github.com/apache/nifi/pull/355#issuecomment-212448324
Just discussed it with @joewitt and will be merging it now
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well
Github user olegz commented on the pull request:
https://github.com/apache/nifi/pull/368#issuecomment-212427393
@pvillard31 I know we have a lot of these "quick-fix-hit-and-run" bugs that
require half a line of code change (and you've been absolutely awesome in
knocking
Github user olegz commented on a diff in the pull request:
https://github.com/apache/nifi/pull/368#discussion_r60407160
--- Diff:
nifi-nar-bundles/nifi-hadoop-bundle/nifi-hdfs-processors/src/main/java/org/apache/nifi/processors/hadoop/SequenceFileWriterImpl.java
---
@@ -94,8
GitHub user olegz opened a pull request:
https://github.com/apache/nifi/pull/365
NIFI-1785 added NON_BLANK_VALIDATOR
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/olegz/nifi NIFI-1785
Alternatively you can review and apply
Github user olegz commented on the pull request:
https://github.com/apache/nifi/pull/345#issuecomment-212039891
Closing this PR and will submit new one for final review
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well
Github user olegz commented on a diff in the pull request:
https://github.com/apache/nifi/pull/345#discussion_r60270023
--- Diff:
nifi-nar-bundles/nifi-kafka-bundle/nifi-kafka-pubsub-processors/src/main/java/org/apache/nifi/processors/kafka/pubsub/AbstractKafkaProcessor.java
Github user olegz commented on a diff in the pull request:
https://github.com/apache/nifi/pull/345#discussion_r60269808
--- Diff:
nifi-nar-bundles/nifi-kafka-bundle/nifi-kafka-pubsub-processors/src/main/java/org/apache/nifi/processors/kafka/pubsub/ConsumeKafka.java
---
@@ -0,0
Github user olegz commented on the pull request:
https://github.com/apache/nifi/pull/361#issuecomment-211976837
+1, merging
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user olegz commented on a diff in the pull request:
https://github.com/apache/nifi/pull/361#discussion_r60230551
--- Diff:
nifi-external/nifi-storm-spout/src/main/java/org/apache/nifi/storm/NiFiBolt.java
---
@@ -0,0 +1,190 @@
+/*
+ * Licensed to the Apache Software
Github user olegz commented on the pull request:
https://github.com/apache/nifi/pull/354#issuecomment-211718256
@joewitt As I am thinking more about it, you have a point for @OnStopped,
so I am retracting my comment. As for volatile, what's at question is the
visibility
Github user olegz commented on a diff in the pull request:
https://github.com/apache/nifi/pull/354#discussion_r60167981
--- Diff:
nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/TransformJSON.java
---
@@ -0,0 +1,211
Github user olegz commented on a diff in the pull request:
https://github.com/apache/nifi/pull/354#discussion_r60167411
--- Diff:
nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/TransformJSON.java
---
@@ -0,0 +1,211
101 - 200 of 452 matches
Mail list logo
