[GitHub] nifi pull request: NIFI-361 - Create Processors to mutate JSON dat...

2016-04-18 Thread olegz
Github user olegz commented on the pull request: https://github.com/apache/nifi/pull/354#issuecomment-211703487 @YolandaMDavis this looks very good. One general comment; Just to finish the life-cycle loop I'd suggest adding a stop operation (operation annotated with @OnStopped) where

[GitHub] nifi pull request: NIFI-1778 Adding NiFiBolt to write back to NiFi...

2016-04-18 Thread olegz
Github user olegz commented on a diff in the pull request: https://github.com/apache/nifi/pull/361#discussion_r60155833 --- Diff: nifi-external/nifi-storm-spout/src/main/java/org/apache/nifi/storm/NiFiBolt.java --- @@ -0,0 +1,190 @@ +/* + * Licensed to the Apache Software

[GitHub] nifi pull request: NIFI-1778 Adding NiFiBolt to write back to NiFi...

2016-04-18 Thread olegz
Github user olegz commented on a diff in the pull request: https://github.com/apache/nifi/pull/361#discussion_r60155646 --- Diff: nifi-external/nifi-storm-spout/src/main/java/org/apache/nifi/storm/NiFiBolt.java --- @@ -0,0 +1,190 @@ +/* + * Licensed to the Apache Software

[GitHub] nifi pull request: NIFI-1197 Added SSL support for MongoDB process...

2016-04-18 Thread olegz
Github user olegz commented on a diff in the pull request: https://github.com/apache/nifi/pull/360#discussion_r60144583 --- Diff: nifi-nar-bundles/nifi-mongodb-bundle/nifi-mongodb-processors/src/main/java/org/apache/nifi/processors/mongodb/AbstractMongoProcessor.java --- @@ -52,6

[GitHub] nifi pull request: NIFI-361 - Create Processors to mutate JSON dat...

2016-04-18 Thread olegz
Github user olegz commented on a diff in the pull request: https://github.com/apache/nifi/pull/354#discussion_r60118214 --- Diff: nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/TransformJSON.java --- @@ -0,0 +1,212

[GitHub] nifi pull request: NIFI-361 - Create Processors to mutate JSON dat...

2016-04-18 Thread olegz
Github user olegz commented on a diff in the pull request: https://github.com/apache/nifi/pull/354#discussion_r60118046 --- Diff: nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/TransformJSON.java --- @@ -0,0 +1,212

[GitHub] nifi pull request: NIFI-361 - Create Processors to mutate JSON dat...

2016-04-18 Thread olegz
Github user olegz commented on a diff in the pull request: https://github.com/apache/nifi/pull/354#discussion_r60117078 --- Diff: nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/TransformJSON.java --- @@ -0,0 +1,212

[GitHub] nifi pull request: NIFI-1678

2016-04-18 Thread olegz
Github user olegz commented on a diff in the pull request: https://github.com/apache/nifi/pull/323#discussion_r60107339 --- Diff: nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-framework-cluster/src/main/java/org/apache/nifi/cluster/coordination/heartbeat

[GitHub] nifi pull request: NIFI-1028 initial commit of NiFi In Depth docum...

2016-04-18 Thread olegz
Github user olegz commented on a diff in the pull request: https://github.com/apache/nifi/pull/339#discussion_r60105112 --- Diff: nifi-docs/src/main/asciidoc/nifi-in-depth.adoc --- @@ -0,0 +1,209 @@ +// +// Licensed to the Apache Software Foundation (ASF) under one or more

[GitHub] nifi pull request: NIFI-1028 initial commit of NiFi In Depth docum...

2016-04-18 Thread olegz
Github user olegz commented on a diff in the pull request: https://github.com/apache/nifi/pull/339#discussion_r60103526 --- Diff: nifi-docs/src/main/asciidoc/nifi-in-depth.adoc --- @@ -0,0 +1,209 @@ +// +// Licensed to the Apache Software Foundation (ASF) under one or more

[GitHub] nifi pull request: NIFI-1668 modified TestProcessorLifecycle to en...

2016-04-18 Thread olegz
Github user olegz commented on the pull request: https://github.com/apache/nifi/pull/324#issuecomment-211487325 @pvillard31 any idea why? I mean 'target' directory should be deletable. Just wonder if you have any idea/pointers? --- If your project is set up for it, you can reply

[GitHub] nifi pull request: NIFI-1727: Refactored logic for merging HTTP Re...

2016-04-18 Thread olegz
Github user olegz commented on a diff in the pull request: https://github.com/apache/nifi/pull/338#discussion_r60093499 --- Diff: nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-framework-cluster/src/main/java/org/apache/nifi/cluster/coordination/http/endpoints

[GitHub] nifi pull request: NIFI-1727: Refactored logic for merging HTTP Re...

2016-04-18 Thread olegz
Github user olegz commented on a diff in the pull request: https://github.com/apache/nifi/pull/338#discussion_r60092307 --- Diff: nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-framework-cluster/src/main/java/org/apache/nifi/cluster/coordination/http/endpoints

[GitHub] nifi pull request: NIFI-1727: Refactored logic for merging HTTP Re...

2016-04-18 Thread olegz
Github user olegz commented on a diff in the pull request: https://github.com/apache/nifi/pull/338#discussion_r60090174 --- Diff: nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-framework-cluster/src/main/java/org/apache/nifi/cluster/coordination/http/endpoints

[GitHub] nifi pull request: NIFI-1727: Refactored logic for merging HTTP Re...

2016-04-18 Thread olegz
Github user olegz commented on a diff in the pull request: https://github.com/apache/nifi/pull/338#discussion_r60088663 --- Diff: nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-framework-cluster/src/main/java/org/apache/nifi/cluster/coordination/http/endpoints

[GitHub] nifi pull request: NIFI-1727: Refactored logic for merging HTTP Re...

2016-04-18 Thread olegz
Github user olegz commented on a diff in the pull request: https://github.com/apache/nifi/pull/338#discussion_r60087458 --- Diff: nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-framework-cluster/src/main/java/org/apache/nifi/cluster/coordination/http/endpoints

[GitHub] nifi pull request: NIFI-1727: Refactored logic for merging HTTP Re...

2016-04-18 Thread olegz
Github user olegz commented on a diff in the pull request: https://github.com/apache/nifi/pull/338#discussion_r60086063 --- Diff: nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-framework-cluster/src/main/java/org/apache/nifi/cluster/coordination/http

[GitHub] nifi pull request: NIFI-361 - Create Processors to mutate JSON dat...

2016-04-18 Thread olegz
Github user olegz commented on a diff in the pull request: https://github.com/apache/nifi/pull/354#discussion_r60084831 --- Diff: nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/TransformJSON.java --- @@ -0,0 +1,212

[GitHub] nifi pull request: NIFI-361 - Create Processors to mutate JSON dat...

2016-04-18 Thread olegz
Github user olegz commented on a diff in the pull request: https://github.com/apache/nifi/pull/354#discussion_r60084343 --- Diff: nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/TransformJSON.java --- @@ -0,0 +1,212

[GitHub] nifi pull request: NIFI-1755 Fixed remote process group status cou...

2016-04-18 Thread olegz
Github user olegz commented on the pull request: https://github.com/apache/nifi/pull/347#issuecomment-211417082 @pvillard31 I was gonna play with it a bit more and possibly create the test, but getting tied up with other things. Yet I was able to dig up one of my experiments that I

[GitHub] nifi pull request: NIFI-1724 Added properties to configure log lev...

2016-04-18 Thread olegz
Github user olegz commented on the pull request: https://github.com/apache/nifi/pull/348#issuecomment-211349732 @pvillard31 Looks good, will test and merge. Could you please reassign this issue in JIRA to yourself (since you did all the work)? Even if its resolved it would be nice

[GitHub] nifi pull request: NIFI-1777 Prevent deleting a connection going t...

2016-04-18 Thread olegz
Github user olegz commented on the pull request: https://github.com/apache/nifi/pull/357#issuecomment-211322321 Was able to validate that when/if someone attempts to delete a connected processor a window pops up with the error message "Destination of Connection (LogAttribu

[GitHub] nifi pull request: NIFI-1777 Prevent deleting a connection going t...

2016-04-18 Thread olegz
Github user olegz commented on the pull request: https://github.com/apache/nifi/pull/357#issuecomment-211319503 @pvillard31 also, when you submit PR click on "Submit Patch" in JIRA (without writing anything in description). I know it may be a bit awkward but this is how

[GitHub] nifi pull request: NIFI-1777 Prevent deleting a connection going t...

2016-04-18 Thread olegz
Github user olegz commented on the pull request: https://github.com/apache/nifi/pull/357#issuecomment-211318338 Perfect, reviewing now --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] nifi pull request: NIFI-1764 fixed NPE in PutKafka

2016-04-17 Thread olegz
Github user olegz commented on the pull request: https://github.com/apache/nifi/pull/350#issuecomment-211148835 This is most likely a no-merge PR. There is some work that is currently being done by @joewitt and elements of this PR will already be there. --- If your project is set up

[GitHub] nifi pull request: NIFI-1672 Improved the Provenance Events emitte...

2016-04-17 Thread olegz
Github user olegz commented on the pull request: https://github.com/apache/nifi/pull/355#issuecomment-211148524 @pvillard31 @joewitt Joe Witt is doing some work on current version of Kafka. Joe, this is just a note that my PR https://github.com/apache/nifi/pull/350 and this one

[GitHub] nifi pull request: NIFI-361 - Create Processors to mutate JSON dat...

2016-04-17 Thread olegz
Github user olegz commented on a diff in the pull request: https://github.com/apache/nifi/pull/354#discussion_r59997381 --- Diff: nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/TransformJSON.java --- @@ -0,0 +1,212

[GitHub] nifi pull request: NIFI-361 - Create Processors to mutate JSON dat...

2016-04-17 Thread olegz
Github user olegz commented on a diff in the pull request: https://github.com/apache/nifi/pull/354#discussion_r59997330 --- Diff: nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/TransformJSON.java --- @@ -0,0 +1,212

[GitHub] nifi pull request: NIFI-361 - Create Processors to mutate JSON dat...

2016-04-17 Thread olegz
Github user olegz commented on a diff in the pull request: https://github.com/apache/nifi/pull/354#discussion_r59997274 --- Diff: nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/TransformJSON.java --- @@ -0,0 +1,212

[GitHub] nifi pull request: NIFI-1582 added state to UpdateAttribute as wel...

2016-04-17 Thread olegz
Github user olegz commented on a diff in the pull request: https://github.com/apache/nifi/pull/319#discussion_r59996122 --- Diff: nifi-nar-bundles/nifi-update-attribute-bundle/nifi-update-attribute-processor/src/main/java/org/apache/nifi/processors/attributes/UpdateAttribute.java

[GitHub] nifi pull request: NIFI-1582 added state to UpdateAttribute as wel...

2016-04-17 Thread olegz
Github user olegz commented on a diff in the pull request: https://github.com/apache/nifi/pull/319#discussion_r59996108 --- Diff: nifi-nar-bundles/nifi-update-attribute-bundle/nifi-update-attribute-processor/src/main/java/org/apache/nifi/processors/attributes/UpdateAttribute.java

[GitHub] nifi pull request: NIFI-1582 added state to UpdateAttribute as wel...

2016-04-17 Thread olegz
Github user olegz commented on a diff in the pull request: https://github.com/apache/nifi/pull/319#discussion_r59995999 --- Diff: nifi-nar-bundles/nifi-update-attribute-bundle/nifi-update-attribute-processor/src/main/java/org/apache/nifi/processors/attributes/UpdateAttribute.java

[GitHub] nifi pull request: Nifi 1214

2016-04-17 Thread olegz
Github user olegz commented on a diff in the pull request: https://github.com/apache/nifi/pull/321#discussion_r59995770 --- Diff: nifi-mock/src/main/java/org/apache/nifi/util/verifier/ConditionsBuilder.java --- @@ -0,0 +1,52 @@ +/* + * Licensed to the Apache Software

[GitHub] nifi pull request: NIFI-1678

2016-04-17 Thread olegz
Github user olegz commented on a diff in the pull request: https://github.com/apache/nifi/pull/323#discussion_r59995690 --- Diff: nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-framework-cluster/src/main/java/org/apache/nifi/cluster/manager/impl

[GitHub] nifi pull request: NIFI-1678

2016-04-17 Thread olegz
Github user olegz commented on a diff in the pull request: https://github.com/apache/nifi/pull/323#discussion_r59995615 --- Diff: nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-framework-cluster/src/main/java/org/apache/nifi/cluster/manager/impl

[GitHub] nifi pull request: NIFI-1678

2016-04-17 Thread olegz
Github user olegz commented on a diff in the pull request: https://github.com/apache/nifi/pull/323#discussion_r59995501 --- Diff: nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-framework-cluster/src/main/java/org/apache/nifi/cluster/coordination/heartbeat

[GitHub] nifi pull request: NIFI-1678

2016-04-17 Thread olegz
Github user olegz commented on a diff in the pull request: https://github.com/apache/nifi/pull/323#discussion_r59995465 --- Diff: nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-framework-cluster/src/main/java/org/apache/nifi/cluster/coordination/heartbeat

[GitHub] nifi pull request: NIFI-1678

2016-04-17 Thread olegz
Github user olegz commented on a diff in the pull request: https://github.com/apache/nifi/pull/323#discussion_r59995435 --- Diff: nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-framework-cluster/src/main/java/org/apache/nifi/cluster/coordination/heartbeat

[GitHub] nifi pull request: NIFI-1678

2016-04-17 Thread olegz
Github user olegz commented on a diff in the pull request: https://github.com/apache/nifi/pull/323#discussion_r59995310 --- Diff: nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-framework-cluster/src/main/java/org/apache/nifi/cluster/coordination/heartbeat

[GitHub] nifi pull request: NIFI-1678

2016-04-17 Thread olegz
Github user olegz commented on a diff in the pull request: https://github.com/apache/nifi/pull/323#discussion_r59995273 --- Diff: nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-framework-cluster/src/main/java/org/apache/nifi/cluster/coordination/heartbeat

[GitHub] nifi pull request: NIFI-1678

2016-04-17 Thread olegz
Github user olegz commented on a diff in the pull request: https://github.com/apache/nifi/pull/323#discussion_r59995177 --- Diff: nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-framework-cluster-protocol/src/main/java/org/apache/nifi/cluster/protocol/jaxb/message

[GitHub] nifi pull request: NIFI-1755 Fixed remote process group status cou...

2016-04-17 Thread olegz
Github user olegz commented on the pull request: https://github.com/apache/nifi/pull/347#issuecomment-211126901 @pvillard31 Changes look good, but was wondering if you could add some tests --- If your project is set up for it, you can reply to this email and have your reply appear

[GitHub] nifi pull request: NIFI-1197 Added SSL support for MongoDB process...

2016-04-17 Thread olegz
Github user olegz commented on the pull request: https://github.com/apache/nifi/pull/360#issuecomment-211126729 Changes and additions look good, testing adequate, +1. Will let it sit for another day and unless there are any objections will merge. --- If your project is set up

[GitHub] nifi pull request: NIFI-1738 - Repair logger names for ControllerS...

2016-04-17 Thread olegz
Github user olegz commented on the pull request: https://github.com/apache/nifi/pull/334#issuecomment-211091503 Perfect, working on it now --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] nifi pull request: NIFI-1724 Added properties to configure log lev...

2016-04-17 Thread olegz
Github user olegz commented on the pull request: https://github.com/apache/nifi/pull/348#issuecomment-211090185 @pvillard31 given that its new functionality and although somewhat trivial I still think adding few tests would be appropriate. --- If your project is set up for it, you

[GitHub] nifi pull request: NIFI-1521 Allows use of SSL in AMQP Processor

2016-04-17 Thread olegz
Github user olegz commented on the pull request: https://github.com/apache/nifi/pull/232#issuecomment-211088066 pvillard31 is this still a work in progress of is it ready for final review? --- If your project is set up for it, you can reply to this email and have your reply appear

[GitHub] nifi pull request: NIFI-1568: Add Filter Capability to UnpackConte...

2016-04-17 Thread olegz
Github user olegz commented on a diff in the pull request: https://github.com/apache/nifi/pull/248#discussion_r59990453 --- Diff: nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/UnpackContent.java --- @@ -154,75

[GitHub] nifi pull request: NIFI-1636: Print Stacktrace When Unexpected OnT...

2016-04-17 Thread olegz
Github user olegz commented on the pull request: https://github.com/apache/nifi/pull/285#issuecomment-211081495 @rickysaltzer where do you think we are with this one? I mean, do you think NIFI-1447 solved your issue or this PR is still valid? --- If your project is set up

[GitHub] nifi pull request: NIFI-1738 - Repair logger names for ControllerS...

2016-04-17 Thread olegz
Github user olegz commented on the pull request: https://github.com/apache/nifi/pull/334#issuecomment-211080536 @Hejki please let us know if you are good with the tests from @jvwing , then we can amend your commit with @jvwing changes and merge. --- If your project is set up

[GitHub] nifi pull request: NIFI-1777 Prevent deleting a connection going t...

2016-04-17 Thread olegz
Github user olegz commented on the pull request: https://github.com/apache/nifi/pull/357#issuecomment-211079403 @pvillard31 I know this is a simple one, but would you consider adding a simple unit test for it as well? --- If your project is set up for it, you can reply to this email

[GitHub] nifi pull request: NIFI-1776 Allowed application/x-gzip as Gzip mi...

2016-04-17 Thread olegz
Github user olegz commented on the pull request: https://github.com/apache/nifi/pull/358#issuecomment-211075106 Fix includes adequate testing +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[GitHub] nifi pull request: NIFI-1727: Refactored logic for merging HTTP Re...

2016-04-17 Thread olegz
Github user olegz commented on the pull request: https://github.com/apache/nifi/pull/338#issuecomment-211074685 Mark, besides the initial comments there also seems to be a lot of repetitive logic throughout. Do you think it is something you want to address now? --- If your project

[GitHub] nifi pull request: NIFI-1727: Refactored logic for merging HTTP Re...

2016-04-17 Thread olegz
Github user olegz commented on a diff in the pull request: https://github.com/apache/nifi/pull/338#discussion_r59989423 --- Diff: nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-framework-cluster/src/main/java/org/apache/nifi/cluster/coordination/http/endpoints

[GitHub] nifi pull request: NIFI-1727: Refactored logic for merging HTTP Re...

2016-04-17 Thread olegz
Github user olegz commented on a diff in the pull request: https://github.com/apache/nifi/pull/338#discussion_r59989402 --- Diff: nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-framework-cluster/src/main/java/org/apache/nifi/cluster/coordination/http/endpoints

[GitHub] nifi pull request: NIFI-1727: Refactored logic for merging HTTP Re...

2016-04-17 Thread olegz
Github user olegz commented on a diff in the pull request: https://github.com/apache/nifi/pull/338#discussion_r59989329 --- Diff: nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-framework-cluster/src/main/java/org/apache/nifi/cluster/coordination/http/endpoints

[GitHub] nifi pull request: NIFI-1727: Refactored logic for merging HTTP Re...

2016-04-17 Thread olegz
Github user olegz commented on a diff in the pull request: https://github.com/apache/nifi/pull/338#discussion_r59989219 --- Diff: nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-framework-cluster/src/main/java/org/apache/nifi/cluster/coordination/http/endpoints

[GitHub] nifi pull request: NIFI-1727: Refactored logic for merging HTTP Re...

2016-04-17 Thread olegz
Github user olegz commented on a diff in the pull request: https://github.com/apache/nifi/pull/338#discussion_r59988925 --- Diff: nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-framework-cluster/src/main/java/org/apache/nifi/cluster/coordination/http/endpoints

[GitHub] nifi pull request: NIFI-1727: Refactored logic for merging HTTP Re...

2016-04-17 Thread olegz
Github user olegz commented on a diff in the pull request: https://github.com/apache/nifi/pull/338#discussion_r59988860 --- Diff: nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-framework-cluster/src/main/java/org/apache/nifi/cluster/coordination/http

[GitHub] nifi pull request: NIFI-1727: Refactored logic for merging HTTP Re...

2016-04-17 Thread olegz
Github user olegz commented on a diff in the pull request: https://github.com/apache/nifi/pull/338#discussion_r59988803 --- Diff: nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-framework-cluster/src/main/java/org/apache/nifi/cluster/coordination/http

[GitHub] nifi pull request: NIFI-1771 deprecated ObjectHolder

2016-04-14 Thread olegz
GitHub user olegz opened a pull request: https://github.com/apache/nifi/pull/351 NIFI-1771 deprecated ObjectHolder You can merge this pull request into a Git repository by running: $ git pull https://github.com/olegz/nifi NIFI-1771 Alternatively you can review and apply

[GitHub] nifi pull request: NIFI-1764 fixed NPE in PutKafka

2016-04-14 Thread olegz
GitHub user olegz opened a pull request: https://github.com/apache/nifi/pull/350 NIFI-1764 fixed NPE in PutKafka NIFI-1764 removed obsolete comment for MESSAGE_DELIMITER You can merge this pull request into a Git repository by running: $ git pull https://github.com/olegz/nifi

[GitHub] nifi pull request: NIFI-1748 removed un-used test data

2016-04-11 Thread olegz
Github user olegz commented on a diff in the pull request: https://github.com/apache/nifi/pull/344#discussion_r59292437 --- Diff: nifi-nar-bundles/nifi-kafka-bundle/nifi-kafka-processors/src/test/java/org/apache/nifi/processors/kafka/KafkaPublisherTest.java --- @@ -124,33 +112,9

[GitHub] nifi pull request: NIFI-1748 removed un-used test data

2016-04-09 Thread olegz
GitHub user olegz opened a pull request: https://github.com/apache/nifi/pull/341 NIFI-1748 removed un-used test data You can merge this pull request into a Git repository by running: $ git pull https://github.com/olegz/nifi NIFI-1748 Alternatively you can review and apply

[GitHub] nifi pull request: NIFI-1690 Changed MonitorMemory to use allowabl...

2016-04-05 Thread olegz
GitHub user olegz opened a pull request: https://github.com/apache/nifi/pull/328 NIFI-1690 Changed MonitorMemory to use allowable values for pool names - removed dead code from MonitorMemory - added MonitorMemoryTest - minor refactoring in MonitorMemory - initial fix

[GitHub] nifi pull request: NIFI-1668 modified TestProcessorLifecycle to en...

2016-04-04 Thread olegz
GitHub user olegz opened a pull request: https://github.com/apache/nifi/pull/324 NIFI-1668 modified TestProcessorLifecycle to ensure FlowController is… … always shut down You can merge this pull request into a Git repository by running: $ git pull https://github.com/olegz

[GitHub] nifi pull request: NIFI-1636: Print Stacktrace When Unexpected OnT...

2016-04-04 Thread olegz
Github user olegz commented on the pull request: https://github.com/apache/nifi/pull/285#issuecomment-205353808 They were logged at DEBUG only level and that was the issue since you would not be able to see them, but now if there is an error the stack trace will be printed

[GitHub] nifi pull request: NIFI-1701 fixed StreamScanner, added more tests

2016-04-04 Thread olegz
Github user olegz closed the pull request at: https://github.com/apache/nifi/pull/314 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] nifi pull request: NIFI-1521 Allows use of SSL in AMQP Processor

2016-04-04 Thread olegz
Github user olegz commented on a diff in the pull request: https://github.com/apache/nifi/pull/232#discussion_r58389967 --- Diff: nifi-nar-bundles/nifi-amqp-bundle/nifi-amqp-processors/src/main/java/org/apache/nifi/amqp/processors/AbstractAMQPProcessor.java --- @@ -191,6 +201,14

[GitHub] nifi pull request: NIFI-1701 fixed StreamScanner, added more tests

2016-03-30 Thread olegz
GitHub user olegz opened a pull request: https://github.com/apache/nifi/pull/314 NIFI-1701 fixed StreamScanner, added more tests You can merge this pull request into a Git repository by running: $ git pull https://github.com/olegz/nifi NIFI-1701 Alternatively you can review

[GitHub] nifi pull request: NIFI-1686 - NiFi is unable to populate over 1/4...

2016-03-29 Thread olegz
Github user olegz commented on the pull request: https://github.com/apache/nifi/pull/305#issuecomment-202872584 @steveyh25 I am ok with NFE. Actually if you do some research it appears to behave a bit better then other approaches that may look better on the surface. I've

[GitHub] nifi pull request: NIFI-1684-B fixed ZKClient connection leak

2016-03-28 Thread olegz
GitHub user olegz opened a pull request: https://github.com/apache/nifi/pull/308 NIFI-1684-B fixed ZKClient connection leak You can merge this pull request into a Git repository by running: $ git pull https://github.com/olegz/nifi tmp Alternatively you can review and apply

[GitHub] nifi pull request: NIFI-1686 - NiFi is unable to populate over 1/4...

2016-03-28 Thread olegz
Github user olegz commented on the pull request: https://github.com/apache/nifi/pull/305#issuecomment-202407396 @trkurc yep, that's the plan once we figure it out --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] nifi pull request: NIFI-1686 - NiFi is unable to populate over 1/4...

2016-03-27 Thread olegz
Github user olegz commented on the pull request: https://github.com/apache/nifi/pull/305#issuecomment-202140044 @steveyh25 yes --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] nifi pull request: NIFI-1686 - NiFi is unable to populate over 1/4...

2016-03-27 Thread olegz
Github user olegz commented on the pull request: https://github.com/apache/nifi/pull/305#issuecomment-202126065 @steveyh25 ping me at 'oleg at hortonworks' for the ide part. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub

[GitHub] nifi pull request: NIFI-1686 - NiFi is unable to populate over 1/4...

2016-03-27 Thread olegz
Github user olegz commented on the pull request: https://github.com/apache/nifi/pull/305#issuecomment-202107378 @steveyh25 Don't sweat it on the tone remark. All good here, just wanted to mention it as some may be more sensitive then others ;) --- If your project is set up

[GitHub] nifi pull request: NIFI-1686 - NiFi is unable to populate over 1/4...

2016-03-27 Thread olegz
Github user olegz commented on a diff in the pull request: https://github.com/apache/nifi/pull/305#discussion_r57531819 --- Diff: nifi-nar-bundles/nifi-amqp-bundle/nifi-amqp-processors/src/main/java/org/apache/nifi/amqp/processors/PublishAMQP.java --- @@ -195,29 +193,85 @@ public

[GitHub] nifi pull request: NIFI-1686 - NiFi is unable to populate over 1/4...

2016-03-27 Thread olegz
Github user olegz commented on a diff in the pull request: https://github.com/apache/nifi/pull/305#discussion_r57530817 --- Diff: nifi-nar-bundles/nifi-amqp-bundle/nifi-amqp-processors/src/main/java/org/apache/nifi/amqp/processors/PublishAMQP.java --- @@ -195,29 +193,85 @@ public

[GitHub] nifi pull request: NIFI-1686 - NiFi is unable to populate over 1/4...

2016-03-27 Thread olegz
Github user olegz commented on a diff in the pull request: https://github.com/apache/nifi/pull/305#discussion_r57530762 --- Diff: nifi-nar-bundles/nifi-amqp-bundle/nifi-amqp-processors/src/main/java/org/apache/nifi/amqp/processors/PublishAMQP.java --- @@ -195,29 +193,85 @@ public

[GitHub] nifi pull request: NIFI-1686 - NiFi is unable to populate over 1/4...

2016-03-27 Thread olegz
Github user olegz commented on a diff in the pull request: https://github.com/apache/nifi/pull/305#discussion_r57530736 --- Diff: nifi-nar-bundles/nifi-amqp-bundle/nifi-amqp-processors/src/main/java/org/apache/nifi/amqp/processors/PublishAMQP.java --- @@ -195,29 +193,85 @@ public

[GitHub] nifi pull request: NIFI-1686 - NiFi is unable to populate over 1/4...

2016-03-27 Thread olegz
Github user olegz commented on a diff in the pull request: https://github.com/apache/nifi/pull/305#discussion_r57530690 --- Diff: nifi-nar-bundles/nifi-amqp-bundle/nifi-amqp-processors/src/main/java/org/apache/nifi/amqp/processors/PublishAMQP.java --- @@ -195,29 +193,85 @@ public

[GitHub] nifi pull request: NIFI-1686 - NiFi is unable to populate over 1/4...

2016-03-27 Thread olegz
Github user olegz commented on a diff in the pull request: https://github.com/apache/nifi/pull/305#discussion_r57530669 --- Diff: nifi-nar-bundles/nifi-amqp-bundle/nifi-amqp-processors/src/main/java/org/apache/nifi/amqp/processors/AMQPUtils.java --- @@ -43,16 +41,48

[GitHub] nifi pull request: NIFI-1684 fixed NPE, added tests

2016-03-24 Thread olegz
GitHub user olegz opened a pull request: https://github.com/apache/nifi/pull/302 NIFI-1684 fixed NPE, added tests You can merge this pull request into a Git repository by running: $ git pull https://github.com/olegz/nifi NIFI-1684 Alternatively you can review and apply

[GitHub] nifi pull request: NIFI-1537 Added SNMP processors

2016-03-24 Thread olegz
Github user olegz commented on the pull request: https://github.com/apache/nifi/pull/257#issuecomment-200797003 @michalklempa @pvillard31 thank you both for the input. Will be reviewing and testing. --- If your project is set up for it, you can reply to this email and have your

[GitHub] nifi pull request: NIFI-1537 Added SNMP processors

2016-03-23 Thread olegz
Github user olegz commented on the pull request: https://github.com/apache/nifi/pull/257#issuecomment-200559586 Pierre You may want to rebase (merge conflicts) and push again since it's out of sink. Also, aside from unit tests would you mind giving some pointers on how

[GitHub] nifi pull request: NIFI-1636: Print Stacktrace When Unepected OnTr...

2016-03-23 Thread olegz
Github user olegz commented on the pull request: https://github.com/apache/nifi/pull/285#issuecomment-200557606 Also, you may want to amend the commit message "Unepected" unless its a new English word I haven't learned yet ;) --- If your project is set up for it, you

[GitHub] nifi pull request: NIFI-1636: Print Stacktrace When Unepected OnTr...

2016-03-23 Thread olegz
Github user olegz commented on the pull request: https://github.com/apache/nifi/pull/285#issuecomment-200557146 Ricky Could you please take a look at https://issues.apache.org/jira/browse/NIFI-1447 and see if it's what you are looking for? If I remember correctly we don't

[GitHub] nifi pull request: NIFI-1645 refactored PutKafka

2016-03-22 Thread olegz
Github user olegz commented on a diff in the pull request: https://github.com/apache/nifi/pull/295#discussion_r57103757 --- Diff: nifi-nar-bundles/nifi-kafka-bundle/nifi-kafka-processors/src/main/java/org/apache/nifi/processors/kafka/PutKafka.java --- @@ -371,11 +371,12

[GitHub] nifi pull request: NIFI-1645 refactored PutKafka

2016-03-22 Thread olegz
Github user olegz commented on a diff in the pull request: https://github.com/apache/nifi/pull/295#discussion_r57040700 --- Diff: nifi-nar-bundles/nifi-kafka-bundle/nifi-kafka-processors/src/main/java/org/apache/nifi/processors/kafka/Partitioners.java --- @@ -0,0 +1,87

[GitHub] nifi pull request: NIFI-1665 fixed GetKafka to reset consumer in c...

2016-03-22 Thread olegz
GitHub user olegz opened a pull request: https://github.com/apache/nifi/pull/296 NIFI-1665 fixed GetKafka to reset consumer in case of timeout You can merge this pull request into a Git repository by running: $ git pull https://github.com/olegz/nifi NIFI-1665 Alternatively

[GitHub] nifi pull request: NIFI-1645 refactored PutKafka

2016-03-22 Thread olegz
GitHub user olegz opened a pull request: https://github.com/apache/nifi/pull/295 NIFI-1645 refactored PutKafka - used newest API available in 0.8.* version - added PutKafka integration tests - Kafka module code coverage is at 85% NIFI-1645 polishing You can merge

[GitHub] nifi pull request: NIFI-1571 initial commit of SpringContext suppo...

2016-03-20 Thread olegz
Github user olegz commented on a diff in the pull request: https://github.com/apache/nifi/pull/271#discussion_r56446641 --- Diff: nifi-nar-bundles/nifi-spring-bundle/nifi-spring-processors/src/main/java/org/apache/nifi/spring/SpringContextProcessor.java --- @@ -0,0 +1,392

[GitHub] nifi pull request: NIFI-1647 fixed validators and config resolutio...

2016-03-19 Thread olegz
GitHub user olegz opened a pull request: https://github.com/apache/nifi/pull/288 NIFI-1647 fixed validators and config resolution You can merge this pull request into a Git repository by running: $ git pull https://github.com/olegz/nifi NIFI-1647 Alternatively you can review

[GitHub] nifi pull request: NIFI-1464 removed e.printStackTrace() from onTr...

2016-03-19 Thread olegz
GitHub user olegz opened a pull request: https://github.com/apache/nifi/pull/287 NIFI-1464 removed e.printStackTrace() from onTrigger in StandarProces… …sScheduler You can merge this pull request into a Git repository by running: $ git pull https://github.com/olegz/nifi

[GitHub] nifi pull request: NIFI-1571 initial commit of SpringContext suppo...

2016-03-19 Thread olegz
Github user olegz commented on the pull request: https://github.com/apache/nifi/pull/271#issuecomment-198126926 Also, the Camel example was added for testing here https://github.com/olegz/si-demo .@PuspenduBanerjee if/when you get a chance please check it out. --- If your project

[GitHub] nifi pull request: NIFI-1571 initial commit of SpringContext suppo...

2016-03-19 Thread olegz
Github user olegz commented on a diff in the pull request: https://github.com/apache/nifi/pull/271#discussion_r56445529 --- Diff: nifi-nar-bundles/nifi-spring-bundle/nifi-spring-processors/src/main/java/org/apache/nifi/spring/SpringContextProcessor.java --- @@ -0,0 +1,392

[GitHub] nifi pull request: NIFI-1631 increased timeouts on test

2016-03-19 Thread olegz
GitHub user olegz opened a pull request: https://github.com/apache/nifi/pull/283 NIFI-1631 increased timeouts on test You can merge this pull request into a Git repository by running: $ git pull https://github.com/olegz/nifi NIFI-1631 Alternatively you can review and apply

[GitHub] nifi pull request: NIFI-1571 initial commit of SpringContext suppo...

2016-03-19 Thread olegz
Github user olegz commented on a diff in the pull request: https://github.com/apache/nifi/pull/271#discussion_r56446521 --- Diff: nifi-nar-bundles/nifi-spring-bundle/nifi-spring-processors/src/main/java/org/apache/nifi/spring/SpringContextProcessor.java --- @@ -0,0 +1,392

[GitHub] nifi pull request: NIFI-1571 initial commit of SpringContext suppo...

2016-03-18 Thread olegz
Github user olegz commented on the pull request: https://github.com/apache/nifi/pull/271#issuecomment-197434936 @trkurc you can use the simple app here: https://github.com/olegz/si-demo. It has some initial docs and is ready to be used as is after 'mvn clean install', but you can

[GitHub] nifi pull request: NIFI-1571 initial commit of SpringContext suppo...

2016-03-15 Thread olegz
Github user olegz commented on the pull request: https://github.com/apache/nifi/pull/271#issuecomment-197121747 @trkurc Without knowing how much spring experience you have it's hard to say, but I do have a sample app which I use for testing that I can push to my github and you

[GitHub] nifi pull request: NIFI-901: Add QueryCassandra and PutCassandraQL...

2016-03-15 Thread olegz
Github user olegz commented on a diff in the pull request: https://github.com/apache/nifi/pull/237#discussion_r56216735 --- Diff: nifi-nar-bundles/nifi-cassandra-bundle/nifi-cassandra-processors/src/main/java/org/apache/nifi/processors/cassandra/PutCassandraQL.java --- @@ -0,0

<    1   2   3   4   5   >