Re: Nuttx Code Formatter Progress [Was RE: Should we relax precheck a little bit?]

sday, March 17, 2020 12:10 PM > *To:* David Sidrane > *Cc:* dev@nuttx.apache.org > *Subject:* Re: Nuttx Code Formatter Progress [Was RE: Should we relax > precheck a little bit?] > > > > David, > > > > Yes, I agree that it would be great if we can upstream t

Re: Nuttx Code Formatter Progress [Was RE: Should we relax precheck a little bit?]

Re: # indenting. I am not sure I understand your comments about this. Are the NuttX Style Guide sections on indenting correct? If so, we can probably add clang-format options to support this style. If not, can we co

RE: Nuttx Code Formatter Progress [Was RE: Should we relax precheck a little bit?]

Hi Adam, See inline… *From:* Adam Feuer [mailto:a...@starcat.io] *Sent:* Tuesday, March 17, 2020 12:10 PM *To:* David Sidrane *Cc:* dev@nuttx.apache.org *Subject:* Re: Nuttx Code Formatter Progress [Was RE: Should we relax precheck a little bit?] David, Yes, I agree that it would be

Re: Nuttx Code Formatter Progress [Was RE: Should we relax precheck a little bit?]

ater. > > > > David > > > > > > > > *From:* Adam Feuer [mailto:a...@starcat.io] > *Sent:* Monday, March 16, 2020 3:35 PM > *To:* David Sidrane; dev@nuttx.apache.org > *Subject:* Re: Nuttx Code Formatter Progress [Was RE: Should we relax > precheck a

RE: Nuttx Code Formatter Progress [Was RE: Should we relax precheck a little bit?]

be much, much greater. David *From:* Adam Feuer [mailto:a...@starcat.io] *Sent:* Monday, March 16, 2020 3:35 PM *To:* David Sidrane; dev@nuttx.apache.org *Subject:* Re: Nuttx Code Formatter Progress [Was RE: Should we relax precheck a little bit?] Here's a Github compare with .clang-f

Re: Nuttx Code Formatter Progress [Was RE: Should we relax precheck a little bit?]

Yes, it may be horrible. Please don't look at the results right now then... this is a work in progress. Okay.  Thanks for clarifying that.  nxstyle is still your friend.

Re: Nuttx Code Formatter Progress [Was RE: Should we relax precheck a little bit?]

 ...  It is simply not following the NuttX coding standard. Perhaps what you should do is also run the modified files through nxstyle.  nxstyle, like most tools, is imperfect but it is the yardstick we use to evaluating conformance to the coding standard now.  Certainly a first step would b

Re: Nuttx Code Formatter Progress [Was RE: Should we relax precheck a little bit?]

Hi Greg, Yes, it may be horrible. Please don't look at the results right now then... this is a work in progress. I'm just trying to do the development and coordination in the open, as the Apache folks have asked— no off-list communication, right? I just posted these so David and others could eas

Re: Nuttx Code Formatter Progress [Was RE: Should we relax precheck a little bit?]

I mentioned in the previous email that the tools was screwing up vertifcal alignment is places where it is recommend and in places where is it required.  Here is an example of the later: * sched/irq/irq.h

Re: Nuttx Code Formatter Progress [Was RE: Should we relax precheck a little bit?]

Here's a Github compare with .clang-format file and the results when clang-format-9 is run on all the files under sched/: https://github.com/apache/incubator-nuttx/compare/master...starcat-io:explore/clang-format-sched If anyone has comments or observations I would love to know them. That is

Re: Nuttx Code Formatter Progress [Was RE: Should we relax precheck a little bit?]

;> David >> >> >> >> *From:* Adam Feuer [mailto:a...@starcat.io] >> *Sent:* Saturday, March 14, 2020 1:59 PM >> *To:* dev@nuttx.apache.org; david.sidr...@nscdg.com; w8j...@gmail.com >> *Subject:* Re: Nuttx Code Formatter Progress [Was RE: Should we relax >

Re: Nuttx Code Formatter Progress [Was RE: Should we relax precheck a little bit?]

e spent > on nstyle, as it is a "shorter haul" with a much, much greater return. > > > > David > > > > *From:* Adam Feuer [mailto:a...@starcat.io] > *Sent:* Saturday, March 14, 2020 1:59 PM > *To:* dev@nuttx.apache.org; david.sidr...@nscdg.com; w8j..

RE: Nuttx Code Formatter Progress [Was RE: Should we relax precheck a little bit?]

d *From:* Adam Feuer [mailto:a...@starcat.io] *Sent:* Saturday, March 14, 2020 1:59 PM *To:* dev@nuttx.apache.org; david.sidr...@nscdg.com; w8j...@gmail.com *Subject:* Re: Nuttx Code Formatter Progress [Was RE: Should we relax precheck a little bit?] I looked at the clang-format source code. It h

Re: Nuttx Code Formatter Progress [Was RE: Should we relax precheck a little bit?]

I looked at the clang-format source code. It has trouble aligning the = of a -= or +=. I easily made a change to align on the - or + of a -= or +=, but some work will be necessary to give an option that aligns the way the nuttx code does it. Will think more about it. -adam On Sat, Mar 14, 2020 a

Re: Nuttx Code Formatter Progress [Was RE: Should we relax precheck a little bit?]

David, Maciej, Peter, Thanks for your help! IndentPPDirectives: PPDIS_AfterHash works. The actual syntax for the .clang-format file is this: IndentPPDirectives: AfterHash That makes things a lot better. There are a bunch of inconsistent macro indents under sched/ though— many macros indent ok,