[jira] Commented: (OFBIZ-3142) Move labels in FindScreenDecorator searchOptions screenlet and search-results screenlet to screenlet title

2009-11-09 Thread Bruno Busco (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-3142?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12774901#action_12774901 ] Bruno Busco commented on OFBIZ-3142: And we should also consider that when the Search

[jira] Commented: (OFBIZ-3142) Move labels in FindScreenDecorator searchOptions screenlet and search-results screenlet to screenlet title

2009-11-09 Thread Anil K Patel (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-3142?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12774903#action_12774903 ] Anil K Patel commented on OFBIZ-3142: - I agree with Bruno, this collapsed thing was on

[jira] Commented: (OFBIZ-3142) Move labels in FindScreenDecorator searchOptions screenlet and search-results screenlet to screenlet title

2009-11-09 Thread Jacques Le Roux (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-3142?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12774904#action_12774904 ] Jacques Le Roux commented on OFBIZ-3142: Thanks Anil, Select Action and Run will

[jira] Commented: (OFBIZ-3142) Move labels in FindScreenDecorator searchOptions screenlet and search-results screenlet to screenlet title

2009-11-09 Thread Anil K Patel (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-3142?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12774907#action_12774907 ] Anil K Patel commented on OFBIZ-3142: - yes, they should, I am using it and have not

[jira] Commented: (OFBIZ-3176) Collapsible Field Groups with clickable title

2009-11-09 Thread Bruno Busco (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-3176?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12774908#action_12774908 ] Bruno Busco commented on OFBIZ-3176: Thank you Deepak, fixed in trunk at revision:

[jira] Commented: (OFBIZ-3176) Collapsible Field Groups with clickable title

2009-11-09 Thread Deepak Dixit (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-3176?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12774918#action_12774918 ] Deepak Dixit commented on OFBIZ-3176: - Thanks Bruno. Collapsible Field Groups with

[jira] Reopened: (OFBIZ-3175) The icon used for accessing the lookups should be defined by the theme

2009-11-09 Thread Hans Bakker (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-3175?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Hans Bakker reopened OFBIZ-3175: lookup image hiding behing the related field in the flatgrey theme The icon used for accessing the

[jira] Updated: (OFBIZ-3175) The icon used for accessing the lookups should be defined by the theme

2009-11-09 Thread Hans Bakker (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-3175?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Hans Bakker updated OFBIZ-3175: --- Attachment: Screenshot.png The icon used for accessing the lookups should be defined by the theme

[jira] Closed: (OFBIZ-3175) The icon used for accessing the lookups should be defined by the theme

2009-11-09 Thread Hans Bakker (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-3175?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Hans Bakker closed OFBIZ-3175. -- Resolution: Fixed never mind, browser cache problem sorry for the noise Regards, Hans The

Re: lookup image hiding behing the related field in the flatgrey theme

2009-11-09 Thread Jacques Le Roux
Please Hans use https://issues.apache.org/jira/browse/OFBIZ-3176 Jacques From: Hans Bakker mailingl...@antwebsystems.com see subject and attached screen dump(small so hopefully it shows) -- http://www.antwebsystems.com : Quality OFBiz support for competitive rates --

Re: lookup image hiding behing the related field in the flatgrey theme

2009-11-09 Thread Jacques Le Roux
Was 3175 but it's already done anyway Jacques From: Jacques Le Roux jacques.le.r...@les7arts.com Please Hans use https://issues.apache.org/jira/browse/OFBIZ-3176 Jacques From: Hans Bakker mailingl...@antwebsystems.com see subject and attached screen dump(small so hopefully it

How about birt?

2009-11-09 Thread Chatree Srichart
Hello! community... How about birt component? Can it be committed to trunk?

[jira] Commented: (OFBIZ-3165) Add additional screen for gift card certificate buying functionality by CSR in Order manager application in add item page

2009-11-09 Thread Ashish Vijaywargiya (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-3165?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12774953#action_12774953 ] Ashish Vijaywargiya commented on OFBIZ-3165: Improved version is in trunk at

[jira] Commented: (OFBIZ-3177) Total amount invoice is incorrect after generating from order

2009-11-09 Thread Willem Janssen (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-3177?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12774954#action_12774954 ] Willem Janssen commented on OFBIZ-3177: --- Hello Sumit, I could reproduce it in the

[jira] Closed: (OFBIZ-3165) Add additional screen for gift card certificate buying functionality by CSR in Order manager application in add item page

2009-11-09 Thread Divesh Dutta (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-3165?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Divesh Dutta closed OFBIZ-3165. --- All the issues related to this task is in trunk now and working properly. So closing this issue now.

[jira] Resolved: (OFBIZ-3165) Add additional screen for gift card certificate buying functionality by CSR in Order manager application in add item page

2009-11-09 Thread Divesh Dutta (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-3165?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Divesh Dutta resolved OFBIZ-3165. - Resolution: Fixed Thanks Ashish for committing my patch. Resolving this issue as this issue is

[jira] Updated: (OFBIZ-3173) Better supportability for products of type MARKETING_PKG_AUTO in order processing and fulfillment process.

2009-11-09 Thread Divesh Dutta (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-3173?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Divesh Dutta updated OFBIZ-3173: Attachment: OFBiz-3173.patch Here is the updated patch with resolved conflicts on file

Typo in framework/service/build.xml

2009-11-09 Thread Ashish Vijaywargiya
Line # 73. jar jarfile=${build.dir}/lib/${name}-rmi.raj The extension will be jar IMO. -- Ashish

Re: pagination problem

2009-11-09 Thread Bruno Busco
Hi Matthieu, I did a quick check on #1. There is something wrong because the div class=screenlet-title-bar shouldn't be contained in a div class=screenlet-body tag but it should always be like this: div class=screenlet div class=screenlet-title-bar /div div class=screenlet-body /div

Re: Typo in framework/service/build.xml

2009-11-09 Thread Jacques Le Roux
Hi Ashish, http://markmail.org/message/jw3kgabwfym5ljqz Jacques From: Ashish Vijaywargiya vijaywargiya.ash...@gmail.com Line # 73. jar jarfile=${build.dir}/lib/${name}-rmi.raj The extension will be jar IMO. -- Ashish

Re: Typo in framework/service/build.xml

2009-11-09 Thread Ashish Vijaywargiya
Thanks for the link Jacques. Sorry to bother you guys :-). -- Ashish On Mon, Nov 9, 2009 at 8:12 PM, Jacques Le Roux jacques.le.r...@les7arts.com wrote: Hi Ashish, http://markmail.org/message/jw3kgabwfym5ljqz Jacques From: Ashish Vijaywargiya vijaywargiya.ash...@gmail.com Line # 73.

[jira] Created: (OFBIZ-3178) error with stock move and reservation with quantity not available

2009-11-09 Thread Albert Mayo (JIRA)
error with stock move and reservation with quantity not available - Key: OFBIZ-3178 URL: https://issues.apache.org/jira/browse/OFBIZ-3178 Project: OFBiz Issue Type: Bug

[jira] Created: (OFBIZ-3179) visual bug

2009-11-09 Thread matthieu bollot (JIRA)
visual bug -- Key: OFBIZ-3179 URL: https://issues.apache.org/jira/browse/OFBIZ-3179 Project: OFBiz Issue Type: Bug Components: order Affects Versions: SVN trunk Reporter: matthieu bollot In

[jira] Created: (OFBIZ-3180) SagePay payment gateway integrated

2009-11-09 Thread Abdullah Shaikh (JIRA)
SagePay payment gateway integrated -- Key: OFBIZ-3180 URL: https://issues.apache.org/jira/browse/OFBIZ-3180 Project: OFBiz Issue Type: New Feature Components: accounting Reporter:

[jira] Updated: (OFBIZ-3180) SagePay payment gateway integrated

2009-11-09 Thread Abdullah Shaikh (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-3180?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Abdullah Shaikh updated OFBIZ-3180: --- Attachment: httpcore-4.0.1.jar httpclient-4.0.jar

[jira] Updated: (OFBIZ-3180) SagePay payment gateway integrated

2009-11-09 Thread Abdullah Shaikh (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-3180?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Abdullah Shaikh updated OFBIZ-3180: --- Attachment: jcip-annotations-1.0.jar SagePay payment gateway integrated

[jira] Commented: (OFBIZ-3179) visual bug

2009-11-09 Thread Jacques Le Roux (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-3179?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12775022#action_12775022 ] Jacques Le Roux commented on OFBIZ-3179: This depends on theme,isn'it ? visual

[jira] Commented: (OFBIZ-3179) visual bug

2009-11-09 Thread matthieu bollot (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-3179?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12775028#action_12775028 ] matthieu bollot commented on OFBIZ-3179: Actually, it appears badly only on the

[jira] Commented: (OFBIZ-3179) visual bug

2009-11-09 Thread Jacques Le Roux (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-3179?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12775063#action_12775063 ] Jacques Le Roux commented on OFBIZ-3179: Hi Matthieu, Have you a patch ? visual

Question about CachedClassLoader

2009-11-09 Thread Adrian Crum
I noticed the CachedClassLoader uses HashMaps and HashSets instead of the Javolution classes. Is there any reason for that? It seems to me the Javolution classes would help speed up class loading. -Adrian

Re: Question about CachedClassLoader

2009-11-09 Thread David E Jones
It could be related to having null keys, which the Javolution classes don't allow (you'll get an NPE). -David On Nov 9, 2009, at 12:11 PM, Adrian Crum wrote: I noticed the CachedClassLoader uses HashMaps and HashSets instead of the Javolution classes. Is there any reason for that? It

[jira] Assigned: (OFBIZ-3179) visual bug

2009-11-09 Thread Bruno Busco (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-3179?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bruno Busco reassigned OFBIZ-3179: -- Assignee: Bruno Busco visual bug -- Key: OFBIZ-3179

[jira] Closed: (OFBIZ-3179) visual bug

2009-11-09 Thread Bruno Busco (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-3179?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bruno Busco closed OFBIZ-3179. -- Resolution: Fixed Thank you for reporting Matthieu, fixed in trunk At revision: 834221 visual bug

0.00 String

2009-11-09 Thread Jacques Le Roux
Hi, I notice that we have number of 0.00 strings harcoded. I think we should introduce a parameter for that in Arithmetic properties Something like default.decimals.string=0.00 A client of mine (POS) wanted to use only 1 decimal and I had to harcode them, I'd like to generalize. What do you

[jira] Commented: (OFBIZ-3180) SagePay payment gateway integrated

2009-11-09 Thread Jacques Le Roux (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-3180?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12775148#action_12775148 ] Jacques Le Roux commented on OFBIZ-3180: Thanks Abdullah, Very cursory review :

[jira] Commented: (OFBIZ-3180) SagePay payment gateway integrated

2009-11-09 Thread Jacques Le Roux (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-3180?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12775150#action_12775150 ] Jacques Le Roux commented on OFBIZ-3180: I'd just put a white space between if and

Re: 0.00 String

2009-11-09 Thread Scott Gray
Hi Jacques, I think it should be irrelevant whether a BigDecimal is initialized as 0, 0.00 or 0.000 because all number should be rounded if needed before being presented in the UI anyway. Assuming that it was currency that your Client wanted 1 decimal place for, wasn't the number

Re: 0.00 String

2009-11-09 Thread Jacques Le Roux
Yes, I agree that's why I asked. However these strings are *intialized* to 0.00 or '0.00 is a ternary ? default and, as they are default, used if no formatted values replace them. At least in POS Receipt.java[472] Operator.java[104] But there are other similar cases outside of POS, look for

Re: 0.00 String

2009-11-09 Thread Scott Gray
Yes there may well be issues with formatting not being applied in various places but I think it is those which should be fixed rather than adding a property. My preference for BigDecimal initialization would be to use BigDecimal.ZERO. Regards Scott On 10/11/2009, at 10:30 AM, Jacques Le

Re: 0.00 String

2009-11-09 Thread Jacques Le Roux
Scott, It's a bit complicated for snippet like // get the selected amount String selectedAmountStr = 0.00; if (paramMap.containsKey(ADD_AMOUNT)) { selectedAmountStr = (String) paramMap.remove(ADD_AMOUNT); } else if (paramMap.containsKey(add_amount)) { selectedAmountStr = (String)

Re: 0.00 String

2009-11-09 Thread Scott Gray
See r834274 Regards Scott On 10/11/2009, at 11:47 AM, Jacques Le Roux wrote: Scott, It's a bit complicated for snippet like // get the selected amount String selectedAmountStr = 0.00; if (paramMap.containsKey(ADD_AMOUNT)) { selectedAmountStr = (String) paramMap.remove(ADD_AMOUNT); } else

Re: 0.00 String

2009-11-09 Thread Jacques Le Roux
Thanks Scott, It's not the same cases I have to deal with (it's only and alway strings), but I agree it's the way. We should do this kind of thing for all other cases also (I will handle POS cases tomorrow) Jacques From: Scott Gray scott.g...@hotwaxmedia.com See r834274 Regards Scott On

[jira] Updated: (OFBIZ-2219) Special feature to allow submitting patches for online help update

2009-11-09 Thread Sharan Foga (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-2219?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sharan Foga updated OFBIZ-2219: --- Attachment: (was: OFBIZ-2219_DocbookAccountingHelp7.patch) Special feature to allow submitting

[jira] Updated: (OFBIZ-2219) Special feature to allow submitting patches for online help update

2009-11-09 Thread Sharan Foga (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-2219?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sharan Foga updated OFBIZ-2219: --- Attachment: OFBIZ-2219_DocbookHRHelp1.patch Hi Hans This is my second try at doing the HR Help fix

[jira] Commented: (OFBIZ-2219) Special feature to allow submitting patches for online help update

2009-11-09 Thread Hans Bakker (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-2219?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12775264#action_12775264 ] Hans Bakker commented on OFBIZ-2219: Hi Sharan, always check the patch file itself

ADAM, SCOTT and others who feel strong (+/-) about adding BIRT to the trunk.

2009-11-09 Thread Hans Bakker
Can you please have a look at the branch: https://svn.apache.org/repos/asf/ofbiz/branches/addbirt we would like to add it to the trunk, Birt is now a separate framework component and could speedup reporting significantly. to look at the the changes in this branch look at the following url:

Re: ADAM, SCOTT and others who feel strong (+/-) about adding BIRT to the trunk.

2009-11-09 Thread Scott Gray
Hi Hans I haven't looked at the branch and I know nothing about birt but I do have some questions: Other than the branch itself is there any documentation about this component, how it works and what it acheives? How does it relate to the existing BI component? Is it going to make

[jira] Commented: (OFBIZ-3180) SagePay payment gateway integrated

2009-11-09 Thread Abdullah Shaikh (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-3180?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12775303#action_12775303 ] Abdullah Shaikh commented on OFBIZ-3180: Thanks Jacques for the review, apart from

extra Birt information (also answers Scott questions)

2009-11-09 Thread Hans Bakker
Some general info about Birt. - This function can be separated in a runtime part and a development part The runtime part we want to put in the framework so the reports which can be developed in Eclipse can be run in OFBiz as an ofbiz report and can be used in any