sonar analysis on ASF servers

2011-05-06 Thread Erwan de FERRIERES
Hi fellow devs, we've been trying to make sonar analysis working on the ASF servers for OFBiz. For this, there is first a configuration to make on Hudson, and we've got some problems there, because of an already used port. Do you think this would be possible to change the 8080 port when runni

Re: Discussion: REST support in OFBiz

2011-05-06 Thread Adrian Crum
I respect that, but looking at it from a newcomer's perspective, I would expect all request mappings to be in the same file. I will think about it more. Thanks for the feedback! -Adrian On 5/6/2011 8:11 PM, Scott Gray wrote: I guess maybe I'm a controller purist as well? The current controll

Re: Discussion: REST support in OFBiz

2011-05-06 Thread Scott Gray
I guess maybe I'm a controller purist as well? The current controller and RequestHandler class pair are built specifically to handle a certain type of request and I'd be a little concerned about increasing the complexity of how to use it. And again my same concern about setting a precedent app

Re: Discussion: REST support in OFBiz

2011-05-06 Thread Adrian Crum
Thanks Scott! I agree with that. We could have a controller.xml element that the current servlet ignores and the REST servlet scoops up. Until something like Moqui is in the project, I think mapping a REST request URL to a service will be a good place to start. That would satisfy the immediate

Re: Discussion: REST support in OFBiz

2011-05-06 Thread Scott Gray
My first feeling in response to modifying the service definition with REST related elements/attributes was that of a purist and I guess I still feel that way, a line needs to be drawn somewhere or next we'll have SOAP-specific bits along with anything else someone wants to jam in there once the

Re: Discussion: REST support in OFBiz

2011-05-06 Thread Adrian Crum
One last thing about this... The idea of adding a REST element to the service definition was based on convenience, but some service engine "purists" might believe that it doesn't belong there. An alternative would be to put the element in a separate file that maps REST requests to services, bu

Re: Discussion: REST support in OFBiz

2011-05-06 Thread Adrian Crum
Round pegs could be considered POSTs, so maybe it's POSTing round pegs in square holes... -Adrian On 5/6/2011 2:14 PM, David E Jones wrote: Yes, POST semantics are more flexible in some ways in that it implies that the resource in the message is added (created) under the location specified, a

Re: Discussion: REST support in OFBiz

2011-05-06 Thread David E Jones
Yes, POST semantics are more flexible in some ways in that it implies that the resource in the message is added (created) under the location specified, and because of this it supports sending multiple resources to be added there. In theory there could already be something under the location wit

Re: Discussion: REST support in OFBiz

2011-05-06 Thread Adrian Crum
Thanks David! I was thinking we would need a servlet for this - because some of the REST semantics are in the HTTP headers as well as in the HTTP method. From what I've read, the generally accepted convention is that POST is a create operation, and PUT is an update operation. But I agree with

Re: Discussion: REST support in OFBiz

2011-05-06 Thread David E Jones
One bit of documentation I like that shows clearly how the RESTful services are defined and what the messages look like is the Adility API docs, such as this one: http://apidoc.adility.com/submission-api The nice thing (and actually many RESTful API docs do this) is that they list each "servi

[jira] [Commented] (OFBIZ-4256) after session timeout, ajax popup dialogbox shows ofbiz login screen

2011-05-06 Thread Sascha Rodekamp (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-4256?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13030032#comment-13030032 ] Sascha Rodekamp commented on OFBIZ-4256: The information comes from the request he

Re: Discussion: REST support in OFBiz

2011-05-06 Thread Adrian Crum
Here is the Amazon REST API - it could be a good source of ideas for implementation: http://docs.amazonwebservices.com/AmazonS3/latest/dev/index.html?RESTAPI.html -Adrian On 5/6/2011 7:33 AM, Jacques Le Roux wrote: After having read the response hyperlinks article I tend to agree with Adrian.

Re: Discussion: REST support in OFBiz

2011-05-06 Thread Jacques Le Roux
After having read the response hyperlinks article I tend to agree with Adrian. HATEOAS seems to me a really important feature of REST I have still to read completly the 1st article Adrian mentionned though. I mean http://www.infoq.com/articles/rest-introduction And yes I also prefer response-hy

[jira] [Commented] (OFBIZ-4256) after session timeout, ajax popup dialogbox shows ofbiz login screen

2011-05-06 Thread Adrian Crum (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-4256?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13029948#comment-13029948 ] Adrian Crum commented on OFBIZ-4256: How does the request handler know that a request

Re: Discussion: REST support in OFBiz

2011-05-06 Thread Adrian Crum
I don't like the idea of adding attributes to the existing service element because we still need a way to specify response hyperlinks (HATEOAS), plus I imagine other sub-elements and additional attributes will be needed as we build it out more. I prefer to keep the attribute names similar to t

[jira] [Issue Comment Edited] (OFBIZ-4243) Caching is used by org.ofbiz.webapp.control.ProtectViewWorker(line 68) for UserLoginAndProtectedView (since changeset r1075350), but the view has set never-c

2011-05-06 Thread Jacques Le Roux (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-4243?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13029924#comment-13029924 ] Jacques Le Roux edited comment on OFBIZ-4243 at 5/6/11 1:23 PM:

[jira] [Updated] (OFBIZ-4270) State dropdown only finds states and does not include county information

2011-05-06 Thread Sascha Rodekamp (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-4270?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sascha Rodekamp updated OFBIZ-4270: --- Attachment: OFBIZ-4270-DependentDropdown.patch Hi Jacques, Hi Sam, i modified the getAssoci

[jira] [Closed] (OFBIZ-4243) Caching is used by org.ofbiz.webapp.control.ProtectViewWorker(line 68) for UserLoginAndProtectedView (since changeset r1075350), but the view has set never-cache="true"

2011-05-06 Thread Jacques Le Roux (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-4243?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jacques Le Roux closed OFBIZ-4243. -- Resolution: Fixed Fix Version/s: SVN trunk Fixed at r1100197, thankd for report Jonas!

[jira] [Assigned] (OFBIZ-4243) Caching is used by org.ofbiz.webapp.control.ProtectViewWorker(line 68) for UserLoginAndProtectedView (since changeset r1075350), but the view has set never-cache="true"

2011-05-06 Thread Jacques Le Roux (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-4243?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jacques Le Roux reassigned OFBIZ-4243: -- Assignee: Jacques Le Roux > Caching is used by org.ofbiz.webapp.control.ProtectViewWork

[jira] [Updated] (OFBIZ-4256) after session timeout, ajax popup dialogbox shows ofbiz login screen

2011-05-06 Thread Sascha Rodekamp (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-4256?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sascha Rodekamp updated OFBIZ-4256: --- Attachment: OFBIZ-4256_ajaxtimeoutfix.patch Hi Adrian, i created a patch for this issue. It w

Re: Discussion: REST support in OFBiz

2011-05-06 Thread Raj Saini
Jacques, I am working on a prototype and let you know my findings. Thanks, Raj On Friday 06 May 2011 03:31 PM, Jacques Le Roux wrote: IIRW CXF uses Java annotations, is this not limiting us (simple-methods)? Raj did you think about an engine part of CXF to include in OFBiz? Jacques From: "A

Re: Discussion: REST support in OFBiz

2011-05-06 Thread Jacques Le Roux
IIRW CXF uses Java annotations, is this not limiting us (simple-methods)? Raj did you think about an engine part of CXF to include in OFBiz? Jacques From: "Adrian Crum" Raj, How do you picture Apache CXF being used in OFBiz? How would we map REST requests to OFBiz services using CXF? -Adri

Re: FYI, I have added "Release Branch 11.04" inside Manage version section of jira

2011-05-06 Thread Ashish Vijaywargiya
Thanks Jacopo. :-) -- Ashish On Fri, May 6, 2011 at 3:04 PM, Jacopo Cappellato < jacopo.cappell...@hotwaxmedia.com> wrote: > Thank you. > I have also added a few more versions for the official releases. > > Jacopo > > On May 6, 2011, at 8:18 AM, Ashish Vijaywargiya wrote: > > > Hello, > > > > I

Re: FYI, I have added "Release Branch 11.04" inside Manage version section of jira

2011-05-06 Thread Jacopo Cappellato
Thank you. I have also added a few more versions for the official releases. Jacopo On May 6, 2011, at 8:18 AM, Ashish Vijaywargiya wrote: > Hello, > > I have added 'Release Branch 11.04" entry inside manage versions section. > Now while creating jira issue anyone can select "Release Branch 11.0

Re: Discussion: REST support in OFBiz

2011-05-06 Thread Jacopo Cappellato
What about adding the "noun" and "verb" attributes to the "service" element? BTW in order to write a good application I suspect that a lot of services should be refactored to better fit into a REST based application. A good candidate for a prototype could be the Webtools' "Entity Data Maintenance

[jira] [Commented] (OFBIZ-4208) Product page meta-tag does not contain i18n content

2011-05-06 Thread Jacques Le Roux (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-4208?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13029861#comment-13029861 ] Jacques Le Roux commented on OFBIZ-4208: Hi Carsten, Did you get a chance to upda

[jira] [Closed] (OFBIZ-4244) EditCategory.ftl is missing a "screenlet-body"-part showing the summery of an image-upload.

2011-05-06 Thread Jacques Le Roux (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-4244?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jacques Le Roux closed OFBIZ-4244. -- Resolution: Fixed Assignee: Jacques Le Roux Thanks Andreas, Your patch is in trunk at r1

[jira] [Reopened] (OFBIZ-4239) The framework/base tests fail

2011-05-06 Thread Jacques Le Roux (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-4239?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jacques Le Roux reopened OFBIZ-4239: There is actually still an issue there > The framework/base tests fail > -

[jira] [Commented] (OFBIZ-4195) Minor Improvement of german Labels

2011-05-06 Thread Jacques Le Roux (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-4195?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13029853#comment-13029853 ] Jacques Le Roux commented on OFBIZ-4195: Should we not close? > Minor Improvement

[jira] [Closed] (OFBIZ-4248) Balancesheet dynamic labels & dutch translation accounting labels

2011-05-06 Thread Jacques Le Roux (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-4248?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jacques Le Roux closed OFBIZ-4248. -- Resolution: Fixed Assignee: Jacques Le Roux Thanks Willem, Your patch is in trunk at r11

[jira] [Issue Comment Edited] (OFBIZ-4268) ResourceBundleMapWrapper memory usage improvement

2011-05-06 Thread Jacques Le Roux (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-4268?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13029828#comment-13029828 ] Jacques Le Roux edited comment on OFBIZ-4268 at 5/6/11 8:54 AM:

[jira] [Closed] (OFBIZ-4268) ResourceBundleMapWrapper memory usage improvement

2011-05-06 Thread Jacques Le Roux (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-4268?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jacques Le Roux closed OFBIZ-4268. -- Resolution: Fixed Fix Version/s: SVN trunk Thanks Philippe, Your patch is in trunk at r

[jira] [Reopened] (OFBIZ-4268) ResourceBundleMapWrapper memory usage improvement

2011-05-06 Thread Jacques Le Roux (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-4268?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jacques Le Roux reopened OFBIZ-4268: Arg, closed by error, always this Cancel button :/ > ResourceBundleMapWrapper memory usage im

[jira] [Closed] (OFBIZ-4268) ResourceBundleMapWrapper memory usage improvement

2011-05-06 Thread Jacques Le Roux (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-4268?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jacques Le Roux closed OFBIZ-4268. -- Resolution: Fixed > ResourceBundleMapWrapper memory usage improvement > ---