I think that most of the code has been copied from here:
https://bitbucket.org/bkumar/spring-groovy-console/overview
I couldn't find a clear License and at this point, also considering that the
shell is disabled by default and (I suspect) not used much, I think we should
revert this commit.
I think we should complete the migration from bsh scripts: to groovy: scripts
and then we could remove the Beanshell specific code and jars from the trunk.
What do you think?
Jacopo
On Apr 5, 2013, at 10:11 AM, Adrian Crum adrian.c...@sandglass-software.com
wrote:
Oh! Thanks for the
I think the only bsh: scriptlets left are in the screen widgets. Also, I
think the use-when attribute uses bsh. So I would need to take a look
at it.
But yes, this task should be completed. We've been talking about it for
years.
-Adrian
On 4/6/2013 9:18 AM, Jacopo Cappellato wrote:
I
Hi Jacopo,
As you can see in the Jira, I ecked the jars were respectively under ASL2 and
BSD.
But indeed, in the 3 GroovyShell*.java, I saw only the 1st part which says it's
ASL2. I did not notice the last line , nor the line Copyright 2007 Bruce
Fancher. Which makes any sense to me. If it's
+1, if we find enough time to do so
Jacques
From: Jacopo Cappellato jacopo.cappell...@hotwaxmedia.com
I think we should complete the migration from bsh scripts: to groovy: scripts
and then we could remove the Beanshell specific code and jars from the trunk.
What do you think?
Jacopo
On
The ASL 2 license permits a copyright line. In fact their example
includes one.
-Adrian
On 4/6/2013 10:06 AM, Jacques Le Roux wrote:
Hi Jacopo,
As you can see in the Jira, I ecked the jars were respectively under ASL2 and
BSD.
But indeed, in the 3 GroovyShell*.java, I saw only the 1st part
What I am saying is that the risk is that the ASL2 header has been added to
files that were not released under the ASL2.
Jacopo
On Apr 6, 2013, at 11:11 AM, Adrian Crum adrian.c...@sandglass-software.com
wrote:
The ASL 2 license permits a copyright line. In fact their example includes
one.
Okay, I understand now. Thank you for the clarification.
-Adrian
On 4/6/2013 10:12 AM, Jacopo Cappellato wrote:
What I am saying is that the risk is that the ASL2 header has been added to
files that were not released under the ASL2.
Jacopo
On Apr 6, 2013, at 11:11 AM, Adrian Crum
[
https://issues.apache.org/jira/browse/OFBIZ-5170?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Adrian Crum updated OFBIZ-5170:
---
Attachment: HotSpotSettings.PNG
Attached a screenshot of the profiler settings. Profiling is limited
[
https://issues.apache.org/jira/browse/OFBIZ-5170?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Adrian Crum updated OFBIZ-5170:
---
Attachment: HotSpots_Rev_1464779.csv
Attached the control Hot Spots file.
Notice the
Hi Adrian,
Thanks for asking, I committed and commented at revision: 1465223
Atul,
It was not easy to read your patch in the email (cut at 80 chars). Please open
a Jira if you want to improve my commit.
Thanks
Jacques
From: Adrian Crum adrian.c...@sandglass-software.com
Jacques,
What
Jacques,
Thanks. I will do it soon.
On Sat, 06 Apr 2013 16:30:30 +0530, Jacques Le Roux
jacques.le.r...@les7arts.com wrote:
Hi Adrian,
Thanks for asking, I committed and commented at revision: 1465223
Atul,
It was not easy to read your patch in the email (cut at 80 chars).
Please
for birt -1
regards,
Hans
On 04/05/2013 09:52 PM, Jacopo Cappellato wrote:
We have recently discussed the idea of keeping all the specialpurpose components in the
trunk, remove them from future release branches (starting with 13.04 that will probably
still contain the ecommerce component
Please don't change the timing logging - there should not be any
conditions placed on it.
You didn't answer my question. I was hoping we could avoid a commit war
by discussing your requirements and designing a solution that makes
everyone happy.
-Adrian
On 4/6/2013 12:00 PM, Jacques Le
I have removed the code in rev. 1465254
Jacopo
On Apr 6, 2013, at 11:16 AM, Adrian Crum adrian.c...@sandglass-software.com
wrote:
Okay, I understand now. Thank you for the clarification.
-Adrian
On 4/6/2013 10:12 AM, Jacopo Cappellato wrote:
What I am saying is that the risk is that
In revision 1465250 I have disabled crowd.
Good news Hans: this time it didn't require much of my work and I was able to
save the birt component by copying to it the old Axis 1 jars (in rev. 1465252);
so we can keep it enabled and it will still compile and run even if the
framework is no more
[
https://issues.apache.org/jira/browse/OFBIZ-5170?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13624431#comment-13624431
]
Adrian Crum commented on OFBIZ-5170:
Before I settled on the final profiling
[
https://issues.apache.org/jira/browse/OFBIZ-5170?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13624431#comment-13624431
]
Adrian Crum edited comment on OFBIZ-5170 at 4/6/13 3:06 PM:
As I mentioned a few times, I am concerned about the amount of jar files
bundled in OFBiz: there are so many and some of them are really old and,
because of dependencies and the lack of proper documentation (we did not a good
job in keeping track of what we have, from where it comes and how it
Try removing the el-api-2.2.jar file and see what happens.
-Adrian
On 4/6/2013 4:14 PM, Jacopo Cappellato wrote:
As I mentioned a few times, I am concerned about the amount of jar files
bundled in OFBiz: there are so many and some of them are really old and,
because of dependencies and the
yeah... logging (and IO in general) are very time consuming tasks and can
dramatically affect load and performance of production instances under heavy
load.
Jacopo
On Apr 6, 2013, at 5:07 PM, Adrian Crum (JIRA) j...@apache.org wrote:
Adrian Crum edited comment on OFBIZ-5170 at 4/6/13 3:06
All tests passed successfully after I removed it (as I was suspecting).
Should we move juel-2.2.1.jar to the j2eespecs folder? Do you have some details
from where the juel-2.2.1.jar comes and from where we should take the updates?
Thanks!
Jacopo
On Apr 6, 2013, at 5:19 PM, Adrian Crum
I thought the commit comment answered your question
OOTB, there is only 1 change from what you committed: now services longer than
1 sec will also show as slow in log
Jacques
From: Adrian Crum adrian.c...@sandglass-software.com
Please don't change the timing logging - there should not be any
Jacopo,
For this commit and when crowd will be removed, I believe we shoult put a note
in the Attic page
https://cwiki.apache.org/confluence/display/OFBADMIN/OFBiz+Attic
Thanks
Jacques
From: jaco...@apache.org
Author: jacopoc
Date: Sat Apr 6 14:48:10 2013
New Revision: 1465254
URL:
Done now:
https://cwiki.apache.org/confluence/display/OFBADMIN/OFBiz+Attic#OFBizAttic-GroovyShell
Jacopo
On Apr 6, 2013, at 6:37 PM, Jacques Le Roux jacques.le.r...@les7arts.com
wrote:
Jacopo,
For this commit and when crowd will be removed, I believe we shoult put a
note in the Attic
This is now done in rev. 1465283
I don't know how to test it but it should work just fine.
Jacopo
On Apr 3, 2013, at 9:17 AM, Jacques Le Roux jacques.le.r...@les7arts.com
wrote:
I see no problems with that, as long as it's tested and work maybe?
Jacques
From: Jacopo Cappellato
this is now done in rev. 1465276 and it should work as before the migration.
@Medhat: the appserver component is used to automatically generate scripts to
deploy OFBiz to other non default application servers.
Jacopo
On Apr 3, 2013, at 9:21 AM, Jacques Le Roux jacques.le.r...@les7arts.com
The Buildbot has detected a new failure on builder ofbiz-trunk while building
ASF Buildbot.
Full details are available at:
http://ci.apache.org/builders/ofbiz-trunk/builds/3665
Buildbot URL: http://ci.apache.org/
Buildslave for this Build: portunus_ubuntu
Build Reason: scheduler
Build Source
According to Jacopo clarification, i agree with this move.
Thank u Jacopo for your clarification.
Regards,
Medhat
On Sat, Apr 6, 2013 at 8:09 PM, Jacopo Cappellato
jacopo.cappell...@hotwaxmedia.com wrote:
this is now done in rev. 1465276 and it should work as before the
migration.
No, a commit is NOT a reply to an email.
Please, let's discuss this. You seem to be forcing your perception of
how logging should be done on the rest of the community. I would prefer
that we all participate in a discussion and come up with a design that
works for everyone.
-Adrian
On
+1
Medhat
On Fri, Apr 5, 2013 at 4:52 PM, Jacopo Cappellato
jacopo.cappell...@hotwaxmedia.com wrote:
We have recently discussed the idea of keeping all the specialpurpose
components in the trunk, remove them from future release branches (starting
with 13.04 that will probably still contain
Here's what I think, it's all raw though :)
* As suggested by Jacopo, we maintain stats in some kind of entity. Let's
say average running time.
* We use this average running time to decide if a timing log should be
printed. The thing is, not all services are same, some are complex and are
32 matches
Mail list logo
