[jira] [Updated] (OFBIZ-4953) Order item status change issue.

2013-07-05 Thread Deepak Dixit (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-4953?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Deepak Dixit updated OFBIZ-4953: Attachment: Updated-OFBIZ-4953-Trunk.patch Updated-OFBIZ-4953-R11.04-R12.04.patch

[jira] [Commented] (OFBIZ-4913) Application Menu items should be link not hidden form.

2013-07-05 Thread Deepak Dixit (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-4913?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13700472#comment-13700472 ] Deepak Dixit commented on OFBIZ-4913: - ping... Application Menu

[jira] [Assigned] (OFBIZ-4913) Application Menu items should be link not hidden form.

2013-07-05 Thread Jacques Le Roux (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-4913?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jacques Le Roux reassigned OFBIZ-4913: -- Assignee: Jacques Le Roux Application Menu items should be link not hidden form.

[jira] [Commented] (OFBIZ-4913) Application Menu items should be link not hidden form.

2013-07-05 Thread Jacques Le Roux (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-4913?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13700489#comment-13700489 ] Jacques Le Roux commented on OFBIZ-4913: Thanks Deepak, Your trunked patch is in

[jira] [Commented] (OFBIZ-5202) upload content at party profile is not working

2013-07-05 Thread Jacques Le Roux (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-5202?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13700507#comment-13700507 ] Jacques Le Roux commented on OFBIZ-5202: I guess it's a conflict for this specific

[jira] [Commented] (OFBIZ-4913) Application Menu items should be link not hidden form.

2013-07-05 Thread Deepak Dixit (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-4913?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13700510#comment-13700510 ] Deepak Dixit commented on OFBIZ-4913: - Thanks Jacques. -- Deepak Dixit

[jira] [Updated] (OFBIZ-5202) upload content at party profile is not working

2013-07-05 Thread Petr Pytelka (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-5202?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Petr Pytelka updated OFBIZ-5202: Attachment: UploadFail-12.04.patch Details in comment upload content at party

[jira] [Commented] (OFBIZ-5202) upload content at party profile is not working

2013-07-05 Thread Petr Pytelka (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-5202?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13700514#comment-13700514 ] Petr Pytelka commented on OFBIZ-5202: - Hello, I've tried to investigate what is the

[jira] [Commented] (OFBIZ-5202) upload content at party profile is not working

2013-07-05 Thread Petr Pytelka (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-5202?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13700545#comment-13700545 ] Petr Pytelka commented on OFBIZ-5202: - One more addition: If I start Ofbiz with demo

[jira] [Commented] (OFBIZ-5202) upload content at party profile is not working

2013-07-05 Thread Jacques Le Roux (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-5202?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13700558#comment-13700558 ] Jacques Le Roux commented on OFBIZ-5202: Thanks Petr, Your last statement is the

[jira] [Commented] (OFBIZ-5202) upload content at party profile is not working

2013-07-05 Thread Petr Pytelka (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-5202?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13700561#comment-13700561 ] Petr Pytelka commented on OFBIZ-5202: - It sounds as a good solution. Thak you for your

Re: svn commit: r1499918 - in /ofbiz/trunk/applications: marketing/widget/sfa/SfaMenus.xml order/widget/ordermgr/OrderMenus.xml

2013-07-05 Thread Adrian Crum
This doesn't make sense. Why are those two menu items exceptions to the rule? -Adrian On 7/5/2013 7:57 AM, jler...@apache.org wrote: Author: jleroux Date: Fri Jul 5 06:57:03 2013 New Revision: 1499918 URL: http://svn.apache.org/r1499918 Log: A patch from Deepak Dixit for Application Menu

Re: svn commit: r1499918 - in /ofbiz/trunk/applications: marketing/widget/sfa/SfaMenus.xml order/widget/ordermgr/OrderMenus.xml

2013-07-05 Thread Deepak Dixit
Hi Adrian, These controller request has event, and if an request event attribute is not null then WidgetWorker.determineAutoLinkType() return hidden-form as link type and its create an empty form for the same. WidgetWorker method convert hyper links to hidden for for service type of event as

Re: svn commit: r1499927 - /ofbiz/trunk/applications/accounting/widget/GlSetupScreens.xml

2013-07-05 Thread Adrian Crum
Please don't do this. Screenlets are used to divide sections of a screen in a multi-purpose screen. This screen appears to have a single purpose. https://cwiki.apache.org/confluence/display/OFBADMIN/User+Interface+Layout+Best+Practices -Adrian On 7/5/2013 9:04 AM, hans...@apache.org wrote:

Re: svn commit: r1499918 - in /ofbiz/trunk/applications: marketing/widget/sfa/SfaMenus.xml order/widget/ordermgr/OrderMenus.xml

2013-07-05 Thread Adrian Crum
On 7/5/2013 12:19 PM, Deepak Dixit wrote: Hi Adrian, These controller request has event, and if an request event attribute is not null then WidgetWorker.determineAutoLinkType() return hidden-form as link type and its create an empty form for the same. WidgetWorker method convert hyper links

Re: svn commit: r1499918 - in /ofbiz/trunk/applications: marketing/widget/sfa/SfaMenus.xml order/widget/ordermgr/OrderMenus.xml

2013-07-05 Thread Adrian Crum
That doesn't answer my question. Why are only two requests being changed? What makes those two requests the exception to all other requests that include an event? -Adrian On 7/5/2013 12:19 PM, Deepak Dixit wrote: Hi Adrian, These controller request has event, and if an request event

Re: svn commit: r1499927 - /ofbiz/trunk/applications/accounting/widget/GlSetupScreens.xml

2013-07-05 Thread Hans Bakker
to make the screen layout consistent to: https://localhost:8443/accounting/control/ListCompanies https://localhost:8443/accounting/control/globalGLSettings https://localhost:8443/accounting/control/editInvoiceItemType https://localhost:8443/accounting/control/editPaymentMethodType

Re: svn commit: r1499927 - /ofbiz/trunk/applications/accounting/widget/GlSetupScreens.xml

2013-07-05 Thread Adrian Crum
Making screens consistent is a good idea, but please make them consistent with GOOD layouts, not with BAD layouts. Please follow the best practices. https://localhost:8443/accounting/control/EditFixedAsset -Adrian On 7/5/2013 12:46 PM, Hans Bakker wrote: to make the screen layout consistent

Re: svn commit: r1499927 - /ofbiz/trunk/applications/accounting/widget/GlSetupScreens.xml

2013-07-05 Thread Hans Bakker
I am sorry Adrian, this is not a pretty screen, https://localhost:8443/accounting/control/EditFixedAsset i prefer the screen with a screenlet as really many, many others. I would like to change your screen too :-) Regards, Hans On 07/05/2013 06:49 PM, Adrian Crum wrote: Making screens

Re: svn commit: r1499918 - in /ofbiz/trunk/applications: marketing/widget/sfa/SfaMenus.xml order/widget/ordermgr/OrderMenus.xml

2013-07-05 Thread Deepak Dixit
I found these reported request :) All the request with event attribute will be render in same way and create hidden form. Thanks Regards -- Deepak Dixit On Jul 5, 2013, at 5:04 PM, Adrian Crum wrote: That doesn't answer my question. Why are only two requests being changed? What makes

Re: svn commit: r1499927 - /ofbiz/trunk/applications/accounting/widget/GlSetupScreens.xml

2013-07-05 Thread Scott Gray
Pretty is irrelevant Hans, it's about document structure. It's pointless wrapping everything in a screenlet or we may as well not even have the widget in the first place and have it embedded in the decorator instead. Using bad layouts as a justification for more of them is silly. Regards

Re: svn commit: r1499918 - in /ofbiz/trunk/applications: marketing/widget/sfa/SfaMenus.xml order/widget/ordermgr/OrderMenus.xml

2013-07-05 Thread Jacques Le Roux
Yes I wondered about that also, but, from his assertion, thought Deepak checked all others Deepak? Jacques From: Adrian Crum adrian.c...@sandglass-software.com That doesn't answer my question. Why are only two requests being changed? What makes those two requests the exception to all other

[jira] [Commented] (OFBIZ-4291) No method to remove a promo code from the shopping cart

2013-07-05 Thread Nandani Aggarwal (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-4291?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13701053#comment-13701053 ] Nandani Aggarwal commented on OFBIZ-4291: - Hello Ankit, I tried your patch to

Re: svn commit: r1499927 - /ofbiz/trunk/applications/accounting/widget/GlSetupScreens.xml

2013-07-05 Thread Adrian Crum
If you want to change the layout best practices, then that is fine - but we need to discuss it first. The current best practices were agreed upon the last time we had this discussion. If you would like to propose something else, then go ahead. When we have a consensus, then we can update the

[jira] [Commented] (OFBIZ-4291) No method to remove a promo code from the shopping cart

2013-07-05 Thread Jacques Le Roux (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-4291?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13701128#comment-13701128 ] Jacques Le Roux commented on OFBIZ-4291: Nandani, It's only about promo codes

Re: svn commit: r1499927 - /ofbiz/trunk/applications/accounting/widget/GlSetupScreens.xml

2013-07-05 Thread Hans Bakker
Adrian, Scott, there is not a single screen that I am aware of in accounting, which is following this so called standard. (where is that documented anyway?) In my view, consistency is much more important, so i followed the current pattern used in accounting. Regards, Hans On 07/06/2013

Re: svn commit: r1499927 - /ofbiz/trunk/applications/accounting/widget/GlSetupScreens.xml

2013-07-05 Thread Hans Bakker
Before you jump in again: I stand corrected: only the fixed asset function is using it, pretty inconsistent if you look to the rest of accounting. Regards, Hans On 07/06/2013 07:16 AM, Hans Bakker wrote: Adrian, Scott, there is not a single screen that I am aware of in accounting, which

[jira] [Created] (OFBIZ-5256) allow a value in the view relation definition

2013-07-05 Thread Hans Bakker (JIRA)
Hans Bakker created OFBIZ-5256: -- Summary: allow a value in the view relation definition Key: OFBIZ-5256 URL: https://issues.apache.org/jira/browse/OFBIZ-5256 Project: OFBiz Issue Type: Bug

[jira] [Updated] (OFBIZ-5256) allow a value in the view relation definition

2013-07-05 Thread Hans Bakker (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-5256?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Hans Bakker updated OFBIZ-5256: --- Attachment: value.diff the patch implementing this Jira allow a value in the view

[jira] [Updated] (OFBIZ-5256) allow a value in the view relation definition

2013-07-05 Thread Hans Bakker (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-5256?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Hans Bakker updated OFBIZ-5256: --- Description: I need help from our framework experts. I want to copy invoices from an ofbiz system

Re: svn commit: r1499927 - /ofbiz/trunk/applications/accounting/widget/GlSetupScreens.xml

2013-07-05 Thread Adrian Crum
The screens used to be consistent until some committers decided to start wrapping all screens in screenlets. As we said, you are copying the wrong layout. If you want consistency, then copy the right layout. -Adrian On 7/6/2013 1:16 AM, Hans Bakker wrote: Adrian, Scott, there is not a

[jira] [Commented] (OFBIZ-4291) No method to remove a promo code from the shopping cart

2013-07-05 Thread Nandani Aggarwal (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-4291?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13701254#comment-13701254 ] Nandani Aggarwal commented on OFBIZ-4291: - Hello , Thanks for reply. A promotion