[jira] [Commented] (OFBIZ-7896) Order: Remove inline js for toggleAll, checkToggle and selectAll calling from ftls.

2016-07-18 Thread Amardeep Singh Jhajj (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-7896?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15383660#comment-15383660 ] Amardeep Singh Jhajj commented on OFBIZ-7896: - Steps to test it: Test selectA

Re: Proposal to modify the testing framework for OFBiz

2016-07-18 Thread Taher Alkhateeb
Hi Scott, Well spoken thank you. Okay may I suggest that for any such work we will discuss it here see its Merit and if it makes sense then we take it in. It is a little early to discuss it right now because we did not yet go to the higher-level components. Once we do I'll be sure to have a conver

[jira] [Commented] (OFBIZ-7896) Order: Remove inline js for toggleAll, checkToggle and selectAll calling from ftls.

2016-07-18 Thread Amardeep Singh Jhajj (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-7896?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15383641#comment-15383641 ] Amardeep Singh Jhajj commented on OFBIZ-7896: - Please find attached patch for

[jira] [Commented] (OFBIZ-7720) Write one generic functionality for select all checkbox by removing currently written multiple fuctionality

2016-07-18 Thread Amardeep Singh Jhajj (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-7720?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15383637#comment-15383637 ] Amardeep Singh Jhajj commented on OFBIZ-7720: - Please find attached patch for

[jira] [Updated] (OFBIZ-7896) Order: Remove inline js for toggleAll, checkToggle and selectAll calling from ftls.

2016-07-18 Thread Amardeep Singh Jhajj (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-7896?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Amardeep Singh Jhajj updated OFBIZ-7896: Attachment: OFBIZ-7896.patch > Order: Remove inline js for toggleAll, checkToggle an

Re: Proposal to modify the testing framework for OFBiz

2016-07-18 Thread Scott Gray
Yeah I'm sure unit tests probably worked well for the start component given it is the lowest level component in the system and closest to a basic java app. I just think the value proposition might decrease the further up the stack we move with them. I'm not against unit tests when they prove usef

Re: Proposal to modify the testing framework for OFBiz

2016-07-18 Thread Taher Alkhateeb
Hi Scott, Thank you for the feedback. To be focused exactly on integration vs unit, I already mentioned above that at least for me the main objective is to confidently and quickly run the tests in short bursts of red-green refactor. This allows me to refactor code without waiting in front of the s

Re: Proposal to modify the testing framework for OFBiz

2016-07-18 Thread Scott Gray
Thanks Ron and Taher for your responses, I appreciate them but I don't hear much in the conversation that speaks to the value of unit tests over integration tests. Most of the thoughts shared speaks more to the value of tests rather than differences in the type of tests. Speed: At an application

[jira] [Commented] (OFBIZ-7365) fonts.pdf Throw error on terminal

2016-07-18 Thread Deepak Dixit (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-7365?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15383578#comment-15383578 ] Deepak Dixit commented on OFBIZ-7365: - Its working fine, Error is related to "Broken P

Re: Proposal to modify the testing framework for OFBiz

2016-07-18 Thread Taher Alkhateeb
Hi Scott, Thank you for your input. Your ideas are thought provoking and enriching to the conversation. The way I look at it, the general rule is usually many unit tests, less integration tests, lesser functional tests. So we are not excluding any types of test, all of them are important in certa

Re: Temporary change for filling the "Fix Versions/s" field in Jira

2016-07-18 Thread Deepak Dixit
Thanks Jacques for update. Thanks & Regards -- Deepak Dixit www.hotwaxsystems.com On Mon, Jul 18, 2016 at 9:46 PM, Jacques Le Roux < jacques.le.r...@les7arts.com> wrote: > Hi Committer, Devs, All, > > You might have noticed I Temporary changed our policy about filling the > "Fix Versions/s" fiel

Re: Proposal to modify the testing framework for OFBiz

2016-07-18 Thread Ron Wheeler
You are probably right that integration testing has a lot more value. However, unit tests are still useful in their own right and may encourage people to write smaller classes that can be tested easily. As you point out, integration testing can be done at several levels with mock implementatio

Re: Proposal to modify the testing framework for OFBiz

2016-07-18 Thread Scott Gray
I know I'm late to the party here, but I just want to say that I think integration tests have far greater value to OFBiz than unit tests. Mostly because we tend to have quite a low number of tests and integration tests give us much better coverage per line of test code and the tests are much close

Re: Proposal to modify the testing framework for OFBiz

2016-07-18 Thread Hans Bakker
great initiative Taher, finally someone who values automated tests to enable TDD but also leading to continuous improvement and finally continuous deployment Regards, Hans Bakker CEO AntWebsystems.com On 18/07/16 12:06, Taher Alkhateeb wrote: Hello Everyone, In reference to this thread a

Re: svn commit: r1752972 - in /ofbiz/trunk/applications: accounting/config/AccountingUiLabels.xml order/template/return/QuickReturn.ftl party/template/party/EditGiftCard.ftl party/template/party/profi

2016-07-18 Thread Jacques Le Roux
At least, AccountingCreateNewCreditCard was used in ReturnForms.xml Jacques Le 18/07/2016 à 21:45, Michael Brohl a écrit : HI Vikas, the comments in Jira https://issues.apache.org/jira/browse/OFBIZ-7707 say that these labels are obsolete, have you checked this? Regards, Michael Brohl ecomi

Re: svn commit: r1752972 - in /ofbiz/trunk/applications: accounting/config/AccountingUiLabels.xml order/template/return/QuickReturn.ftl party/template/party/EditGiftCard.ftl party/template/party/profi

2016-07-18 Thread Michael Brohl
HI Vikas, the comments in Jira https://issues.apache.org/jira/browse/OFBIZ-7707 say that these labels are obsolete, have you checked this? Regards, Michael Brohl ecomify GmbH www.ecomify.de Am 18.07.16 um 20:24 schrieb Vikas Mayur: Just for a cosmetic and trivial (JIRA issue indicates that

Re: svn commit: r1752972 - in /ofbiz/trunk/applications: accounting/config/AccountingUiLabels.xml order/template/return/QuickReturn.ftl party/template/party/EditGiftCard.ftl party/template/party/profi

2016-07-18 Thread Vikas Mayur
Just for a cosmetic and trivial (JIRA issue indicates that) change loosing the translation to 15 odd languages, is it desirable? It might be years effort to have the label defined in those languages. Regards Vikas On Sat, Jul 16, 2016 at 9:22 AM, wrote: > Author: pranayp > Date: Sat Jul 16 14:

[jira] [Commented] (OFBIZ-7897) Introduce unit tests to the start component

2016-07-18 Thread Taher Alkhateeb (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-7897?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15382735#comment-15382735 ] Taher Alkhateeb commented on OFBIZ-7897: Also a small comment, a very nice test re

[jira] [Closed] (OFBIZ-7254) provide a new unit testing framework for OFBiz

2016-07-18 Thread Taher Alkhateeb (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-7254?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Taher Alkhateeb closed OFBIZ-7254. -- Resolution: Fixed Already 8 unit tests are introduced to the framework and working properly in

[jira] [Created] (OFBIZ-7899) createDataResource will sometimes fail when uploading Excel documents due to missing libraries

2016-07-18 Thread Forrest Rae (JIRA)
Forrest Rae created OFBIZ-7899: -- Summary: createDataResource will sometimes fail when uploading Excel documents due to missing libraries Key: OFBIZ-7899 URL: https://issues.apache.org/jira/browse/OFBIZ-7899

[jira] [Comment Edited] (OFBIZ-1463) JUnit test case for various application components

2016-07-18 Thread Taher Alkhateeb (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-1463?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15382667#comment-15382667 ] Taher Alkhateeb edited comment on OFBIZ-1463 at 7/18/16 5:33 PM: ---

[jira] [Commented] (OFBIZ-1463) JUnit test case for various application components

2016-07-18 Thread Taher Alkhateeb (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-1463?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15382667#comment-15382667 ] Taher Alkhateeb commented on OFBIZ-1463: Hello everyone, I've introduced unit test

[jira] [Comment Edited] (OFBIZ-1463) JUnit test case for various application components

2016-07-18 Thread Taher Alkhateeb (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-1463?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15382667#comment-15382667 ] Taher Alkhateeb edited comment on OFBIZ-1463 at 7/18/16 5:33 PM: ---

[jira] [Commented] (OFBIZ-7897) Introduce unit tests to the start component

2016-07-18 Thread Taher Alkhateeb (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-7897?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15382663#comment-15382663 ] Taher Alkhateeb commented on OFBIZ-7897: Committed the first batch of unit tests (

[jira] [Commented] (OFBIZ-7365) fonts.pdf Throw error on terminal

2016-07-18 Thread Jacques Le Roux (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-7365?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15382648#comment-15382648 ] Jacques Le Roux commented on OFBIZ-7365: Hi Vaibhav, can you still reproduce local

[jira] [Created] (OFBIZ-7898) Create a (short term) Gradle "cleanAnt" task to remove old build dirs

2016-07-18 Thread Jacques Le Roux (JIRA)
Jacques Le Roux created OFBIZ-7898: -- Summary: Create a (short term) Gradle "cleanAnt" task to remove old build dirs Key: OFBIZ-7898 URL: https://issues.apache.org/jira/browse/OFBIZ-7898 Project: OFBi

[jira] [Updated] (OFBIZ-7897) Introduce unit tests to the start component

2016-07-18 Thread Taher Alkhateeb (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-7897?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Taher Alkhateeb updated OFBIZ-7897: --- Summary: Introduce unit tests to the start component (was: Introduce unit tests to the startu

[jira] [Created] (OFBIZ-7897) Introduce unit tests to the startup component

2016-07-18 Thread Taher Alkhateeb (JIRA)
Taher Alkhateeb created OFBIZ-7897: -- Summary: Introduce unit tests to the startup component Key: OFBIZ-7897 URL: https://issues.apache.org/jira/browse/OFBIZ-7897 Project: OFBiz Issue Type: S

[jira] [Updated] (OFBIZ-7815) OFBiz secured background process does not work on Windows

2016-07-18 Thread Jacques Le Roux (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-7815?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jacques Le Roux updated OFBIZ-7815: --- Issue Type: Sub-task (was: Bug) Parent: OFBIZ-7534 > OFBiz secured background process

Temporary change for filling the "Fix Versions/s" field in Jira

2016-07-18 Thread Jacques Le Roux
Hi Committer, Devs, All, You might have noticed I Temporary changed our policy about filling the "Fix Versions/s" field in Jira Please read https://cwiki.apache.org/confluence/pages/diffpagesbyversion.action?pageId=7766050&selectedPageVersions=46&selectedPageVersions=45 Thanks Jacques

[jira] [Comment Edited] (OFBIZ-1463) JUnit test case for various application components

2016-07-18 Thread Pierre Smits (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-1463?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15382301#comment-15382301 ] Pierre Smits edited comment on OFBIZ-1463 at 7/18/16 1:56 PM: --

[jira] [Commented] (OFBIZ-1463) JUnit test case for various application components

2016-07-18 Thread Pierre Smits (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-1463?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15382301#comment-15382301 ] Pierre Smits commented on OFBIZ-1463: - We all know trunk can be a volatile branch and

[jira] [Updated] (OFBIZ-7895) ebay : Remove unused imports from groovy files.

2016-07-18 Thread Ankit Joshi (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-7895?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ankit Joshi updated OFBIZ-7895: --- Attachment: OFBIZ-7895-trunk.patch Attached the patch to remove unused imports for code optimization p

[jira] [Updated] (OFBIZ-7895) ebay : Remove unused imports from groovy files.

2016-07-18 Thread Ankit Joshi (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-7895?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ankit Joshi updated OFBIZ-7895: --- Assignee: (was: Ankit Joshi) > ebay : Remove unused imports from groovy files. > -

[jira] [Created] (OFBIZ-7896) Order: Remove inline js for toggleAll, checkToggle and selectAll calling from ftls.

2016-07-18 Thread Amardeep Singh Jhajj (JIRA)
Amardeep Singh Jhajj created OFBIZ-7896: --- Summary: Order: Remove inline js for toggleAll, checkToggle and selectAll calling from ftls. Key: OFBIZ-7896 URL: https://issues.apache.org/jira/browse/OFBIZ-7896

[jira] [Created] (OFBIZ-7895) ebay : Remove unused imports from groovy files.

2016-07-18 Thread Ankit Joshi (JIRA)
Ankit Joshi created OFBIZ-7895: -- Summary: ebay : Remove unused imports from groovy files. Key: OFBIZ-7895 URL: https://issues.apache.org/jira/browse/OFBIZ-7895 Project: OFBiz Issue Type: Sub-tas

[jira] [Updated] (OFBIZ-7720) Write one generic functionality for select all checkbox by removing currently written multiple fuctionality

2016-07-18 Thread Amardeep Singh Jhajj (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-7720?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Amardeep Singh Jhajj updated OFBIZ-7720: Attachment: OFBIZ-7720.patch > Write one generic functionality for select all checkb

[jira] [Commented] (OFBIZ-1463) JUnit test case for various application components

2016-07-18 Thread Taher Alkhateeb (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-1463?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15382269#comment-15382269 ] Taher Alkhateeb commented on OFBIZ-1463: Hm, It is certainly doable with gradl

[jira] [Commented] (OFBIZ-1463) JUnit test case for various application components

2016-07-18 Thread Jacques Le Roux (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-1463?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15382248#comment-15382248 ] Jacques Le Roux commented on OFBIZ-1463: I know it's totally out of subject and ce

[jira] [Closed] (OFBIZ-7605) Extend use of Apache IVY re external library management for r13x

2016-07-18 Thread Jacques Le Roux (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-7605?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jacques Le Roux closed OFBIZ-7605. -- Resolution: Not A Problem Assignee: Jacques Le Roux (was: Pierre Smits) No longer a probl

[jira] [Comment Edited] (OFBIZ-5541) Address '.classpath' issue

2016-07-18 Thread Jacques Le Roux (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-5541?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15382235#comment-15382235 ] Jacques Le Roux edited comment on OFBIZ-5541 at 7/18/16 1:02 PM: ---

[jira] [Closed] (OFBIZ-5464) Extend Ivy usage for easier external lib management

2016-07-18 Thread Jacques Le Roux (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-5464?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jacques Le Roux closed OFBIZ-5464. -- Resolution: Not A Problem Assignee: Jacques Le Roux (was: Pierre Smits) No longer a probl

[jira] [Closed] (OFBIZ-7614) Extend use of Apache IVY re external library management for r14x

2016-07-18 Thread Jacques Le Roux (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-7614?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jacques Le Roux closed OFBIZ-7614. -- Resolution: Not A Problem Assignee: Jacques Le Roux No longer a problem since Ivy will not

[jira] [Updated] (OFBIZ-7872) Clean up commented out code in Free Marker Template for Content

2016-07-18 Thread Aman Agrawal (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-7872?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Aman Agrawal updated OFBIZ-7872: Priority: Minor (was: Major) > Clean up commented out code in Free Marker Template for Content > --

[jira] [Created] (OFBIZ-7894) Clean up commented out code in Free Marker Template for Manufacturing

2016-07-18 Thread Aman Agrawal (JIRA)
Aman Agrawal created OFBIZ-7894: --- Summary: Clean up commented out code in Free Marker Template for Manufacturing Key: OFBIZ-7894 URL: https://issues.apache.org/jira/browse/OFBIZ-7894 Project: OFBiz

[jira] [Closed] (OFBIZ-7615) Extend use of Apache IVY re external library management for r15x

2016-07-18 Thread Jacques Le Roux (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-7615?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jacques Le Roux closed OFBIZ-7615. -- Resolution: Not A Problem Assignee: Jacques Le Roux No longer a problem since Ivy will not

[jira] [Comment Edited] (OFBIZ-5465) Address 'LICENCE' doc

2016-07-18 Thread Jacques Le Roux (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-5465?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15382237#comment-15382237 ] Jacques Le Roux edited comment on OFBIZ-5465 at 7/18/16 1:01 PM: ---

[jira] [Comment Edited] (OFBIZ-5466) Address 'NOTICE' doc

2016-07-18 Thread Jacques Le Roux (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-5466?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15382236#comment-15382236 ] Jacques Le Roux edited comment on OFBIZ-5466 at 7/18/16 1:01 PM: ---

[jira] [Comment Edited] (OFBIZ-5541) Address '.classpath' issue

2016-07-18 Thread Jacques Le Roux (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-5541?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15382235#comment-15382235 ] Jacques Le Roux edited comment on OFBIZ-5541 at 7/18/16 1:01 PM: ---

[jira] [Closed] (OFBIZ-5466) Address 'NOTICE' doc

2016-07-18 Thread Jacques Le Roux (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-5466?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jacques Le Roux closed OFBIZ-5466. -- Resolution: Not A Problem No longer a problem since Ivy will not be used bu Gradle > Address 'N

[jira] [Closed] (OFBIZ-5465) Address 'LICENCE' doc

2016-07-18 Thread Jacques Le Roux (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-5465?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jacques Le Roux closed OFBIZ-5465. -- Resolution: Not A Problem No longer a problem since Ivy will not be used bu Gradle > Address 'L

[jira] [Closed] (OFBIZ-5541) Address '.classpath' issue

2016-07-18 Thread Jacques Le Roux (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-5541?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jacques Le Roux closed OFBIZ-5541. -- Resolution: Not A Problem No monger a problem since Ivy will not be used bu Gradle > Address '.

[jira] [Updated] (OFBIZ-7872) Clean up commented out code in Free Marker Template for Content

2016-07-18 Thread Aman Agrawal (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-7872?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Aman Agrawal updated OFBIZ-7872: Attachment: OFBIZ-7872_trunk.patch Patch provided. > Clean up commented out code in Free Marker Tem

[jira] [Updated] (OFBIZ-7752) 'parentCommEventId' is not passed in parameter from edit communication event

2016-07-18 Thread Jacques Le Roux (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-7752?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jacques Le Roux updated OFBIZ-7752: --- Fix Version/s: (was: Upcoming Branch) I finally remove "Upcoming Branch" from the "Fix ver

Re: JackRabbit branch

2016-07-18 Thread Michael Brohl
+1, Jacques Michael Brohl ecomify GmbH www.ecomify.de Am 18.07.16 um 11:17 schrieb Jacques Le Roux: Hi, I believe the JackRabbit branch is now completely unmergeable. I suggest that we archive it in Jira. It adds only confusion there. Same for the the Boostrap theme? I see no problems kee

[jira] [Comment Edited] (OFBIZ-6274) Rename OFBiz artifacts from 'org.ofbiz.*' to org.apache.ofbiz.*'

2016-07-18 Thread Jacques Le Roux (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-6274?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15382163#comment-15382163 ] Jacques Le Roux edited comment on OFBIZ-6274 at 7/18/16 12:05 PM: --

[jira] [Commented] (OFBIZ-6274) Rename OFBiz artifacts from 'org.ofbiz.*' to org.apache.ofbiz.*'

2016-07-18 Thread Jacques Le Roux (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-6274?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15382163#comment-15382163 ] Jacques Le Roux commented on OFBIZ-6274: We also changed the log4j2.xml at r175302

[jira] [Commented] (OFBIZ-7752) 'parentCommEventId' is not passed in parameter from edit communication event

2016-07-18 Thread Jacques Le Roux (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-7752?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15382151#comment-15382151 ] Jacques Le Roux commented on OFBIZ-7752: Done > 'parentCommEventId' is not passed

[jira] [Commented] (OFBIZ-7752) 'parentCommEventId' is not passed in parameter from edit communication event

2016-07-18 Thread Jacques Le Roux (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-7752?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15382149#comment-15382149 ] Jacques Le Roux commented on OFBIZ-7752: Done > 'parentCommEventId' is not passed

Re: JackRabbit branch

2016-07-18 Thread Jacques Le Roux
Done Jacques Le 18/07/2016 à 12:09, Pierre Smits a écrit : Hi Jacques, If that is the case, I don't see any reason to object. Best regards, Pierre Smits ORRTIZ.COM OFBiz based solutions & services OFBiz Extensions Marketplace http://oem.ofbizci.net/oci-2/ On Mon,

[jira] [Updated] (OFBIZ-7893) Rename generated *ofbiz-gradle.jar* to *ofbiz.jar*

2016-07-18 Thread Jacques Le Roux (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-7893?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jacques Le Roux updated OFBIZ-7893: --- Issue Type: Sub-task (was: Improvement) Parent: OFBIZ-7888 > Rename generated *ofbiz-

[jira] [Commented] (OFBIZ-7892) Move *CertKeystore.groovy* to location according to best practice

2016-07-18 Thread Jacques Le Roux (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-7892?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15382038#comment-15382038 ] Jacques Le Roux commented on OFBIZ-7892: Done thanks for the request Pierre > Mov

[jira] [Comment Edited] (OFBIZ-7892) Move *CertKeystore.groovy* to location according to best practice

2016-07-18 Thread Jacques Le Roux (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-7892?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15382038#comment-15382038 ] Jacques Le Roux edited comment on OFBIZ-7892 at 7/18/16 10:14 AM: --

[jira] [Closed] (OFBIZ-7892) Move *CertKeystore.groovy* to location according to best practice

2016-07-18 Thread Jacques Le Roux (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-7892?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jacques Le Roux closed OFBIZ-7892. -- Resolution: Done Fix Version/s: Upcoming Branch > Move *CertKeystore.groovy* to location

Re: JackRabbit branch

2016-07-18 Thread Pierre Smits
Hi Jacques, If that is the case, I don't see any reason to object. Best regards, Pierre Smits ORRTIZ.COM OFBiz based solutions & services OFBiz Extensions Marketplace http://oem.ofbizci.net/oci-2/ On Mon, Jul 18, 2016 at 12:02 PM, Taher Alkhateeb < slidingfilame...@gma

[jira] [Assigned] (OFBIZ-7892) Move *CertKeystore.groovy* to location according to best practice

2016-07-18 Thread Jacques Le Roux (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-7892?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jacques Le Roux reassigned OFBIZ-7892: -- Assignee: Jacques Le Roux > Move *CertKeystore.groovy* to location according to best pr

[jira] [Commented] (OFBIZ-7893) Rename generated *ofbiz-gradle.jar* to *ofbiz.jar*

2016-07-18 Thread Pierre Smits (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-7893?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15382030#comment-15382030 ] Pierre Smits commented on OFBIZ-7893: - Thank you for sharing your viewpoint on what th

Re: JackRabbit branch

2016-07-18 Thread Jacques Le Roux
Nope, simply that we will no longer see the JackRabbit branch when filling the Fix Version/s field, which is disturbing, same for Bootstrap Jacques Le 18/07/2016 à 11:31, Pierre Smits a écrit : Your assumption and suggestion applies to many more branches than just the 2 mentioned, but only 2

Re: JackRabbit branch

2016-07-18 Thread Taher Alkhateeb
+1 On Mon, Jul 18, 2016 at 1:01 PM, Jacques Le Roux < jacques.le.r...@les7arts.com> wrote: > Nope, simply that we will no longer see the JackRabbit branch when filling > the Fix Version/s field, which is disturbing, same for Bootstrap > > Jacques > > > > Le 18/07/2016 à 11:31, Pierre Smits a écri

[jira] [Commented] (OFBIZ-7782) Duplicates of .properties and Label files appear

2016-07-18 Thread Pierre Smits (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-7782?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15382023#comment-15382023 ] Pierre Smits commented on OFBIZ-7782: - I leave that up to you. Or to any other OFBiz c

[jira] [Comment Edited] (OFBIZ-7782) Duplicates of .properties and Label files appear

2016-07-18 Thread Pierre Smits (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-7782?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15382023#comment-15382023 ] Pierre Smits edited comment on OFBIZ-7782 at 7/18/16 10:01 AM: -

[jira] [Commented] (OFBIZ-7893) Rename generated *ofbiz-gradle.jar* to *ofbiz.jar*

2016-07-18 Thread Taher Alkhateeb (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-7893?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15382022#comment-15382022 ] Taher Alkhateeb commented on OFBIZ-7893: There are no inconsistencies because ever

[jira] [Commented] (OFBIZ-7782) Duplicates of .properties and Label files appear

2016-07-18 Thread Jacques Le Roux (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-7782?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15382021#comment-15382021 ] Jacques Le Roux commented on OFBIZ-7782: You might rather challenge people here h

[jira] [Comment Edited] (OFBIZ-7893) Rename generated *ofbiz-gradle.jar* to *ofbiz.jar*

2016-07-18 Thread Pierre Smits (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-7893?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15382019#comment-15382019 ] Pierre Smits edited comment on OFBIZ-7893 at 7/18/16 9:56 AM: --

[jira] [Commented] (OFBIZ-7893) Rename generated *ofbiz-gradle.jar* to *ofbiz.jar*

2016-07-18 Thread Pierre Smits (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-7893?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15382019#comment-15382019 ] Pierre Smits commented on OFBIZ-7893: - Thanks for your opinion on the nice to have. Bu

[jira] [Commented] (OFBIZ-7893) Rename generated *ofbiz-gradle.jar* to *ofbiz.jar*

2016-07-18 Thread Taher Alkhateeb (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-7893?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15382017#comment-15382017 ] Taher Alkhateeb commented on OFBIZ-7893: Hi Jacques, Sure, please go ahead and st

[jira] [Commented] (OFBIZ-7893) Rename generated *ofbiz-gradle.jar* to *ofbiz.jar*

2016-07-18 Thread Jacques Le Roux (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-7893?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15382013#comment-15382013 ] Jacques Le Roux commented on OFBIZ-7893: We should discuss this on dev ML > Renam

[jira] [Commented] (OFBIZ-7893) Rename generated *ofbiz-gradle.jar* to *ofbiz.jar*

2016-07-18 Thread Pierre Smits (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-7893?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15382009#comment-15382009 ] Pierre Smits commented on OFBIZ-7893: - It must be something that resides somewhere out

[jira] [Commented] (OFBIZ-7893) Rename generated *ofbiz-gradle.jar* to *ofbiz.jar*

2016-07-18 Thread Taher Alkhateeb (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-7893?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15382008#comment-15382008 ] Taher Alkhateeb commented on OFBIZ-7893: This patch breaks the build script becaus

[jira] [Commented] (OFBIZ-7892) Move *CertKeystore.groovy* to location according to best practice

2016-07-18 Thread Pierre Smits (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-7892?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15381997#comment-15381997 ] Pierre Smits commented on OFBIZ-7892: - It is now. :) > Move *CertKeystore.groovy* to

[jira] [Closed] (OFBIZ-6302) Ftl to Widget: improve ViewCertificate to use widgets instead of ftl

2016-07-18 Thread Pierre Smits (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-6302?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Pierre Smits closed OFBIZ-6302. --- > Ftl to Widget: improve ViewCertificate to use widgets instead of ftl > -

[jira] [Comment Edited] (OFBIZ-7782) Duplicates of .properties and Label files appear

2016-07-18 Thread Pierre Smits (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-7782?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15381992#comment-15381992 ] Pierre Smits edited comment on OFBIZ-7782 at 7/18/16 9:40 AM: --

[jira] [Commented] (OFBIZ-7782) Duplicates of .properties and Label files appear

2016-07-18 Thread Pierre Smits (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-7782?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15381992#comment-15381992 ] Pierre Smits commented on OFBIZ-7782: - Clearly the author of the article was misinform

[jira] [Commented] (OFBIZ-7893) Rename generated *ofbiz-gradle.jar* to *ofbiz.jar*

2016-07-18 Thread Jacques Le Roux (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-7893?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15381987#comment-15381987 ] Jacques Le Roux commented on OFBIZ-7893: AFAIK this has been done already not sure

[jira] [Commented] (OFBIZ-7892) Move *CertKeystore.groovy* to location according to best practice

2016-07-18 Thread Deepak Dixit (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-7892?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15381988#comment-15381988 ] Deepak Dixit commented on OFBIZ-7892: - Hi [~pfm.smits], OFBIZ-6302 not closed yet, it

[jira] [Commented] (OFBIZ-7835) Unable to identify the fields on the edit of product attributes, facilities, payment types, Meters, work effort, parties

2016-07-18 Thread Montalbano Florian (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-7835?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15381982#comment-15381982 ] Montalbano Florian commented on OFBIZ-7835: --- Hi, this patch works well ! The tit

Re: JackRabbit branch

2016-07-18 Thread Pierre Smits
Your assumption and suggestion applies to many more branches than just the 2 mentioned, but only 2 were registered in JIRA. What does that 'archive it in Jira' entail? Will associated issues be removed from JIRA? Best regards, Pierre Smits ORRTIZ.COM OFBiz based solutio

[jira] [Commented] (OFBIZ-7782) Duplicates of .properties and Label files appear

2016-07-18 Thread Jacques Le Roux (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-7782?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15381976#comment-15381976 ] Jacques Le Roux commented on OFBIZ-7782: I don't know for Ant (and I doubt) but fo

[jira] [Commented] (OFBIZ-7892) Move *CertKeystore.groovy* to location according to best practice

2016-07-18 Thread Pierre Smits (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-7892?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15381967#comment-15381967 ] Pierre Smits commented on OFBIZ-7892: - That issue was dealt with. And it created a new

JackRabbit branch

2016-07-18 Thread Jacques Le Roux
Hi, I believe the JackRabbit branch is now completely unmergeable. I suggest that we archive it in Jira. It adds only confusion there. Same for the the Boostrap theme? I see no problems keeping all branches even old in the repo, it does annoy there. Thanks Jacques

[jira] [Commented] (OFBIZ-1463) JUnit test case for various application components

2016-07-18 Thread Taher Alkhateeb (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-1463?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15381956#comment-15381956 ] Taher Alkhateeb commented on OFBIZ-1463: Hello everyone, It is important to note

[jira] [Commented] (OFBIZ-7892) Move *CertKeystore.groovy* to location according to best practice

2016-07-18 Thread Deepak Dixit (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-7892?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15381949#comment-15381949 ] Deepak Dixit commented on OFBIZ-7892: - Hi [~pfm.smits], I think instead of reporting

[jira] [Commented] (OFBIZ-7752) 'parentCommEventId' is not passed in parameter from edit communication event

2016-07-18 Thread Pranay Pandey (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-7752?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15381951#comment-15381951 ] Pranay Pandey commented on OFBIZ-7752: -- Thanks Jacques, a note for the contributors w

[jira] [Comment Edited] (OFBIZ-7752) 'parentCommEventId' is not passed in parameter from edit communication event

2016-07-18 Thread Jacques Le Roux (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-7752?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15381933#comment-15381933 ] Jacques Le Roux edited comment on OFBIZ-7752 at 7/18/16 9:10 AM: ---

[jira] [Commented] (OFBIZ-7782) Duplicates of .properties and Label files appear

2016-07-18 Thread Pierre Smits (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-7782?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15381947#comment-15381947 ] Pierre Smits commented on OFBIZ-7782: - FWIW: Gradle is a layer over Ant and Ant IVY an

[jira] [Comment Edited] (OFBIZ-7752) 'parentCommEventId' is not passed in parameter from edit communication event

2016-07-18 Thread Jacques Le Roux (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-7752?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15381933#comment-15381933 ] Jacques Le Roux edited comment on OFBIZ-7752 at 7/18/16 9:09 AM: ---

[jira] [Commented] (OFBIZ-7782) Duplicates of .properties and Label files appear

2016-07-18 Thread Pierre Smits (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-7782?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15381942#comment-15381942 ] Pierre Smits commented on OFBIZ-7782: - That is easy to say when you don't know the inn

[jira] [Updated] (OFBIZ-7752) 'parentCommEventId' is not passed in parameter from edit communication event

2016-07-18 Thread Jacques Le Roux (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-7752?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jacques Le Roux updated OFBIZ-7752: --- Fix Version/s: (was: 15.12.01) (was: 14.12.01) Re

[jira] [Commented] (OFBIZ-7782) Duplicates of .properties and Label files appear

2016-07-18 Thread Pierre Smits (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-7782?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15381941#comment-15381941 ] Pierre Smits commented on OFBIZ-7782: - It seems to me that this issue should be enough

[jira] [Updated] (OFBIZ-7888) Apache OFBiz and OPS

2016-07-18 Thread Pierre Smits (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-7888?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Pierre Smits updated OFBIZ-7888: Description: This is a placeholder issue intended to capture issues that are related to the OPS sid

  1   2   >