Re: svn commit: r1761130 - in /ofbiz/trunk: applications/order/servicedef/services_request.xml framework/common/ofbiz-component.xml framework/common/servicedef/services_method.xml

Arun, are you sure about the referenced Jira issues? At least OFBIZ-8033 is another issue which I just committed. Can you please review and correct, it seems that the issues get the commit attached which is not correct. Thanks and regards, Michael Am 17.09.16 um 08:51 schrieb

Re: Ideas about OFBiz servlet filters

Great proposal, I had quite some headaches with this 2-3 years ago when I was diving deep into the multitenancy with several (mini) shops and content sites for different tenants.. ContextFilter handles it well, but the others don't for the reasons you mention. I was hesitating to propose anything

buildbot success in on ofbiz-branch14

The Buildbot has detected a restored build on builder ofbiz-branch14 while building . Full details are available at: https://ci.apache.org/builders/ofbiz-branch14/builds/297 Buildbot URL: https://ci.apache.org/ Buildslave for this Build: lares_ubuntu Build Reason: The AnyBranchScheduler

Re: Ideas about OFBiz servlet filters

Thanks Jacopo! I'll try to change the SEO filter next Monday. -邮件原件- 发件人: Jacopo Cappellato [mailto:jacopo.cappell...@hotwaxsystems.com] 发送时间: 2016年9月17日 22:25 收件人: dev@ofbiz.apache.org 主题: Re: Ideas about OFBiz servlet filters Hi Jinghai, please see inline: On Sat, Sep 17, 2016 at

Re: Ideas about OFBiz servlet filters

Hi Jinghai, please see inline: On Sat, Sep 17, 2016 at 3:16 PM, Shi Jinghai wrote: > Hi Jacopo, > > Thanks for your message! > > The new ControlFilter works well as expected. > > I am glad it worked well; hopefully in the weekend I am going to remove the (now) duplicated

buildbot success in on ofbiz-branch15

The Buildbot has detected a restored build on builder ofbiz-branch15 while building . Full details are available at: https://ci.apache.org/builders/ofbiz-branch15/builds/257 Buildbot URL: https://ci.apache.org/ Buildslave for this Build: silvanus_ubuntu Build Reason: The AnyBranchScheduler

Re: Ideas about OFBiz servlet filters

Hi Jacopo, Thanks for your message! The new ControlFilter works well as expected. I checked in a new OFBizSolrContextFilter in rev. 1761214 to follow up this change, the web.xml is changed as well. Personally, I feel the name ControlFilter and ContextFilter are a bit strange, see web.xml:

Re: buildbot failure in on ofbiz-branch15

This should be fixed with r1761213 Jacques Le 17/09/2016 à 14:11, Jacques Le Roux a écrit : I'm checking that (unfortunately 2 commits in the same test run) Jacques Le 17/09/2016 à 13:53, build...@apache.org a écrit : The Buildbot has detected a new failure on builder ofbiz-branch15 while

Re: buildbot failure in on ofbiz-branch15

I'm checking that (unfortunately 2 commits in the same test run) Jacques Le 17/09/2016 à 13:53, build...@apache.org a écrit : The Buildbot has detected a new failure on builder ofbiz-branch15 while building . Full details are available at:

buildbot failure in on ofbiz-branch14

The Buildbot has detected a new failure on builder ofbiz-branch14 while building . Full details are available at: https://ci.apache.org/builders/ofbiz-branch14/builds/296 Buildbot URL: https://ci.apache.org/ Buildslave for this Build: lares_ubuntu Build Reason: The AnyBranchScheduler

Re: svn commit: r1761200 - in /ofbiz/trunk/framework/base/src/main/java/org/apache/ofbiz/base: container/ conversion/test/ util/ util/cache/ util/collections/ util/collections/test/ util/string/test/

Hi Ashish, The comment above should be removed as well Le 17/09/2016 à 13:38, ash...@apache.org a écrit : Modified: ofbiz/trunk/framework/base/src/main/java/org/apache/ofbiz/base/util/UtilXml.java

Re: Permission service not on the same transaction

Hi all, I need some Help !! I put my arm in a gearing :( After refactor the permission service, I raise a silent problem that is all call-service used on mini-lang test didn't passed to service validation. I correct some easier case like bad attribut passed but now rest some complicate case

buildbot failure in on ofbiz-branch15

The Buildbot has detected a new failure on builder ofbiz-branch15 while building . Full details are available at: https://ci.apache.org/builders/ofbiz-branch15/builds/256 Buildbot URL: https://ci.apache.org/ Buildslave for this Build: silvanus_ubuntu Build Reason: The AnyBranchScheduler

Re: svn commit: r1761181 [1/2] - in /ofbiz/trunk/applications/product/src/main/java/org/apache/ofbiz: product/category/ product/category/ftl/ product/config/ product/feature/ product/imagemanagement/

Hi Jacques, Ashish I also noted few classes with such patterns during clean up, and in first attempt I just cleaned the default TODOs. I will provide a patch with this and other suggested enhancements. Thanks & Regards, Harsh On Saturday 17 September 2016 04:56 PM, Jacques Le Roux wrote:

Re: svn commit: r1761181 [1/2] - in /ofbiz/trunk/applications/product/src/main/java/org/apache/ofbiz: product/category/ product/category/ftl/ product/config/ product/feature/ product/imagemanagement/

Hi Ashish, This should be improved, exception in services should use Debug.logError, use return ServiceUtil.returnError and not swallow the exception Le 17/09/2016 à 12:34, ash...@apache.org a écrit : product = EntityQuery.use(delegator).from("Product").where("productId",

Re: svn commit: r1761181 [1/2] - in /ofbiz/trunk/applications/product/src/main/java/org/apache/ofbiz: product/category/ product/category/ftl/ product/config/ product/feature/ product/imagemanagement/

Hi Ashish, The comment above should be removed as well Le 17/09/2016 à 12:34, ash...@apache.org a écrit : public String complete(boolean force) throws GeneralException { // clear out empty lines -// this.checkEmptyLines(); // removing, this seems to be causeing issues

Re: svn commit: r1761181 [1/2] - in /ofbiz/trunk/applications/product/src/main/java/org/apache/ofbiz: product/category/ product/category/ftl/ product/config/ product/feature/ product/imagemanagement/

Hi Ashish, I think we lose some information here Le 17/09/2016 à 12:34, ash...@apache.org a écrit : public static Map prodFindDistinctVariants(DispatchContext dctx, Map context) { -// * String productId -- Parent (virtual) product

Re: [VOTE] ASL2 header in README files?

We are on the same page: if there is no doubt about the fact that a given file (not just readme files) doesn't contain any degree of creativity then the license header is not required. Jacopo On Sat, Sep 17, 2016 at 9:07 AM, Jacques Le Roux < jacques.le.r...@les7arts.com> wrote: > Jacopo, > >

Re: [VOTE] ASL2 header in README files?

Jacopo, I'm glad we also agree about not blindly putting an Alv2 header in all readme files Jacques Le 17/09/2016 à 08:42, Jacopo Cappellato a écrit : Jacques, I am glad that you finally agreed upon my initial interpretation of the policy. It took time (for the community and the legal team

Re: [VOTE] ASL2 header in README files?

Jacques, I am glad that you finally agreed upon my initial interpretation of the policy. It took time (for the community and the legal team [*]) to explain to you and Pierre that your original interpretation was incorrect but I am glad we are now all on the same page and we can move on and work