Re: Services with no definition and usage

2017-09-11 Thread Scott Gray
I'm in favor of keeping them and adding the service definitions. As Taher mentions, these are CRUD services and IMO if we have the table, we should have the set of services allowing management of the data. These implementations are quite synonymous with the FacilityContactMech services, they're o

Re: OFBiz Core Dependency on Plugins

2017-09-11 Thread Ratnesh Upadhyay
Thanks, Rishi, Michael and Taher for the inputs. I'll review the shared Jira tickets and update them as needed. Regards, Ratnesh Upadhyay HotWax Systems | www.hotwaxsystems.com On Sun, Sep 10, 2017 at 12:45 AM, Michael Brohl wrote: > Yeah right, that was the missing Jira. > > Thanks Taher! > >

Re: Adding Bitcoin Support to OFBiz

2017-09-11 Thread Sharan Foga
Hi Julien I've verified that your ICLA has been filed and have updated your Jira permissions so you should be able to assign issues to yourself now. And welcome to the project! :-) Thanks Sharan On 11/09/17 10:45, Sharan Foga wrote: Hi Julian If you have filed an ICLA and have been setup a

Re: Adding Bitcoin Support to OFBiz

2017-09-11 Thread Blockfreight™ | Julian Smith
Thank you. I confirm I appear (as Julian Smith) on the https://people.apache.org/unlistedclas.html list. J.

Re: Adding Bitcoin Support to OFBiz

2017-09-11 Thread Jacques Le Roux
Le 11/09/2017 à 10:45, Sharan Foga a écrit : The official repository is SVN but you can use and provide a svn formatted patch in the Jira Missed a word there :) The official repository is SVN but you can use *GitHub* and provide a svn formatted patch in the Jira Jacques

Re: svn commit: r1807240 - /ofbiz/ofbiz-framework/trunk/applications/order/src/main/java/org/apache/of biz/order/order/OrderReadHelper.java

2017-09-11 Thread Jacques Le Roux
Le 11/09/2017 à 10:34, Scott Gray a écrit : Since this is such a complex problem perhaps we better come up with a best practice since we have so many Helper/Worker/Reader classes in OFBiz and a bit of API consistency goes a long way. If a GenericEntityException is thrown within a Helper/Worker/R

Re: Adding Bitcoin Support to OFBiz

2017-09-11 Thread Sharan Foga
Hi Julian If you have filed an ICLA and have been setup as a contributor in our Jira instance, you should be able to assign an issue to yourself. This is a feature we enabled for contributors with ICLAs so that others can see that you are working on it. I'll do a quick check to see if your Ji

Re: svn commit: r1807240 - /ofbiz/ofbiz-framework/trunk/applications/order/src/main/java/org/apache/of biz/order/order/OrderReadHelper.java

2017-09-11 Thread Jacques Le Roux
Le 11/09/2017 à 10:28, Taher Alkhateeb a écrit : Quoting Scott: "This is often why we can't just bulk fix the issues reported by static analysis tools, because the fix requires a thought-out solution that's totally dependent on the context of the code in question" So I guess him and I are in agre

Re: svn commit: r1807240 - /ofbiz/ofbiz-framework/trunk/applications/order/src/main/java/org/apache/of biz/order/order/OrderReadHelper.java

2017-09-11 Thread Scott Gray
Since this is such a complex problem perhaps we better come up with a best practice since we have so many Helper/Worker/Reader classes in OFBiz and a bit of API consistency goes a long way. If a GenericEntityException is thrown within a Helper/Worker/Reader class method, how should we handle it?

Re: svn commit: r1807240 - /ofbiz/ofbiz-framework/trunk/applications/order/src/main/java/org/apache/of biz/order/order/OrderReadHelper.java

2017-09-11 Thread Taher Alkhateeb
Quoting Scott: "This is often why we can't just bulk fix the issues reported by static analysis tools, because the fix requires a thought-out solution that's totally dependent on the context of the code in question" So I guess him and I are in agreement at least in this point. Furthermore, to my un

Re: svn commit: r1807999 - in /ofbiz/site: index.html template/page/index.tpl.php

2017-09-11 Thread Deepak Dixit
Hi Sharan, I fixed the span closing issue, In this commit I found only formatting changes Could you please correct me if I missed something in this commit? Thanks & Regards -- Deepak Dixit www.hotwaxsystems.com www.hotwax.co On Mon, Sep 11, 2017 at 1:40 PM, wrote: > Author: sharan > Date: Mon

Re: Adding Bitcoin Support to OFBiz

2017-09-11 Thread Jacques Le Roux
Hi Julian, You don't need to assign the task to yourself for begin to work on it, simply provide a patch when done New features are always only implemented in trunk The official repository is SVN but you can use and provide a svn formatted patch in the Jira One important point, will you prov

Re: svn commit: r1807240 - /ofbiz/ofbiz-framework/trunk/applications/order/src/main/java/org/apache/of biz/order/order/OrderReadHelper.java

2017-09-11 Thread Jacques Le Roux
Le 10/09/2017 à 19:56, Taher Alkhateeb a écrit : Inline On Sun, Sep 10, 2017 at 8:40 PM, Jacques Le Roux wrote: I easily see 3 alternatives: 1. Swallow the exception, like we currently do. This should be forbidden in all cases, I'd veto that!- 2. Log an error and return a wrong result, like

Adding Bitcoin Support to OFBiz

2017-09-11 Thread Blockfreight™ | Julian Smith
Attn: *OFBiz Dev List* Re: *Add Bitcoin to Accounting* Hi All, Further to our discussion, I am keen to add Bitcoin support to the next release of OFBiz. - As per the developer guide, I have filled an Apache ICLA. - I created this ticket: https://issues.apache.org/jira/browse/OFBIZ-9