Re: svn commit: r1817750 - in /ofbiz/ofbiz-framework/trunk/framework/base/src/main/java/org/apache/ofbiz/ base/component: ComponentConfig.java ComponentLoaderConfig.java ComponentResourceHandler.java

I've reverted these commits and reapplied the original patches. Thanks all for taking care, Michael Am 11.12.17 um 15:21 schrieb Jacques Le Roux: I reviewed r1817748 1817742 1817743 1817744 there are OK with me So you just have to revert the removing of the tests on Debug in these commits 

Re: svn commit: r1817750 - in /ofbiz/ofbiz-framework/trunk/framework/base/src/main/java/org/apache/ofbiz/ base/component: ComponentConfig.java ComponentLoaderConfig.java ComponentResourceHandler.java

I reviewed r1817748 1817742 1817743 1817744 there are OK with me So you just have to revert the removing of the tests on Debug in these commits  (IIRW only in r1817748 and r1817750) Notably beware of "if (debug) {" in r1817748. Jacques Le 11/12/2017 à 12:39, Michael Brohl a écrit :

Re: [DISCUSSION] Review ProductPromo action and condition process

Ha I see, you speak about             Then yes I understand and I think a POC would be welcome :) Jacques Le 11/12/2017 à 13:08, Jacques Le Roux a écrit : Hi Nicolas, I don't see why you speak about enumeration for ProductPromoCond and ProductPromoAction which are plain entities.

Re: [DISCUSSION] Review ProductPromo action and condition process

Hello, Le 11/12/2017 à 13:08, Jacques Le Roux a écrit : Hi Nicolas, I don't see why you speak about enumeration for ProductPromoCond and ProductPromoAction which are plain entities. Because it's the enumeration that determine the code base to execute. It's the reason that I proposed to

Re: svn commit: r1817750 - in /ofbiz/ofbiz-framework/trunk/framework/base/src/main/java/org/apache/ofbiz/ base/component: ComponentConfig.java ComponentLoaderConfig.java ComponentResourceHandler.java

Same feel from France center :) Nicolas Le 11/12/2017 à 11:50, Taher Alkhateeb a écrit : On a side note to Michael kudos on the massive bug hunting effort lately. On Dec 11, 2017 1:33 PM, "Michael Brohl" wrote: I will see how I can handle this effectively without

Put the social networks icons above "Latest tweets" (OFBIZ-10050)

Hi, I wanted to put the social networks icons above "Latest tweets" but it's not as easy as I thought without breaking the layout. Could someone with more knowledge with the site have a look please? TIA Jacques

Re: [DISCUSSION] migrate mini lang to Java and/or groovy

Of course, as retweeted Sharan, we can still hope the Groovy community will resolve these issues as planned https://twitter.com/ApacheGroovy/status/937684077045481475 Jacques Le 30/11/2017 à 15:51, Jacques Le Roux a écrit : Le 30/11/2017 à 15:33, Jacques Le Roux a écrit : Also, even if it's

Re: Permission overrides auth parameter of service

Hi Suraj, I don't see how you could check permissions for an anonymous user. Maybe by giving anonymous users specific permissions in the context of ecommerce? But does it makes sense, I'm not sure. Then maybe as mentioned Rishi we should fix services like CreateShoppingList BTW did you cross

Re: [DISCUSSION] Review ProductPromo action and condition process

Hi Nicolas, I don't see why you speak about enumeration for ProductPromoCond and ProductPromoAction which are plain entities. Jacques Le 08/12/2017 à 14:14, Nicolas Malin a écrit : Hello, Yesterday during a boring time in the come back home train, I read the ofbiz demo data review that the

Re: Websocket example not working in OFBiz

Hi Pallavi, One thing you could do if you find more information is to reopen OFBIZ-7538 Jacques Le 11/12/2017 à 11:46, Pallavi Goyal a écrit : Hello All, I am working on the Web Socket implementation in OFBiz taking reference from OFBIZ-7073

Re: svn commit: r1817750 - in /ofbiz/ofbiz-framework/trunk/framework/base/src/main/java/org/apache/ofbiz/ base/component: ComponentConfig.java ComponentLoaderConfig.java ComponentResourceHandler.java

Thanks, Taher! :-) Am 11.12.17 um 11:50 schrieb Taher Alkhateeb: On a side note to Michael kudos on the massive bug hunting effort lately. On Dec 11, 2017 1:33 PM, "Michael Brohl" wrote: I will see how I can handle this effectively without doing all my review work

Re: svn commit: r1817750 - in /ofbiz/ofbiz-framework/trunk/framework/base/src/main/java/org/apache/ofbiz/ base/component: ComponentConfig.java ComponentLoaderConfig.java ComponentResourceHandler.java

On a side note to Michael kudos on the massive bug hunting effort lately. On Dec 11, 2017 1:33 PM, "Michael Brohl" wrote: > I will see how I can handle this effectively without doing all my review > work twice. > > There should be not too much commits which are

Websocket example not working in OFBiz

Hello All, I am working on the Web Socket implementation in OFBiz taking reference from OFBIZ-7073 and OFBIZ-7467 . When I open the main page of example component and check the console log for

Re: svn commit: r1817750 - in /ofbiz/ofbiz-framework/trunk/framework/base/src/main/java/org/apache/ofbiz/ base/component: ComponentConfig.java ComponentLoaderConfig.java ComponentResourceHandler.java

I will see how I can handle this effectively without doing all my review work twice. There should be not too much commits which are affected. I'll see if I can repair it this evening. Am 11.12.17 um 11:29 schrieb Jacques Le Roux: Michael, It would be easier for reviewers if you could

Re: svn commit: r1817750 - in /ofbiz/ofbiz-framework/trunk/framework/base/src/main/java/org/apache/ofbiz/ base/component: ComponentConfig.java ComponentLoaderConfig.java ComponentResourceHandler.java

Michael, It would be easier for reviewers if you could revert your commits (not those of the weekend, I have not reviewed them all yet but most of them, and so far did not find any important issues, just few improvements I did). This would prevent us from double reviewing. For me at least

Re: svn commit: r1817750 - in /ofbiz/ofbiz-framework/trunk/framework/base/src/main/java/org/apache/ofbiz/ base/component: ComponentConfig.java ComponentLoaderConfig.java ComponentResourceHandler.java

Thank you Michael! Please see a minor comment inline: On Mon, Dec 11, 2017 at 10:21 AM, Michael Brohl wrote: > > I will check my latest commits and change this back where it is reasonable > (i.e. where we have concatenations). > Actually this is not only relevant for

Re: svn commit: r1817750 - in /ofbiz/ofbiz-framework/trunk/framework/base/src/main/java/org/apache/ofbiz/ base/component: ComponentConfig.java ComponentLoaderConfig.java ComponentResourceHandler.java

Yes better to keep it indeed Jacques Le 11/12/2017 à 10:05, Taher Alkhateeb a écrit : Unless maybe something changed with the log4j API that I am unaware of. But I suspect that's hard to implement On Dec 11, 2017 12:01 PM, "Taher Alkhateeb" wrote: I agree with

Re: svn commit: r1817750 - in /ofbiz/ofbiz-framework/trunk/framework/base/src/main/java/org/apache/ofbiz/ base/component: ComponentConfig.java ComponentLoaderConfig.java ComponentResourceHandler.java

These are good points, I wasn't aware of this and just saw the (in my view) unnecessary extra lines of code. I will check my latest commits and change this back where it is reasonable (i.e. where we have concatenations). Luckily, I just started this this morning and not during the heavier

Re: svn commit: r1817750 - in /ofbiz/ofbiz-framework/trunk/framework/base/src/main/java/org/apache/ofbiz/ base/component: ComponentConfig.java ComponentLoaderConfig.java ComponentResourceHandler.java

Unless maybe something changed with the log4j API that I am unaware of. But I suspect that's hard to implement On Dec 11, 2017 12:01 PM, "Taher Alkhateeb" wrote: > I agree with Jacopo. String concatenation is a relatively expensive > operation because strings are

Re: svn commit: r1817750 - in /ofbiz/ofbiz-framework/trunk/framework/base/src/main/java/org/apache/ofbiz/ base/component: ComponentConfig.java ComponentLoaderConfig.java ComponentResourceHandler.java

I agree with Jacopo. String concatenation is a relatively expensive operation because strings are immutable and this is exactly why the log4j library provides the checking methods. I would also note that you need these checking functions the most when the call is most utilized (verbose or debug).

Re: svn commit: r1817750 - in /ofbiz/ofbiz-framework/trunk/framework/base/src/main/java/org/apache/ofbiz/ base/component: ComponentConfig.java ComponentLoaderConfig.java ComponentResourceHandler.java

On Mon, Dec 11, 2017 at 9:31 AM, Jacques Le Roux < jacques.le.r...@les7arts.com> wrote: > [...] > Also for OFBIZ-9872 the Jira lacks a description to possibly understand > why theses changes (notably why you rightly removed the "if > (Debug.verboseOn())" test because it's done at the bottom level