Re: svn commit: r1858270 [1/3] - in /ofbiz/ofbiz-framework/trunk/applications: datamodel/data/demo/ datamodel/data/seed/ datamodel/entitydef/ order/config/ order/data/ order/entitydef/ order/groovyScr

2019-05-14 Thread Deepak Dixit
Thanks Suraj. Thanks & Regards -- Deepak Dixit On Wed, May 15, 2019 at 11:49 AM Suraj Khurana wrote: > Done at rev #1859267 > > -- > Best Regards, > Suraj Khurana > Technical Consultant > > > > > > On Wed, May 15, 2019 at 11:31 AM Suraj Khurana > wrote: > > > Thanks Deepak. Yes, it is due to s

Re: svn commit: r1856609 - in /ofbiz/ofbiz-framework/trunk/applications/order: groovyScripts/test/OrderTests.groovy testdef/data/OrderTestData.xml

2019-05-14 Thread Jacques Le Roux
Great news, it's resolved with r1859267 Le 14/05/2019 à 11:38, Jacques Le Roux a écrit : Thanks Rishi, It seems it's something else now. I'll also have a look, hopefully today Jacques Le 14/05/2019 à 11:22, Rishi Solanki a écrit : Below are the test cases failure list on running "cleanAll l

Re: svn commit: r1856609 - in /ofbiz/ofbiz-framework/trunk/applications/order: groovyScripts/test/OrderTests.groovy testdef/data/OrderTestData.xml

2019-05-14 Thread Suraj Khurana
I hope this is fixed after rev #1859267. -- Best Regards, Suraj Khurana Technical Consultant On Tue, May 14, 2019 at 3:10 PM Jacques Le Roux < jacques.le.r...@les7arts.com> wrote: > Thanks Rishi, > > It seems it's something else now. > > I'll also have a look, hopefully today > > Jacques > >

Re: svn commit: r1858270 [1/3] - in /ofbiz/ofbiz-framework/trunk/applications: datamodel/data/demo/ datamodel/data/seed/ datamodel/entitydef/ order/config/ order/data/ order/entitydef/ order/groovyScr

2019-05-14 Thread Suraj Khurana
Done at rev #1859267 -- Best Regards, Suraj Khurana Technical Consultant On Wed, May 15, 2019 at 11:31 AM Suraj Khurana wrote: > Thanks Deepak. Yes, it is due to same block that Deepak has mentioned. > > I checked on my local machine and everything works fine after handling > this code bloc

Re: svn commit: r1858270 [1/3] - in /ofbiz/ofbiz-framework/trunk/applications: datamodel/data/demo/ datamodel/data/seed/ datamodel/entitydef/ order/config/ order/data/ order/entitydef/ order/groovyScr

2019-05-14 Thread Suraj Khurana
Thanks Deepak. Yes, it is due to same block that Deepak has mentioned. I checked on my local machine and everything works fine after handling this code block. I will modify the condition little bit and commit in sometime. -- Best Regards, Suraj Khurana Technical Consultant On Wed, May 15, 20

Re: svn commit: r1858270 [1/3] - in /ofbiz/ofbiz-framework/trunk/applications: datamodel/data/demo/ datamodel/data/seed/ datamodel/entitydef/ order/config/ order/data/ order/entitydef/ order/groovyScr

2019-05-14 Thread Deepak Dixit
It seems following code causing the issue from this commit: == Modified: ofbiz/ofbiz-framework/trunk/applications/order/src/main/java/org/apache/ofbiz/order/order/OrderServices.java URL: http://svn.apache.org/viewvc/ofbiz/ofbiz-framework/trunk/applications/order/src/main/java/org/a

Re: svn commit: r1856609 - in /ofbiz/ofbiz-framework/trunk/applications/order: groovyScripts/test/OrderTests.groovy testdef/data/OrderTestData.xml

2019-05-14 Thread Jacques Le Roux
Thanks Rishi, It seems it's something else now. I'll also have a look, hopefully today Jacques Le 14/05/2019 à 11:22, Rishi Solanki a écrit : Below are the test cases failure list on running "cleanAll loadAll testIntegration" 1) [JUNIT (failure)] - production-run-tests.testCreateProductionRun

Re: svn commit: r1856609 - in /ofbiz/ofbiz-framework/trunk/applications/order: groovyScripts/test/OrderTests.groovy testdef/data/OrderTestData.xml

2019-05-14 Thread Rishi Solanki
Below are the test cases failure list on running "cleanAll loadAll testIntegration" 1) [JUNIT (failure)] - production-run-tests.testCreateProductionRunForOrder : Assertion failed: ( NOT empty[originalOrderItemShipGrpInvRes=null]) 2) [JUNIT (failure)] - invoice-per-shipment-tests.testInvoicePerShipm

Re: [PROPOSAL] DataModel - Improve entities using fromPartyId & toPartyId

2019-05-14 Thread Rishi Solanki
Dear Pierre, Few inputs for thoughts; One agreement from company to multiple parties may exists. For example; >From Company if sale is more than $10,000 then company may credit/discount 10% of sale to its suppliers. Then it will be applicable to more than one supplier, then AgreementRole entity is

Re: svn commit: r1856609 - in /ofbiz/ofbiz-framework/trunk/applications/order: groovyScripts/test/OrderTests.groovy testdef/data/OrderTestData.xml

2019-05-14 Thread Rishi Solanki
Jacques, I have completed my in hand items and closed the ticket - https://issues.apache.org/jira/browse/OFBIZ-10457 Nothing is pending in my knowledge also sms settings are disabled by default. I'll check the tests in case something is not working due to message component then I will fix that. If