Re: [jira] [Updated] (OFBIZ-11031) Improve SalesOrderItemFact table

2019-05-16 Thread Suraj Khurana
Hello, I am inclined with Aditya's thought here. >>Furthermore, a parent ticket works well for task and new feature tickets. And not that well for bug fix and improvement tickets. IMO, it does. [1] As a reviewer, I think of all the tickets are bundled together inside a parent ticket, than it wou

Re: Reviving the OFBiz community day

2019-05-16 Thread Swapnil M Mane
Thanks so much Sharan for your kind help :-) I have created sprint - "OFBiz Community Day (May 2019)" and associated it with an issue for testing purpose. Everything is working as expected. P.S. To set the sprint on any issue, simply click on the "Edit" option on the issue and select the sprint f

Re: Reviving the OFBiz community day

2019-05-16 Thread Sharan Foga
Hi All One of things we did for the community days is to use Jira Sprints to identify the issues to work on. As Swapnil is co-ordinating this effort - I've added him to the Jira admins so that he can create sprints. I have just created a scrum board that we can use. Please feel to try it and

Re: [PROPOSAL] DataModel - Improve entities using fromPartyId & toPartyId

2019-05-16 Thread Michael Brohl
Hi Pierre, I think there are more sophisticated concepts for some of the mentioned entities, for example - OrderRole for orders allows to connect an unlimited number of parties with different roles - CustRequestParty, QuoteRole, CustRequestRole - same principle For these, introducing from/

Re: [jira] [Updated] (OFBIZ-11031) Improve SalesOrderItemFact table

2019-05-16 Thread Pierre Smits
Hi Aditya, All, IMO, there are already to many tickets not worked on, but being managed. And I don't see much progress initiated by the assignees of those tickets to get the work of the underlying tasks completed. While parent tickets (and sub tasks) work well for other parties with a more hierarc

Re: [PROPOSAL] DataModel - Improve entities using fromPartyId & toPartyId

2019-05-16 Thread Pierre Smits
Hi Rishi, All, The agreement entity caters for capturing the principal two parties and their appropriate roles. This caters for the majority of the agreements struck between the representatives of the internal (accounting) organisation and their business partners. The use case you presented (one

Re: [jira] [Updated] (OFBIZ-11031) Improve SalesOrderItemFact table

2019-05-16 Thread Aditya Sharma
Hi Pierre, It seems work is related to Business Intelligence[1] work. Thanks for your efforts in this direction. I would suggest that it would be much better if you could have a parent ticket for all these tasks that define the plan and purpose. It would quite easy to track the progress if the tic

Re: JobSandbox temporal expression timezone

2019-05-16 Thread Pawan Verma
Hello Devs, I have logged Jira for this improvement. Here is the link for the same: https://issues.apache.org/jira/browse/OFBIZ-11035 Soon, I will add a patch for this. Suggestions are most welcome. Thanks! -- Thanks & Regards Pawan Verma Technical Consultant *HotWax Systems* *Enterprise open so

Re: Code Improvement for Groovy

2019-05-16 Thread Jacques Le Roux
Thanks Scott, Quite helpful! Jacques Le 16/05/2019 à 10:12, Scott Gray a écrit : Hi Pawan Sounds good, just one point to be careful of: maxRetry = 0 if (!maxRetry) { // Not set, use a default maxRetry = -1 } Because groovy evaluates zero to be false, it wouldn't be possible to set maxRet

Re: Code Improvement for Groovy

2019-05-16 Thread Scott Gray
Hi Pawan Sounds good, just one point to be careful of: maxRetry = 0 if (!maxRetry) { // Not set, use a default maxRetry = -1 } Because groovy evaluates zero to be false, it wouldn't be possible to set maxRetry to zero. So it's best not to use groovy truth for null-checks on numbers in some cas